)]}'
{"nova/tests/unit/policies/test_server_topology.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5087542f2050de83ac9280b4b3ad9b4bb719dd7c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import fixtures"},{"line_number":14,"context_line":"import mock"},{"line_number":15,"context_line":"from oslo_utils.fixture import uuidsentinel as uuids"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from nova.api.openstack.compute import server_topology"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_a71233b3","line":14,"updated":"2020-04-05 04:52:33.000000000","message":"pep8: F401 \u0027mock\u0027 imported but unused","commit_id":"408933af5e40c414f7a6699d36eb244e0fe52e69"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5087542f2050de83ac9280b4b3ad9b4bb719dd7c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        ]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def test_index_server_topology_policy(self):"},{"line_number":82,"context_line":"        rule_name \u003d policies.BASE_POLICY_NAME  % \u0027index\u0027"},{"line_number":83,"context_line":"        self.common_policy_check(self.admin_or_owner_authorized_contexts,"},{"line_number":84,"context_line":"                                 self.admin_or_owner_unauthorized_contexts,"},{"line_number":85,"context_line":"                                 rule_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_87172fa4","line":82,"updated":"2020-04-05 04:52:33.000000000","message":"pep8: E221 multiple spaces before operator","commit_id":"408933af5e40c414f7a6699d36eb244e0fe52e69"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"aafb845fbccaaf1c715b0e3a0e721f38d1b9302e","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_index_host_server_topology_policy(self):"},{"line_number":89,"context_line":"        rule_name \u003d policies.BASE_POLICY_NAME % \u0027host:index\u0027"},{"line_number":90,"context_line":"        rule \u003d policies.BASE_POLICY_NAME % \u0027index\u0027"},{"line_number":91,"context_line":"        self.policy.set_rules({rule: \"@\"}, overwrite\u003dFalse)"},{"line_number":92,"context_line":"        authorize_res, unauthorize_res \u003d self.common_policy_check("},{"line_number":93,"context_line":"            self.admin_authorized_contexts, self.admin_unauthorized_contexts,"},{"line_number":94,"context_line":"            rule_name, self.controller.index, self.req, self.instance.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_1f7b43be","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":59},"updated":"2020-04-07 09:12:55.000000000","message":"I am not sure we want to null out the previous check, because the code actually checks both policies.\n\nOr is the something in our test validation that causes problems without this? If so, might be worth a comment here.","commit_id":"504255e76c1fca1b4d5fbc5d85c1a3de025e38b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d5c4654e0ee570012d615e3fe9d2cd80b27a3224","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_index_host_server_topology_policy(self):"},{"line_number":89,"context_line":"        rule_name \u003d policies.BASE_POLICY_NAME % \u0027host:index\u0027"},{"line_number":90,"context_line":"        rule \u003d policies.BASE_POLICY_NAME % \u0027index\u0027"},{"line_number":91,"context_line":"        self.policy.set_rules({rule: \"@\"}, overwrite\u003dFalse)"},{"line_number":92,"context_line":"        authorize_res, unauthorize_res \u003d self.common_policy_check("},{"line_number":93,"context_line":"            self.admin_authorized_contexts, self.admin_unauthorized_contexts,"},{"line_number":94,"context_line":"            rule_name, self.controller.index, self.req, self.instance.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_ac8e6624","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":59},"in_reply_to":"df33271e_0ce152fd","updated":"2020-04-07 15:14:26.000000000","message":"wait, that is what the override rule is to allow unauth context to pass it. somewhere it fail on tests. I think common_policy_check does not adjust the multi policy checks with fatal-false cases. \n\nlet me check","commit_id":"504255e76c1fca1b4d5fbc5d85c1a3de025e38b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"a456f8c3ff7800044730b5f79677eb80c1edd3cc","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_index_host_server_topology_policy(self):"},{"line_number":89,"context_line":"        rule_name \u003d policies.BASE_POLICY_NAME % \u0027host:index\u0027"},{"line_number":90,"context_line":"        rule \u003d policies.BASE_POLICY_NAME % \u0027index\u0027"},{"line_number":91,"context_line":"        self.policy.set_rules({rule: \"@\"}, overwrite\u003dFalse)"},{"line_number":92,"context_line":"        authorize_res, unauthorize_res \u003d self.common_policy_check("},{"line_number":93,"context_line":"            self.admin_authorized_contexts, self.admin_unauthorized_contexts,"},{"line_number":94,"context_line":"            rule_name, self.controller.index, self.req, self.instance.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_0ce152fd","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":59},"in_reply_to":"df33271e_1f7b43be","updated":"2020-04-07 15:11:21.000000000","message":"yeah its tests causing issue. for example some unauthorized context for host policy allow index policy and fail.\n\nI will add note for that.","commit_id":"504255e76c1fca1b4d5fbc5d85c1a3de025e38b3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e39c2023e54031b83a58be2fd807ba73e2dffbd7","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_index_host_server_topology_policy(self):"},{"line_number":89,"context_line":"        rule_name \u003d policies.BASE_POLICY_NAME % \u0027host:index\u0027"},{"line_number":90,"context_line":"        rule \u003d policies.BASE_POLICY_NAME % \u0027index\u0027"},{"line_number":91,"context_line":"        self.policy.set_rules({rule: \"@\"}, overwrite\u003dFalse)"},{"line_number":92,"context_line":"        authorize_res, unauthorize_res \u003d self.common_policy_check("},{"line_number":93,"context_line":"            self.admin_authorized_contexts, self.admin_unauthorized_contexts,"},{"line_number":94,"context_line":"            rule_name, self.controller.index, self.req, self.instance.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_9b6d959b","line":91,"range":{"start_line":90,"start_character":0,"end_line":91,"end_character":59},"in_reply_to":"df33271e_ac8e6624","updated":"2020-04-07 18:52:01.000000000","message":"this was failing on \u0027index\u0027 policy before as we check this first in API. adding note.","commit_id":"504255e76c1fca1b4d5fbc5d85c1a3de025e38b3"}]}