)]}'
{"nova/policies/server_topology.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9a51262e4617b878c7d11a59502b9767d6839494","unresolved":false,"context_lines":[{"line_number":21,"context_line":"server_topology_policies \u003d ["},{"line_number":22,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":23,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027index\u0027,"},{"line_number":24,"context_line":"        check_str\u003dbase.PROJECT_MEMBER_OR_SYSTEM_ADMIN,"},{"line_number":25,"context_line":"        description\u003d\"Show the NUMA topology data for a server\","},{"line_number":26,"context_line":"        operations\u003d["},{"line_number":27,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_3f07271f","line":24,"updated":"2020-04-07 09:14:43.000000000","message":"Should this not be reader?","commit_id":"8d7742bd1e780ffd303615981e8b1aa8da390471"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2a88a8d946e9810bc62b3c9cd627ef596d787ba9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"server_topology_policies \u003d ["},{"line_number":22,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":23,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027index\u0027,"},{"line_number":24,"context_line":"        check_str\u003dbase.PROJECT_MEMBER_OR_SYSTEM_ADMIN,"},{"line_number":25,"context_line":"        description\u003d\"Show the NUMA topology data for a server\","},{"line_number":26,"context_line":"        operations\u003d["},{"line_number":27,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_8cba82bd","line":24,"in_reply_to":"df33271e_3f07271f","updated":"2020-04-07 15:17:00.000000000","message":"oh, my bad. thanks for catching. done","commit_id":"8d7742bd1e780ffd303615981e8b1aa8da390471"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9a51262e4617b878c7d11a59502b9767d6839494","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":34,"context_line":"        # Control host NUMA node and cpu pinning information"},{"line_number":35,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027host:index\u0027,"},{"line_number":36,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN,"},{"line_number":37,"context_line":"        description\u003d\"Show the NUMA topology data for a server with host\""},{"line_number":38,"context_line":"        \"NUMA ID and CPU pinning information\","},{"line_number":39,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_1f02230c","line":36,"updated":"2020-04-07 09:14:43.000000000","message":"system_reader?","commit_id":"8d7742bd1e780ffd303615981e8b1aa8da390471"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2a88a8d946e9810bc62b3c9cd627ef596d787ba9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":34,"context_line":"        # Control host NUMA node and cpu pinning information"},{"line_number":35,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027host:index\u0027,"},{"line_number":36,"context_line":"        check_str\u003dbase.SYSTEM_ADMIN,"},{"line_number":37,"context_line":"        description\u003d\"Show the NUMA topology data for a server with host\""},{"line_number":38,"context_line":"        \"NUMA ID and CPU pinning information\","},{"line_number":39,"context_line":"        operations\u003d["}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_ccb48ad4","line":36,"in_reply_to":"df33271e_1f02230c","updated":"2020-04-07 15:17:00.000000000","message":"doen","commit_id":"8d7742bd1e780ffd303615981e8b1aa8da390471"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"67ac969d07cf94708f1cae5e72107f37e0e91c80","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                \u0027path\u0027: \u0027/servers/{server_id}/topology\u0027"},{"line_number":43,"context_line":"            }"},{"line_number":44,"context_line":"        ],"},{"line_number":45,"context_line":"        scope_types\u003d[\u0027system\u0027]),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4c43b2_29dd5142","line":45,"updated":"2020-04-14 10:10:06.000000000","message":"I wonder about adding project here","commit_id":"4cc619acd7c0463352d3ec21808ffb80e84c87b1"}],"nova/tests/unit/policies/test_server_topology.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"221a62b86c38b6b907a92cc279221823a324a48e","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            self.project_foo_context"},{"line_number":154,"context_line":"        ]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Check that system admin is able to get the server topology"},{"line_number":157,"context_line":"        # host information."},{"line_number":158,"context_line":"        self.admin_authorized_contexts \u003d ["},{"line_number":159,"context_line":"            self.system_admin_context]"},{"line_number":160,"context_line":"        # Check that non-system/admin is not able to get the server topology"},{"line_number":161,"context_line":"        # host information."},{"line_number":162,"context_line":"        self.admin_unauthorized_contexts \u003d ["},{"line_number":163,"context_line":"            self.legacy_admin_context, self.system_member_context,"},{"line_number":164,"context_line":"            self.system_reader_context, self.system_foo_context,"},{"line_number":165,"context_line":"            self.project_admin_context, self.project_member_context,"},{"line_number":166,"context_line":"            self.other_project_member_context,"},{"line_number":167,"context_line":"            self.project_foo_context, self.project_reader_context"},{"line_number":168,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_c208e029","line":168,"range":{"start_line":156,"start_character":0,"end_line":168,"end_character":9},"updated":"2020-04-07 09:15:37.000000000","message":"At the moment this is a duplicate of the above test, which seems a bit odd.","commit_id":"8d7742bd1e780ffd303615981e8b1aa8da390471"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2a88a8d946e9810bc62b3c9cd627ef596d787ba9","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            self.project_foo_context"},{"line_number":154,"context_line":"        ]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        # Check that system admin is able to get the server topology"},{"line_number":157,"context_line":"        # host information."},{"line_number":158,"context_line":"        self.admin_authorized_contexts \u003d ["},{"line_number":159,"context_line":"            self.system_admin_context]"},{"line_number":160,"context_line":"        # Check that non-system/admin is not able to get the server topology"},{"line_number":161,"context_line":"        # host information."},{"line_number":162,"context_line":"        self.admin_unauthorized_contexts \u003d ["},{"line_number":163,"context_line":"            self.legacy_admin_context, self.system_member_context,"},{"line_number":164,"context_line":"            self.system_reader_context, self.system_foo_context,"},{"line_number":165,"context_line":"            self.project_admin_context, self.project_member_context,"},{"line_number":166,"context_line":"            self.other_project_member_context,"},{"line_number":167,"context_line":"            self.project_foo_context, self.project_reader_context"},{"line_number":168,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"df33271e_cc02ca6f","line":168,"range":{"start_line":156,"start_character":0,"end_line":168,"end_character":9},"in_reply_to":"df33271e_c208e029","updated":"2020-04-07 15:17:00.000000000","message":"yeah, as policy is system scope only so it eliminate the legacy admin context while scope enable only. \n\ndone","commit_id":"8d7742bd1e780ffd303615981e8b1aa8da390471"}]}