)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e0f642e9caf01012b6a59abd5232eec4a784cd88","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"                                \u0027vm_state\u0027, \u0027instance_type_id\u0027, \u0027uuid\u0027,"},{"line_number":1610,"context_line":"                                \u0027metadata\u0027, \u0027host\u0027, \u0027task_state\u0027,"},{"line_number":1611,"context_line":"                                \u0027system_metadata\u0027, \u0027locked\u0027, \u0027hidden\u0027,"},{"line_number":1612,"context_line":"                                \u0027config_drive\u0027]"},{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"    # Filter the query"},{"line_number":1615,"context_line":"    query_prefix \u003d _exact_instance_filter(query_prefix,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_2c4a5626","line":1612,"range":{"start_line":1612,"start_character":32,"end_line":1612,"end_character":46},"updated":"2020-04-07 15:06:58.000000000","message":"This ties us to using the literal strings True and False in the API. Do we insist on that at the moment? If not, perhaps we should do as we do for the \u0027deleted\u0027 query arg [1]?\n\n[1] https://github.com/openstack/nova/blob/cd16ae25c865f25dbb313976b3d8ef9372db80af/nova/api/openstack/compute/servers.py#L248-L259","commit_id":"b2ad8ca4566dd5b76065769bd8a71891c4f4ffef"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8e2ae9a2cdd07afb981bec70575a8b0abefcef6b","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"                                \u0027vm_state\u0027, \u0027instance_type_id\u0027, \u0027uuid\u0027,"},{"line_number":1610,"context_line":"                                \u0027metadata\u0027, \u0027host\u0027, \u0027task_state\u0027,"},{"line_number":1611,"context_line":"                                \u0027system_metadata\u0027, \u0027locked\u0027, \u0027hidden\u0027,"},{"line_number":1612,"context_line":"                                \u0027config_drive\u0027]"},{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"    # Filter the query"},{"line_number":1615,"context_line":"    query_prefix \u003d _exact_instance_filter(query_prefix,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_58d145cd","line":1612,"range":{"start_line":1612,"start_character":32,"end_line":1612,"end_character":46},"in_reply_to":"df33271e_2c4a5626","updated":"2020-04-08 03:39:28.000000000","message":"I think this way will make the config_drive complex, how about change it to boolean type, as I comment in bug 1871409:\n\nI think we can enable config_drive to True/False, only a boolean type, that in:\n\n* Create Server ``POST /servers`` API, request config_drive is boolean type [1], it\u0027s parameter type is boolean\n* List Servers Detailed  ``GET /servers/detail`` API, return \"config_drive\": \"\" [2], it\u0027s parameter type is string\n* Show Server Details ``GET /servers/{server_id}`` API, return \"config_drive\": \"\" [2], it\u0027s parameter type is string\n\nWe have already done boolean verification when the request was created, IMO the response can be consistent.\nThis way we need to change the nova api, that need to add a micorversion to support, \u003d\u003e https://etherpad.openstack.org/p/nova-api-cleanup L86.\n\n[1]https://opendev.org/openstack/nova/src/branch/master/api-ref/source/parameters.yaml#L2079-L2089\n[2]https://opendev.org/openstack/nova/src/branch/master/api-ref/source/parameters.yaml#L2097-L2104","commit_id":"b2ad8ca4566dd5b76065769bd8a71891c4f4ffef"}]}