)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"97faff56d64668ef270ed2f5855a7ce661d41c6b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"microversion 2.85. The schema enforced \"\u0027delete_on_termination\u0027:"},{"line_number":11,"context_line":"parameter_types.boolean\" that field value is a boolean like string,"},{"line_number":12,"context_line":"but we donot covert from string to boolean before update the"},{"line_number":13,"context_line":"attachment\u0027s bdm, see [1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1]http://paste.openstack.org/show/791792/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This commit fix this issue, convert \u0027delete_on_termination\u0027 from string"},{"line_number":18,"context_line":"to boolean before updating the bdm."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_e1c05de3","line":15,"range":{"start_line":13,"start_character":18,"end_line":15,"end_character":42},"updated":"2020-04-08 11:34:05.000000000","message":"That\u0027s going to be lost eventually, can you add it as a comment in the bug?","commit_id":"3298e0447f228f2ebe9ecb3866f6d91da2618d90"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8a0d40d027fe68b02c27c5fa461102e7f9ed0b4e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"microversion 2.85. The schema enforced \"\u0027delete_on_termination\u0027:"},{"line_number":11,"context_line":"parameter_types.boolean\" that field value is a boolean like string,"},{"line_number":12,"context_line":"but we donot covert from string to boolean before update the"},{"line_number":13,"context_line":"attachment\u0027s bdm, see [1]."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1]http://paste.openstack.org/show/791792/"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This commit fix this issue, convert \u0027delete_on_termination\u0027 from string"},{"line_number":18,"context_line":"to boolean before updating the bdm."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df33271e_54458914","line":15,"range":{"start_line":13,"start_character":18,"end_line":15,"end_character":42},"in_reply_to":"df33271e_e1c05de3","updated":"2020-04-08 12:14:51.000000000","message":"OK, will comment in the bug.","commit_id":"3298e0447f228f2ebe9ecb3866f6d91da2618d90"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"37d1b77ab125efabe62c6f3149f783bd9d639ebf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In volume update API we can update the \u0027delete_on_termination\u0027 since"},{"line_number":10,"context_line":"microversion 2.85. The schema enforced \"\u0027delete_on_termination\u0027:"},{"line_number":11,"context_line":"parameter_types.boolean\" that field value is a boolean like string,"},{"line_number":12,"context_line":"but we donot covert from string to boolean before update the"},{"line_number":13,"context_line":"attachment\u0027s bdm, see [1] (it is also commented in bug 1871598.)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1]http://paste.openstack.org/show/791792/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df33271e_f7365fb4","line":12,"range":{"start_line":12,"start_character":7,"end_line":12,"end_character":12},"updated":"2020-04-08 12:31:45.000000000","message":"nit: do not","commit_id":"98fbff8b4c7eb2c62c74f28bb344a09094729212"}],"nova/api/openstack/compute/volumes.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"97faff56d64668ef270ed2f5855a7ce661d41c6b","unresolved":false,"context_lines":[{"line_number":452,"context_line":"                raise exc.HTTPBadRequest(explanation\u003d\u0027The tag property is \u0027"},{"line_number":453,"context_line":"                                         \u0027not mutable\u0027)"},{"line_number":454,"context_line":"            if \u0027delete_on_termination\u0027 in att:"},{"line_number":455,"context_line":"                bdm.delete_on_termination \u003d strutils.bool_from_string("},{"line_number":456,"context_line":"                        att[\u0027delete_on_termination\u0027])"},{"line_number":457,"context_line":"            bdm.save()"},{"line_number":458,"context_line":"        except exception.VolumeBDMNotFound as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_c12ef9a3","line":455,"range":{"start_line":455,"start_character":44,"end_line":455,"end_character":69},"updated":"2020-04-08 11:34:05.000000000","message":"Should we use strict\u003dTrue and catch ValueError\u0027s?\n\nhttps://github.com/openstack/oslo.utils/blob/2180db82b605cf84902ee379fffc0b34e17e92c7/oslo_utils/strutils.py#L123-L158\n\nOtherwise this is going to default to False. Otherwise if a user is attempting to update this to True but provides `foo` the request is successful but it remains False.","commit_id":"3298e0447f228f2ebe9ecb3866f6d91da2618d90"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8a0d40d027fe68b02c27c5fa461102e7f9ed0b4e","unresolved":false,"context_lines":[{"line_number":452,"context_line":"                raise exc.HTTPBadRequest(explanation\u003d\u0027The tag property is \u0027"},{"line_number":453,"context_line":"                                         \u0027not mutable\u0027)"},{"line_number":454,"context_line":"            if \u0027delete_on_termination\u0027 in att:"},{"line_number":455,"context_line":"                bdm.delete_on_termination \u003d strutils.bool_from_string("},{"line_number":456,"context_line":"                        att[\u0027delete_on_termination\u0027])"},{"line_number":457,"context_line":"            bdm.save()"},{"line_number":458,"context_line":"        except exception.VolumeBDMNotFound as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_975ef30f","line":455,"range":{"start_line":455,"start_character":44,"end_line":455,"end_character":69},"in_reply_to":"df33271e_54d74950","updated":"2020-04-08 12:14:51.000000000","message":"Right, I will update it.","commit_id":"3298e0447f228f2ebe9ecb3866f6d91da2618d90"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6bc7b14f576287c230acec64dd319a071ee5a5fc","unresolved":false,"context_lines":[{"line_number":452,"context_line":"                raise exc.HTTPBadRequest(explanation\u003d\u0027The tag property is \u0027"},{"line_number":453,"context_line":"                                         \u0027not mutable\u0027)"},{"line_number":454,"context_line":"            if \u0027delete_on_termination\u0027 in att:"},{"line_number":455,"context_line":"                bdm.delete_on_termination \u003d strutils.bool_from_string("},{"line_number":456,"context_line":"                        att[\u0027delete_on_termination\u0027])"},{"line_number":457,"context_line":"            bdm.save()"},{"line_number":458,"context_line":"        except exception.VolumeBDMNotFound as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_54d74950","line":455,"range":{"start_line":455,"start_character":44,"end_line":455,"end_character":69},"in_reply_to":"df33271e_c12ef9a3","updated":"2020-04-08 11:37:40.000000000","message":"We could even call strutils.is_valid_boolstr(att[\u0027delete_on_termination\u0027]) to determine if it\u0027s valid before calling strutils.bool_from_string and catching ValueError\u0027s.","commit_id":"3298e0447f228f2ebe9ecb3866f6d91da2618d90"}],"nova/tests/unit/api/openstack/compute/test_volumes.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"97faff56d64668ef270ed2f5855a7ce661d41c6b","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"        body \u003d {\u0027volumeAttachment\u0027: {"},{"line_number":1257,"context_line":"            \u0027volumeId\u0027: FAKE_UUID_A,"},{"line_number":1258,"context_line":"            \u0027tag\u0027: \u0027fake-tag\u0027,"},{"line_number":1259,"context_line":"            \u0027delete_on_termination\u0027: \u0027False\u0027,"},{"line_number":1260,"context_line":"            \u0027device\u0027: \u0027/dev/fake0\u0027,"},{"line_number":1261,"context_line":"        }}"},{"line_number":1262,"context_line":"        self.attachments.update(self.req, FAKE_UUID,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_a17bf5bb","line":1259,"range":{"start_line":1259,"start_character":0,"end_line":1259,"end_character":45},"updated":"2020-04-08 11:34:05.000000000","message":"nit - would be good to test this with other acceptable values, \u0027true\u0027, \u0027True\u0027, \u0027false\u0027 etc?","commit_id":"3298e0447f228f2ebe9ecb3866f6d91da2618d90"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"8a0d40d027fe68b02c27c5fa461102e7f9ed0b4e","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"        body \u003d {\u0027volumeAttachment\u0027: {"},{"line_number":1257,"context_line":"            \u0027volumeId\u0027: FAKE_UUID_A,"},{"line_number":1258,"context_line":"            \u0027tag\u0027: \u0027fake-tag\u0027,"},{"line_number":1259,"context_line":"            \u0027delete_on_termination\u0027: \u0027False\u0027,"},{"line_number":1260,"context_line":"            \u0027device\u0027: \u0027/dev/fake0\u0027,"},{"line_number":1261,"context_line":"        }}"},{"line_number":1262,"context_line":"        self.attachments.update(self.req, FAKE_UUID,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_b76337dc","line":1259,"range":{"start_line":1259,"start_character":0,"end_line":1259,"end_character":45},"in_reply_to":"df33271e_a17bf5bb","updated":"2020-04-08 12:14:51.000000000","message":"Done","commit_id":"3298e0447f228f2ebe9ecb3866f6d91da2618d90"}]}