)]}'
{"nova/api/openstack/compute/flavor_access.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"98ab75f76c0a407662d9ce6db787b0ede528da88","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def index(self, req, flavor_id):"},{"line_number":44,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":45,"context_line":"        context.can(fa_policies.BASE_POLICY_NAME,"},{"line_number":46,"context_line":"                    target\u003d{\u0027project_id\u0027: context.project_id})"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        flavor \u003d common.get_flavor(context, flavor_id)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_a391809c","line":46,"updated":"2020-04-14 08:51:54.000000000","message":"Not sure what the project I’d means here? It’s a noop right? If we want this we should check project scope rather than the id.","commit_id":"813e24e95c4d5d6c4a91abed3d2b140570e40648"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"d661ce803d21bcb52455833e472668eb867da6fb","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def index(self, req, flavor_id):"},{"line_number":44,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":45,"context_line":"        context.can(fa_policies.BASE_POLICY_NAME,"},{"line_number":46,"context_line":"                    target\u003d{\u0027project_id\u0027: context.project_id})"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        flavor \u003d common.get_flavor(context, flavor_id)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4c43b2_12c34eef","line":46,"in_reply_to":"3f4c43b2_a391809c","updated":"2020-04-14 17:57:43.000000000","message":"I am passing these to support the old defaults in case we want to remove the default_targets[1] but that is not going till we switch the scope things. So I can keep it not passing target now and later once we switch to scope checks by default then we can pass. \n\n[1] https://github.com/openstack/nova/blob/9001d7e3459d97f507e8ce638d1fc3935401252d/nova/policy.py#L167","commit_id":"813e24e95c4d5d6c4a91abed3d2b140570e40648"}]}