)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a247c09c9c7ed19e881037cd9ccfe9f8ae92292","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we use the flavor extra_specs \"hide_hypervisor_id\" in"},{"line_number":10,"context_line":"AggregateInstanceExtraSpecsFilter, then will retrun False."},{"line_number":11,"context_line":"So we need correct the extra_specs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9d8d8c3a30cf6da7e8fb48374347e069ab075df2"},{"line_number":14,"context_line":"Closes-Bug: 1841932"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_50ccf933","line":11,"updated":"2020-04-30 16:55:05.000000000","message":"You need to support both types and simply consider the older style deprecated. You also need to add a validator to \u0027nova/api/validation/extra_specs/hw.py\u0027. You can copy the one for \u0027hide_hypervisor_id\u0027 from \u0027nova/api/validation/extra_specs/null.py\u0027","commit_id":"025e4e5d15c7b71dacb64ae006046011ae88757c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52b923379165147b8e2a0c0c5e97c237f920e6e0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"So we need correct the extra_specs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9d8d8c3a30cf6da7e8fb48374347e069ab075df2"},{"line_number":14,"context_line":"Closes-Bug: 1841932"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f493fa4_57f78bd5","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":19},"updated":"2020-05-05 11:45:05.000000000","message":"can you add a release note for this sice we are introducing a new extra spec and deprecating the old one.","commit_id":"261bdb6713ef3119df82b71de59721d9997a82ab"}],"doc/source/user/flavors.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a247c09c9c7ed19e881037cd9ccfe9f8ae92292","unresolved":false,"context_lines":[{"line_number":747,"context_line":""},{"line_number":748,"context_line":"  - VALUE: (string) \u0027true\u0027 or \u0027false\u0027. \u0027false\u0027 is equivalent to the"},{"line_number":749,"context_line":"    property not existing."},{"line_number":750,"context_line":""},{"line_number":751,"context_line":".. _extra-specs-secure-boot:"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"Secure Boot"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1f493fa4_90b9617a","line":750,"updated":"2020-04-30 16:55:05.000000000","message":"can you add a versionchanged directive here stating that this was previously called \u0027hide_hypervisor_id\u0027 and the old name is still supported\n\n  .. versionchanged:: 22.0.0\n\n     Previously, ...","commit_id":"025e4e5d15c7b71dacb64ae006046011ae88757c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d174a291388c0678c5f7993dece1953e22f7d5a3","unresolved":false,"context_lines":[{"line_number":738,"context_line":"     As of the 18.0.0 Rocky release, this is only supported by the libvirt"},{"line_number":739,"context_line":"     driver."},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"     Before the 22.0.0 Ussuri release, this was previously called"},{"line_number":742,"context_line":"     \u0027hide_hypervisor_id\u0027 and the old name is still supported."},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"  .. code:: console"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_9c2018fa","line":741,"range":{"start_line":741,"start_character":5,"end_line":741,"end_character":11},"updated":"2020-05-05 10:55:50.000000000","message":"Prior to","commit_id":"261bdb6713ef3119df82b71de59721d9997a82ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d174a291388c0678c5f7993dece1953e22f7d5a3","unresolved":false,"context_lines":[{"line_number":738,"context_line":"     As of the 18.0.0 Rocky release, this is only supported by the libvirt"},{"line_number":739,"context_line":"     driver."},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"     Before the 22.0.0 Ussuri release, this was previously called"},{"line_number":742,"context_line":"     \u0027hide_hypervisor_id\u0027 and the old name is still supported."},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"  .. code:: console"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_7c1d4cbc","line":741,"range":{"start_line":741,"start_character":48,"end_line":741,"end_character":58},"updated":"2020-05-05 10:55:50.000000000","message":"drop this word","commit_id":"261bdb6713ef3119df82b71de59721d9997a82ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d174a291388c0678c5f7993dece1953e22f7d5a3","unresolved":false,"context_lines":[{"line_number":739,"context_line":"     driver."},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"     Before the 22.0.0 Ussuri release, this was previously called"},{"line_number":742,"context_line":"     \u0027hide_hypervisor_id\u0027 and the old name is still supported."},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"  .. code:: console"},{"line_number":745,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_fc867cdb","line":742,"range":{"start_line":742,"start_character":25,"end_line":742,"end_character":62},"updated":"2020-05-05 10:55:50.000000000","message":"An alias is provided to provide backwards compatibility.","commit_id":"261bdb6713ef3119df82b71de59721d9997a82ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d174a291388c0678c5f7993dece1953e22f7d5a3","unresolved":false,"context_lines":[{"line_number":739,"context_line":"     driver."},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"     Before the 22.0.0 Ussuri release, this was previously called"},{"line_number":742,"context_line":"     \u0027hide_hypervisor_id\u0027 and the old name is still supported."},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"  .. code:: console"},{"line_number":745,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1f493fa4_dc774008","line":742,"range":{"start_line":742,"start_character":5,"end_line":742,"end_character":25},"updated":"2020-05-05 10:55:50.000000000","message":"``hide_hypervisor_id``","commit_id":"261bdb6713ef3119df82b71de59721d9997a82ab"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"af92beb4c9bd8ff0862ae9abffec6f21d8216b70","unresolved":false,"context_lines":[{"line_number":738,"context_line":"     As of the 18.0.0 Rocky release, this is only supported by the libvirt"},{"line_number":739,"context_line":"     driver."},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"     Prior to the 22.0.0 Ussuri release, this was called"},{"line_number":742,"context_line":"     ``hide_hypervisor_id``. An alias is provided to provide backwards"},{"line_number":743,"context_line":"     compatibility."},{"line_number":744,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1f493fa4_7fca4c4f","line":741,"range":{"start_line":741,"start_character":18,"end_line":741,"end_character":24},"updated":"2020-05-06 06:46:49.000000000","message":"21.0.0 Ussuri release","commit_id":"93c12799b48e1874bf7f8ac6e63e4cab3d7e2f35"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"89230ad5ab4a7641ca5e1255cb5f9753a6c59c07","unresolved":false,"context_lines":[{"line_number":742,"context_line":"     ``hide_hypervisor_id``. An alias is provided to provide backwards"},{"line_number":743,"context_line":"     compatibility."},{"line_number":744,"context_line":""},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"  .. code:: console"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"     $ openstack flavor set FLAVOR-NAME \\"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1f493fa4_19688385","line":745,"updated":"2020-05-06 10:07:39.000000000","message":"nit: extra newline","commit_id":"b32905e1424fdc45b8c10ce6c36e8de31f7f8c07"}],"nova/api/validation/extra_specs/hw.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d174a291388c0678c5f7993dece1953e22f7d5a3","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        hugepage_validators +"},{"line_number":381,"context_line":"        numa_validators +"},{"line_number":382,"context_line":"        cpu_topology_validators +"},{"line_number":383,"context_line":"        hide_hypervisor_id_validator +"},{"line_number":384,"context_line":"        feature_flag_validators"},{"line_number":385,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_7c726c13","line":383,"updated":"2020-05-05 10:55:50.000000000","message":"nit: Can you place this before \u0027cpu_policy_validators\u0027 so this list has the same order as the file?","commit_id":"261bdb6713ef3119df82b71de59721d9997a82ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"89230ad5ab4a7641ca5e1255cb5f9753a6c59c07","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \u0027description\u0027: \u0027Whether to hide the hypervisor ID.\u0027,"},{"line_number":55,"context_line":"        },"},{"line_number":56,"context_line":"    )"},{"line_number":57,"context_line":"]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"cpu_policy_validators \u003d ["},{"line_number":60,"context_line":"    base.ExtraSpecValidator("}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_59be8bd4","line":57,"updated":"2020-05-06 10:07:39.000000000","message":"could you also add \u0027deprecated\u003dTrue\u0027 to the old \u0027hide_hypervisor_id\u0027 extra spec definition in \u0027nova/api/validation/extra_specs/null.py\u0027? You should also modify the description to include something like the following:\n\n  This extra spec is not compatible with the \n  \u0027AggregateInstanceExtraSpecsFilter\u0027 scheduler filter. The\n  \u0027hw:hide_hypervisor_id\u0027 extra spec should be used instead.","commit_id":"b32905e1424fdc45b8c10ce6c36e8de31f7f8c07"}],"nova/api/validation/extra_specs/null.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3deb9a922229707a20fe8068bdb9cdff161f03cd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        },"},{"line_number":34,"context_line":"        deprecated\u003dTrue,"},{"line_number":35,"context_line":"    ),"},{"line_number":36,"context_line":"    # TODO(stephenfin): This should be moved to a namespace"},{"line_number":37,"context_line":"    base.ExtraSpecValidator("},{"line_number":38,"context_line":"        name\u003d\u0027group_policy\u0027,"},{"line_number":39,"context_line":"        description\u003d("}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_6da3c1b2","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":59},"updated":"2020-05-06 13:42:37.000000000","message":"we could add a \"placement:\" namespace i guess that said i do not know of a correct way to use isolate that wont potentaill break other features so in my view this should only ever be set to none and we should consider removing it entirely.","commit_id":"fc7f784e112b260c1da15d29ac07fcf5a10580ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"96ccd5d96abd0fe3104b622495c8703c4ecaa9e8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    base.ExtraSpecValidator("},{"line_number":23,"context_line":"        name\u003d\u0027hide_hypervisor_id\u0027,"},{"line_number":24,"context_line":"        description\u003d("},{"line_number":25,"context_line":"            \u0027This extra spec is not compatible with the \u0027"},{"line_number":26,"context_line":"            \u0027AggregateInstanceExtraSpecsFilter scheduler filter. The\u0027"},{"line_number":27,"context_line":"            \u0027``hw:hide_hypervisor_id`` extra spec should be used instead.\u0027"},{"line_number":28,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_eecfb854","line":25,"updated":"2020-05-07 08:55:40.000000000","message":"You reverted my changes from PS6. I assume that was accidental. When working on a patch, I suggest not keeping a local copy. Instead, each time you want to respin a patch you should download it from the server:\n\n  git review -d 722187\n\nand then when you\u0027re finished, you should push it to the server and delete the local copy:\n\n  git review -fy","commit_id":"539fa51c36096d8ea4f45983099c638c97510366"},{"author":{"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},"change_message_id":"5ff96327fec06d37f2375cffa08844afc7d16565","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027type\u0027: bool,"},{"line_number":31,"context_line":"            \u0027description\u0027: \u0027Whether to hide the hypervisor ID.\u0027,"},{"line_number":32,"context_line":"        },"},{"line_number":33,"context_line":"        deprecated\u003dTrue,"},{"line_number":34,"context_line":"    ),"},{"line_number":35,"context_line":"    base.ExtraSpecValidator("},{"line_number":36,"context_line":"        name\u003d\u0027group_policy\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_9476f1d7","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":24},"updated":"2020-05-08 05:46:45.000000000","message":"when we delete this, the docs tests will pass. But I don\u0027t know why.","commit_id":"539fa51c36096d8ea4f45983099c638c97510366"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed33f272363e90eb51ef10089eeca89b1aae14ca","unresolved":false,"context_lines":[{"line_number":30,"context_line":"            \u0027type\u0027: bool,"},{"line_number":31,"context_line":"            \u0027description\u0027: \u0027Whether to hide the hypervisor ID.\u0027,"},{"line_number":32,"context_line":"        },"},{"line_number":33,"context_line":"        deprecated\u003dTrue,"},{"line_number":34,"context_line":"    ),"},{"line_number":35,"context_line":"    base.ExtraSpecValidator("},{"line_number":36,"context_line":"        name\u003d\u0027group_policy\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_257369b3","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":24},"in_reply_to":"1f493fa4_9476f1d7","updated":"2020-05-08 09:19:15.000000000","message":"I resolved this.","commit_id":"539fa51c36096d8ea4f45983099c638c97510366"}],"nova/api/validation/extra_specs/validators.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d174a291388c0678c5f7993dece1953e22f7d5a3","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            break"},{"line_number":58,"context_line":"    else:"},{"line_number":59,"context_line":"        return"},{"line_number":60,"context_line":"    raise exception.ValidationError("},{"line_number":61,"context_line":"        f\"Validation failed; extra spec \u0027{name}\u0027 does not appear to be a \""},{"line_number":62,"context_line":"        f\"valid extra spec.\""},{"line_number":63,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_bc651448","line":60,"updated":"2020-05-05 10:55:50.000000000","message":"unrelated (and incorrect, IMO) change","commit_id":"261bdb6713ef3119df82b71de59721d9997a82ab"}],"nova/tests/unit/api/openstack/compute/test_flavors_extra_specs.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a247c09c9c7ed19e881037cd9ccfe9f8ae92292","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    @mock.patch(\u0027nova.objects.flavor._flavor_extra_specs_add\u0027)"},{"line_number":297,"context_line":"    def test_create_valid_specs(self, mock_flavor_extra_specs):"},{"line_number":298,"context_line":"        valid_specs \u003d {"},{"line_number":299,"context_line":"            \u0027hw:hide_hypervisor_id\u0027: \u0027true\u0027,"},{"line_number":300,"context_line":"            \u0027hw:numa_nodes\u0027: \u00271\u0027,"},{"line_number":301,"context_line":"            \u0027hw:numa_cpus.0\u0027: \u00270-3,8-9,11,10\u0027,"},{"line_number":302,"context_line":"            \u0027resources:VCPU\u0027: \u00274\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_7065b51d","line":299,"updated":"2020-04-30 16:55:05.000000000","message":"The old one has to stay valid","commit_id":"025e4e5d15c7b71dacb64ae006046011ae88757c"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d174a291388c0678c5f7993dece1953e22f7d5a3","unresolved":false,"context_lines":[{"line_number":4499,"context_line":"        self.flags(virt_type\u003d\u0027qemu\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":4500,"context_line":""},{"line_number":4501,"context_line":"        self._test_get_guest_config_windows_hyperv("},{"line_number":4502,"context_line":"            flavor\u003dflavor_hide_id, hvid_hidden\u003dTrue)"},{"line_number":4503,"context_line":""},{"line_number":4504,"context_line":"    def test_get_guest_config_windows_hyperv_all_hide_img(self):"},{"line_number":4505,"context_line":"        # Similar to test_get_guest_config_windows_hyperv_feature2"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_fc5f9c6f","line":4502,"updated":"2020-05-05 10:55:50.000000000","message":"Can you add a new tests that validates the old extra spec is still parsed too?","commit_id":"261bdb6713ef3119df82b71de59721d9997a82ab"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"52b923379165147b8e2a0c0c5e97c237f920e6e0","unresolved":false,"context_lines":[{"line_number":4499,"context_line":"        self.flags(virt_type\u003d\u0027qemu\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":4500,"context_line":""},{"line_number":4501,"context_line":"        self._test_get_guest_config_windows_hyperv("},{"line_number":4502,"context_line":"            flavor\u003dflavor_hide_id, hvid_hidden\u003dTrue)"},{"line_number":4503,"context_line":""},{"line_number":4504,"context_line":"    def test_get_guest_config_windows_hyperv_all_hide_img(self):"},{"line_number":4505,"context_line":"        # Similar to test_get_guest_config_windows_hyperv_feature2"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_d75efbe7","line":4502,"in_reply_to":"1f493fa4_fc5f9c6f","updated":"2020-05-05 11:45:05.000000000","message":"yes i was going to say the same.\nwe need to still support the old extra spec even if it is now deprecated and should not be used for new vms.","commit_id":"261bdb6713ef3119df82b71de59721d9997a82ab"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a247c09c9c7ed19e881037cd9ccfe9f8ae92292","unresolved":false,"context_lines":[{"line_number":5170,"context_line":"            flavor):"},{"line_number":5171,"context_line":"        hide_hypervisor_id \u003d (strutils.bool_from_string("},{"line_number":5172,"context_line":"                flavor.extra_specs.get(\u0027hw:hide_hypervisor_id\u0027)) or"},{"line_number":5173,"context_line":"            image_meta.properties.get(\u0027img_hide_hypervisor_id\u0027))"},{"line_number":5174,"context_line":""},{"line_number":5175,"context_line":"        if virt_type \u003d\u003d \"xen\":"},{"line_number":5176,"context_line":"            # PAE only makes sense in X86"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_906e81fd","line":5173,"updated":"2020-04-30 16:55:05.000000000","message":"You have to support the old version of this also.","commit_id":"025e4e5d15c7b71dacb64ae006046011ae88757c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d174a291388c0678c5f7993dece1953e22f7d5a3","unresolved":false,"context_lines":[{"line_number":5187,"context_line":"        hide_hypervisor_id \u003d (strutils.bool_from_string("},{"line_number":5188,"context_line":"                flavor.extra_specs.get(\u0027hide_hypervisor_id\u0027)) or"},{"line_number":5189,"context_line":"                strutils.bool_from_string("},{"line_number":5190,"context_line":"                flavor.extra_specs.get(\u0027hw:hide_hypervisor_id\u0027)) or"},{"line_number":5191,"context_line":"                image_meta.properties.get(\u0027img_hide_hypervisor_id\u0027))"},{"line_number":5192,"context_line":""},{"line_number":5193,"context_line":"        if virt_type \u003d\u003d \"xen\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_fcd4bcbf","line":5190,"range":{"start_line":5190,"start_character":15,"end_line":5190,"end_character":16},"updated":"2020-05-05 10:55:50.000000000","message":"nit: this would read better if it was indented by four spaces","commit_id":"261bdb6713ef3119df82b71de59721d9997a82ab"}],"releasenotes/notes/bug-1841932-c871ac7b3b05d67e.yaml":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"af92beb4c9bd8ff0862ae9abffec6f21d8216b70","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hide_hypervisor_id extra_specs in nova flavor cannot pass"},{"line_number":5,"context_line":"    AggregateInstanceExtraSpecsFilter. So we add an alias to provide"},{"line_number":6,"context_line":"    backwards compatibility. See"},{"line_number":7,"context_line":"    `bug 1841932 \u003chttps://bugs.launchpad.net/nova/+bug/1841932\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_5fccb060","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":22},"updated":"2020-05-06 06:46:49.000000000","message":"nit: ``hide_hypervisor_id``","commit_id":"93c12799b48e1874bf7f8ac6e63e4cab3d7e2f35"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"89230ad5ab4a7641ca5e1255cb5f9753a6c59c07","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ``hide_hypervisor_id`` extra_specs in nova flavor cannot pass"},{"line_number":5,"context_line":"    AggregateInstanceExtraSpecsFilter. So we add an alias to provide"},{"line_number":6,"context_line":"    backwards compatibility. See"},{"line_number":7,"context_line":"    `bug 1841932 \u003chttps://bugs.launchpad.net/nova/+bug/1841932\u003e`__"},{"line_number":8,"context_line":"    for details."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_b9dcef46","line":8,"range":{"start_line":4,"start_character":4,"end_line":8,"end_character":16},"updated":"2020-05-06 10:07:39.000000000","message":"This still doesn\u0027t really explain things. How about:\n\n  Add support for the ``hw:hide_hypervisor_id`` extra spec. This is an\n  alias for the ``hide_hypervisor_id`` extra spec, which was not\n  compatible with the ``AggregateInstanceExtraSpecsFilter`` scheduler\n  filter. See\n  `bug 1841932 \u003chttps://bugs.launchpad.net/nova/+bug/1841932\u003e`__\n  for more details.","commit_id":"b32905e1424fdc45b8c10ce6c36e8de31f7f8c07"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"df38b10bbe8f5274fcc2bc2ca903bbb103b1141e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add support for the ``hw:hide_hypervisor_id`` extra spec. This is an"},{"line_number":5,"context_line":"    alias for the ``hide_hypervisor_id`` extra spec, which was not"},{"line_number":6,"context_line":"    compatible with the ``AggregateInstanceExtraSpecsFilter`` scheduler"},{"line_number":7,"context_line":"    filter. See `bug 1841932 \u003chttps://bugs.launchpad.net/nova/+bug/1841932\u003e`__"},{"line_number":8,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_9f6d819b","line":7,"range":{"start_line":7,"start_character":77,"end_line":7,"end_character":78},"updated":"2020-05-07 05:58:15.000000000","message":"It has two \"_\", I think you should remove one.","commit_id":"fc7f784e112b260c1da15d29ac07fcf5a10580ad"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"29c71b4961fb4b7e93082d678176d2a6168326a5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add support for the ``hw:hide_hypervisor_id`` extra spec. This is an"},{"line_number":5,"context_line":"    alias for the ``hide_hypervisor_id`` extra spec, which was not"},{"line_number":6,"context_line":"    compatible with the ``AggregateInstanceExtraSpecsFilter`` scheduler"},{"line_number":7,"context_line":"    filter. See `bug 1841932 \u003chttps://bugs.launchpad.net/nova/+bug/1841932\u003e`__"},{"line_number":8,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_04c4855e","line":7,"range":{"start_line":7,"start_character":77,"end_line":7,"end_character":78},"in_reply_to":"1f493fa4_2ec5203d","updated":"2020-05-07 10:38:55.000000000","message":"Thanks stephenfin, got it, IMO, it ok for one _ or two _ at here.","commit_id":"fc7f784e112b260c1da15d29ac07fcf5a10580ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cda9947ab8e3e4447f56b4860a2757938ea20be1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add support for the ``hw:hide_hypervisor_id`` extra spec. This is an"},{"line_number":5,"context_line":"    alias for the ``hide_hypervisor_id`` extra spec, which was not"},{"line_number":6,"context_line":"    compatible with the ``AggregateInstanceExtraSpecsFilter`` scheduler"},{"line_number":7,"context_line":"    filter. See `bug 1841932 \u003chttps://bugs.launchpad.net/nova/+bug/1841932\u003e`__"},{"line_number":8,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_2ec5203d","line":7,"range":{"start_line":7,"start_character":77,"end_line":7,"end_character":78},"in_reply_to":"1f493fa4_4e4fcc69","updated":"2020-05-07 08:53:49.000000000","message":"This was actually correct as it was. Two underscores means \"don\u0027t create an anchor for this.\" With one underscore, it creates an anchor so you can reference it later in the document like so:\n\n  blah blah blah `bug 1841932`_ blah.\n\nwhich is okay in this case but should generally be avoided in release notes since anchors must have unique names and we could end up with conflicts on more generic names (e.g. \"see `this bug \u003chttps://.../\u003e`_ for more information\").","commit_id":"fc7f784e112b260c1da15d29ac07fcf5a10580ad"},{"author":{"_account_id":27594,"name":"Jie Li","email":"lijie@unitedstack.com","username":"ramboman"},"change_message_id":"08f724eb9d56027c8ca7feb386d7b04e1758a55b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Add support for the ``hw:hide_hypervisor_id`` extra spec. This is an"},{"line_number":5,"context_line":"    alias for the ``hide_hypervisor_id`` extra spec, which was not"},{"line_number":6,"context_line":"    compatible with the ``AggregateInstanceExtraSpecsFilter`` scheduler"},{"line_number":7,"context_line":"    filter. See `bug 1841932 \u003chttps://bugs.launchpad.net/nova/+bug/1841932\u003e`__"},{"line_number":8,"context_line":"    for more details."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1f493fa4_4e4fcc69","line":7,"range":{"start_line":7,"start_character":77,"end_line":7,"end_character":78},"in_reply_to":"1f493fa4_9f6d819b","updated":"2020-05-07 08:22:44.000000000","message":"thank you, done","commit_id":"fc7f784e112b260c1da15d29ac07fcf5a10580ad"}]}