)]}'
{"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"89021fdcb1b8368d255b806a2ac46987957d9fd4","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                    continue"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"                alloc_reqs \u003d alloc_reqs_by_rp_uuid[cn_uuid]"},{"line_number":233,"context_line":"                # TODO(jaypipes): Loop through all allocation_requests instead"},{"line_number":234,"context_line":"                # of just trying the first one. For now, since we\u0027ll likely"},{"line_number":235,"context_line":"                # want to order the allocation_requests in the future based on"},{"line_number":236,"context_line":"                # information in the provider summaries, we\u0027ll just try to"},{"line_number":237,"context_line":"                # claim resources using the first allocation_request"},{"line_number":238,"context_line":"                for alloc_req in alloc_reqs:"},{"line_number":239,"context_line":"                    if utils.claim_resources(elevated, self.placement_client,"},{"line_number":240,"context_line":"                            spec_obj, instance_uuid, alloc_req,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_7e9b0965","line":237,"range":{"start_line":233,"start_character":0,"end_line":237,"end_character":68},"updated":"2020-04-28 11:22:57.000000000","message":"This TODO needs adjustment as now we do iterate on allocation candidates. But we still need to keep a TODO about future improvement of a custom ordering of the iteration (a.k.a preferring one allocation candidate over another)","commit_id":"39f50c0013b92b5b4b35108cabf17db7a344db76"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"89021fdcb1b8368d255b806a2ac46987957d9fd4","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                                             allocation_request_version):"},{"line_number":243,"context_line":"                        claimed_host \u003d host"},{"line_number":244,"context_line":"                        break"},{"line_number":245,"context_line":"                if claimed_host:"},{"line_number":246,"context_line":"                    break"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"            if claimed_host is None:"},{"line_number":249,"context_line":"                # We weren\u0027t able to claim resources in the placement API"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_9ea255fb","line":246,"range":{"start_line":245,"start_character":1,"end_line":246,"end_character":25},"updated":"2020-04-28 11:22:57.000000000","message":"I\u0027m not sure you need this extra break as 243 already breaks form the for loop when claimed_host is set.","commit_id":"39f50c0013b92b5b4b35108cabf17db7a344db76"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"e451f801effffc7bccaf69fe709cc5d846cef956","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                                             allocation_request_version):"},{"line_number":243,"context_line":"                        claimed_host \u003d host"},{"line_number":244,"context_line":"                        break"},{"line_number":245,"context_line":"                if claimed_host:"},{"line_number":246,"context_line":"                    break"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"            if claimed_host is None:"},{"line_number":249,"context_line":"                # We weren\u0027t able to claim resources in the placement API"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_00d25100","line":246,"range":{"start_line":245,"start_character":1,"end_line":246,"end_character":25},"in_reply_to":"1f493fa4_9ea255fb","updated":"2020-05-12 10:37:11.000000000","message":"The break above breaks the alloc_reqs for loop.\nthe break here breaks the hosts for loop.","commit_id":"39f50c0013b92b5b4b35108cabf17db7a344db76"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"89021fdcb1b8368d255b806a2ac46987957d9fd4","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        # representing the selected host along with alternates from the same"},{"line_number":387,"context_line":"        # cell."},{"line_number":388,"context_line":"        selections_to_return \u003d []"},{"line_number":389,"context_line":"        for index, selected_host in enumerate(selected_hosts):"},{"line_number":390,"context_line":"            # This is the list of hosts for one particular instance."},{"line_number":391,"context_line":"            if alloc_reqs_by_rp_uuid:"},{"line_number":392,"context_line":"                alloc_reqs \u003d alloc_reqs_by_rp_uuid.get(selected_host.uuid)"},{"line_number":393,"context_line":"                index \u003d index if len(alloc_reqs) \u003e index else 0"},{"line_number":394,"context_line":"                selected_alloc_req \u003d alloc_reqs[index]"},{"line_number":395,"context_line":"            else:"},{"line_number":396,"context_line":"                selected_alloc_req \u003d None"},{"line_number":397,"context_line":"            selection \u003d objects.Selection.from_host_state(selected_host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_498ad969","line":394,"range":{"start_line":389,"start_character":1,"end_line":394,"end_character":54},"updated":"2020-04-28 11:22:57.000000000","message":"I think this is buggy. I don\u0027t see how the index of selected_hosts list can be used as an index of alloc_requests for that given host.","commit_id":"39f50c0013b92b5b4b35108cabf17db7a344db76"}]}