)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"26565ec239e52c2fad7a573f8fa47730c0cce1a9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and end up having the new defaults only but expectation is that"},{"line_number":11,"context_line":"old deprecated rule keep working."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If rule is present in policy file then, that has priority than"},{"line_number":14,"context_line":"their defaults so either rule should not be present in policy file"},{"line_number":15,"context_line":"or users needs to update their token to match the overridden rule"},{"line_number":16,"context_line":"permission."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_d574c06a","line":13,"range":{"start_line":13,"start_character":3,"end_line":13,"end_character":7},"updated":"2020-04-28 07:34:47.000000000","message":"a rule","commit_id":"1901cf668e9fba529e037edd45b6af78bc34581f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"26565ec239e52c2fad7a573f8fa47730c0cce1a9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"and end up having the new defaults only but expectation is that"},{"line_number":11,"context_line":"old deprecated rule keep working."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If rule is present in policy file then, that has priority than"},{"line_number":14,"context_line":"their defaults so either rule should not be present in policy file"},{"line_number":15,"context_line":"or users needs to update their token to match the overridden rule"},{"line_number":16,"context_line":"permission."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_f5673cb6","line":13,"range":{"start_line":13,"start_character":58,"end_line":13,"end_character":62},"updated":"2020-04-28 07:34:47.000000000","message":"over","commit_id":"1901cf668e9fba529e037edd45b6af78bc34581f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"26565ec239e52c2fad7a573f8fa47730c0cce1a9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"old deprecated rule keep working."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If rule is present in policy file then, that has priority than"},{"line_number":14,"context_line":"their defaults so either rule should not be present in policy file"},{"line_number":15,"context_line":"or users needs to update their token to match the overridden rule"},{"line_number":16,"context_line":"permission."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_75116c04","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":14},"updated":"2020-04-28 07:34:47.000000000","message":"its defaults","commit_id":"1901cf668e9fba529e037edd45b6af78bc34581f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"26565ec239e52c2fad7a573f8fa47730c0cce1a9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"old deprecated rule keep working."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If rule is present in policy file then, that has priority than"},{"line_number":14,"context_line":"their defaults so either rule should not be present in policy file"},{"line_number":15,"context_line":"or users needs to update their token to match the overridden rule"},{"line_number":16,"context_line":"permission."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_1500e8aa","line":14,"range":{"start_line":14,"start_character":25,"end_line":14,"end_character":29},"updated":"2020-04-28 07:34:47.000000000","message":"rules","commit_id":"1901cf668e9fba529e037edd45b6af78bc34581f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"26565ec239e52c2fad7a573f8fa47730c0cce1a9","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If rule is present in policy file then, that has priority than"},{"line_number":14,"context_line":"their defaults so either rule should not be present in policy file"},{"line_number":15,"context_line":"or users needs to update their token to match the overridden rule"},{"line_number":16,"context_line":"permission."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This issue was always present when any policy defaults were changed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_f5fc5cb6","line":15,"range":{"start_line":15,"start_character":9,"end_line":15,"end_character":14},"updated":"2020-04-28 07:34:47.000000000","message":"need","commit_id":"1901cf668e9fba529e037edd45b6af78bc34581f"}],"nova/cmd/status.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b9c4dd898d5d6c149382b211f43f4aab314bf729","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        defaults."},{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        msg \u003d _(\"Your policy file is overwriten with new default values \""},{"line_number":356,"context_line":"                 \"which examines the token scope. If that is done \""},{"line_number":357,"context_line":"                 \"intentionally to migrate to new defaults then it is fine \""},{"line_number":358,"context_line":"                 \"and in future, you can use new flag \""},{"line_number":359,"context_line":"                 \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_3dcb27a5","line":356,"range":{"start_line":356,"start_character":16,"end_line":356,"end_character":17},"updated":"2020-04-29 12:35:15.000000000","message":"indentation is off","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"887a7d1d9b5568e17acdbc78102b8b74e848811c","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        defaults."},{"line_number":354,"context_line":"        \"\"\""},{"line_number":355,"context_line":"        msg \u003d _(\"Your policy file is overwriten with new default values \""},{"line_number":356,"context_line":"                 \"which examines the token scope. If that is done \""},{"line_number":357,"context_line":"                 \"intentionally to migrate to new defaults then it is fine \""},{"line_number":358,"context_line":"                 \"and in future, you can use new flag \""},{"line_number":359,"context_line":"                 \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_022ec7f9","line":356,"range":{"start_line":356,"start_character":16,"end_line":356,"end_character":17},"in_reply_to":"1f493fa4_3dcb27a5","updated":"2020-04-29 15:43:42.000000000","message":"Done","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b9c4dd898d5d6c149382b211f43f4aab314bf729","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        msg \u003d _(\"Your policy file is overwriten with new default values \""},{"line_number":356,"context_line":"                 \"which examines the token scope. If that is done \""},{"line_number":357,"context_line":"                 \"intentionally to migrate to new defaults then it is fine \""},{"line_number":358,"context_line":"                 \"and in future, you can use new flag \""},{"line_number":359,"context_line":"                 \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""},{"line_number":360,"context_line":"                 \"without overwriting the policy file. If you did not intend \""},{"line_number":361,"context_line":"                 \"to migrate to new default in this upgrade then \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_5dc39389","line":358,"range":{"start_line":358,"start_character":22,"end_line":358,"end_character":31},"updated":"2020-04-29 12:35:15.000000000","message":"in the future","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b9c4dd898d5d6c149382b211f43f4aab314bf729","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        msg \u003d _(\"Your policy file is overwriten with new default values \""},{"line_number":356,"context_line":"                 \"which examines the token scope. If that is done \""},{"line_number":357,"context_line":"                 \"intentionally to migrate to new defaults then it is fine \""},{"line_number":358,"context_line":"                 \"and in future, you can use new flag \""},{"line_number":359,"context_line":"                 \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""},{"line_number":360,"context_line":"                 \"without overwriting the policy file. If you did not intend \""},{"line_number":361,"context_line":"                 \"to migrate to new default in this upgrade then \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_fd39bfa3","line":358,"range":{"start_line":358,"start_character":45,"end_line":358,"end_character":53},"updated":"2020-04-29 12:35:15.000000000","message":"then new flag","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"887a7d1d9b5568e17acdbc78102b8b74e848811c","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        msg \u003d _(\"Your policy file is overwriten with new default values \""},{"line_number":356,"context_line":"                 \"which examines the token scope. If that is done \""},{"line_number":357,"context_line":"                 \"intentionally to migrate to new defaults then it is fine \""},{"line_number":358,"context_line":"                 \"and in future, you can use new flag \""},{"line_number":359,"context_line":"                 \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""},{"line_number":360,"context_line":"                 \"without overwriting the policy file. If you did not intend \""},{"line_number":361,"context_line":"                 \"to migrate to new default in this upgrade then \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_e230fb58","line":358,"range":{"start_line":358,"start_character":22,"end_line":358,"end_character":31},"in_reply_to":"1f493fa4_5dc39389","updated":"2020-04-29 15:43:42.000000000","message":"Done","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"887a7d1d9b5568e17acdbc78102b8b74e848811c","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        msg \u003d _(\"Your policy file is overwriten with new default values \""},{"line_number":356,"context_line":"                 \"which examines the token scope. If that is done \""},{"line_number":357,"context_line":"                 \"intentionally to migrate to new defaults then it is fine \""},{"line_number":358,"context_line":"                 \"and in future, you can use new flag \""},{"line_number":359,"context_line":"                 \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""},{"line_number":360,"context_line":"                 \"without overwriting the policy file. If you did not intend \""},{"line_number":361,"context_line":"                 \"to migrate to new default in this upgrade then \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_824137ac","line":358,"range":{"start_line":358,"start_character":45,"end_line":358,"end_character":53},"in_reply_to":"1f493fa4_fd39bfa3","updated":"2020-04-29 15:43:42.000000000","message":"Done","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b9c4dd898d5d6c149382b211f43f4aab314bf729","unresolved":false,"context_lines":[{"line_number":358,"context_line":"                 \"and in future, you can use new flag \""},{"line_number":359,"context_line":"                 \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""},{"line_number":360,"context_line":"                 \"without overwriting the policy file. If you did not intend \""},{"line_number":361,"context_line":"                 \"to migrate to new default in this upgrade then \""},{"line_number":362,"context_line":"                 \"scope-checking rules will fail. For details about policy \""},{"line_number":363,"context_line":"                 \"changes and scope token, please refer to this document \""},{"line_number":364,"context_line":"                 \"https://docs.openstack.org/nova/latest/configuration\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_7d764f72","line":361,"range":{"start_line":361,"start_character":36,"end_line":361,"end_character":43},"updated":"2020-04-29 12:35:15.000000000","message":"defaults","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"887a7d1d9b5568e17acdbc78102b8b74e848811c","unresolved":false,"context_lines":[{"line_number":358,"context_line":"                 \"and in future, you can use new flag \""},{"line_number":359,"context_line":"                 \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""},{"line_number":360,"context_line":"                 \"without overwriting the policy file. If you did not intend \""},{"line_number":361,"context_line":"                 \"to migrate to new default in this upgrade then \""},{"line_number":362,"context_line":"                 \"scope-checking rules will fail. For details about policy \""},{"line_number":363,"context_line":"                 \"changes and scope token, please refer to this document \""},{"line_number":364,"context_line":"                 \"https://docs.openstack.org/nova/latest/configuration\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_c247bfbb","line":361,"range":{"start_line":361,"start_character":36,"end_line":361,"end_character":43},"in_reply_to":"1f493fa4_7d764f72","updated":"2020-04-29 15:43:42.000000000","message":"Done","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b9c4dd898d5d6c149382b211f43f4aab314bf729","unresolved":false,"context_lines":[{"line_number":358,"context_line":"                 \"and in future, you can use new flag \""},{"line_number":359,"context_line":"                 \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""},{"line_number":360,"context_line":"                 \"without overwriting the policy file. If you did not intend \""},{"line_number":361,"context_line":"                 \"to migrate to new default in this upgrade then \""},{"line_number":362,"context_line":"                 \"scope-checking rules will fail. For details about policy \""},{"line_number":363,"context_line":"                 \"changes and scope token, please refer to this document \""},{"line_number":364,"context_line":"                 \"https://docs.openstack.org/nova/latest/configuration\""},{"line_number":365,"context_line":"                 \"policy-concepts.html. Reason for such automatic overwritten \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_1d5c6beb","line":362,"range":{"start_line":361,"start_character":60,"end_line":362,"end_character":49},"updated":"2020-04-29 12:35:15.000000000","message":"then with your current policy file the scope checking rule will fail.","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"887a7d1d9b5568e17acdbc78102b8b74e848811c","unresolved":false,"context_lines":[{"line_number":358,"context_line":"                 \"and in future, you can use new flag \""},{"line_number":359,"context_line":"                 \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""},{"line_number":360,"context_line":"                 \"without overwriting the policy file. If you did not intend \""},{"line_number":361,"context_line":"                 \"to migrate to new default in this upgrade then \""},{"line_number":362,"context_line":"                 \"scope-checking rules will fail. For details about policy \""},{"line_number":363,"context_line":"                 \"changes and scope token, please refer to this document \""},{"line_number":364,"context_line":"                 \"https://docs.openstack.org/nova/latest/configuration\""},{"line_number":365,"context_line":"                 \"policy-concepts.html. Reason for such automatic overwritten \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_e2191bd7","line":362,"range":{"start_line":361,"start_character":60,"end_line":362,"end_character":49},"in_reply_to":"1f493fa4_1d5c6beb","updated":"2020-04-29 15:43:42.000000000","message":"Done","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b9c4dd898d5d6c149382b211f43f4aab314bf729","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                 \"scope-checking rules will fail. For details about policy \""},{"line_number":363,"context_line":"                 \"changes and scope token, please refer to this document \""},{"line_number":364,"context_line":"                 \"https://docs.openstack.org/nova/latest/configuration\""},{"line_number":365,"context_line":"                 \"policy-concepts.html. Reason for such automatic overwritten \""},{"line_number":366,"context_line":"                 \"policy file is that if you generated the policy file with \""},{"line_number":367,"context_line":"                 \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                 \"Two ways to fix this until you are ready to migrate to \""},{"line_number":369,"context_line":"                 \"scoped policies. 1. Generated the policy file with \""},{"line_number":370,"context_line":"                 \"\u0027oslopolicy-sample-generator\u0027 in yaml format and update \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_1d110b05","line":367,"range":{"start_line":365,"start_character":40,"end_line":367,"end_character":63},"updated":"2020-04-29 12:35:15.000000000","message":"A possible reason for such policy file is that you generated the policy file with \u0027oslopolicy-sample-generator\u0027 in json format.","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"887a7d1d9b5568e17acdbc78102b8b74e848811c","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                 \"scope-checking rules will fail. For details about policy \""},{"line_number":363,"context_line":"                 \"changes and scope token, please refer to this document \""},{"line_number":364,"context_line":"                 \"https://docs.openstack.org/nova/latest/configuration\""},{"line_number":365,"context_line":"                 \"policy-concepts.html. Reason for such automatic overwritten \""},{"line_number":366,"context_line":"                 \"policy file is that if you generated the policy file with \""},{"line_number":367,"context_line":"                 \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                 \"Two ways to fix this until you are ready to migrate to \""},{"line_number":369,"context_line":"                 \"scoped policies. 1. Generated the policy file with \""},{"line_number":370,"context_line":"                 \"\u0027oslopolicy-sample-generator\u0027 in yaml format and update \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_420d6f8e","line":367,"range":{"start_line":365,"start_character":40,"end_line":367,"end_character":63},"in_reply_to":"1f493fa4_1d110b05","updated":"2020-04-29 15:43:42.000000000","message":"Done","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b9c4dd898d5d6c149382b211f43f4aab314bf729","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                 \"policy file is that if you generated the policy file with \""},{"line_number":367,"context_line":"                 \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                 \"Two ways to fix this until you are ready to migrate to \""},{"line_number":369,"context_line":"                 \"scoped policies. 1. Generated the policy file with \""},{"line_number":370,"context_line":"                 \"\u0027oslopolicy-sample-generator\u0027 in yaml format and update \""},{"line_number":371,"context_line":"                 \"the policy.yaml location in ``oslo_policy.policy_file``. \""},{"line_number":372,"context_line":"                 \"2. Use a pre-existing sample config file from the Train \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_9d8b5b66","line":369,"range":{"start_line":369,"start_character":38,"end_line":369,"end_character":47},"updated":"2020-04-29 12:35:15.000000000","message":"Generate","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"887a7d1d9b5568e17acdbc78102b8b74e848811c","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                 \"policy file is that if you generated the policy file with \""},{"line_number":367,"context_line":"                 \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                 \"Two ways to fix this until you are ready to migrate to \""},{"line_number":369,"context_line":"                 \"scoped policies. 1. Generated the policy file with \""},{"line_number":370,"context_line":"                 \"\u0027oslopolicy-sample-generator\u0027 in yaml format and update \""},{"line_number":371,"context_line":"                 \"the policy.yaml location in ``oslo_policy.policy_file``. \""},{"line_number":372,"context_line":"                 \"2. Use a pre-existing sample config file from the Train \""}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_221023a8","line":369,"range":{"start_line":369,"start_character":38,"end_line":369,"end_character":47},"in_reply_to":"1f493fa4_9d8b5b66","updated":"2020-04-29 15:43:42.000000000","message":"Done","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b9c4dd898d5d6c149382b211f43f4aab314bf729","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                 \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                 \"Two ways to fix this until you are ready to migrate to \""},{"line_number":369,"context_line":"                 \"scoped policies. 1. Generated the policy file with \""},{"line_number":370,"context_line":"                 \"\u0027oslopolicy-sample-generator\u0027 in yaml format and update \""},{"line_number":371,"context_line":"                 \"the policy.yaml location in ``oslo_policy.policy_file``. \""},{"line_number":372,"context_line":"                 \"2. Use a pre-existing sample config file from the Train \""},{"line_number":373,"context_line":"                 \"release.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_7ddf6f68","line":370,"range":{"start_line":370,"start_character":62,"end_line":370,"end_character":63},"updated":"2020-04-29 12:35:15.000000000","message":"and keep the generated content commented out","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"887a7d1d9b5568e17acdbc78102b8b74e848811c","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                 \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                 \"Two ways to fix this until you are ready to migrate to \""},{"line_number":369,"context_line":"                 \"scoped policies. 1. Generated the policy file with \""},{"line_number":370,"context_line":"                 \"\u0027oslopolicy-sample-generator\u0027 in yaml format and update \""},{"line_number":371,"context_line":"                 \"the policy.yaml location in ``oslo_policy.policy_file``. \""},{"line_number":372,"context_line":"                 \"2. Use a pre-existing sample config file from the Train \""},{"line_number":373,"context_line":"                 \"release.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_62250b09","line":370,"range":{"start_line":370,"start_character":62,"end_line":370,"end_character":63},"in_reply_to":"1f493fa4_7ddf6f68","updated":"2020-04-29 15:43:42.000000000","message":"Done","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f59f35164cb61fd82d8bd4c299c0f97660f865c8","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        rule_new_default \u003d \"role:admin and system_scope:all\""},{"line_number":376,"context_line":"        enforcer \u003d policy._ENFORCER"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        if enforcer:"},{"line_number":379,"context_line":"            try:"},{"line_number":380,"context_line":"                current_rule \u003d str(enforcer.rules[rule]).strip(\"()\")"},{"line_number":381,"context_line":"                if current_rule \u003d\u003d rule_new_default:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_18863914","line":378,"updated":"2020-04-29 13:28:19.000000000","message":"This check does not work for me in a fresh devstack. What am I missing?\nhttp://paste.openstack.org/show/792881/","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"887a7d1d9b5568e17acdbc78102b8b74e848811c","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        rule_new_default \u003d \"role:admin and system_scope:all\""},{"line_number":376,"context_line":"        enforcer \u003d policy._ENFORCER"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        if enforcer:"},{"line_number":379,"context_line":"            try:"},{"line_number":380,"context_line":"                current_rule \u003d str(enforcer.rules[rule]).strip(\"()\")"},{"line_number":381,"context_line":"                if current_rule \u003d\u003d rule_new_default:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_a2ed53b8","line":378,"in_reply_to":"1f493fa4_18863914","updated":"2020-04-29 15:43:42.000000000","message":"thanks for testing it. I need to init policy in case of None to cover the case where policy are not initialized yet. \n\nAlso if it still stay None for any case we should fail the check instead of pass which can be false pass.\n\nAlso we need to add a test framework for this tool cases, like pre-install, pre-service-start etc. Our current unit tests always initialize the things and start the service. But this is something we can do later so that we can catch all the cases for new chekcs.","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c310c62b36916f1ad136e4924256b5e424134c4f","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        return upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def _check_policy(self):"},{"line_number":351,"context_line":"        \"\"\"Checks to see that if policy file is overwritten with the new"},{"line_number":352,"context_line":"        defaults."},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        msg \u003d _(\"Your policy file is overwriten with new default values \""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_2d491db6","line":351,"range":{"start_line":351,"start_character":25,"end_line":351,"end_character":29},"updated":"2020-04-30 13:56:40.000000000","message":"s//, otherwise it sounds like there\u0027s a second part to the sentence.","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7db992c63dfced0dfe661a26c862ba146c111c26","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        return upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"    def _check_policy(self):"},{"line_number":351,"context_line":"        \"\"\"Checks to see that if policy file is overwritten with the new"},{"line_number":352,"context_line":"        defaults."},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        msg \u003d _(\"Your policy file is overwriten with new default values \""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_d6fe4669","line":351,"range":{"start_line":351,"start_character":25,"end_line":351,"end_character":29},"in_reply_to":"1f493fa4_2d491db6","updated":"2020-04-30 14:46:12.000000000","message":"Done","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c310c62b36916f1ad136e4924256b5e424134c4f","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        defaults."},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        msg \u003d _(\"Your policy file is overwriten with new default values \""},{"line_number":355,"context_line":"                \"which examines the token scope. If that is done \""},{"line_number":356,"context_line":"                \"intentionally to migrate to new defaults then it is fine \""},{"line_number":357,"context_line":"                \"and in the future, you can use the new flag \""},{"line_number":358,"context_line":"                \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_cdcfd926","line":355,"range":{"start_line":355,"start_character":23,"end_line":355,"end_character":31},"updated":"2020-04-30 13:56:40.000000000","message":"examine","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7db992c63dfced0dfe661a26c862ba146c111c26","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        defaults."},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        msg \u003d _(\"Your policy file is overwriten with new default values \""},{"line_number":355,"context_line":"                \"which examines the token scope. If that is done \""},{"line_number":356,"context_line":"                \"intentionally to migrate to new defaults then it is fine \""},{"line_number":357,"context_line":"                \"and in the future, you can use the new flag \""},{"line_number":358,"context_line":"                \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_760bf28c","line":355,"range":{"start_line":355,"start_character":23,"end_line":355,"end_character":31},"in_reply_to":"1f493fa4_cdcfd926","updated":"2020-04-30 14:46:12.000000000","message":"Done","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c310c62b36916f1ad136e4924256b5e424134c4f","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                \"will fail. For details about policy changes and scope \""},{"line_number":363,"context_line":"                \"token, please refer to this document \""},{"line_number":364,"context_line":"                \"https://docs.openstack.org/nova/latest/configuration\""},{"line_number":365,"context_line":"                \"policy-concepts.html. A possible reason for such policy \""},{"line_number":366,"context_line":"                \"file is that you generated the policy file with \""},{"line_number":367,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_cde8797d","line":365,"range":{"start_line":365,"start_character":65,"end_line":365,"end_character":66},"updated":"2020-04-30 13:56:40.000000000","message":"a","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7db992c63dfced0dfe661a26c862ba146c111c26","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                \"will fail. For details about policy changes and scope \""},{"line_number":363,"context_line":"                \"token, please refer to this document \""},{"line_number":364,"context_line":"                \"https://docs.openstack.org/nova/latest/configuration\""},{"line_number":365,"context_line":"                \"policy-concepts.html. A possible reason for such policy \""},{"line_number":366,"context_line":"                \"file is that you generated the policy file with \""},{"line_number":367,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_b601fa6c","line":365,"range":{"start_line":365,"start_character":65,"end_line":365,"end_character":66},"in_reply_to":"1f493fa4_cde8797d","updated":"2020-04-30 14:46:12.000000000","message":"Done","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c310c62b36916f1ad136e4924256b5e424134c4f","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                \"file is that you generated the policy file with \""},{"line_number":367,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""},{"line_number":369,"context_line":"                \"scoped policies. 1. Generate the policy file with \""},{"line_number":370,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in yaml format and keep \""},{"line_number":371,"context_line":"                \"the generated content commented out and update \""},{"line_number":372,"context_line":"                \"the generated policy.yaml location in \""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_2df75d5b","line":369,"range":{"start_line":369,"start_character":32,"end_line":369,"end_character":33},"updated":"2020-04-30 13:56:40.000000000","message":":","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7db992c63dfced0dfe661a26c862ba146c111c26","unresolved":false,"context_lines":[{"line_number":366,"context_line":"                \"file is that you generated the policy file with \""},{"line_number":367,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""},{"line_number":369,"context_line":"                \"scoped policies. 1. Generate the policy file with \""},{"line_number":370,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in yaml format and keep \""},{"line_number":371,"context_line":"                \"the generated content commented out and update \""},{"line_number":372,"context_line":"                \"the generated policy.yaml location in \""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_16fc2e6e","line":369,"range":{"start_line":369,"start_character":32,"end_line":369,"end_character":33},"in_reply_to":"1f493fa4_2df75d5b","updated":"2020-04-30 14:46:12.000000000","message":"Done","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c310c62b36916f1ad136e4924256b5e424134c4f","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""},{"line_number":369,"context_line":"                \"scoped policies. 1. Generate the policy file with \""},{"line_number":370,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in yaml format and keep \""},{"line_number":371,"context_line":"                \"the generated content commented out and update \""},{"line_number":372,"context_line":"                \"the generated policy.yaml location in \""},{"line_number":373,"context_line":"                \"``oslo_policy.policy_file``. \""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_cd9d190b","line":370,"range":{"start_line":370,"start_character":61,"end_line":370,"end_character":65},"updated":"2020-04-30 13:56:40.000000000","message":",","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7db992c63dfced0dfe661a26c862ba146c111c26","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""},{"line_number":369,"context_line":"                \"scoped policies. 1. Generate the policy file with \""},{"line_number":370,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in yaml format and keep \""},{"line_number":371,"context_line":"                \"the generated content commented out and update \""},{"line_number":372,"context_line":"                \"the generated policy.yaml location in \""},{"line_number":373,"context_line":"                \"``oslo_policy.policy_file``. \""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_f6f6e28e","line":370,"range":{"start_line":370,"start_character":61,"end_line":370,"end_character":65},"in_reply_to":"1f493fa4_cd9d190b","updated":"2020-04-30 14:46:12.000000000","message":"Done","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c310c62b36916f1ad136e4924256b5e424134c4f","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                \"the generated policy.yaml location in \""},{"line_number":373,"context_line":"                \"``oslo_policy.policy_file``. \""},{"line_number":374,"context_line":"                \"2. Use a pre-existing sample config file from the Train \""},{"line_number":375,"context_line":"                \"release.\")"},{"line_number":376,"context_line":"        rule \u003d \"system_admin_api\""},{"line_number":377,"context_line":"        rule_new_default \u003d \"role:admin and system_scope:all\""},{"line_number":378,"context_line":"        status \u003d upgradecheck.Result(upgradecheck.Code.SUCCESS)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_8d65d120","line":375,"updated":"2020-04-30 13:56:40.000000000","message":"3. Use an empty file to take all the defaults ?\n\nIf someone is upgrading and hits this, doesn\u0027t have policy changes, or an old file, emptying the file will be the easiest thing to do right?","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7db992c63dfced0dfe661a26c862ba146c111c26","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                \"the generated policy.yaml location in \""},{"line_number":373,"context_line":"                \"``oslo_policy.policy_file``. \""},{"line_number":374,"context_line":"                \"2. Use a pre-existing sample config file from the Train \""},{"line_number":375,"context_line":"                \"release.\")"},{"line_number":376,"context_line":"        rule \u003d \"system_admin_api\""},{"line_number":377,"context_line":"        rule_new_default \u003d \"role:admin and system_scope:all\""},{"line_number":378,"context_line":"        status \u003d upgradecheck.Result(upgradecheck.Code.SUCCESS)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_9664be4b","line":375,"in_reply_to":"1f493fa4_8d65d120","updated":"2020-04-30 14:46:12.000000000","message":"yeah, empty file is also an option. done","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c310c62b36916f1ad136e4924256b5e424134c4f","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        rule \u003d \"system_admin_api\""},{"line_number":377,"context_line":"        rule_new_default \u003d \"role:admin and system_scope:all\""},{"line_number":378,"context_line":"        status \u003d upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":379,"context_line":"        # NOTE(gmann): Initialise the policy is it not initialized."},{"line_number":380,"context_line":"        # We need policy enforcer with all the rules loaded to check"},{"line_number":381,"context_line":"        # their value with defaults."},{"line_number":382,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_ed73b5e5","line":379,"range":{"start_line":379,"start_character":45,"end_line":379,"end_character":47},"updated":"2020-04-30 13:56:40.000000000","message":"if?","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7db992c63dfced0dfe661a26c862ba146c111c26","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        rule \u003d \"system_admin_api\""},{"line_number":377,"context_line":"        rule_new_default \u003d \"role:admin and system_scope:all\""},{"line_number":378,"context_line":"        status \u003d upgradecheck.Result(upgradecheck.Code.SUCCESS)"},{"line_number":379,"context_line":"        # NOTE(gmann): Initialise the policy is it not initialized."},{"line_number":380,"context_line":"        # We need policy enforcer with all the rules loaded to check"},{"line_number":381,"context_line":"        # their value with defaults."},{"line_number":382,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_56f2369b","line":379,"range":{"start_line":379,"start_character":45,"end_line":379,"end_character":47},"in_reply_to":"1f493fa4_ed73b5e5","updated":"2020-04-30 14:46:12.000000000","message":"Done","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c310c62b36916f1ad136e4924256b5e424134c4f","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            # is still not available the return warning to avoid any false"},{"line_number":389,"context_line":"            # result."},{"line_number":390,"context_line":"            if policy._ENFORCER is not None:"},{"line_number":391,"context_line":"                current_rule \u003d str(policy._ENFORCER.rules[rule]).strip(\"()\")"},{"line_number":392,"context_line":"                if current_rule \u003d\u003d rule_new_default:"},{"line_number":393,"context_line":"                    status \u003d upgradecheck.Result(upgradecheck.Code.WARNING,"},{"line_number":394,"context_line":"                                                 msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_2d53dd3a","line":391,"updated":"2020-04-30 13:56:40.000000000","message":"You\u0027re just checking one api element, and if it\u0027s present, assuming that the whole file is generated from new defaults? That seems a little fragile to me. I was expecting to run through every rule and look for any scope-checking rule I guess...","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3ae970a290408225c5f7b73228453125ca5417a5","unresolved":false,"context_lines":[{"line_number":388,"context_line":"            # is still not available the return warning to avoid any false"},{"line_number":389,"context_line":"            # result."},{"line_number":390,"context_line":"            if policy._ENFORCER is not None:"},{"line_number":391,"context_line":"                current_rule \u003d str(policy._ENFORCER.rules[rule]).strip(\"()\")"},{"line_number":392,"context_line":"                if current_rule \u003d\u003d rule_new_default:"},{"line_number":393,"context_line":"                    status \u003d upgradecheck.Result(upgradecheck.Code.WARNING,"},{"line_number":394,"context_line":"                                                 msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_e16e1ec7","line":391,"in_reply_to":"1f493fa4_2d53dd3a","updated":"2020-04-30 14:58:14.000000000","message":"I was thinking of doing for one common base rule is enough because of two reasons. Doing all might be a little messy here as their defaults are different.\n\n1. we need to cover the generated file from tool which automatically added the new defaults so checking one rule is enough to verify that it is with new default.\n\n2. if people have manually modified the file and have mix defaults then they are doing it intentionally so they know what all they are changing.","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c310c62b36916f1ad136e4924256b5e424134c4f","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                current_rule \u003d str(policy._ENFORCER.rules[rule]).strip(\"()\")"},{"line_number":392,"context_line":"                if current_rule \u003d\u003d rule_new_default:"},{"line_number":393,"context_line":"                    status \u003d upgradecheck.Result(upgradecheck.Code.WARNING,"},{"line_number":394,"context_line":"                                                 msg)"},{"line_number":395,"context_line":"            else:"},{"line_number":396,"context_line":"                status \u003d upgradecheck.Result("},{"line_number":397,"context_line":"                    upgradecheck.Code.WARNING,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_10155640","line":394,"updated":"2020-04-30 13:56:40.000000000","message":"Shouldn\u0027t we check if enforce_scope is set here and return OK if so?\n\nOn a new deployment that runs nova-status (which is done), if they generate a new policy file _and_ set the right config, we shouldn\u0027t complain right?","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3ae970a290408225c5f7b73228453125ca5417a5","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                current_rule \u003d str(policy._ENFORCER.rules[rule]).strip(\"()\")"},{"line_number":392,"context_line":"                if current_rule \u003d\u003d rule_new_default:"},{"line_number":393,"context_line":"                    status \u003d upgradecheck.Result(upgradecheck.Code.WARNING,"},{"line_number":394,"context_line":"                                                 msg)"},{"line_number":395,"context_line":"            else:"},{"line_number":396,"context_line":"                status \u003d upgradecheck.Result("},{"line_number":397,"context_line":"                    upgradecheck.Code.WARNING,"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_b6b9fa79","line":394,"in_reply_to":"1f493fa4_10155640","updated":"2020-04-30 14:58:14.000000000","message":"yeah we can avoid warning for new deployment moving to scope checks. done","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c310c62b36916f1ad136e4924256b5e424134c4f","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        # Added in Train"},{"line_number":424,"context_line":"        (_(\u0027Cinder API\u0027), _check_cinder),"},{"line_number":425,"context_line":"        # Added in Ussuri"},{"line_number":426,"context_line":"        (_(\u0027Nova Policy\u0027), _check_policy),"},{"line_number":427,"context_line":"    )"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_ed21f5b5","line":426,"range":{"start_line":426,"start_character":12,"end_line":426,"end_character":23},"updated":"2020-04-30 13:56:40.000000000","message":"Maybe this should be more specific, like \"Policy scope-based defaults\" ? You wouldn\u0027t want someone to see a check of this and think that it meant anything security-related was validated.","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3ae970a290408225c5f7b73228453125ca5417a5","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        # Added in Train"},{"line_number":424,"context_line":"        (_(\u0027Cinder API\u0027), _check_cinder),"},{"line_number":425,"context_line":"        # Added in Ussuri"},{"line_number":426,"context_line":"        (_(\u0027Nova Policy\u0027), _check_policy),"},{"line_number":427,"context_line":"    )"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_1606ee52","line":426,"range":{"start_line":426,"start_character":12,"end_line":426,"end_character":23},"in_reply_to":"1f493fa4_ed21f5b5","updated":"2020-04-30 14:58:14.000000000","message":"ok, done","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fd30cfdd029a246efd46648f87d370ba7008d325","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        \"\"\"Checks to see if policy file is overwritten with the new"},{"line_number":352,"context_line":"        defaults."},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        msg \u003d _(\"Your policy file is overwriten with new default values \""},{"line_number":355,"context_line":"                \"which examine the token scope. If that is done \""},{"line_number":356,"context_line":"                \"intentionally to migrate to new defaults then it is fine \""},{"line_number":357,"context_line":"                \"and in the future, you can use the new flag \""}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_2949085f","line":354,"range":{"start_line":354,"start_character":37,"end_line":354,"end_character":47},"updated":"2020-04-30 18:48:56.000000000","message":"overwritten, although this probably conveys more concern or confusion than we should have. I would say:\n\n\"Your policy file contains rules which examine token scope, which may be due to generation with the new defaults.\"","commit_id":"8fb231be18e097828b74f37b7c44ed4290828299"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a566a07c04dd1482106c7b84e19530e0c299b86","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        \"\"\"Checks to see if policy file is overwritten with the new"},{"line_number":352,"context_line":"        defaults."},{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        msg \u003d _(\"Your policy file is overwriten with new default values \""},{"line_number":355,"context_line":"                \"which examine the token scope. If that is done \""},{"line_number":356,"context_line":"                \"intentionally to migrate to new defaults then it is fine \""},{"line_number":357,"context_line":"                \"and in the future, you can use the new flag \""}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_692dd0fc","line":354,"range":{"start_line":354,"start_character":37,"end_line":354,"end_character":47},"in_reply_to":"1f493fa4_2949085f","updated":"2020-04-30 19:17:50.000000000","message":"Done","commit_id":"8fb231be18e097828b74f37b7c44ed4290828299"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fd30cfdd029a246efd46648f87d370ba7008d325","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                \"which examine the token scope. If that is done \""},{"line_number":356,"context_line":"                \"intentionally to migrate to new defaults then it is fine \""},{"line_number":357,"context_line":"                \"and in the future, you can use the new flag \""},{"line_number":358,"context_line":"                \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""},{"line_number":359,"context_line":"                \"without overwriting the policy file. If you did not intend \""},{"line_number":360,"context_line":"                \"to migrate to new defaults in this upgrade then \""},{"line_number":361,"context_line":"                \"with your current policy file the scope checking rule \""},{"line_number":362,"context_line":"                \"will fail. For details about policy changes and scope \""}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_a9a358ff","line":359,"range":{"start_line":358,"start_character":52,"end_line":359,"end_character":52},"updated":"2020-04-30 18:48:56.000000000","message":"You keep focusing on the \"new defaults\" but I think this is confusing. Especially here, where the context is seemingly that their file has been intentionally configured as such. So I think this sentence should be:\n\n If that is done intentionally to migrate to the new rule format, then\n you need to set oslo_policy.enforce_new_defaults\u003dTrue in order to\n use them.","commit_id":"8fb231be18e097828b74f37b7c44ed4290828299"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a566a07c04dd1482106c7b84e19530e0c299b86","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                \"which examine the token scope. If that is done \""},{"line_number":356,"context_line":"                \"intentionally to migrate to new defaults then it is fine \""},{"line_number":357,"context_line":"                \"and in the future, you can use the new flag \""},{"line_number":358,"context_line":"                \"\u0027oslo_policy.enforce_new_defaults\u0027 to move to new defaults \""},{"line_number":359,"context_line":"                \"without overwriting the policy file. If you did not intend \""},{"line_number":360,"context_line":"                \"to migrate to new defaults in this upgrade then \""},{"line_number":361,"context_line":"                \"with your current policy file the scope checking rule \""},{"line_number":362,"context_line":"                \"will fail. For details about policy changes and scope \""}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_89b3fce8","line":359,"range":{"start_line":358,"start_character":52,"end_line":359,"end_character":52},"in_reply_to":"1f493fa4_a9a358ff","updated":"2020-04-30 19:17:50.000000000","message":"ok, i will reword those to mention that flag is an alternate way to do that. they can switch to new rules by overwritting the file or with this new flag which is recommended.","commit_id":"8fb231be18e097828b74f37b7c44ed4290828299"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fd30cfdd029a246efd46648f87d370ba7008d325","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                \"token, please refer to this document \""},{"line_number":364,"context_line":"                \"https://docs.openstack.org/nova/latest/configuration\""},{"line_number":365,"context_line":"                \"policy-concepts.html. A possible reason for a such policy \""},{"line_number":366,"context_line":"                \"file is that you generated the policy file with \""},{"line_number":367,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""},{"line_number":369,"context_line":"                \"scoped policies: 1. Generate the policy file with \""}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_09b24c49","line":366,"range":{"start_line":366,"start_character":44,"end_line":366,"end_character":59},"updated":"2020-04-30 18:48:56.000000000","message":"nit: should be \"it\" to avoid repetition.","commit_id":"8fb231be18e097828b74f37b7c44ed4290828299"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a566a07c04dd1482106c7b84e19530e0c299b86","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                \"token, please refer to this document \""},{"line_number":364,"context_line":"                \"https://docs.openstack.org/nova/latest/configuration\""},{"line_number":365,"context_line":"                \"policy-concepts.html. A possible reason for a such policy \""},{"line_number":366,"context_line":"                \"file is that you generated the policy file with \""},{"line_number":367,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":368,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""},{"line_number":369,"context_line":"                \"scoped policies: 1. Generate the policy file with \""}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_29f2a89a","line":366,"range":{"start_line":366,"start_character":44,"end_line":366,"end_character":59},"in_reply_to":"1f493fa4_09b24c49","updated":"2020-04-30 19:17:50.000000000","message":"Done","commit_id":"8fb231be18e097828b74f37b7c44ed4290828299"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fd30cfdd029a246efd46648f87d370ba7008d325","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                \"the generated policy.yaml location in \""},{"line_number":373,"context_line":"                \"``oslo_policy.policy_file``. \""},{"line_number":374,"context_line":"                \"2. Use a pre-existing sample config file from the Train \""},{"line_number":375,"context_line":"                \"release. 3. Use an empty file to take all the default.\")"},{"line_number":376,"context_line":"        rule \u003d \"system_admin_api\""},{"line_number":377,"context_line":"        rule_new_default \u003d \"role:admin and system_scope:all\""},{"line_number":378,"context_line":"        status \u003d upgradecheck.Result(upgradecheck.Code.SUCCESS)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_69867068","line":375,"range":{"start_line":375,"start_character":63,"end_line":375,"end_character":70},"updated":"2020-04-30 18:48:56.000000000","message":"defaults","commit_id":"8fb231be18e097828b74f37b7c44ed4290828299"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a566a07c04dd1482106c7b84e19530e0c299b86","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                \"the generated policy.yaml location in \""},{"line_number":373,"context_line":"                \"``oslo_policy.policy_file``. \""},{"line_number":374,"context_line":"                \"2. Use a pre-existing sample config file from the Train \""},{"line_number":375,"context_line":"                \"release. 3. Use an empty file to take all the default.\")"},{"line_number":376,"context_line":"        rule \u003d \"system_admin_api\""},{"line_number":377,"context_line":"        rule_new_default \u003d \"role:admin and system_scope:all\""},{"line_number":378,"context_line":"        status \u003d upgradecheck.Result(upgradecheck.Code.SUCCESS)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f493fa4_09ed2cb6","line":375,"range":{"start_line":375,"start_character":63,"end_line":375,"end_character":70},"in_reply_to":"1f493fa4_69867068","updated":"2020-04-30 19:17:50.000000000","message":"Done","commit_id":"8fb231be18e097828b74f37b7c44ed4290828299"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d194f7d5601bd6e9c5fe667d70bda06605d11f90","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        \"\"\""},{"line_number":354,"context_line":"        msg \u003d _(\"Your policy file contains rules which examine token scope, \""},{"line_number":355,"context_line":"                \"which may be due to generation with the new defaults. \""},{"line_number":356,"context_line":"                \"If that is done intentionally to migrate to new rule format, \""},{"line_number":357,"context_line":"                \"then it is fine and new recommended way to that is to enable \""},{"line_number":358,"context_line":"                \"the flag \u0027oslo_policy.enforce_new_defaults\u0027. If you did not \""},{"line_number":359,"context_line":"                \"intend to migrate to new defaults in this upgrade then \""}],"source_content_type":"text/x-python","patch_set":11,"id":"1f493fa4_699790ed","line":356,"range":{"start_line":356,"start_character":17,"end_line":356,"end_character":76},"updated":"2020-04-30 19:25:03.000000000","message":"This means they have new-style rules in their policy file *and* want to keep them. You only display this if enforce_scope\u003dFalse...","commit_id":"70be23aac482765515121817e7b8ce65b6e27bb7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d194f7d5601bd6e9c5fe667d70bda06605d11f90","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                \"which may be due to generation with the new defaults. \""},{"line_number":356,"context_line":"                \"If that is done intentionally to migrate to new rule format, \""},{"line_number":357,"context_line":"                \"then it is fine and new recommended way to that is to enable \""},{"line_number":358,"context_line":"                \"the flag \u0027oslo_policy.enforce_new_defaults\u0027. If you did not \""},{"line_number":359,"context_line":"                \"intend to migrate to new defaults in this upgrade then \""},{"line_number":360,"context_line":"                \"with your current policy file the scope checking rule \""},{"line_number":361,"context_line":"                \"will fail. For details about policy changes and scope \""}],"source_content_type":"text/x-python","patch_set":11,"id":"1f493fa4_89a01c44","line":358,"range":{"start_line":358,"start_character":17,"end_line":358,"end_character":59},"updated":"2020-04-30 19:25:03.000000000","message":"...but then here you tell them it\u0027s cool, just enable this. However, this will not make the message go away or fix the problem, right? They need to set enforce_scope\u003dTrue?","commit_id":"70be23aac482765515121817e7b8ce65b6e27bb7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0821f4799bf70c5fee63132003d18d552af1003c","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                \"which may be due to generation with the new defaults. \""},{"line_number":356,"context_line":"                \"If that is done intentionally to migrate to new rule format, \""},{"line_number":357,"context_line":"                \"then it is fine and new recommended way to that is to enable \""},{"line_number":358,"context_line":"                \"the flag \u0027oslo_policy.enforce_new_defaults\u0027. If you did not \""},{"line_number":359,"context_line":"                \"intend to migrate to new defaults in this upgrade then \""},{"line_number":360,"context_line":"                \"with your current policy file the scope checking rule \""},{"line_number":361,"context_line":"                \"will fail. For details about policy changes and scope \""}],"source_content_type":"text/x-python","patch_set":11,"id":"1f493fa4_c92184b6","line":358,"range":{"start_line":358,"start_character":17,"end_line":358,"end_character":59},"in_reply_to":"1f493fa4_89a01c44","updated":"2020-04-30 19:33:05.000000000","message":"adding scope flag also. how about below sentence :\n\n\"If that is done intentionally to migrate to new rule format, \"\n\"then you are required to enable \u0027oslo_policy.enforce_scope\u003dTrue\u0027 also.\"\n\"Another easy and recommended way, you can achieve the same via two flags, \"\n\" \u0027oslo_policy.enforce_scope\u003dTrue\u0027 and \u0027oslo_policy.enforce_new_defaults\u003dTrue\u0027 \"\n\" and avoid overwriting the file\"","commit_id":"70be23aac482765515121817e7b8ce65b6e27bb7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7bae0824a102e10ae9d041f7ef85a33485847725","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                \"which may be due to generation with the new defaults. \""},{"line_number":356,"context_line":"                \"If that is done intentionally to migrate to new rule format, \""},{"line_number":357,"context_line":"                \"then it is fine and new recommended way to that is to enable \""},{"line_number":358,"context_line":"                \"the flag \u0027oslo_policy.enforce_new_defaults\u0027. If you did not \""},{"line_number":359,"context_line":"                \"intend to migrate to new defaults in this upgrade then \""},{"line_number":360,"context_line":"                \"with your current policy file the scope checking rule \""},{"line_number":361,"context_line":"                \"will fail. For details about policy changes and scope \""}],"source_content_type":"text/x-python","patch_set":11,"id":"1f493fa4_6404d715","line":358,"range":{"start_line":358,"start_character":17,"end_line":358,"end_character":59},"in_reply_to":"1f493fa4_c92184b6","updated":"2020-04-30 19:34:18.000000000","message":"Yes,  but add \"the\" in front of \"new rule format\".\n\nBut yep, sounds good.","commit_id":"70be23aac482765515121817e7b8ce65b6e27bb7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"fc88fcd93e33e6148a9266a2a8d8b4a4595eb753","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                \"recommended way for you to achieve the same via two flags, \""},{"line_number":360,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 and \""},{"line_number":361,"context_line":"                \"\u0027oslo_policy.enforce_new_defaults\u003dTrue\u0027 and avoid \""},{"line_number":362,"context_line":"                \"overwriting the file. If that is done intentionally to \""},{"line_number":363,"context_line":"                \"migrate to new rule format, then it is fine and new \""},{"line_number":364,"context_line":"                \"recommended way to that is to enable the flag \""},{"line_number":365,"context_line":"                \"\u0027oslo_policy.enforce_new_defaults\u0027. If you did not \""},{"line_number":366,"context_line":"                \"intend to migrate to new defaults in this upgrade then \""},{"line_number":367,"context_line":"                \"with your current policy file the scope checking rule \""},{"line_number":368,"context_line":"                \"will fail. For details about policy changes and scope \""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f493fa4_24b2cf49","line":365,"range":{"start_line":362,"start_character":39,"end_line":365,"end_character":52},"updated":"2020-04-30 19:44:40.000000000","message":"Did you mean to remove this?","commit_id":"741f631b27aed07e7fab675e420334ed516a8644"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        msg \u003d _(\"Your policy file contains rules which examine token scope, \""},{"line_number":355,"context_line":"                \"which may be due to generation with the new defaults. \""},{"line_number":356,"context_line":"                \"If that is done intentionally to migrate to the new rule \""},{"line_number":357,"context_line":"                \"format, then you are required to enable the flag\""},{"line_number":358,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 also. Another easy and \""},{"line_number":359,"context_line":"                \"recommended way for you to achieve the same via two flags, \""},{"line_number":360,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 and \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_64d85752","line":357,"range":{"start_line":357,"start_character":65,"end_line":357,"end_character":66},"updated":"2020-04-30 20:12:00.000000000","message":"Need a space here","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5bbef15d9712e60b6e0bc6b7cfa6e3a50b20675a","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        msg \u003d _(\"Your policy file contains rules which examine token scope, \""},{"line_number":355,"context_line":"                \"which may be due to generation with the new defaults. \""},{"line_number":356,"context_line":"                \"If that is done intentionally to migrate to the new rule \""},{"line_number":357,"context_line":"                \"format, then you are required to enable the flag\""},{"line_number":358,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 also. Another easy and \""},{"line_number":359,"context_line":"                \"recommended way for you to achieve the same via two flags, \""},{"line_number":360,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 and \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_4491dbf0","line":357,"range":{"start_line":357,"start_character":65,"end_line":357,"end_character":66},"in_reply_to":"1f493fa4_64d85752","updated":"2020-04-30 20:33:23.000000000","message":"Done","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                \"which may be due to generation with the new defaults. \""},{"line_number":356,"context_line":"                \"If that is done intentionally to migrate to the new rule \""},{"line_number":357,"context_line":"                \"format, then you are required to enable the flag\""},{"line_number":358,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 also. Another easy and \""},{"line_number":359,"context_line":"                \"recommended way for you to achieve the same via two flags, \""},{"line_number":360,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 and \""},{"line_number":361,"context_line":"                \"\u0027oslo_policy.enforce_new_defaults\u003dTrue\u0027 and avoid \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_a4eb7f75","line":358,"range":{"start_line":358,"start_character":49,"end_line":358,"end_character":50},"updated":"2020-04-30 20:12:00.000000000","message":"Maybe should also mention \"and educate end users on how to request scoped tokens from Keystone\"","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5bbef15d9712e60b6e0bc6b7cfa6e3a50b20675a","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                \"which may be due to generation with the new defaults. \""},{"line_number":356,"context_line":"                \"If that is done intentionally to migrate to the new rule \""},{"line_number":357,"context_line":"                \"format, then you are required to enable the flag\""},{"line_number":358,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 also. Another easy and \""},{"line_number":359,"context_line":"                \"recommended way for you to achieve the same via two flags, \""},{"line_number":360,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 and \""},{"line_number":361,"context_line":"                \"\u0027oslo_policy.enforce_new_defaults\u003dTrue\u0027 and avoid \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_44aa7b18","line":358,"range":{"start_line":358,"start_character":49,"end_line":358,"end_character":50},"in_reply_to":"1f493fa4_a4eb7f75","updated":"2020-04-30 20:33:23.000000000","message":"actually I mentioned the doc link at L366 to know complete things otherwise it is too much info here. along with scope, read-only roles are also they have to do extra for new defaults.\n\nI can move the document line here so that they read the complete things together","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                \"If that is done intentionally to migrate to the new rule \""},{"line_number":357,"context_line":"                \"format, then you are required to enable the flag\""},{"line_number":358,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 also. Another easy and \""},{"line_number":359,"context_line":"                \"recommended way for you to achieve the same via two flags, \""},{"line_number":360,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 and \""},{"line_number":361,"context_line":"                \"\u0027oslo_policy.enforce_new_defaults\u003dTrue\u0027 and avoid \""},{"line_number":362,"context_line":"                \"overwriting the file. If you did not intend to migrate \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_046fd32a","line":359,"range":{"start_line":359,"start_character":61,"end_line":359,"end_character":64},"updated":"2020-04-30 20:12:00.000000000","message":"is via","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5bbef15d9712e60b6e0bc6b7cfa6e3a50b20675a","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                \"If that is done intentionally to migrate to the new rule \""},{"line_number":357,"context_line":"                \"format, then you are required to enable the flag\""},{"line_number":358,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 also. Another easy and \""},{"line_number":359,"context_line":"                \"recommended way for you to achieve the same via two flags, \""},{"line_number":360,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 and \""},{"line_number":361,"context_line":"                \"\u0027oslo_policy.enforce_new_defaults\u003dTrue\u0027 and avoid \""},{"line_number":362,"context_line":"                \"overwriting the file. If you did not intend to migrate \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_24a5af47","line":359,"range":{"start_line":359,"start_character":61,"end_line":359,"end_character":64},"in_reply_to":"1f493fa4_046fd32a","updated":"2020-04-30 20:33:23.000000000","message":"Done","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 and \""},{"line_number":361,"context_line":"                \"\u0027oslo_policy.enforce_new_defaults\u003dTrue\u0027 and avoid \""},{"line_number":362,"context_line":"                \"overwriting the file. If you did not intend to migrate \""},{"line_number":363,"context_line":"                \"to new defaults in this upgrade then with your current \""},{"line_number":364,"context_line":"                \"policy file the scope checking rule will fail. For details \""},{"line_number":365,"context_line":"                \"about policy changes and scope token, please refer to this \""},{"line_number":366,"context_line":"                \"document https://docs.openstack.org/nova/latest/\""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_c45a0b81","line":363,"range":{"start_line":363,"start_character":41,"end_line":363,"end_character":48},"updated":"2020-04-30 20:12:00.000000000","message":"upgrade,","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5bbef15d9712e60b6e0bc6b7cfa6e3a50b20675a","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                \"\u0027oslo_policy.enforce_scope\u003dTrue\u0027 and \""},{"line_number":361,"context_line":"                \"\u0027oslo_policy.enforce_new_defaults\u003dTrue\u0027 and avoid \""},{"line_number":362,"context_line":"                \"overwriting the file. If you did not intend to migrate \""},{"line_number":363,"context_line":"                \"to new defaults in this upgrade then with your current \""},{"line_number":364,"context_line":"                \"policy file the scope checking rule will fail. For details \""},{"line_number":365,"context_line":"                \"about policy changes and scope token, please refer to this \""},{"line_number":366,"context_line":"                \"document https://docs.openstack.org/nova/latest/\""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_8465a320","line":363,"range":{"start_line":363,"start_character":41,"end_line":363,"end_character":48},"in_reply_to":"1f493fa4_c45a0b81","updated":"2020-04-30 20:33:23.000000000","message":"Done","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                \"overwriting the file. If you did not intend to migrate \""},{"line_number":363,"context_line":"                \"to new defaults in this upgrade then with your current \""},{"line_number":364,"context_line":"                \"policy file the scope checking rule will fail. For details \""},{"line_number":365,"context_line":"                \"about policy changes and scope token, please refer to this \""},{"line_number":366,"context_line":"                \"document https://docs.openstack.org/nova/latest/\""},{"line_number":367,"context_line":"                \"configuration/policy-concepts.html. A possible reason for \""},{"line_number":368,"context_line":"                \"a such policy file is that you generated it with \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_a45d3f7a","line":365,"range":{"start_line":365,"start_character":42,"end_line":365,"end_character":53},"updated":"2020-04-30 20:12:00.000000000","message":"scoped tokens","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5bbef15d9712e60b6e0bc6b7cfa6e3a50b20675a","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                \"overwriting the file. If you did not intend to migrate \""},{"line_number":363,"context_line":"                \"to new defaults in this upgrade then with your current \""},{"line_number":364,"context_line":"                \"policy file the scope checking rule will fail. For details \""},{"line_number":365,"context_line":"                \"about policy changes and scope token, please refer to this \""},{"line_number":366,"context_line":"                \"document https://docs.openstack.org/nova/latest/\""},{"line_number":367,"context_line":"                \"configuration/policy-concepts.html. A possible reason for \""},{"line_number":368,"context_line":"                \"a such policy file is that you generated it with \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_646857f4","line":365,"range":{"start_line":365,"start_character":42,"end_line":365,"end_character":53},"in_reply_to":"1f493fa4_a45d3f7a","updated":"2020-04-30 20:33:23.000000000","message":"Done","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                \"about policy changes and scope token, please refer to this \""},{"line_number":366,"context_line":"                \"document https://docs.openstack.org/nova/latest/\""},{"line_number":367,"context_line":"                \"configuration/policy-concepts.html. A possible reason for \""},{"line_number":368,"context_line":"                \"a such policy file is that you generated it with \""},{"line_number":369,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":370,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""},{"line_number":371,"context_line":"                \"scoped policies: 1. Generate the policy file with \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_84c92327","line":368,"range":{"start_line":368,"start_character":17,"end_line":368,"end_character":23},"updated":"2020-04-30 20:12:00.000000000","message":"such a","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5bbef15d9712e60b6e0bc6b7cfa6e3a50b20675a","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                \"about policy changes and scope token, please refer to this \""},{"line_number":366,"context_line":"                \"document https://docs.openstack.org/nova/latest/\""},{"line_number":367,"context_line":"                \"configuration/policy-concepts.html. A possible reason for \""},{"line_number":368,"context_line":"                \"a such policy file is that you generated it with \""},{"line_number":369,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":370,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""},{"line_number":371,"context_line":"                \"scoped policies: 1. Generate the policy file with \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_447f1baa","line":368,"range":{"start_line":368,"start_character":17,"end_line":368,"end_character":23},"in_reply_to":"1f493fa4_84c92327","updated":"2020-04-30 20:33:23.000000000","message":"Done","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                \"configuration/policy-concepts.html. A possible reason for \""},{"line_number":368,"context_line":"                \"a such policy file is that you generated it with \""},{"line_number":369,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":370,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""},{"line_number":371,"context_line":"                \"scoped policies: 1. Generate the policy file with \""},{"line_number":372,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in yaml format, keep \""},{"line_number":373,"context_line":"                \"the generated content commented out and update \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_04dd13df","line":370,"range":{"start_line":370,"start_character":17,"end_line":370,"end_character":20},"updated":"2020-04-30 20:12:00.000000000","message":"Three?","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5bbef15d9712e60b6e0bc6b7cfa6e3a50b20675a","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                \"configuration/policy-concepts.html. A possible reason for \""},{"line_number":368,"context_line":"                \"a such policy file is that you generated it with \""},{"line_number":369,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in json format. \""},{"line_number":370,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""},{"line_number":371,"context_line":"                \"scoped policies: 1. Generate the policy file with \""},{"line_number":372,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in yaml format, keep \""},{"line_number":373,"context_line":"                \"the generated content commented out and update \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_247acfb8","line":370,"range":{"start_line":370,"start_character":17,"end_line":370,"end_character":20},"in_reply_to":"1f493fa4_04dd13df","updated":"2020-04-30 20:33:23.000000000","message":"ah right.","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""},{"line_number":371,"context_line":"                \"scoped policies: 1. Generate the policy file with \""},{"line_number":372,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in yaml format, keep \""},{"line_number":373,"context_line":"                \"the generated content commented out and update \""},{"line_number":374,"context_line":"                \"the generated policy.yaml location in \""},{"line_number":375,"context_line":"                \"``oslo_policy.policy_file``. \""},{"line_number":376,"context_line":"                \"2. Use a pre-existing sample config file from the Train \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_c4cfab26","line":373,"range":{"start_line":373,"start_character":49,"end_line":373,"end_character":52},"updated":"2020-04-30 20:12:00.000000000","message":"out,","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5bbef15d9712e60b6e0bc6b7cfa6e3a50b20675a","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                \"Two ways to fix this until you are ready to migrate to \""},{"line_number":371,"context_line":"                \"scoped policies: 1. Generate the policy file with \""},{"line_number":372,"context_line":"                \"\u0027oslopolicy-sample-generator\u0027 in yaml format, keep \""},{"line_number":373,"context_line":"                \"the generated content commented out and update \""},{"line_number":374,"context_line":"                \"the generated policy.yaml location in \""},{"line_number":375,"context_line":"                \"``oslo_policy.policy_file``. \""},{"line_number":376,"context_line":"                \"2. Use a pre-existing sample config file from the Train \""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_844e4394","line":373,"range":{"start_line":373,"start_character":49,"end_line":373,"end_character":52},"in_reply_to":"1f493fa4_c4cfab26","updated":"2020-04-30 20:33:23.000000000","message":"Done","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                \"the generated policy.yaml location in \""},{"line_number":375,"context_line":"                \"``oslo_policy.policy_file``. \""},{"line_number":376,"context_line":"                \"2. Use a pre-existing sample config file from the Train \""},{"line_number":377,"context_line":"                \"release. 3. Use an empty file to take all the defaults.\")"},{"line_number":378,"context_line":"        rule \u003d \"system_admin_api\""},{"line_number":379,"context_line":"        rule_new_default \u003d \"role:admin and system_scope:all\""},{"line_number":380,"context_line":"        status \u003d upgradecheck.Result(upgradecheck.Code.SUCCESS)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_64f5f756","line":377,"range":{"start_line":377,"start_character":26,"end_line":377,"end_character":72},"updated":"2020-04-30 20:12:00.000000000","message":"Empty or non-existent will work, right?","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5bbef15d9712e60b6e0bc6b7cfa6e3a50b20675a","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                \"the generated policy.yaml location in \""},{"line_number":375,"context_line":"                \"``oslo_policy.policy_file``. \""},{"line_number":376,"context_line":"                \"2. Use a pre-existing sample config file from the Train \""},{"line_number":377,"context_line":"                \"release. 3. Use an empty file to take all the defaults.\")"},{"line_number":378,"context_line":"        rule \u003d \"system_admin_api\""},{"line_number":379,"context_line":"        rule_new_default \u003d \"role:admin and system_scope:all\""},{"line_number":380,"context_line":"        status \u003d upgradecheck.Result(upgradecheck.Code.SUCCESS)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_7f629eaf","line":377,"range":{"start_line":377,"start_character":26,"end_line":377,"end_character":72},"in_reply_to":"1f493fa4_64f5f756","updated":"2020-04-30 20:33:23.000000000","message":"non existing file needs to be tested well, by seeing all the different way of policy file usage and how olso load the json format first and then fallback to yaml if error, I will wait to mention that.","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"139b05329dcecec31fbab6544b44dfbe21eef0a2","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                \"the generated policy.yaml location in \""},{"line_number":375,"context_line":"                \"``oslo_policy.policy_file``. \""},{"line_number":376,"context_line":"                \"2. Use a pre-existing sample config file from the Train \""},{"line_number":377,"context_line":"                \"release. 3. Use an empty file to take all the defaults.\")"},{"line_number":378,"context_line":"        rule \u003d \"system_admin_api\""},{"line_number":379,"context_line":"        rule_new_default \u003d \"role:admin and system_scope:all\""},{"line_number":380,"context_line":"        status \u003d upgradecheck.Result(upgradecheck.Code.SUCCESS)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f493fa4_d51e330a","line":377,"range":{"start_line":377,"start_character":26,"end_line":377,"end_character":72},"in_reply_to":"1f493fa4_7f629eaf","updated":"2020-04-30 22:18:32.000000000","message":"Hm, maybe I\u0027m confused. I was thinking the non-existent file would mean to take all of the defaults too.","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"}],"releasenotes/notes/bug-1875418-0df3198e36530ec7.yaml":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0616f67fc35d0878544064c24a451b1616525db1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Nova policies implemented the ``scope_type`` and new defaults"},{"line_number":5,"context_line":"    provided by keystone. Old defaults are deprecated and still work"},{"line_number":6,"context_line":"    if rules are not overridden in policy file. If rules are overridden in"},{"line_number":7,"context_line":"    policy file with new defaults value and expectation is to move to"},{"line_number":8,"context_line":"    new defaults completely then you are good, if the expectation is that old"},{"line_number":9,"context_line":"    defaults still work then please read further and check `this bug"},{"line_number":10,"context_line":"    \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_3c49968a","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":39},"updated":"2020-04-27 21:15:21.000000000","message":"Not just with the new defaults, but any new value that requires scoped tokens right?","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9d02e0d1a3ff849d09c5e2c66a4eb01f03c7b4c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Nova policies implemented the ``scope_type`` and new defaults"},{"line_number":5,"context_line":"    provided by keystone. Old defaults are deprecated and still work"},{"line_number":6,"context_line":"    if rules are not overridden in policy file. If rules are overridden in"},{"line_number":7,"context_line":"    policy file with new defaults value and expectation is to move to"},{"line_number":8,"context_line":"    new defaults completely then you are good, if the expectation is that old"},{"line_number":9,"context_line":"    defaults still work then please read further and check `this bug"},{"line_number":10,"context_line":"    \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_df46a4c0","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":39},"in_reply_to":"1f493fa4_3c49968a","updated":"2020-04-27 22:01:22.000000000","message":"yeah, done","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0616f67fc35d0878544064c24a451b1616525db1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Nova policies implemented the ``scope_type`` and new defaults"},{"line_number":5,"context_line":"    provided by keystone. Old defaults are deprecated and still work"},{"line_number":6,"context_line":"    if rules are not overridden in policy file. If rules are overridden in"},{"line_number":7,"context_line":"    policy file with new defaults value and expectation is to move to"},{"line_number":8,"context_line":"    new defaults completely then you are good, if the expectation is that old"},{"line_number":9,"context_line":"    defaults still work then please read further and check `this bug"},{"line_number":10,"context_line":"    \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_9c26eacd","line":8,"range":{"start_line":7,"start_character":44,"end_line":8,"end_character":45},"updated":"2020-04-27 21:15:21.000000000","message":"I\u0027m not sure what you\u0027re getting at here. Are you saying \"if you are currently overriding some rules, but plan to STOP overriding rules in V\" ? I think that\u0027s pretty confusing, and unlikely to be the case, right? If I want to give people permission to live migrate now, the same will be true in V after the new defaults are in place.","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9d02e0d1a3ff849d09c5e2c66a4eb01f03c7b4c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Nova policies implemented the ``scope_type`` and new defaults"},{"line_number":5,"context_line":"    provided by keystone. Old defaults are deprecated and still work"},{"line_number":6,"context_line":"    if rules are not overridden in policy file. If rules are overridden in"},{"line_number":7,"context_line":"    policy file with new defaults value and expectation is to move to"},{"line_number":8,"context_line":"    new defaults completely then you are good, if the expectation is that old"},{"line_number":9,"context_line":"    defaults still work then please read further and check `this bug"},{"line_number":10,"context_line":"    \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_3f86a8dc","line":8,"range":{"start_line":7,"start_character":44,"end_line":8,"end_character":45},"in_reply_to":"1f493fa4_9c26eacd","updated":"2020-04-27 22:01:22.000000000","message":"not for the already overridden rule, I meant to state that if users are overwriting the policy file to migrate to new defaults so that their deployment stop supporting old deprecated rule. \n\noverwriting policy file to adopt the new defaults was old way and we introduced the new flag \u0027enforce_new_defaults\u0027 for that.","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0616f67fc35d0878544064c24a451b1616525db1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    defaults still work then please read further and check `this bug"},{"line_number":10,"context_line":"    \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    With Nova policies changed as mentioned above, old defaults are supported"},{"line_number":13,"context_line":"    with keeping those as deprecated rule along with new defaults. For deployment"},{"line_number":14,"context_line":"    relying on policy defaults, it will keep working because of old defaults are"},{"line_number":15,"context_line":"    still supported as a deprecated rule. If the deployment has overridden the policy"},{"line_number":16,"context_line":"    rule then defaults are not into picture and token are checked as per the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_7c0cbe40","line":13,"range":{"start_line":12,"start_character":4,"end_line":13,"end_character":65},"updated":"2020-04-27 21:15:21.000000000","message":"This doesn\u0027t make sense to me, even though I\u0027ve been discussing this with you, so I think it probably needs to be clearer. Do you mean \"old (style, with no scope) overrides are compatible with new defaults\" ?","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9d02e0d1a3ff849d09c5e2c66a4eb01f03c7b4c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    defaults still work then please read further and check `this bug"},{"line_number":10,"context_line":"    \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    With Nova policies changed as mentioned above, old defaults are supported"},{"line_number":13,"context_line":"    with keeping those as deprecated rule along with new defaults. For deployment"},{"line_number":14,"context_line":"    relying on policy defaults, it will keep working because of old defaults are"},{"line_number":15,"context_line":"    still supported as a deprecated rule. If the deployment has overridden the policy"},{"line_number":16,"context_line":"    rule then defaults are not into picture and token are checked as per the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_fff60063","line":13,"range":{"start_line":12,"start_character":4,"end_line":13,"end_character":65},"in_reply_to":"1f493fa4_7c0cbe40","updated":"2020-04-27 22:01:22.000000000","message":"let me clarify it more. I mean policy by default support both new and old defaults so that existing token (without scope) and new token ( with scope)  work fine.","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6995cb9551a2ad181d0739733650bc32a7a11003","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    defaults still work then please read further and check `this bug"},{"line_number":10,"context_line":"    \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    With Nova policies changed as mentioned above, old defaults are supported"},{"line_number":13,"context_line":"    with keeping those as deprecated rule along with new defaults. For deployment"},{"line_number":14,"context_line":"    relying on policy defaults, it will keep working because of old defaults are"},{"line_number":15,"context_line":"    still supported as a deprecated rule. If the deployment has overridden the policy"},{"line_number":16,"context_line":"    rule then defaults are not into picture and token are checked as per the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_1abe5ad4","line":13,"range":{"start_line":12,"start_character":4,"end_line":13,"end_character":65},"in_reply_to":"1f493fa4_fff60063","updated":"2020-04-27 22:40:50.000000000","message":"this is kind of duplicate with very first paragraph (after updates as per other comments) so removing it from here.","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0616f67fc35d0878544064c24a451b1616525db1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    With Nova policies changed as mentioned above, old defaults are supported"},{"line_number":13,"context_line":"    with keeping those as deprecated rule along with new defaults. For deployment"},{"line_number":14,"context_line":"    relying on policy defaults, it will keep working because of old defaults are"},{"line_number":15,"context_line":"    still supported as a deprecated rule. If the deployment has overridden the policy"},{"line_number":16,"context_line":"    rule then defaults are not into picture and token are checked as per the"},{"line_number":17,"context_line":"    overridden rule value."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_ff2e0090","line":15,"range":{"start_line":13,"start_character":67,"end_line":15,"end_character":41},"updated":"2020-04-27 21:15:21.000000000","message":"I think this means \"If you don\u0027t override any policies at all, then you don\u0027t need to do anything different, now or in the future\", is that right? If so, maybe say this at the beginning before getting to the \"if you _do_ override some rules, then read on...\"","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9d02e0d1a3ff849d09c5e2c66a4eb01f03c7b4c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    With Nova policies changed as mentioned above, old defaults are supported"},{"line_number":13,"context_line":"    with keeping those as deprecated rule along with new defaults. For deployment"},{"line_number":14,"context_line":"    relying on policy defaults, it will keep working because of old defaults are"},{"line_number":15,"context_line":"    still supported as a deprecated rule. If the deployment has overridden the policy"},{"line_number":16,"context_line":"    rule then defaults are not into picture and token are checked as per the"},{"line_number":17,"context_line":"    overridden rule value."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_3fed088b","line":15,"range":{"start_line":13,"start_character":67,"end_line":15,"end_character":41},"in_reply_to":"1f493fa4_ff2e0090","updated":"2020-04-27 22:01:22.000000000","message":"yeah, done.","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0616f67fc35d0878544064c24a451b1616525db1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    With Nova policies changed as mentioned above, old defaults are supported"},{"line_number":13,"context_line":"    with keeping those as deprecated rule along with new defaults. For deployment"},{"line_number":14,"context_line":"    relying on policy defaults, it will keep working because of old defaults are"},{"line_number":15,"context_line":"    still supported as a deprecated rule. If the deployment has overridden the policy"},{"line_number":16,"context_line":"    rule then defaults are not into picture and token are checked as per the"},{"line_number":17,"context_line":"    overridden rule value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    If you re-generate the policy.json file via \u0027oslopolicy-sample-generator\u0027"},{"line_number":20,"context_line":"    or any other script which does not include the deprecated rule in the generated"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_9f141c46","line":17,"range":{"start_line":15,"start_character":42,"end_line":17,"end_character":26},"updated":"2020-04-27 21:15:21.000000000","message":"Do you mean if they have overridden *all* of them, or some of them? Or either?","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9d02e0d1a3ff849d09c5e2c66a4eb01f03c7b4c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    With Nova policies changed as mentioned above, old defaults are supported"},{"line_number":13,"context_line":"    with keeping those as deprecated rule along with new defaults. For deployment"},{"line_number":14,"context_line":"    relying on policy defaults, it will keep working because of old defaults are"},{"line_number":15,"context_line":"    still supported as a deprecated rule. If the deployment has overridden the policy"},{"line_number":16,"context_line":"    rule then defaults are not into picture and token are checked as per the"},{"line_number":17,"context_line":"    overridden rule value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    If you re-generate the policy.json file via \u0027oslopolicy-sample-generator\u0027"},{"line_number":20,"context_line":"    or any other script which does not include the deprecated rule in the generated"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_3fa2284c","line":17,"range":{"start_line":15,"start_character":42,"end_line":17,"end_character":26},"in_reply_to":"1f493fa4_9f141c46","updated":"2020-04-27 22:01:22.000000000","message":"for rule which are overridden in policy file. I will clarify that.","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0616f67fc35d0878544064c24a451b1616525db1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    rule then defaults are not into picture and token are checked as per the"},{"line_number":17,"context_line":"    overridden rule value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    If you re-generate the policy.json file via \u0027oslopolicy-sample-generator\u0027"},{"line_number":20,"context_line":"    or any other script which does not include the deprecated rule in the generated"},{"line_number":21,"context_line":"    file. This means rule is overridden with the new-default value"},{"line_number":22,"context_line":"    (\"system_admin_api\": \"role:admin and system_scope:all\") only. Policy checks the"},{"line_number":23,"context_line":"    existing token with these new values in policy.json and fail. This is the exact"},{"line_number":24,"context_line":"    same way when the operator wants to switch to new defaults by overriding the rule"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_5f20d49b","line":21,"range":{"start_line":19,"start_character":4,"end_line":21,"end_character":8},"updated":"2020-04-27 21:15:21.000000000","message":"This sentence appears to be in the format \"if...then\" but without the \"then\" part.","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9d02e0d1a3ff849d09c5e2c66a4eb01f03c7b4c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    rule then defaults are not into picture and token are checked as per the"},{"line_number":17,"context_line":"    overridden rule value."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    If you re-generate the policy.json file via \u0027oslopolicy-sample-generator\u0027"},{"line_number":20,"context_line":"    or any other script which does not include the deprecated rule in the generated"},{"line_number":21,"context_line":"    file. This means rule is overridden with the new-default value"},{"line_number":22,"context_line":"    (\"system_admin_api\": \"role:admin and system_scope:all\") only. Policy checks the"},{"line_number":23,"context_line":"    existing token with these new values in policy.json and fail. This is the exact"},{"line_number":24,"context_line":"    same way when the operator wants to switch to new defaults by overriding the rule"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_3fbb4872","line":21,"range":{"start_line":19,"start_character":4,"end_line":21,"end_character":8},"in_reply_to":"1f493fa4_5f20d49b","updated":"2020-04-27 22:01:22.000000000","message":"oh, let me complete that sentence.","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0616f67fc35d0878544064c24a451b1616525db1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    (though we introduced a new way in Ussuri cycle to achieve the new defaults behaviour"},{"line_number":27,"context_line":"    via  flag ``oslo_policy.enforce_new_defaults``). In that case, existing token"},{"line_number":28,"context_line":"    work for old default might stop working."},{"line_number":29,"context_line":"    To fix that,v either you need to comment out or remove the rules in the generated"},{"line_number":30,"context_line":"    file which are expected to work with defaults and only keep the rule which needs"},{"line_number":31,"context_line":"    to overridden to provide different permissions than their default Or update the"},{"line_number":32,"context_line":"    token to new defaults."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_df3344f5","line":29,"range":{"start_line":29,"start_character":16,"end_line":29,"end_character":17},"updated":"2020-04-27 21:15:21.000000000","message":"s//","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9d02e0d1a3ff849d09c5e2c66a4eb01f03c7b4c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    (though we introduced a new way in Ussuri cycle to achieve the new defaults behaviour"},{"line_number":27,"context_line":"    via  flag ``oslo_policy.enforce_new_defaults``). In that case, existing token"},{"line_number":28,"context_line":"    work for old default might stop working."},{"line_number":29,"context_line":"    To fix that,v either you need to comment out or remove the rules in the generated"},{"line_number":30,"context_line":"    file which are expected to work with defaults and only keep the rule which needs"},{"line_number":31,"context_line":"    to overridden to provide different permissions than their default Or update the"},{"line_number":32,"context_line":"    token to new defaults."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_9fb37c98","line":29,"range":{"start_line":29,"start_character":16,"end_line":29,"end_character":17},"in_reply_to":"1f493fa4_df3344f5","updated":"2020-04-27 22:01:22.000000000","message":"Done","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0616f67fc35d0878544064c24a451b1616525db1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    To fix that,v either you need to comment out or remove the rules in the generated"},{"line_number":30,"context_line":"    file which are expected to work with defaults and only keep the rule which needs"},{"line_number":31,"context_line":"    to overridden to provide different permissions than their default Or update the"},{"line_number":32,"context_line":"    token to new defaults."},{"line_number":33,"context_line":"    Using the old policy file (note freshly generated), for example, train deployment"},{"line_number":34,"context_line":"    policy file, willkeep working without any issue."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_bf5e380f","line":32,"updated":"2020-04-27 21:15:21.000000000","message":"I think the whole paragraph above could be more clearly stated like this:\n\n\"If you generate the policy file with $tool, you will get rules defaulted in the new format, which examines the token scope. Unless you turn on $configoption, scope-checking rules will fail. Thus, be sure to enable $configoption, or use a pre-existing sample config file from the Train release until you are ready to migrate to scoped policies.\"","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9d02e0d1a3ff849d09c5e2c66a4eb01f03c7b4c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    To fix that,v either you need to comment out or remove the rules in the generated"},{"line_number":30,"context_line":"    file which are expected to work with defaults and only keep the rule which needs"},{"line_number":31,"context_line":"    to overridden to provide different permissions than their default Or update the"},{"line_number":32,"context_line":"    token to new defaults."},{"line_number":33,"context_line":"    Using the old policy file (note freshly generated), for example, train deployment"},{"line_number":34,"context_line":"    policy file, willkeep working without any issue."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_5f6bb4ef","line":32,"in_reply_to":"1f493fa4_bf5e380f","updated":"2020-04-27 22:01:22.000000000","message":"Done","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0616f67fc35d0878544064c24a451b1616525db1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    to overridden to provide different permissions than their default Or update the"},{"line_number":32,"context_line":"    token to new defaults."},{"line_number":33,"context_line":"    Using the old policy file (note freshly generated), for example, train deployment"},{"line_number":34,"context_line":"    policy file, willkeep working without any issue."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_bf30f8e9","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":25},"updated":"2020-04-27 21:15:21.000000000","message":"\"will keep\"","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e9d02e0d1a3ff849d09c5e2c66a4eb01f03c7b4c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    to overridden to provide different permissions than their default Or update the"},{"line_number":32,"context_line":"    token to new defaults."},{"line_number":33,"context_line":"    Using the old policy file (note freshly generated), for example, train deployment"},{"line_number":34,"context_line":"    policy file, willkeep working without any issue."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f493fa4_ff69e0f8","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":25},"in_reply_to":"1f493fa4_bf30f8e9","updated":"2020-04-27 22:01:22.000000000","message":"Done","commit_id":"70cbba2f3548871d0ef43f75cdeea1844200bae4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"26565ec239e52c2fad7a573f8fa47730c0cce1a9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    any policies at all, then you don\u0027t need to do anything different until"},{"line_number":8,"context_line":"    W release when old deprecated rules are removed and token needs to be"},{"line_number":9,"context_line":"    scoped to work with new defautls and scope of policies. For migration"},{"line_number":10,"context_line":"    to new policies you can refer `this document"},{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    If you are overridding the policy rules(all of some of them) in policy file with"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_95da3848","line":10,"range":{"start_line":10,"start_character":28,"end_line":10,"end_character":33},"updated":"2020-04-28 07:34:47.000000000","message":"refer to","commit_id":"1901cf668e9fba529e037edd45b6af78bc34581f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"26565ec239e52c2fad7a573f8fa47730c0cce1a9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    to new policies you can refer `this document"},{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    If you are overridding the policy rules(all of some of them) in policy file with"},{"line_number":14,"context_line":"    new defaults value or any new value that requires scoped tokens and expectation"},{"line_number":15,"context_line":"    is that old token which used to work with old defaults still work then please read"},{"line_number":16,"context_line":"    further and check `this bug \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_d5e7a011","line":13,"range":{"start_line":13,"start_character":48,"end_line":13,"end_character":50},"updated":"2020-04-28 07:34:47.000000000","message":"or","commit_id":"1901cf668e9fba529e037edd45b6af78bc34581f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"26565ec239e52c2fad7a573f8fa47730c0cce1a9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    If you are overridding the policy rules(all of some of them) in policy file with"},{"line_number":14,"context_line":"    new defaults value or any new value that requires scoped tokens and expectation"},{"line_number":15,"context_line":"    is that old token which used to work with old defaults still work then please read"},{"line_number":16,"context_line":"    further and check `this bug \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_35c2445a","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":22},"updated":"2020-04-28 07:34:47.000000000","message":"default values","commit_id":"1901cf668e9fba529e037edd45b6af78bc34581f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"26565ec239e52c2fad7a573f8fa47730c0cce1a9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    to new policies you can refer `this document"},{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    If you are overridding the policy rules(all of some of them) in policy file with"},{"line_number":14,"context_line":"    new defaults value or any new value that requires scoped tokens and expectation"},{"line_number":15,"context_line":"    is that old token which used to work with old defaults still work then please read"},{"line_number":16,"context_line":"    further and check `this bug \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    If you generate the policy file with \u0027oslopolicy-sample-generator\u0027 or any"},{"line_number":19,"context_line":"    other tool, you will get rules defaulted in the new format, which examines the"},{"line_number":20,"context_line":"    token scope. Unless you turn on ``oslo_policy.enforce_scope``, scope-checking"},{"line_number":21,"context_line":"    rules will fail. Thus, be sure to enable ``oslo_policy.enforce_scope``, or"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_9532385d","line":18,"range":{"start_line":13,"start_character":3,"end_line":18,"end_character":6},"updated":"2020-04-28 07:34:47.000000000","message":"I would move the bug ref to the last paragraph as something like:\n\n\"For more background about the possible problem check `this bug report`.\"\n\nAnd then we can say that:\n\n\"If you are overwriting the policy rules(all or some of them) in the policy file with new default values or any new value that requires scoped tokens then non-scoped tokens will not work.\n\nAlso if you generate ...","commit_id":"1901cf668e9fba529e037edd45b6af78bc34581f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b9c4dd898d5d6c149382b211f43f4aab314bf729","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    If you are overwriting the policy rules(all or some of them) in policy"},{"line_number":14,"context_line":"    file with new default values or any new value that requires scoped tokens"},{"line_number":15,"context_line":"    then non-scoped tokens will not work. Also if  you generate the policy"},{"line_number":16,"context_line":"    file with \u0027oslopolicy-sample-generator\u0027 json format or any other tool,"},{"line_number":17,"context_line":"    you will get rules defaulted in the new format, which examines the token"},{"line_number":18,"context_line":"    scope. Unless you turn on ``oslo_policy.enforce_scope``, scope-checking"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f493fa4_9d151be8","line":15,"range":{"start_line":15,"start_character":49,"end_line":15,"end_character":52},"updated":"2020-04-29 12:35:15.000000000","message":"nit: remove double space","commit_id":"e97f4586cbee705389b57707e1cd3388b698354f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c310c62b36916f1ad136e4924256b5e424134c4f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    to new policies you can refer to `this document"},{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    If you are overwriting the policy rules(all or some of them) in policy"},{"line_number":14,"context_line":"    file with new default values or any new value that requires scoped tokens"},{"line_number":15,"context_line":"    then non-scoped tokens will not work. Also if you generate the policy"},{"line_number":16,"context_line":"    file with \u0027oslopolicy-sample-generator\u0027 json format or any other tool,"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f493fa4_cd123962","line":13,"range":{"start_line":13,"start_character":43,"end_line":13,"end_character":44},"updated":"2020-04-30 13:56:40.000000000","message":"missing space","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c310c62b36916f1ad136e4924256b5e424134c4f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    scope. Unless you turn on ``oslo_policy.enforce_scope``, scope-checking"},{"line_number":19,"context_line":"    rules will fail. Thus, be sure to enable ``oslo_policy.enforce_scope``, or"},{"line_number":20,"context_line":"    use a pre-existing sample config file from the Train release until you are"},{"line_number":21,"context_line":"    ready to migrate to scoped policies. Other way is to generate the policy"},{"line_number":22,"context_line":"    file in yaml format as described `here"},{"line_number":23,"context_line":"    \u003chttps://docs.openstack.org/oslo.policy/latest/cli/index.html#oslopolicy-policy-generator\u003e`_"},{"line_number":24,"context_line":"    and update the policy.yaml location in ``oslo_policy.policy_file``."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1f493fa4_ed0a9523","line":21,"range":{"start_line":21,"start_character":41,"end_line":21,"end_character":46},"updated":"2020-04-30 13:56:40.000000000","message":"Another","commit_id":"f7f0aded5bdc8937aa081b78767dbba1a9f7a410"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Nova policies implemented the ``scope_type`` and new defaults"},{"line_number":5,"context_line":"    provided by keystone. Old defaults are deprecated and still work"},{"line_number":6,"context_line":"    if rules are not overridden in policy file. If you don\u0027t override"},{"line_number":7,"context_line":"    any policies at all, then you don\u0027t need to do anything different until"},{"line_number":8,"context_line":"    W release when old deprecated rules are removed and token needs to be"},{"line_number":9,"context_line":"    scoped to work with new defautls and scope of policies. For migration"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_44f27b9b","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":34},"updated":"2020-04-30 20:12:00.000000000","message":"in the","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6079541f7ff14305033cf188c92a7557f0ba917b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Nova policies implemented the ``scope_type`` and new defaults"},{"line_number":5,"context_line":"    provided by keystone. Old defaults are deprecated and still work"},{"line_number":6,"context_line":"    if rules are not overridden in policy file. If you don\u0027t override"},{"line_number":7,"context_line":"    any policies at all, then you don\u0027t need to do anything different until"},{"line_number":8,"context_line":"    W release when old deprecated rules are removed and token needs to be"},{"line_number":9,"context_line":"    scoped to work with new defautls and scope of policies. For migration"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_ff786ec4","line":6,"range":{"start_line":6,"start_character":32,"end_line":6,"end_character":34},"in_reply_to":"1f493fa4_44f27b9b","updated":"2020-04-30 21:11:57.000000000","message":"Done","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Nova policies implemented the ``scope_type`` and new defaults"},{"line_number":5,"context_line":"    provided by keystone. Old defaults are deprecated and still work"},{"line_number":6,"context_line":"    if rules are not overridden in policy file. If you don\u0027t override"},{"line_number":7,"context_line":"    any policies at all, then you don\u0027t need to do anything different until"},{"line_number":8,"context_line":"    W release when old deprecated rules are removed and token needs to be"},{"line_number":9,"context_line":"    scoped to work with new defautls and scope of policies. For migration"},{"line_number":10,"context_line":"    to new policies you can refer to `this document"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_842da3ff","line":7,"range":{"start_line":7,"start_character":70,"end_line":7,"end_character":75},"updated":"2020-04-30 20:12:00.000000000","message":"until the","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6079541f7ff14305033cf188c92a7557f0ba917b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Nova policies implemented the ``scope_type`` and new defaults"},{"line_number":5,"context_line":"    provided by keystone. Old defaults are deprecated and still work"},{"line_number":6,"context_line":"    if rules are not overridden in policy file. If you don\u0027t override"},{"line_number":7,"context_line":"    any policies at all, then you don\u0027t need to do anything different until"},{"line_number":8,"context_line":"    W release when old deprecated rules are removed and token needs to be"},{"line_number":9,"context_line":"    scoped to work with new defautls and scope of policies. For migration"},{"line_number":10,"context_line":"    to new policies you can refer to `this document"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_df73f2e5","line":7,"range":{"start_line":7,"start_character":70,"end_line":7,"end_character":75},"in_reply_to":"1f493fa4_842da3ff","updated":"2020-04-30 21:11:57.000000000","message":"Done","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    provided by keystone. Old defaults are deprecated and still work"},{"line_number":6,"context_line":"    if rules are not overridden in policy file. If you don\u0027t override"},{"line_number":7,"context_line":"    any policies at all, then you don\u0027t need to do anything different until"},{"line_number":8,"context_line":"    W release when old deprecated rules are removed and token needs to be"},{"line_number":9,"context_line":"    scoped to work with new defautls and scope of policies. For migration"},{"line_number":10,"context_line":"    to new policies you can refer to `this document"},{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_a436df4f","line":8,"range":{"start_line":8,"start_character":56,"end_line":8,"end_character":67},"updated":"2020-04-30 20:12:00.000000000","message":"tokens need","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6079541f7ff14305033cf188c92a7557f0ba917b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    provided by keystone. Old defaults are deprecated and still work"},{"line_number":6,"context_line":"    if rules are not overridden in policy file. If you don\u0027t override"},{"line_number":7,"context_line":"    any policies at all, then you don\u0027t need to do anything different until"},{"line_number":8,"context_line":"    W release when old deprecated rules are removed and token needs to be"},{"line_number":9,"context_line":"    scoped to work with new defautls and scope of policies. For migration"},{"line_number":10,"context_line":"    to new policies you can refer to `this document"},{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_3f7f76ab","line":8,"range":{"start_line":8,"start_character":56,"end_line":8,"end_character":67},"in_reply_to":"1f493fa4_a436df4f","updated":"2020-04-30 21:11:57.000000000","message":"Done","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    if rules are not overridden in policy file. If you don\u0027t override"},{"line_number":7,"context_line":"    any policies at all, then you don\u0027t need to do anything different until"},{"line_number":8,"context_line":"    W release when old deprecated rules are removed and token needs to be"},{"line_number":9,"context_line":"    scoped to work with new defautls and scope of policies. For migration"},{"line_number":10,"context_line":"    to new policies you can refer to `this document"},{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_04ceb361","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":36},"updated":"2020-04-30 20:12:00.000000000","message":"defaults","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6079541f7ff14305033cf188c92a7557f0ba917b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    if rules are not overridden in policy file. If you don\u0027t override"},{"line_number":7,"context_line":"    any policies at all, then you don\u0027t need to do anything different until"},{"line_number":8,"context_line":"    W release when old deprecated rules are removed and token needs to be"},{"line_number":9,"context_line":"    scoped to work with new defautls and scope of policies. For migration"},{"line_number":10,"context_line":"    to new policies you can refer to `this document"},{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_1f7a7ab8","line":9,"range":{"start_line":9,"start_character":28,"end_line":9,"end_character":36},"in_reply_to":"1f493fa4_04ceb361","updated":"2020-04-30 21:11:57.000000000","message":"Done","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    to new policies you can refer to `this document"},{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    If you are overwriting the policy rules (all or some of them) in policy"},{"line_number":14,"context_line":"    file with new default values or any new value that requires scoped tokens"},{"line_number":15,"context_line":"    then non-scoped tokens will not work. Also if you generate the policy"},{"line_number":16,"context_line":"    file with \u0027oslopolicy-sample-generator\u0027 json format or any other tool,"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_044193a9","line":13,"range":{"start_line":13,"start_character":66,"end_line":13,"end_character":68},"updated":"2020-04-30 20:12:00.000000000","message":"in the","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6079541f7ff14305033cf188c92a7557f0ba917b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    to new policies you can refer to `this document"},{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    If you are overwriting the policy rules (all or some of them) in policy"},{"line_number":14,"context_line":"    file with new default values or any new value that requires scoped tokens"},{"line_number":15,"context_line":"    then non-scoped tokens will not work. Also if you generate the policy"},{"line_number":16,"context_line":"    file with \u0027oslopolicy-sample-generator\u0027 json format or any other tool,"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_5f51a235","line":13,"range":{"start_line":13,"start_character":66,"end_line":13,"end_character":68},"in_reply_to":"1f493fa4_044193a9","updated":"2020-04-30 21:11:57.000000000","message":"Done","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    If you are overwriting the policy rules (all or some of them) in policy"},{"line_number":14,"context_line":"    file with new default values or any new value that requires scoped tokens"},{"line_number":15,"context_line":"    then non-scoped tokens will not work. Also if you generate the policy"},{"line_number":16,"context_line":"    file with \u0027oslopolicy-sample-generator\u0027 json format or any other tool,"},{"line_number":17,"context_line":"    you will get rules defaulted in the new format, which examines the token"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_c4e5ebdd","line":14,"range":{"start_line":14,"start_character":76,"end_line":14,"end_character":77},"updated":"2020-04-30 20:12:00.000000000","message":"tokens,","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6079541f7ff14305033cf188c92a7557f0ba917b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"    \u003chttps://docs.openstack.org/nova/latest/configuration/policy-concepts.html#migration-plan\u003e`_."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    If you are overwriting the policy rules (all or some of them) in policy"},{"line_number":14,"context_line":"    file with new default values or any new value that requires scoped tokens"},{"line_number":15,"context_line":"    then non-scoped tokens will not work. Also if you generate the policy"},{"line_number":16,"context_line":"    file with \u0027oslopolicy-sample-generator\u0027 json format or any other tool,"},{"line_number":17,"context_line":"    you will get rules defaulted in the new format, which examines the token"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_bf442675","line":14,"range":{"start_line":14,"start_character":76,"end_line":14,"end_character":77},"in_reply_to":"1f493fa4_c4e5ebdd","updated":"2020-04-30 21:11:57.000000000","message":"Done","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    file with \u0027oslopolicy-sample-generator\u0027 json format or any other tool,"},{"line_number":17,"context_line":"    you will get rules defaulted in the new format, which examines the token"},{"line_number":18,"context_line":"    scope. Unless you turn on ``oslo_policy.enforce_scope``, scope-checking"},{"line_number":19,"context_line":"    rules will fail. Thus, be sure to enable ``oslo_policy.enforce_scope``, or"},{"line_number":20,"context_line":"    use a pre-existing sample config file from the Train release until you are"},{"line_number":21,"context_line":"    ready to migrate to scoped policies. Another way is to generate the policy"},{"line_number":22,"context_line":"    file in yaml format as described `here"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_647e97e4","line":19,"range":{"start_line":19,"start_character":21,"end_line":19,"end_character":74},"updated":"2020-04-30 20:12:00.000000000","message":"I think we should probably mention here that if one sets enforce_scope \u003d True, then they will need to educate their users on how to request scoped tokens from keystone. I worry about operators setting enforce_scope \u003d True, not knowing they need scoped tokens, and then all of the admin APIs start to fail because everyone\u0027s using project tokens.","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"72db28707912bdc90fffdd7e0151cd66f2c6da2e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    and update the policy.yaml location in ``oslo_policy.policy_file``."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    For more background about the possible problem, check `this bug"},{"line_number":27,"context_line":"    \u003chttps://bugs.launchpad.net/nova/+bug/1875418\u003e`_.\""},{"line_number":28,"context_line":"    A upgrade check has been added to the ``nova-status upgrade check``"},{"line_number":29,"context_line":"    command for this."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f493fa4_c4fe8b69","line":27,"range":{"start_line":27,"start_character":53,"end_line":27,"end_character":54},"updated":"2020-04-30 20:12:00.000000000","message":"This shouldn\u0027t be here, right?","commit_id":"dc4379a448b8a6816fb980aae8b410d4e731825f"}]}