)]}'
{"id":"openstack%2Fnova~723699","triplet_id":"openstack%2Fnova~stable%2Fqueens~Idba40838b7b1d5389ab308f2ea40e28911aecffa","project":"openstack/nova","branch":"stable/queens","hashtags":[],"change_id":"Idba40838b7b1d5389ab308f2ea40e28911aecffa","subject":"DNM: Heal allocations with incomplete consumer information","status":"ABANDONED","created":"2020-04-27 21:12:50.000000000","updated":"2020-04-27 21:43:27.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"381f3b12d9331283bf7baadb7fde159158a65cf4","_number":723699,"virtual_id_number":723699,"owner":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"actions":{},"labels":{"Verified":{"all":[{"date":"2020-04-27 21:32:07.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"date":"2020-04-27 21:30:45.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"date":"2020-04-27 21:12:50.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-27 21:12:50.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2020-04-27 21:30:45.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-04-27 21:32:07.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"}],"messages":[{"id":"05377312a84b124ce512ec5f2882cd92c06249ec","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-04-27 21:12:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5c55b7b85ea8a067cd6442b6b06a3a4039a0ab2d","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-04-27 21:30:45.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/99/723699/1/check/pmem-tempest-plugin-filtered/10680c2/ : POST_FAILURE in 5m 30s\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/99/723699/1/check/pmem-tempest-plugin-filtered-multi-node/3c7c3a8/ : POST_FAILURE in 5m 54s","accounts_in_message":[],"_revision_number":1},{"id":"13dd1535e03627ce10e8b7630192393103bc95fa","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-04-27 21:32:07.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/723699/1 : FAILURE in 8m 34s","accounts_in_message":[],"_revision_number":1},{"id":"381f3b12d9331283bf7baadb7fde159158a65cf4","author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"date":"2020-04-27 21:43:27.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"22995679fe7a8170f2f3af692ad804ca16e23149","revisions":{"22995679fe7a8170f2f3af692ad804ca16e23149":{"kind":"REWORK","_number":1,"created":"2020-04-27 21:12:50.000000000","uploader":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"ref":"refs/changes/99/723699/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/99/723699/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/723699/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/723699/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/723699/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/99/723699/1"}}},"commit":{"parents":[{"commit":"7018f3df14182c38021f6f52594c42ead886b47b","subject":"DNM: Partial cherry-pick of FakeResponse","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7018f3df14182c38021f6f52594c42ead886b47b"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-06-11 23:46:16.000000000","tz":-240},"committer":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2020-04-27 21:12:31.000000000","tz":-240},"subject":"DNM: Heal allocations with incomplete consumer information","message":"DNM: Heal allocations with incomplete consumer information\n\nAllocations created before microversion 1.8 didn\u0027t have project_id\n/ user_id consumer information. In Rocky those will be migrated\nto have consumer records, but using configurable sentinel values.\n\nAs part of heal_allocations, we can detect this and heal the\nallocations using the instance.project_id/user_id information.\n\nThis is something we\u0027d need if we ever use Placement allocation\ninformation counting quotas.\n\nNote that we should be using Placement API version 1.28 with\nconsumer_generation when updating the allocations, but since\npeople might backport this change the usage of consumer\ngenerations is left for a follow up patch.\n\nRelated to blueprint add-consumer-generation\n\nNOTE(artom) Conflicts and notes:\n\n* The big one is conflicts caused by the\n  bp/placement-mirror-host-aggregates series being absent in queens.\n  Git gets tremendously confused about the absence of that code around\n  this backport\u0027s additions, but all the conflicts actually have a\n  clean resolution: don\u0027t include any of\n  bp/placement-mirror-host-aggregates\u0027s code in this backport. The\n  ResourceProviderNotFound exception is - wait for it - an exception,\n  and it\u0027s included here.\n\n* trivial-ish conflicts in nova/exception.py due to\n  different exceptions around the newly added one.\n\n* test_heal_allocations_update_sentinel_consumer(),\n  test_heal_allocations_sentinel_consumer(), and\n  test_heal_allocations_sentinel_consumer_put_fails() used config\n  options introduced by 03d80cf0de, which will not be backported.\n  Their use is assertions about initial values or return values and\n  the tests are still valid without those assertions, so they\u0027re just\n  commented out in the backport. NOTEs have been left inline.\n\n* Test inheritance had to be adjusted because in queens the\n  ProviderUsageBaseTestCase is in\n  nova/tests/functional/test_servers.py and not\n  nova/tests/functional/integrated_helpers.py\n\n* mock, collections and oslo_serialization jsonutils imports had to be\n  added.\n\n* ResourceClass is in nova/objects/fields.py instead of its own\n  nova/rc_fields. Adjust the import.\n\n* To get get_allocations_for_consumer() to include the entire JSON\n  response, the include_project_user param is used instead of its\n  future replacement, include_generation.\n\n* The ALLOCATION_PROJECT_USER placement API microversion is used\n  instead of CONSUMER_GENERATION_VERSION, which doesn\u0027t exist yet.\n\nChange-Id: Idba40838b7b1d5389ab308f2ea40e28911aecffa\n(cherry picked from commit 6b6d81cf2b4600bafaca05117c079e8a1d240756)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/22995679fe7a8170f2f3af692ad804ca16e23149"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/22995679fe7a8170f2f3af692ad804ca16e23149"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}