)]}'
{"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"72e615d046071bba411319e9391432ed6d2388ad","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                    return vbd_ref"},{"line_number":404,"context_line":"            except session.XenAPI.Failure as exc:"},{"line_number":405,"context_line":"                LOG.exception(exc)"},{"line_number":406,"context_line":"    raise exception.StorageError("},{"line_number":407,"context_line":"            reason\u003d(_(\u0027VBD not found in instance %s\u0027) % vm_ref))"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_799ce45d","line":406,"updated":"2014-05-18 11:17:16.000000000","message":"minor nit - you have an extra () that is not needed here","commit_id":"56701398514049200e755ef659523845150f8060"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5cfe38f06787460d3f48cec53f1e655bfdd3d674","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    for vdi_ref in vdi_refs:"},{"line_number":519,"context_line":"        try:"},{"line_number":520,"context_line":"            destroy_vdi(session, vdi_ref)"},{"line_number":521,"context_line":"        except exception.StorageError as exc:"},{"line_number":522,"context_line":"            msg \u003d _(\"Ignoring error while destroying VDI: %s\") % vdi_ref"},{"line_number":523,"context_line":"            LOG.debug(msg)"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_6b125b58","line":521,"updated":"2014-05-16 07:59:14.000000000","message":"This \"exc\" is not used and can be removed.","commit_id":"56701398514049200e755ef659523845150f8060"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"35146c1934ac392cee494aac7217b8f3c8b335c1","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    for vdi_ref in vdi_refs:"},{"line_number":519,"context_line":"        try:"},{"line_number":520,"context_line":"            destroy_vdi(session, vdi_ref)"},{"line_number":521,"context_line":"        except exception.StorageError as exc:"},{"line_number":522,"context_line":"            msg \u003d _(\"Ignoring error while destroying VDI: %s\") % vdi_ref"},{"line_number":523,"context_line":"            LOG.debug(msg)"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_99a29e97","line":521,"in_reply_to":"7adec928_6b125b58","updated":"2014-05-16 14:25:26.000000000","message":"+1","commit_id":"56701398514049200e755ef659523845150f8060"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"afca4b778c37a31c0548d8aca2912d27b7da5b77","unresolved":false,"context_lines":[{"line_number":518,"context_line":"    for vdi_ref in vdi_refs:"},{"line_number":519,"context_line":"        try:"},{"line_number":520,"context_line":"            destroy_vdi(session, vdi_ref)"},{"line_number":521,"context_line":"        except exception.StorageError as exc:"},{"line_number":522,"context_line":"            msg \u003d _(\"Ignoring error while destroying VDI: %s\") % vdi_ref"},{"line_number":523,"context_line":"            LOG.debug(msg)"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_164eb4c1","line":521,"in_reply_to":"7adec928_99a29e97","updated":"2014-05-22 13:53:23.000000000","message":"oops, cut and paste fail, thanks.","commit_id":"56701398514049200e755ef659523845150f8060"}],"nova/virt/xenapi/volume_utils.py":[{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"f7eedf19a3c7fed07f13f338d8f5f6d55395bd16","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    if not vdi_ref:"},{"line_number":157,"context_line":"        raise exception.StorageError("},{"line_number":158,"context_line":"                _(\u0027VDI not found on SR %(sr)s (vdi_uuid \u0027"},{"line_number":159,"context_line":"                  \u0027%(vdi_uuid)s, target_lun %(target_lun)s)\u0027) %"},{"line_number":160,"context_line":"                    {\u0027sr\u0027: sr_ref, \u0027vdi_uuid\u0027: vdi_uuid,"},{"line_number":161,"context_line":"                     \u0027target_lun\u0027: target_lun})"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ae8d1ca_9d7ccd74","line":158,"updated":"2014-05-27 14:27:03.000000000","message":"Everywhere else we are explicit and assign this to reason\u003d\n\nWhy didn\u0027t we do it here?","commit_id":"c0a0b165b2586774e2cbc9a26f5ef8078cfc9558"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8cf6ad5be5d6aac66625c5115ac361301a8becbb","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    if not vdi_ref:"},{"line_number":157,"context_line":"        raise exception.StorageError("},{"line_number":158,"context_line":"                _(\u0027VDI not found on SR %(sr)s (vdi_uuid \u0027"},{"line_number":159,"context_line":"                  \u0027%(vdi_uuid)s, target_lun %(target_lun)s)\u0027) %"},{"line_number":160,"context_line":"                    {\u0027sr\u0027: sr_ref, \u0027vdi_uuid\u0027: vdi_uuid,"},{"line_number":161,"context_line":"                     \u0027target_lun\u0027: target_lun})"}],"source_content_type":"text/x-python","patch_set":9,"id":"3ae8d1ca_a3f32a09","line":158,"in_reply_to":"3ae8d1ca_9d7ccd74","updated":"2014-05-27 15:05:50.000000000","message":"oops, I missed it, code was probably broken before!","commit_id":"c0a0b165b2586774e2cbc9a26f5ef8078cfc9558"}]}