)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a9d0e00b77bd13cf5595b1336d9d18ec54ce57e9","unresolved":false,"context_lines":[{"line_number":2392,"context_line":""},{"line_number":2393,"context_line":""},{"line_number":2394,"context_line":"@require_admin_context"},{"line_number":2395,"context_line":"def instance_get_all_by_grantee_security_groups(context, group_ids):"},{"line_number":2396,"context_line":"    return _instances_fill_metadata(context,"},{"line_number":2397,"context_line":"        _instance_get_all_query(context)."},{"line_number":2398,"context_line":"            join(models.Instance.security_groups)."}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_72f78ef5","line":2395,"updated":"2015-08-19 10:36:36.000000000","message":"I think this should just be:\n\ndef instance_get_all_by_security_groups(context, group_ids):\n\nam I missing something?","commit_id":"f7a8d6367677645c4addde295a3d2ee9f2b3700a"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"6cbaa8afc03b72ce393fb08ebebeb486d8495cfa","unresolved":false,"context_lines":[{"line_number":2392,"context_line":""},{"line_number":2393,"context_line":""},{"line_number":2394,"context_line":"@require_admin_context"},{"line_number":2395,"context_line":"def instance_get_all_by_grantee_security_groups(context, group_ids):"},{"line_number":2396,"context_line":"    return _instances_fill_metadata(context,"},{"line_number":2397,"context_line":"        _instance_get_all_query(context)."},{"line_number":2398,"context_line":"            join(models.Instance.security_groups)."}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_1b374de4","line":2395,"in_reply_to":"fa1b9901_72f78ef5","updated":"2015-08-19 11:53:35.000000000","message":"So, every secgroup rule has two associations to secgroups/instances for the two directions of the rule, one for instances granting access and one for instances that are granted access.\n\nThe normal instance.security_groups[n].rules path that you can lookup using the instance object gets you the rules where the instance is granted access. Here we want to lookup one step further, so instead of getting\n\n  instance -\u003e security_groups -\u003e rules where security_groups in []\n\nwe want\n\n  instance -\u003e security_groups -\u003e rules -\u003e grantee_security_group where grantee_security_group in []","commit_id":"f7a8d6367677645c4addde295a3d2ee9f2b3700a"}]}