)]}'
{"nova/objects/instance.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8a2cc565f098d0778a3b36c1b6604ba973b2b720","unresolved":false,"context_lines":[{"line_number":1163,"context_line":"    # Version 1.15: Instance \u003c\u003d version 1.19"},{"line_number":1164,"context_line":"    # Version 1.16: Added get_all() method"},{"line_number":1165,"context_line":"    # Version 1.17: Instance \u003c\u003d version 1.20"},{"line_number":1166,"context_line":"    # Version 1.18: New method get_by_grantee_security_groups()"},{"line_number":1167,"context_line":"    VERSION \u003d \u00271.18\u0027"},{"line_number":1168,"context_line":""},{"line_number":1169,"context_line":"    fields \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_12fbb2c2","line":1166,"updated":"2015-08-19 10:39:53.000000000","message":"you seem to be adding two methods here.","commit_id":"ead035463196df47cc1870a788f7bed65fe3521e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8a2cc565f098d0778a3b36c1b6604ba973b2b720","unresolved":false,"context_lines":[{"line_number":1305,"context_line":"        return cls.get_by_security_group_id(context, security_group.id)"},{"line_number":1306,"context_line":""},{"line_number":1307,"context_line":"    @base.remotable_classmethod"},{"line_number":1308,"context_line":"    def get_by_grantee_security_group_ids(cls, context, security_group_ids):"},{"line_number":1309,"context_line":"        db_instances \u003d db.instance_get_all_by_grantee_security_groups("},{"line_number":1310,"context_line":"            context, security_group_ids)"},{"line_number":1311,"context_line":"        return _make_instance_list(context, cls(), db_instances, [])"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_52428a11","line":1308,"updated":"2015-08-19 10:39:53.000000000","message":"why not just call this:\n\nget_by_security_group_ids?","commit_id":"ead035463196df47cc1870a788f7bed65fe3521e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8a2cc565f098d0778a3b36c1b6604ba973b2b720","unresolved":false,"context_lines":[{"line_number":1311,"context_line":"        return _make_instance_list(context, cls(), db_instances, [])"},{"line_number":1312,"context_line":""},{"line_number":1313,"context_line":"    @classmethod"},{"line_number":1314,"context_line":"    def get_by_grantee_security_groups(cls, context, security_groups):"},{"line_number":1315,"context_line":"        group_ids \u003d [group.id for group in security_groups]"},{"line_number":1316,"context_line":"        return cls.get_by_grantee_security_group_ids(context, group_ids)"},{"line_number":1317,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_925fc2e4","line":1314,"updated":"2015-08-19 10:39:53.000000000","message":"as above, maybe drop the grantee?","commit_id":"ead035463196df47cc1870a788f7bed65fe3521e"}],"nova/tests/unit/objects/test_instance.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8a2cc565f098d0778a3b36c1b6604ba973b2b720","unresolved":false,"context_lines":[{"line_number":1609,"context_line":"        self.assertTrue(instances[0].obj_attr_is_set(\u0027system_metadata\u0027))"},{"line_number":1610,"context_line":"        self.assertEqual({\u0027foo\u0027: \u0027bar\u0027}, instances[0].system_metadata)"},{"line_number":1611,"context_line":""},{"line_number":1612,"context_line":"    def test_get_by_grantee_security_group(self):"},{"line_number":1613,"context_line":"        fake_instances \u003d ["},{"line_number":1614,"context_line":"            fake_instance.fake_db_instance(id\u003d1),"},{"line_number":1615,"context_line":"            fake_instance.fake_db_instance(id\u003d2)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_d26d3a99","line":1612,"updated":"2015-08-19 10:39:53.000000000","message":"should you not be testing both methods?","commit_id":"ead035463196df47cc1870a788f7bed65fe3521e"}]}