)]}'
{"nova/api/openstack/servers.py":[{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"1a7d066906bf056b72b115f32e471d0559f83ca0","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        # Convert local_zone_only into a boolean"},{"line_number":144,"context_line":"        if \u0027local_zone_only\u0027 in search_opts:"},{"line_number":145,"context_line":"            search_opts[\u0027local_zone_only\u0027] \u003d utils.bool_from_str("},{"line_number":146,"context_line":"                    search_opts[\u0027local_zone_only\u0027])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # If search by \u0027status\u0027, we need to convert it to \u0027vm_state\u0027"},{"line_number":149,"context_line":"        # to pass on to child zones."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BHg%3D","line":146,"updated":"2011-09-28 23:05:40.000000000","message":"I prefer the old way with get(), that way local_zone_only is always in the search_opts dict and you only have to check True/False later on:\n\nsearch_opts[\u0027local_zone_only\u0027] \u003d utils.bool_from_str(\nsearch_opts.get(\u0027local_zone_only\u0027], False))","commit_id":"73086615cdacda91d1ce1dc8e185ba3070ff2463"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"55d7bab13784725ef411d101b05a792b748b45d0","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        # Convert local_zone_only into a boolean"},{"line_number":144,"context_line":"        if \u0027local_zone_only\u0027 in search_opts:"},{"line_number":145,"context_line":"            search_opts[\u0027local_zone_only\u0027] \u003d utils.bool_from_str("},{"line_number":146,"context_line":"                    search_opts[\u0027local_zone_only\u0027])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        # If search by \u0027status\u0027, we need to convert it to \u0027vm_state\u0027"},{"line_number":149,"context_line":"        # to pass on to child zones."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BGs%3D","line":146,"in_reply_to":"AAAACX%2F%2F%2BHg%3D","updated":"2011-09-28 23:22:45.000000000","message":"Ok.  I actually did this so we don\u0027t really need a novaclient update immediately, as changing it back means it\u0027ll always get passed to novaclient.  Maybe novaclient will ignore it, however.\n\nI\u0027ll fix it up... updating novaclient is no big deal if we find we need it. ;)","commit_id":"73086615cdacda91d1ce1dc8e185ba3070ff2463"}],"nova/compute/api.py":[{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"1a7d066906bf056b72b115f32e471d0559f83ca0","unresolved":false,"context_lines":[{"line_number":959,"context_line":"                \u0027name\u0027: \u0027display_name\u0027,"},{"line_number":960,"context_line":"                \u0027instance_name\u0027: \u0027name\u0027,"},{"line_number":961,"context_line":"                \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":962,"context_line":"                \u0027local_zone_only\u0027: None,"},{"line_number":963,"context_line":"                \u0027flavor\u0027: _remap_flavor_filter,"},{"line_number":964,"context_line":"                \u0027fixed_ip\u0027: _remap_fixed_ip_filter}"},{"line_number":965,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BG8%3D","line":962,"updated":"2011-09-28 23:05:40.000000000","message":"Do we need this special \"None\" value?\n\nIf we leave it out, then it goes across without change, right?","commit_id":"73086615cdacda91d1ce1dc8e185ba3070ff2463"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"55d7bab13784725ef411d101b05a792b748b45d0","unresolved":false,"context_lines":[{"line_number":959,"context_line":"                \u0027name\u0027: \u0027display_name\u0027,"},{"line_number":960,"context_line":"                \u0027instance_name\u0027: \u0027name\u0027,"},{"line_number":961,"context_line":"                \u0027tenant_id\u0027: \u0027project_id\u0027,"},{"line_number":962,"context_line":"                \u0027local_zone_only\u0027: None,"},{"line_number":963,"context_line":"                \u0027flavor\u0027: _remap_flavor_filter,"},{"line_number":964,"context_line":"                \u0027fixed_ip\u0027: _remap_fixed_ip_filter}"},{"line_number":965,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BGo%3D","line":962,"in_reply_to":"AAAACX%2F%2F%2BG8%3D","updated":"2011-09-28 23:22:45.000000000","message":"If we leave it out, it\u0027s passed to the get_instance_by_filters call.  That call should ignore it, but the intent here was to keep mostly sane values being passed to the DB layer.  I can remove it.. it\u0027s really kind of pointless.","commit_id":"73086615cdacda91d1ce1dc8e185ba3070ff2463"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"1a7d066906bf056b72b115f32e471d0559f83ca0","unresolved":false,"context_lines":[{"line_number":974,"context_line":"            except KeyError:"},{"line_number":975,"context_line":"                filters[opt] \u003d value"},{"line_number":976,"context_line":"            else:"},{"line_number":977,"context_line":"                if remap_object:"},{"line_number":978,"context_line":"                    if isinstance(remap_object, basestring):"},{"line_number":979,"context_line":"                        filters[remap_object] \u003d value"},{"line_number":980,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BG0%3D","line":977,"updated":"2011-09-28 23:05:40.000000000","message":"this shouldn\u0027t be needed if unmapped objects are copied verbatim.\n\n(screams of a test)","commit_id":"73086615cdacda91d1ce1dc8e185ba3070ff2463"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"55d7bab13784725ef411d101b05a792b748b45d0","unresolved":false,"context_lines":[{"line_number":974,"context_line":"            except KeyError:"},{"line_number":975,"context_line":"                filters[opt] \u003d value"},{"line_number":976,"context_line":"            else:"},{"line_number":977,"context_line":"                if remap_object:"},{"line_number":978,"context_line":"                    if isinstance(remap_object, basestring):"},{"line_number":979,"context_line":"                        filters[remap_object] \u003d value"},{"line_number":980,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F%2BGk%3D","line":977,"in_reply_to":"AAAACX%2F%2F%2BG0%3D","updated":"2011-09-28 23:22:45.000000000","message":"This is all needed, except for the \"if remap_object\" line.. IFF I remove the one thing (\u0027local_zone_only\u0027) that has \u0027None\u0027 above.  \n\nThe remappings are search options to rename to appropriate values (to match Instance columns)... or they are functions to call to do the mapping... or None meaning to not pass to filter at all.  There are tests for a number of the filtering cases in test_compute.py and OS API test_servers.py IIRC.\n\nBut... this is completely unrelated to this branch.","commit_id":"73086615cdacda91d1ce1dc8e185ba3070ff2463"}]}