)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f50ae2424924087e810427b5bdb8ff370d075c9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"silence amqp heartbeat warning"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the nova api is executing under uWSGI or MOD_WSGI"},{"line_number":10,"context_line":"the lifetime of the amqp heartbeat thread is contoled"},{"line_number":11,"context_line":"by the wsgi server. As a result when the nova api is run"},{"line_number":12,"context_line":"in this configurtion we expect the  that the heartbeat thread"},{"line_number":13,"context_line":"will be suspended and heatbeats will be missed when the wsgi"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f493fa4_734f7f6a","line":10,"range":{"start_line":10,"start_character":45,"end_line":10,"end_character":53},"updated":"2020-04-30 17:01:23.000000000","message":"controlled","commit_id":"1152f977f19695a053c47935ace16de6f2f6a98b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f50ae2424924087e810427b5bdb8ff370d075c9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"will be suspended and heatbeats will be missed when the wsgi"},{"line_number":14,"context_line":"server suspend execution of the wsgi application."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change add a python loging filter to supress"},{"line_number":17,"context_line":"the reporting of heatbeat warnings as this behavior is"},{"line_number":18,"context_line":"expected. since operator cannot do anything to address"},{"line_number":19,"context_line":"the issue the warning is just noise and many operators"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f493fa4_532d2393","line":16,"range":{"start_line":16,"start_character":25,"end_line":16,"end_character":31},"updated":"2020-04-30 17:01:23.000000000","message":"logging","commit_id":"1152f977f19695a053c47935ace16de6f2f6a98b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f50ae2424924087e810427b5bdb8ff370d075c9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"will be suspended and heatbeats will be missed when the wsgi"},{"line_number":14,"context_line":"server suspend execution of the wsgi application."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change add a python loging filter to supress"},{"line_number":17,"context_line":"the reporting of heatbeat warnings as this behavior is"},{"line_number":18,"context_line":"expected. since operator cannot do anything to address"},{"line_number":19,"context_line":"the issue the warning is just noise and many operators"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f493fa4_93232ba7","line":16,"range":{"start_line":16,"start_character":42,"end_line":16,"end_character":49},"updated":"2020-04-30 17:01:23.000000000","message":"suppress","commit_id":"1152f977f19695a053c47935ace16de6f2f6a98b"}],"nova/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b07dde13f54397aff17fc4c93f5d41ff4e624be8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def rabbit_heartbeat_filter(log_record):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    # Note the type in the log message was fixed in"},{"line_number":36,"context_line":"    # change Id11db4113c9b1c3add602192c1e915218704ef27"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_2aa76ca9","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":27},"updated":"2020-04-28 22:30:15.000000000","message":"the other approch i could take rather then droping the log message by returning false would be to always return true but set the log level to debug instead of leaving it at warning.","commit_id":"b7968be46da39e3d6de6acaeb71dd4be825ec94e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b57a998b75b0fad29cdc397291198bb884b214d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def rabbit_heartbeat_filter(log_record):"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    # Note the type in the log message was fixed in"},{"line_number":36,"context_line":"    # change Id11db4113c9b1c3add602192c1e915218704ef27"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_cafd286f","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":27},"in_reply_to":"1f493fa4_2aa76ca9","updated":"2020-04-28 22:33:08.000000000","message":"given the excption will be logged at debug anyway\n\nhttps://github.com/openstack/oslo.messaging/blob/cf23a0d37afab8bd027b4fc484af8d9ebab20b6d/oslo_messaging/_drivers/impl_rabbit.py#L1020-L1022\n\ni think dropping it is the correct approch","commit_id":"b7968be46da39e3d6de6acaeb71dd4be825ec94e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3f869d81614bd47848163ab7dc3730e6e20cd54e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    messages \u003d ["},{"line_number":41,"context_line":"        \"Unexpected error during heartbeart thread processing\","},{"line_number":42,"context_line":"        \"Unexpected error during heartbeat thread processing\"]"},{"line_number":43,"context_line":"    return not any( msg in log_record.msg for msg in messages)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"def parse_args(argv, default_config_files\u003dNone, configure_db\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_a0a71d0b","line":43,"updated":"2020-04-29 00:18:59.000000000","message":"pep8: E201 whitespace after \u0027(\u0027","commit_id":"b7968be46da39e3d6de6acaeb71dd4be825ec94e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3f869d81614bd47848163ab7dc3730e6e20cd54e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # NOTE(sean-k-mooney): this file addresses bug #1825584"},{"line_number":57,"context_line":"    # https://bugs.launchpad.net/nova/+bug/1825584"},{"line_number":58,"context_line":"    # eventlet monkey-patching breaks AMQP heartbeat on uWSGI"},{"line_number":59,"context_line":"    rabbit_logger \u003d logging.getLogger(\u0027oslo.messaging._drivers.impl_rabbit\u0027)"},{"line_number":60,"context_line":"    rabbit_logger.addFilter(rabbit_heartbeat_filter)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # NOTE(danms): DEBUG logging in privsep will result in some large"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_00b09142","line":59,"updated":"2020-04-29 00:18:59.000000000","message":"pep8: F821 undefined name \u0027logging\u0027","commit_id":"b7968be46da39e3d6de6acaeb71dd4be825ec94e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"69f92a864277b8c23f26bd30f884a47dda70ee22","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # NOTE(sean-k-mooney): this file addresses bug #1825584"},{"line_number":57,"context_line":"    # https://bugs.launchpad.net/nova/+bug/1825584"},{"line_number":58,"context_line":"    # eventlet monkey-patching breaks AMQP heartbeat on uWSGI"},{"line_number":59,"context_line":"    rabbit_logger \u003d logging.getLogger(\u0027oslo.messaging._drivers.impl_rabbit\u0027)"},{"line_number":60,"context_line":"    rabbit_logger.addFilter(rabbit_heartbeat_filter)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # NOTE(danms): DEBUG logging in privsep will result in some large"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_e03c8530","line":59,"in_reply_to":"1f493fa4_00b09142","updated":"2020-04-30 17:44:03.000000000","message":"ya it would help if i imported that...\n\nor update \n\nfrom oslo_log import log\nto \nfrom oslo_log import log as logging","commit_id":"b7968be46da39e3d6de6acaeb71dd4be825ec94e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b07dde13f54397aff17fc4c93f5d41ff4e624be8","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # NOTE(sean-k-mooney): this file addresses bug #1825584"},{"line_number":57,"context_line":"    # https://bugs.launchpad.net/nova/+bug/1825584"},{"line_number":58,"context_line":"    # eventlet monkey-patching breaks AMQP heartbeat on uWSGI"},{"line_number":59,"context_line":"    rabbit_logger \u003d logging.getLogger(\u0027oslo.messaging._drivers.impl_rabbit\u0027)"},{"line_number":60,"context_line":"    rabbit_logger.addFilter(rabbit_heartbeat_filter)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # NOTE(danms): DEBUG logging in privsep will result in some large"},{"line_number":63,"context_line":"    # and potentially sensitive things being logged."}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_2a72cc49","line":60,"range":{"start_line":59,"start_character":3,"end_line":60,"end_character":52},"updated":"2020-04-28 22:30:15.000000000","message":"i have not actully tested this yet but i think it should work.\n\nwe shoudl be able to see the difference in the gate logs.","commit_id":"b7968be46da39e3d6de6acaeb71dd4be825ec94e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"69f92a864277b8c23f26bd30f884a47dda70ee22","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    # NOTE(sean-k-mooney): this file addresses bug #1825584"},{"line_number":57,"context_line":"    # https://bugs.launchpad.net/nova/+bug/1825584"},{"line_number":58,"context_line":"    # eventlet monkey-patching breaks AMQP heartbeat on uWSGI"},{"line_number":59,"context_line":"    rabbit_logger \u003d log.getLogger(\u0027oslo.messaging._drivers.impl_rabbit\u0027)"},{"line_number":60,"context_line":"    rabbit_logger.addFilter(rabbit_heartbeat_filter)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # NOTE(danms): DEBUG logging in privsep will result in some large"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_72b4be80","line":59,"range":{"start_line":59,"start_character":20,"end_line":59,"end_character":72},"updated":"2020-04-30 17:44:03.000000000","message":"ok this returns a log adapter no the logger...\n\nso yes i shoudl improt base python logging and use that to get the actual logger.","commit_id":"5bc2547e33785e8fbc66eab0f5d2920c59b5d7c9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7e33b5126bf4b618e8d8237167367a39f500a5dd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    # Note the type in the log message was fixed in"},{"line_number":38,"context_line":"    # change Id11db4113c9b1c3add602192c1e915218704ef27"},{"line_number":39,"context_line":"    # but we handle both form to allow this to be backported"},{"line_number":40,"context_line":"    # without consideration of the version of oslo.messaging used."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    messages \u003d ["},{"line_number":43,"context_line":"        \"Unexpected error during heartbeart thread processing\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_d30f732b","line":40,"updated":"2020-04-30 17:00:11.000000000","message":"Can you add a TODO to remove one of these when we bump oslo.messaging to 9.8.0 or greater? That or just do the bump here","commit_id":"1152f977f19695a053c47935ace16de6f2f6a98b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e829fa40be41afe0a786e90937b79383a9e72fae","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    # Note the type in the log message was fixed in"},{"line_number":38,"context_line":"    # change Id11db4113c9b1c3add602192c1e915218704ef27"},{"line_number":39,"context_line":"    # but we handle both form to allow this to be backported"},{"line_number":40,"context_line":"    # without consideration of the version of oslo.messaging used."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    messages \u003d ["},{"line_number":43,"context_line":"        \"Unexpected error during heartbeart thread processing\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_06b23b49","line":40,"in_reply_to":"1f493fa4_b3446775","updated":"2020-04-30 18:01:21.000000000","message":"actully we already require 10.3.0 on master so ill just remove the compat code in the followup.","commit_id":"1152f977f19695a053c47935ace16de6f2f6a98b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"69f92a864277b8c23f26bd30f884a47dda70ee22","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    # Note the type in the log message was fixed in"},{"line_number":38,"context_line":"    # change Id11db4113c9b1c3add602192c1e915218704ef27"},{"line_number":39,"context_line":"    # but we handle both form to allow this to be backported"},{"line_number":40,"context_line":"    # without consideration of the version of oslo.messaging used."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    messages \u003d ["},{"line_number":43,"context_line":"        \"Unexpected error during heartbeart thread processing\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_b3446775","line":40,"in_reply_to":"1f493fa4_d30f732b","updated":"2020-04-30 17:44:03.000000000","message":"am sure ill add a follow up with the bump and a todo in this patch.\n\nwhat changed in 9.8.0\nthe spelling mistake?\n\ni want to support both form so i can backport this without changing it but i can also quickly drop the typo version when i bump the min verions.","commit_id":"1152f977f19695a053c47935ace16de6f2f6a98b"}]}