)]}'
{"doc/source/admin/index.rst":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"a7785de5819625c51de0d5fac4eaee6f0fa40e20","unresolved":false,"context_lines":[{"line_number":144,"context_line":"   support-compute"},{"line_number":145,"context_line":"   secure-live-migration-with-qemu-native-tls"},{"line_number":146,"context_line":"   mitigation-for-Intel-MDS-security-flaws"},{"line_number":147,"context_line":"   vendordata"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1f493fa4_ebb96f15","line":147,"updated":"2020-05-06 22:36:54.000000000","message":"I guess here would be the best place for a doc on healthcheck, sorta like what keystone has done at [1]?\n\n[1] https://docs.openstack.org/keystone/latest/admin/health-check-middleware.html","commit_id":"bf891ca1aa22999580b563d862b0b213af5e2d97"}],"etc/nova/api-paste.ini":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b570c8e15d2f17a0c7e5318173d1ba13b105a9d8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"paste.filter_factory \u003d keystonemiddleware.auth_token:filter_factory"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"[filter:healthcheck]"},{"line_number":104,"context_line":"paste.filter_factory \u003d oslo_middleware:Healthcheck.factory"}],"source_content_type":"text/x-properties","patch_set":8,"id":"1f493fa4_224456b7","line":104,"updated":"2020-05-04 14:54:49.000000000","message":"FWIW, I got a deprecation warning when testing locally :\n\n /home/sbauza/git/openstack/nova/.tox/functional/lib/python3.7/site-packages/paste/deploy/util.py:55: DeprecationWarning: Using function/method \u0027Healthcheck.factory()\u0027 is deprecated: The healthcheck middleware must now be configured as an application, not as a filter\n\n\nI think we shouldn\u0027t merge this now and try at least to use correctly the healthcheck middleware :\n\nhttps://github.com/openstack/oslo.middleware/blob/2e56b4379ab5a8bd5c42e885253c81d2a5f021c2/oslo_middleware/healthcheck/__init__.py#L242-L248","commit_id":"12981eb7b7a07ea4ff69da4c25f199f9281bcc6c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3d617dee414a79796142166b5dbe2471605721f2","unresolved":false,"context_lines":[{"line_number":101,"context_line":"paste.filter_factory \u003d keystonemiddleware.auth_token:filter_factory"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"[filter:healthcheck]"},{"line_number":104,"context_line":"paste.filter_factory \u003d oslo_middleware:Healthcheck.factory"}],"source_content_type":"text/x-properties","patch_set":8,"id":"1f493fa4_65dbfe7c","line":104,"in_reply_to":"1f493fa4_224456b7","updated":"2020-05-04 23:24:15.000000000","message":"+1","commit_id":"12981eb7b7a07ea4ff69da4c25f199f9281bcc6c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"124c4a075d80b3b4169c7940679855013e8e924c","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[app:healthcheck]"},{"line_number":106,"context_line":"paste.app_factory \u003d oslo_middleware:Healthcheck.app_factory"},{"line_number":107,"context_line":"backends \u003d disable_by_file"},{"line_number":108,"context_line":"disable_by_file_path \u003d /var/run/nova/healthcheck_disable"}],"source_content_type":"text/x-properties","patch_set":9,"id":"1f493fa4_00f4965a","line":107,"range":{"start_line":107,"start_character":11,"end_line":107,"end_character":26},"updated":"2020-05-05 17:55:37.000000000","message":"Another plugin available is disable_by_files_ports for app running on a particular port.","commit_id":"938073678165b5ad718a5e6d55abc04e34ce7a92"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"a7785de5819625c51de0d5fac4eaee6f0fa40e20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1f493fa4_2beb5712","line":109,"updated":"2020-05-06 22:36:54.000000000","message":"There\u0027s a possible `detailed` option here that defaults to False that would give *waaaay* more information than is warranted, so as long as that\u0027s False I\u0027m comfortable keeping this un-authenticated.","commit_id":"bf891ca1aa22999580b563d862b0b213af5e2d97"}],"nova/tests/functional/test_middleware.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eae72ad50f9682e37e94cf2fac18b34dc9893a9a","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.assertNotIn(\u0027Access-Control-Allow-Origin\u0027, response.headers)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_healthcheck(self):"},{"line_number":127,"context_line":"        response \u003d self._do_get(\u0027/healthcheck\u0027, strip_version\u003dTrue)"},{"line_number":128,"context_line":"        self.assertEqual(response.status_code, 200)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_e792809f","line":127,"updated":"2020-05-04 13:57:33.000000000","message":"still getting a HTTP300 with this locally","commit_id":"65f2edb2d072d8ef4d79d8783271d98893bf4e43"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a101e539ba5c7356ee03881fdf99f78ae0cddb3f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.assertNotIn(\u0027Access-Control-Allow-Origin\u0027, response.headers)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_healthcheck(self):"},{"line_number":127,"context_line":"        response \u003d self.request(\u0027/healthcheck\u0027)"},{"line_number":128,"context_line":"        self.assertEqual(response.status_code, 200)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_27c5885c","line":127,"updated":"2020-05-04 14:07:18.000000000","message":"this won\u0027t work, just writing a new revision now","commit_id":"78d899273307d297f5a18f476c0facea152b6ab4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3d617dee414a79796142166b5dbe2471605721f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1f493fa4_85e28a2e","line":139,"updated":"2020-05-04 23:24:15.000000000","message":"Oh, well that was easier than I expected.","commit_id":"12981eb7b7a07ea4ff69da4c25f199f9281bcc6c"}]}