)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"233c1397f75e3dd7aa3285645f9120f0517d8c9b","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                exception.UnexpectedDeletingTaskStateError):"},{"line_number":236,"context_line":"            compute_utils.delete_image("},{"line_number":237,"context_line":"                context, instance, self.image_api, image_id)"},{"line_number":238,"context_line":"        except Exception:"},{"line_number":239,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":240,"context_line":"                compute_utils.delete_image("},{"line_number":241,"context_line":"                    context, instance, self.image_api, image_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_f354d856","line":238,"range":{"start_line":238,"start_character":7,"end_line":238,"end_character":25},"updated":"2020-05-06 08:28:17.000000000","message":"This is the base exception, should be able catch InstanceNotFound and UnexpectedDeletingTaskStateError also, or I miss something. Would you mind to file a bug for this, then we can know the issue better.","commit_id":"9b007791e022b24ef67aceb99fa190b55af12584"},{"author":{"_account_id":23654,"name":"tianmaofu","email":"tianmaofu@126.com","username":"tianmaofu"},"change_message_id":"238e8ff6ab12d407d22c5ac221865b14a3cb4233","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                exception.UnexpectedDeletingTaskStateError):"},{"line_number":236,"context_line":"            compute_utils.delete_image("},{"line_number":237,"context_line":"                context, instance, self.image_api, image_id)"},{"line_number":238,"context_line":"        except Exception:"},{"line_number":239,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":240,"context_line":"                compute_utils.delete_image("},{"line_number":241,"context_line":"                    context, instance, self.image_api, image_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e672357c","line":238,"range":{"start_line":238,"start_character":7,"end_line":238,"end_character":25},"in_reply_to":"1f493fa4_f354d856","updated":"2020-05-28 00:54:56.000000000","message":"Hi, Alex, How about the patch 2?","commit_id":"9b007791e022b24ef67aceb99fa190b55af12584"},{"author":{"_account_id":23654,"name":"tianmaofu","email":"tianmaofu@126.com","username":"tianmaofu"},"change_message_id":"a961ae7b1d12c49f6f3824f7fc2c31da201a6d72","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                exception.UnexpectedDeletingTaskStateError):"},{"line_number":236,"context_line":"            compute_utils.delete_image("},{"line_number":237,"context_line":"                context, instance, self.image_api, image_id)"},{"line_number":238,"context_line":"        except Exception:"},{"line_number":239,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":240,"context_line":"                compute_utils.delete_image("},{"line_number":241,"context_line":"                    context, instance, self.image_api, image_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_3380008c","line":238,"range":{"start_line":238,"start_character":7,"end_line":238,"end_character":25},"in_reply_to":"1f493fa4_f354d856","updated":"2020-05-06 08:47:22.000000000","message":"Yeah, i know this is the base Exception.\n\nWhen catch InstanceNotFound and UnexpectedDeleting, we don\u0027t want to raise it again and log it(because we warning it before). so I add another catch section here.\n\nIn some point, this is not a bug. we can treat it like a Improvement.","commit_id":"9b007791e022b24ef67aceb99fa190b55af12584"}]}
