)]}'
{".zuul.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"964eb0a52e60e34b60e5613a65d0593461cbc47b","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        - nova-lvm"},{"line_number":378,"context_line":"        - nova-multi-cell"},{"line_number":379,"context_line":"        - nova-next"},{"line_number":380,"context_line":"        - nova-tox-functional-py36"},{"line_number":381,"context_line":"        - nova-tox-functional-py38"},{"line_number":382,"context_line":"        - tempest-integrated-compute:"},{"line_number":383,"context_line":"            # NOTE(gmann): Policies changes do not need to run all the"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_40d4b0bd","line":380,"range":{"start_line":380,"start_character":0,"end_line":380,"end_character":34},"updated":"2020-05-07 17:05:51.000000000","message":"Can we drop this now? I don\u0027t really see any reason to run against multiple Python 3 versions when we\u0027re already doing this for unit tests. Sure, it\u0027s extra coverage but it doesn\u0027t really seem necessary","commit_id":"5fb210aa38730073f58ca7d93d6b8542c726bff4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ec243f76a2af9e7bf7be5bed1b53d4064d5d9a28","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        - nova-lvm"},{"line_number":378,"context_line":"        - nova-multi-cell"},{"line_number":379,"context_line":"        - nova-next"},{"line_number":380,"context_line":"        - nova-tox-functional-py36"},{"line_number":381,"context_line":"        - nova-tox-functional-py38"},{"line_number":382,"context_line":"        - tempest-integrated-compute:"},{"line_number":383,"context_line":"            # NOTE(gmann): Policies changes do not need to run all the"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_8b36d9e6","line":380,"range":{"start_line":380,"start_character":0,"end_line":380,"end_character":34},"in_reply_to":"1f493fa4_40d4b0bd","updated":"2020-05-07 17:13:24.000000000","message":"agree. I think unit test is enough to cover all and latest version on fucntional or integration job. \n\ndone","commit_id":"5fb210aa38730073f58ca7d93d6b8542c726bff4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"964eb0a52e60e34b60e5613a65d0593461cbc47b","unresolved":false,"context_lines":[{"line_number":411,"context_line":"      jobs:"},{"line_number":412,"context_line":"        - nova-grenade-multinode"},{"line_number":413,"context_line":"        - nova-live-migration"},{"line_number":414,"context_line":"        - nova-tox-functional-py36"},{"line_number":415,"context_line":"        - nova-tox-functional-py38"},{"line_number":416,"context_line":"        - nova-multi-cell"},{"line_number":417,"context_line":"        - nova-next"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_80d518ba","line":414,"range":{"start_line":414,"start_character":0,"end_line":414,"end_character":34},"updated":"2020-05-07 17:05:51.000000000","message":"Ditto","commit_id":"5fb210aa38730073f58ca7d93d6b8542c726bff4"}],"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"791ce153a35e06066e04d07a3f2fb87df4b6a2e0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Unit tests are already moved to py3.8 but functional tests are not."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit moves the py3.7 functional job py3.8 and add that in"},{"line_number":15,"context_line":"check and gate pipeline."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1d6a2986fcb0435cfabdd104d202b65329909d2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f493fa4_8ca9cfde","line":15,"updated":"2020-05-07 19:48:50.000000000","message":"I think this should have mentioned that you\u0027re also explicitly dropping the py3.6 functional job because I didn\u0027t expect that based on the earlier statement in this commit message \"we need to test py3.6 and py3.8\".","commit_id":"5ffc6f0ba00291c667857962bf77aabae54057d9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f1db9b74a6536fd299795933d8cc4a45576421a6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Unit tests are already moved to py3.8 but functional tests are not."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit moves the py3.7 functional job py3.8 and add that in"},{"line_number":15,"context_line":"check and gate pipeline."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1d6a2986fcb0435cfabdd104d202b65329909d2b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1f493fa4_8c9d4f59","line":15,"in_reply_to":"1f493fa4_8ca9cfde","updated":"2020-05-07 20:13:10.000000000","message":"yeah, i forgot to update it. \ndone.","commit_id":"5ffc6f0ba00291c667857962bf77aabae54057d9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"734d5a954825d2c9d4e5de299742ccbd0501180d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Moving functional jobs to Victoria testing runtime"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As per Victoria testing runtime[1], we need to tests py3.6, y3.7, and py3.8."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- py3.7 is being tested with integration jobs."},{"line_number":12,"context_line":"- py3.6 and py3.8 are tested with unit test jobs."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_0add9a13","line":9,"range":{"start_line":9,"start_character":60,"end_line":9,"end_character":61},"updated":"2020-05-08 08:48:58.000000000","message":"py","commit_id":"0cd6be02c6792c6c65742e8944e608ca96548cca"}],"tox.ini":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"964eb0a52e60e34b60e5613a65d0593461cbc47b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  Run functional tests using python3.8."},{"line_number":101,"context_line":"deps \u003d {[testenv:functional]deps}"},{"line_number":102,"context_line":"commands \u003d"},{"line_number":103,"context_line":"  {[testenv:functional]commands}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[testenv:api-samples]"},{"line_number":106,"context_line":"setenv \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1f493fa4_20c7e414","line":103,"updated":"2020-05-07 17:05:51.000000000","message":"Can you add a new so we can keep functional-py37 for now (we still support py37)","commit_id":"5fb210aa38730073f58ca7d93d6b8542c726bff4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b44ace52256e9c4d8cf0d9ef2cf4d6d2fd36cfa8","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  Run functional tests using python3.8."},{"line_number":101,"context_line":"deps \u003d {[testenv:functional]deps}"},{"line_number":102,"context_line":"commands \u003d"},{"line_number":103,"context_line":"  {[testenv:functional]commands}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[testenv:api-samples]"},{"line_number":106,"context_line":"setenv \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1f493fa4_e0597c5a","line":103,"in_reply_to":"1f493fa4_20c7e414","updated":"2020-05-07 17:09:40.000000000","message":"Alternative, we could merge these into:\n\n  [testenv:functional-py{36,37,38}]\n  description \u003d\n    Run functional tests using {basepython}.\n  deps \u003d {[testenv:functional]deps}\n  commands \u003d\n    {[testenv:functional]commands}","commit_id":"5fb210aa38730073f58ca7d93d6b8542c726bff4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ec243f76a2af9e7bf7be5bed1b53d4064d5d9a28","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  Run functional tests using python3.8."},{"line_number":101,"context_line":"deps \u003d {[testenv:functional]deps}"},{"line_number":102,"context_line":"commands \u003d"},{"line_number":103,"context_line":"  {[testenv:functional]commands}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[testenv:api-samples]"},{"line_number":106,"context_line":"setenv \u003d"}],"source_content_type":"text/x-properties","patch_set":1,"id":"1f493fa4_eb4afd52","line":103,"in_reply_to":"1f493fa4_e0597c5a","updated":"2020-05-07 17:13:24.000000000","message":"ok. for local run or any third party we can.","commit_id":"5fb210aa38730073f58ca7d93d6b8542c726bff4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"85de4488637c7cc9b4e34009222182df5faa935d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  stestr --test-path\u003d./nova/tests/functional run {posargs}"},{"line_number":89,"context_line":"  stestr slowest"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"[testenv:functional-py{36,37,38}]"},{"line_number":92,"context_line":"description \u003d"},{"line_number":93,"context_line":"  Run functional tests using {basepython}."},{"line_number":94,"context_line":"deps \u003d {[testenv:functional]deps}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1f493fa4_c048bbcd","line":91,"updated":"2020-05-07 21:07:37.000000000","message":"Something weird is happening locally when I try out this change.\n\nWhen I run \u0027tox -efunctional-py36 ServiceTestCase\u0027 with this patch, it\u0027s running unit tests under nova/tests/unit/ instead of functional tests under nova/tests/functional. It works as expected on the current master branch.\n\nNot sure what\u0027s going on -- why does this change cause that behavior?","commit_id":"9eaa14aa5f9525954838399c3fb855c8f93201d4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2570f346efa164590ac1f1e8f25257e5274d5d38","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  stestr --test-path\u003d./nova/tests/functional run {posargs}"},{"line_number":89,"context_line":"  stestr slowest"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"[testenv:functional-py{36,37,38}]"},{"line_number":92,"context_line":"description \u003d"},{"line_number":93,"context_line":"  Run functional tests using {basepython}."},{"line_number":94,"context_line":"deps \u003d {[testenv:functional]deps}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1f493fa4_e386a165","line":91,"in_reply_to":"1f493fa4_237369b3","updated":"2020-05-07 21:49:41.000000000","message":"I am also confused. on gate it is working fine on new functional 3.8 job[1]\n\nBut when I run locally it goes to [testenv] not [testenv:functional] command with which is what melanie reported.  \n\n[1] https://zuul.opendev.org/t/openstack/build/e76e46bc0806417d8912b3d96a8c821f/log/job-output.txt#1305","commit_id":"9eaa14aa5f9525954838399c3fb855c8f93201d4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a647a652b9c84ce3c071dc1f7bdaa0b4f88226b1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  stestr --test-path\u003d./nova/tests/functional run {posargs}"},{"line_number":89,"context_line":"  stestr slowest"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"[testenv:functional-py{36,37,38}]"},{"line_number":92,"context_line":"description \u003d"},{"line_number":93,"context_line":"  Run functional tests using {basepython}."},{"line_number":94,"context_line":"deps \u003d {[testenv:functional]deps}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1f493fa4_f462d5ac","line":91,"in_reply_to":"1f493fa4_79aebee7","updated":"2020-05-08 03:46:00.000000000","message":"Ahhhh dang. Thanks gmann, so sorry for sending you on that wild goose chase. :( :( :(\n\nI upgraded to tox 3.15 and now it\u0027s working well for me.","commit_id":"9eaa14aa5f9525954838399c3fb855c8f93201d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"63264e480c3eabb4774a66d145640b8cdee76493","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  stestr --test-path\u003d./nova/tests/functional run {posargs}"},{"line_number":89,"context_line":"  stestr slowest"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"[testenv:functional-py{36,37,38}]"},{"line_number":92,"context_line":"description \u003d"},{"line_number":93,"context_line":"  Run functional tests using {basepython}."},{"line_number":94,"context_line":"deps \u003d {[testenv:functional]deps}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1f493fa4_237369b3","line":91,"in_reply_to":"1f493fa4_c048bbcd","updated":"2020-05-07 21:44:11.000000000","message":"This _should_ work, per the docs [1]. Sounds like a tox bug\n\n[1] https://tox.readthedocs.io/en/latest/config.html#generative-section-names","commit_id":"9eaa14aa5f9525954838399c3fb855c8f93201d4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"bbceb8507ecf9f3f88e7ef0d4db6fc9535fd28fd","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  stestr --test-path\u003d./nova/tests/functional run {posargs}"},{"line_number":89,"context_line":"  stestr slowest"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"[testenv:functional-py{36,37,38}]"},{"line_number":92,"context_line":"description \u003d"},{"line_number":93,"context_line":"  Run functional tests using {basepython}."},{"line_number":94,"context_line":"deps \u003d {[testenv:functional]deps}"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1f493fa4_79aebee7","line":91,"in_reply_to":"1f493fa4_e386a165","updated":"2020-05-08 00:59:19.000000000","message":"got it. Expanding the testenv section is added in 3.15 version[1]. And I was trying to fix in 3.14.6 (my local tox version ) in different way [2] which also worked fine for me locally :) but saved my PR while testing on 3.15.\n\nWe need to raise the tox min version to 3.15 here to make it work. gate job somehow got the 3.15 as it was fresh VM. \n\n\n[1]\nhttps://github.com/tox-dev/tox/pull/1545\n[2] https://github.com/gmannos/tox/commit/77a1974ecb8b3ae1a2838cb8f7daa8a9d2bb7602","commit_id":"9eaa14aa5f9525954838399c3fb855c8f93201d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"734d5a954825d2c9d4e5de299742ccbd0501180d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.15"},{"line_number":3,"context_line":"envlist \u003d py38,functional,pep8"},{"line_number":4,"context_line":"# Automatic envs (pyXX) will only use the python version appropriate to that"},{"line_number":5,"context_line":"# env and ignore basepython inherited from [testenv] if we set"}],"source_content_type":"text/x-properties","patch_set":5,"id":"1f493fa4_8a3eca26","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":17},"updated":"2020-05-08 08:48:58.000000000","message":"Thanks for investigating this but 3.15 is _super_ new (like, 6 days old) and isn\u0027t available on Fedora at least. I wonder if it would make more sense to suffer the bit of duplication for now and bump this later in the cycle? The alternative is that *everyone* (except maybe Arch people) installs from PyPI as soon as this is merged, which doesn\u0027t seem great.","commit_id":"0cd6be02c6792c6c65742e8944e608ca96548cca"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e1c6f36df97f3ae46f6beea545af34912ec0eadd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"minversion \u003d 3.15"},{"line_number":3,"context_line":"envlist \u003d py38,functional,pep8"},{"line_number":4,"context_line":"# Automatic envs (pyXX) will only use the python version appropriate to that"},{"line_number":5,"context_line":"# env and ignore basepython inherited from [testenv] if we set"}],"source_content_type":"text/x-properties","patch_set":5,"id":"1f493fa4_43fe6838","line":2,"range":{"start_line":1,"start_character":0,"end_line":2,"end_character":17},"in_reply_to":"1f493fa4_8a3eca26","updated":"2020-05-08 15:53:24.000000000","message":"I see. make sense let\u0027s do that sometime later.\n\ndone","commit_id":"0cd6be02c6792c6c65742e8944e608ca96548cca"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7cdaf1ed9f8977dd758bce602569cfdb44e83844","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  stestr --test-path\u003d./nova/tests/functional run {posargs}"},{"line_number":89,"context_line":"  stestr slowest"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"[testenv:functional-py36]"},{"line_number":92,"context_line":"description \u003d"},{"line_number":93,"context_line":"  Run functional tests using python3.6."},{"line_number":94,"context_line":"deps \u003d {[testenv:functional]deps}"}],"source_content_type":"text/x-properties","patch_set":6,"id":"1f493fa4_323ba3c8","line":91,"updated":"2020-05-08 16:49:58.000000000","message":"A TODO to merge these one we can bump the minimum might be helpful","commit_id":"c3834e675fde19689543d3a99767555ffa3dcb2d"}]}