)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2168572bf655a4e138800d6e8fd6f5bac6386a71","unresolved":false,"context_lines":[{"line_number":10,"context_line":"running under Python runtimes older than 3.3. Since we now only support"},{"line_number":11,"context_line":"versions higher than this, this third party package requirement can now"},{"line_number":12,"context_line":"be removed."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I955117b838cdd8a1858cfccbc3caa33ba6ad59f7"},{"line_number":15,"context_line":"Signed-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_827c40b6","line":13,"updated":"2020-05-04 23:03:30.000000000","message":"Just noting that even if we remove this, AFAICT the monotonic package will still be pulled in by eventlet\u0027s own dependencies?\n\nhttps://github.com/eventlet/eventlet/blob/cf47cb518db3e0dbdd48473fb40cf9f6ecd50e07/setup.py#L21","commit_id":"5af9ad4e54138e9dfcba50a30601c9df1d98c62b"}],"nova/service.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7b911cee3eb200bc148a1c47043771817bd689eb","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    if hub.clock is not monotonic.monotonic:"},{"line_number":101,"context_line":"        raise RuntimeError("},{"line_number":102,"context_line":"            \u0027eventlet hub is not using a monotonic clock - \u0027"},{"line_number":103,"context_line":"            \u0027periodic tasks will be affected by drifts of system time.\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class Service(service.Service):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_512e88a5","side":"PARENT","line":103,"updated":"2020-05-11 11:06:38.000000000","message":"Reading the commit message, I\u0027m not sure we should be doing this. This was added to make sure nova doesn\u0027t start with the default eventlet hub but rather the one from oslo.service that uses the monotonic timer. Perhaps we could rework this to compare against time.monotonic instead?","commit_id":"fdcb1e306eb5d2396d5af65a12f09d74cbfc4d20"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"24002aa7f9645648dcff5d5bdcbe7545ad231dcd","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    if hub.clock is not monotonic.monotonic:"},{"line_number":101,"context_line":"        raise RuntimeError("},{"line_number":102,"context_line":"            \u0027eventlet hub is not using a monotonic clock - \u0027"},{"line_number":103,"context_line":"            \u0027periodic tasks will be affected by drifts of system time.\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class Service(service.Service):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_bcb1bbe4","side":"PARENT","line":103,"in_reply_to":"ff570b3c_512e88a5","updated":"2020-05-11 11:37:38.000000000","message":"It seems really odd to me, and I assumed a leftover from before parts were moved out into oslo.service, that nova would need to have a unit test to validate an internal detail of an external library like this. That\u0027s not normally something I would deem appropriate for a unit test.\n\nWhat is the concern or the need for nova to be validating here?","commit_id":"fdcb1e306eb5d2396d5af65a12f09d74cbfc4d20"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"22f7e0783fea4b20e811afaf972c8cb6dfdd7591","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    if hub.clock is not monotonic.monotonic:"},{"line_number":101,"context_line":"        raise RuntimeError("},{"line_number":102,"context_line":"            \u0027eventlet hub is not using a monotonic clock - \u0027"},{"line_number":103,"context_line":"            \u0027periodic tasks will be affected by drifts of system time.\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class Service(service.Service):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_854b8e85","side":"PARENT","line":103,"in_reply_to":"ff570b3c_bcb1bbe4","updated":"2020-08-17 09:41:41.000000000","message":"I guess the concern now would be that the eventlet hub is not configured properly. You\u0027re right that reaching into what are essentially the guts of oslo.service probably isn\u0027t the right call and we should trust the import of oslo.service to be doing its job.","commit_id":"fdcb1e306eb5d2396d5af65a12f09d74cbfc4d20"}]}