)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5688f065494ba7380d9586abef3a4ab8bec7feb2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     varshneyg \u003cnalini.v@partner.samsung.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-21 00:31:07 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add migration to make key field type VARBINARY in aggregate_metadata table,"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because MySQL is case insensitive by default, and this migration make key"},{"line_number":10,"context_line":"field sensitive so that it will make metadata keys case-sensitive and store"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ff570b3c_4abb2de4","line":7,"updated":"2020-05-27 18:16:31.000000000","message":"This is also not comprehensive. There are additional APIs where we have metadata subject to the same issue. If we modify one of them, we should identify and modify the others in a consistent way.","commit_id":"92fdd7103f7c708c220b95a9af1c864ec4fdfc7d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a17bf667afb2f9c8294163cce08abb3d659b42f6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Because MySQL is case insensitive by default, and this migration make key"},{"line_number":10,"context_line":"field sensitive so that it will make metadata keys case-sensitive and store"},{"line_number":11,"context_line":"abc\u003d1 and ABC\u003d2 will be two diffrent values"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4b4fe7bbd9cb2a38d1705773ca4fd6a5660a44b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ff570b3c_6a59d133","line":12,"updated":"2020-05-27 17:59:53.000000000","message":"This is in reference to https://bugs.launchpad.net/nova/+bug/1538011 so the commit message should have:\n\nCloses-Bug: #1538011","commit_id":"92fdd7103f7c708c220b95a9af1c864ec4fdfc7d"}],"nova/db/sqlalchemy/migrate_repo/versions/413_mysql_aggregate_metadata_binary_collation.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6721083dc6dc2232672e39728add893df39a432b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                               \"COLLATE utf8_bin;\")"},{"line_number":29,"context_line":"        else:"},{"line_number":30,"context_line":"            table \u003d Table(\u0027aggregate_metadata\u0027, meta, autoload\u003dTrue)"},{"line_number":31,"context_line":"            table.c.key.alter(type\u003dString(255,\"CHARACTER SET utf8_bin\"), "},{"line_number":32,"context_line":"                    nullable\u003dFalse)"},{"line_number":33,"context_line":"            shadow_table \u003d Table(\u0027shadow_aggregate_metadata\u0027, meta,"},{"line_number":34,"context_line":"                    autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_df485e5d","line":31,"updated":"2020-05-17 07:35:56.000000000","message":"pep8: E231 missing whitespace after \u0027,\u0027","commit_id":"149b54bc31d54ecf3c65500c9bf03c05c8bb9c0f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6721083dc6dc2232672e39728add893df39a432b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                               \"COLLATE utf8_bin;\")"},{"line_number":29,"context_line":"        else:"},{"line_number":30,"context_line":"            table \u003d Table(\u0027aggregate_metadata\u0027, meta, autoload\u003dTrue)"},{"line_number":31,"context_line":"            table.c.key.alter(type\u003dString(255,\"CHARACTER SET utf8_bin\"), "},{"line_number":32,"context_line":"                    nullable\u003dFalse)"},{"line_number":33,"context_line":"            shadow_table \u003d Table(\u0027shadow_aggregate_metadata\u0027, meta,"},{"line_number":34,"context_line":"                    autoload\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_bf45aa45","line":31,"updated":"2020-05-17 07:35:56.000000000","message":"pep8: W291 trailing whitespace","commit_id":"149b54bc31d54ecf3c65500c9bf03c05c8bb9c0f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6721083dc6dc2232672e39728add893df39a432b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                    nullable\u003dFalse)"},{"line_number":33,"context_line":"            shadow_table \u003d Table(\u0027shadow_aggregate_metadata\u0027, meta,"},{"line_number":34,"context_line":"                    autoload\u003dTrue)"},{"line_number":35,"context_line":"            shadow_table.c.key.alter(type\u003dString(255,\"CHARACTER SET utf8_bin\"), "},{"line_number":36,"context_line":"                    nullable\u003dFalse)"},{"line_number":37,"context_line":"    except Exception:"},{"line_number":38,"context_line":"        msg \u003d (_(\u0027Migration cannot continue until aggregate metadata key \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_1f78168e","line":35,"updated":"2020-05-17 07:35:56.000000000","message":"pep8: E231 missing whitespace after \u0027,\u0027","commit_id":"149b54bc31d54ecf3c65500c9bf03c05c8bb9c0f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6721083dc6dc2232672e39728add893df39a432b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                    nullable\u003dFalse)"},{"line_number":33,"context_line":"            shadow_table \u003d Table(\u0027shadow_aggregate_metadata\u0027, meta,"},{"line_number":34,"context_line":"                    autoload\u003dTrue)"},{"line_number":35,"context_line":"            shadow_table.c.key.alter(type\u003dString(255,\"CHARACTER SET utf8_bin\"), "},{"line_number":36,"context_line":"                    nullable\u003dFalse)"},{"line_number":37,"context_line":"    except Exception:"},{"line_number":38,"context_line":"        msg \u003d (_(\u0027Migration cannot continue until aggregate metadata key \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff570b3c_ff7c4284","line":35,"updated":"2020-05-17 07:35:56.000000000","message":"pep8: W291 trailing whitespace","commit_id":"149b54bc31d54ecf3c65500c9bf03c05c8bb9c0f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a17bf667afb2f9c8294163cce08abb3d659b42f6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"            migrate_engine.execute(\"ALTER TABLE shadow_aggregate_metadata \""},{"line_number":25,"context_line":"                               \"CONVERT TO CHARACTER SET utf8 \""},{"line_number":26,"context_line":"                               \"COLLATE utf8_bin;\")"},{"line_number":27,"context_line":"    except Exception:"},{"line_number":28,"context_line":"        msg \u003d (_(\u0027Migration cannot continue until aggregate metadata key \u0027"},{"line_number":29,"context_line":"                 \u0027have been migrated to the `__DEFAULT__` key type. Please \u0027"},{"line_number":30,"context_line":"                 \u0027run `nova-manage db online_data_migrations`. \u0027))"},{"line_number":31,"context_line":"        raise exception.ValidationError(msg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_ea44c149","line":31,"range":{"start_line":27,"start_character":4,"end_line":31,"end_character":44},"updated":"2020-05-27 17:59:53.000000000","message":"What is this exception handling doing and how is it related to online_data_migrations?","commit_id":"92fdd7103f7c708c220b95a9af1c864ec4fdfc7d"}],"nova/db/sqlalchemy/models.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a17bf667afb2f9c8294163cce08abb3d659b42f6","unresolved":false,"context_lines":[{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":""},{"line_number":1154,"context_line":"# NOTE(alaski): This table exists in the nova_api database and its usage here"},{"line_number":1155,"context_line":"# is deprecated."},{"line_number":1156,"context_line":"class AggregateMetadata(BASE, NovaBase, models.SoftDeleteMixin):"},{"line_number":1157,"context_line":"    \"\"\"Represents a metadata key/value pair for an aggregate.\"\"\""},{"line_number":1158,"context_line":"    __tablename__ \u003d \u0027aggregate_metadata\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff570b3c_ea5de115","line":1155,"updated":"2020-05-27 17:59:53.000000000","message":"This table is not used and thus should not be updated at this point.","commit_id":"92fdd7103f7c708c220b95a9af1c864ec4fdfc7d"}],"nova/tests/unit/db/test_migrations.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"54c3da36a14cb1131604de9464a60db464451635","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            # it does not affect anything."},{"line_number":236,"context_line":"            346,"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            # 413 Alter key column from aggretae_metadata table, so it "},{"line_number":239,"context_line":"            # can be done without affecting anything"},{"line_number":240,"context_line":"            413,"},{"line_number":241,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_47886dc5","line":238,"updated":"2020-05-12 10:54:46.000000000","message":"pep8: W291 trailing whitespace","commit_id":"0643b6d128715a55d1aa27e69df9e6e6ecf519a2"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"9bed17368e2ba1382a681b02955fef2df53b0361","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            # it does not affect anything."},{"line_number":236,"context_line":"            346,"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"            # 413 Alter key column from aggretae_metadata table, so it "},{"line_number":239,"context_line":"            # can be done without affecting anything"},{"line_number":240,"context_line":"            413,"},{"line_number":241,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_b8c24732","line":238,"updated":"2020-05-12 14:32:39.000000000","message":"pep8: W291 trailing whitespace","commit_id":"a544baaf849b5debe2ddf2b31b984933dab794bf"}]}