)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"86bb402593814048ff27621d64c21e74275f3761","unresolved":false,"context_lines":[{"line_number":7,"context_line":"DescribeInstances in ec2 shows wrong image-message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If one instance boots from a volume,"},{"line_number":10,"context_line":" the value of \u0027image_id\u0027 by \u0027DescribeInstances\u0027 in ec2,"},{"line_number":11,"context_line":" will be a wrong number."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The value of \u0027image_ref\u0027 for this type of instances, is \u0027\u0027, not None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUX%2F%2Fb0E%3D","line":10,"updated":"2014-02-13 08:36:55.000000000","message":"can you please fix this. the indentation is a bit wrong","commit_id":"4195576fbd3de09d4af69ccaa201fd26bb9792be"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"9814fe83e4fc0a29ec6c6ac235ba666e6ec8c933","unresolved":false,"context_lines":[{"line_number":7,"context_line":"DescribeInstances in ec2 shows wrong image-message"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If one instance boots from a volume,"},{"line_number":10,"context_line":" the value of \u0027image_id\u0027 by \u0027DescribeInstances\u0027 in ec2,"},{"line_number":11,"context_line":" will be a wrong number."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The value of \u0027image_ref\u0027 for this type of instances, is \u0027\u0027, not None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUX%2F%2FTqA%3D","line":10,"in_reply_to":"AAAAUX%2F%2Fb0E%3D","updated":"2014-02-14 03:15:50.000000000","message":"Done","commit_id":"4195576fbd3de09d4af69ccaa201fd26bb9792be"}],"nova/api/ec2/cloud.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"86bb402593814048ff27621d64c21e74275f3761","unresolved":false,"context_lines":[{"line_number":1206,"context_line":"            fixed_vm_uuid \u003d floating_ip[\u0027instance\u0027][\u0027uuid\u0027]"},{"line_number":1207,"context_line":"            if fixed_vm_uuid is not None:"},{"line_number":1208,"context_line":"                ec2_id \u003d ec2utils.id_to_ec2_inst_id(fixed_vm_uuid)"},{"line_number":1209,"context_line":"#             fixed_id \u003d floating_ip[\u0027fixed_ip_id\u0027]"},{"line_number":1210,"context_line":"#             fixed \u003d self.network_api.get_fixed_ip(context, fixed_id)"},{"line_number":1211,"context_line":"#             if fixed[\u0027instance_uuid\u0027] is not None:"},{"line_number":1212,"context_line":"#                 ec2_id \u003d ec2utils.id_to_ec2_inst_id(fixed[\u0027instance_uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2Fbz0%3D","line":1209,"updated":"2014-02-13 08:36:55.000000000","message":"these comments should be deleted","commit_id":"4195576fbd3de09d4af69ccaa201fd26bb9792be"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"9814fe83e4fc0a29ec6c6ac235ba666e6ec8c933","unresolved":false,"context_lines":[{"line_number":1206,"context_line":"            fixed_vm_uuid \u003d floating_ip[\u0027instance\u0027][\u0027uuid\u0027]"},{"line_number":1207,"context_line":"            if fixed_vm_uuid is not None:"},{"line_number":1208,"context_line":"                ec2_id \u003d ec2utils.id_to_ec2_inst_id(fixed_vm_uuid)"},{"line_number":1209,"context_line":"#             fixed_id \u003d floating_ip[\u0027fixed_ip_id\u0027]"},{"line_number":1210,"context_line":"#             fixed \u003d self.network_api.get_fixed_ip(context, fixed_id)"},{"line_number":1211,"context_line":"#             if fixed[\u0027instance_uuid\u0027] is not None:"},{"line_number":1212,"context_line":"#                 ec2_id \u003d ec2utils.id_to_ec2_inst_id(fixed[\u0027instance_uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FTqE%3D","line":1209,"in_reply_to":"AAAAUX%2F%2Fbz0%3D","updated":"2014-02-14 03:15:50.000000000","message":"Done","commit_id":"4195576fbd3de09d4af69ccaa201fd26bb9792be"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f1c835f1d21b64871f086df171c3f1e8fc8f57d8","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        if floating_ip[\u0027fixed_ip_id\u0027]:"},{"line_number":1206,"context_line":"            fixed_vm_uuid \u003d floating_ip[\u0027instance\u0027][\u0027uuid\u0027]"},{"line_number":1207,"context_line":"            if fixed_vm_uuid is not None:"},{"line_number":1208,"context_line":"                ec2_id \u003d ec2utils.id_to_ec2_inst_id(fixed_vm_uuid)"},{"line_number":1209,"context_line":"        address \u003d {\u0027public_ip\u0027: floating_ip[\u0027address\u0027],"},{"line_number":1210,"context_line":"                   \u0027instance_id\u0027: ec2_id}"},{"line_number":1211,"context_line":"        if context.is_admin:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FcW4%3D","line":1208,"updated":"2014-04-21 18:30:31.000000000","message":"I\u0027m having trouble seeing how this change relates to a boot from volume instance, as described in the commit message","commit_id":"d6a9ce49732dabe6c9f5531168fceec62feaf552"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"c62adffa0755240126976f054fe2fb37145e8a81","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"        if floating_ip[\u0027fixed_ip_id\u0027]:"},{"line_number":1206,"context_line":"            fixed_vm_uuid \u003d floating_ip[\u0027instance\u0027][\u0027uuid\u0027]"},{"line_number":1207,"context_line":"            if fixed_vm_uuid is not None:"},{"line_number":1208,"context_line":"                ec2_id \u003d ec2utils.id_to_ec2_inst_id(fixed_vm_uuid)"},{"line_number":1209,"context_line":"        address \u003d {\u0027public_ip\u0027: floating_ip[\u0027address\u0027],"},{"line_number":1210,"context_line":"                   \u0027instance_id\u0027: ec2_id}"},{"line_number":1211,"context_line":"        if context.is_admin:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FaMs%3D","line":1208,"in_reply_to":"AAAAXH%2F%2FcW4%3D","updated":"2014-04-22 01:37:40.000000000","message":"Oops, this\u0027s an another bug registered on https://review.openstack.org/#/c/72628/.\n\nI mixed them together.. Sorry for that..","commit_id":"d6a9ce49732dabe6c9f5531168fceec62feaf552"}],"nova/api/ec2/ec2utils.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f1c835f1d21b64871f086df171c3f1e8fc8f57d8","unresolved":false,"context_lines":[{"line_number":107,"context_line":"@memoize"},{"line_number":108,"context_line":"def glance_id_to_id(context, glance_id):"},{"line_number":109,"context_line":"    \"\"\"Convert a glance id to an internal (db) id.\"\"\""},{"line_number":110,"context_line":"    if glance_id is None or glance_id \u003d\u003d \u0027\u0027:"},{"line_number":111,"context_line":"        return"},{"line_number":112,"context_line":"    try:"},{"line_number":113,"context_line":"        return db.s3_image_get_by_uuid(context, glance_id)[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FcXo%3D","line":110,"updated":"2014-04-21 18:30:31.000000000","message":"could also change this to:\n\n    if not glance_id:","commit_id":"d6a9ce49732dabe6c9f5531168fceec62feaf552"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"c62adffa0755240126976f054fe2fb37145e8a81","unresolved":false,"context_lines":[{"line_number":107,"context_line":"@memoize"},{"line_number":108,"context_line":"def glance_id_to_id(context, glance_id):"},{"line_number":109,"context_line":"    \"\"\"Convert a glance id to an internal (db) id.\"\"\""},{"line_number":110,"context_line":"    if glance_id is None or glance_id \u003d\u003d \u0027\u0027:"},{"line_number":111,"context_line":"        return"},{"line_number":112,"context_line":"    try:"},{"line_number":113,"context_line":"        return db.s3_image_get_by_uuid(context, glance_id)[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FaMo%3D","line":110,"in_reply_to":"AAAAXH%2F%2FcXo%3D","updated":"2014-04-22 01:37:40.000000000","message":"Done","commit_id":"d6a9ce49732dabe6c9f5531168fceec62feaf552"}],"nova/tests/api/ec2/test_cloud.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"2f573df912e2a48790518a1e9bf1a948eb6a98cc","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"        sys_meta \u003d flavors.save_flavor_info("},{"line_number":1299,"context_line":"            {}, flavors.get_flavor(1))"},{"line_number":1300,"context_line":"        args \u003d {\u0027reservation_id\u0027: \u0027a\u0027,"},{"line_number":1301,"context_line":"                 \u0027image_ref\u0027: image_uuid,"},{"line_number":1302,"context_line":"                 \u0027instance_type_id\u0027: 1,"},{"line_number":1303,"context_line":"                 \u0027host\u0027: \u0027host1\u0027,"},{"line_number":1304,"context_line":"                 \u0027vm_state\u0027: \u0027active\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FbrY%3D","line":1301,"updated":"2014-02-13 08:53:03.000000000","message":"nit: Keep align","commit_id":"4195576fbd3de09d4af69ccaa201fd26bb9792be"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"9814fe83e4fc0a29ec6c6ac235ba666e6ec8c933","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"        sys_meta \u003d flavors.save_flavor_info("},{"line_number":1299,"context_line":"            {}, flavors.get_flavor(1))"},{"line_number":1300,"context_line":"        args \u003d {\u0027reservation_id\u0027: \u0027a\u0027,"},{"line_number":1301,"context_line":"                 \u0027image_ref\u0027: image_uuid,"},{"line_number":1302,"context_line":"                 \u0027instance_type_id\u0027: 1,"},{"line_number":1303,"context_line":"                 \u0027host\u0027: \u0027host1\u0027,"},{"line_number":1304,"context_line":"                 \u0027vm_state\u0027: \u0027active\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2FTqI%3D","line":1301,"in_reply_to":"AAAAUX%2F%2FbrY%3D","updated":"2014-02-14 03:15:50.000000000","message":"Done","commit_id":"4195576fbd3de09d4af69ccaa201fd26bb9792be"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e2ba0d476c850bbe795d8bb4eefa6e953740201e","unresolved":false,"context_lines":[{"line_number":1350,"context_line":"                \u0027host\u0027: \u0027host1\u0027,"},{"line_number":1351,"context_line":"                \u0027vm_state\u0027: \u0027active\u0027,"},{"line_number":1352,"context_line":"                \u0027system_metadata\u0027: sys_meta}"},{"line_number":1353,"context_line":"        inst \u003d db.instance_create(self.context, args)"},{"line_number":1354,"context_line":"        result \u003d self.cloud.describe_instances(self.context)"},{"line_number":1355,"context_line":"        result \u003d result[\u0027reservationSet\u0027][0]"},{"line_number":1356,"context_line":"        instance \u003d result[\u0027instancesSet\u0027][0]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FSOA%3D","line":1353,"updated":"2014-04-22 18:44:31.000000000","message":"Instead of adding another db call here, it would be better to use nova.objects.instance.Instance, instead.\n\nAlso, the test case says \"boot from volume\", but there\u0027s nothing in here that makes this a boot from volume instance.  How do we know the state of the instance matches the expected state of one booted from a volume?","commit_id":"703f87fc454dedda35af96aec7512304dc565763"},{"author":{"_account_id":8021,"name":"wingwj","email":"wingwj@gmail.com","username":"wingwj"},"change_message_id":"1d9223d18822665192879783584f222d9fee314d","unresolved":false,"context_lines":[{"line_number":1350,"context_line":"                \u0027host\u0027: \u0027host1\u0027,"},{"line_number":1351,"context_line":"                \u0027vm_state\u0027: \u0027active\u0027,"},{"line_number":1352,"context_line":"                \u0027system_metadata\u0027: sys_meta}"},{"line_number":1353,"context_line":"        inst \u003d db.instance_create(self.context, args)"},{"line_number":1354,"context_line":"        result \u003d self.cloud.describe_instances(self.context)"},{"line_number":1355,"context_line":"        result \u003d result[\u0027reservationSet\u0027][0]"},{"line_number":1356,"context_line":"        instance \u003d result[\u0027instancesSet\u0027][0]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAXH%2F%2FPgw%3D","line":1353,"in_reply_to":"AAAAXH%2F%2FSOA%3D","updated":"2014-04-23 04:14:14.000000000","message":"The difference in db between a boot from volume instance and a normal image instance, is the \u0027image_ref\u0027 field only. So I set it to \u0027\u0027.","commit_id":"703f87fc454dedda35af96aec7512304dc565763"}]}