)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a4861eaf47a85a8bf55df8e1f4a07ce5e2eb29cf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"docs: Use proper headers in nova-manage man page"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is step one in improving the usability of these docs. The current"},{"line_number":10,"context_line":"style makes it impossible to link to individual commands. There is a"},{"line_number":11,"context_line":"better way. Use headers along with code blocks to show the actual"},{"line_number":12,"context_line":"command. This was mostly generated from a find-replace along with some"},{"line_number":13,"context_line":"follow-up manual fixes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_807f6ca9","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":56},"updated":"2020-05-20 00:53:04.000000000","message":"I\u0027m curious what does a link to an individual command look like? That is, what benefit do we get to use after making this change. I\u0027m guessing it will be something similar to how we can do :oslo.config:option`\u003coption\u003e` but at least for me it would help to know what will it look like to use this.","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cee0b1b83221449e36ca33c464fe9a3b401eeb70","unresolved":false,"context_lines":[{"line_number":7,"context_line":"docs: Use proper headers in nova-manage man page"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is step one in improving the usability of these docs. The current"},{"line_number":10,"context_line":"style makes it impossible to link to individual commands. There is a"},{"line_number":11,"context_line":"better way. Use headers along with code blocks to show the actual"},{"line_number":12,"context_line":"command. This was mostly generated from a find-replace along with some"},{"line_number":13,"context_line":"follow-up manual fixes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_d758fafa","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":56},"in_reply_to":"ff570b3c_807f6ca9","updated":"2020-05-20 17:23:38.000000000","message":"Ah, I meant you could get a URL link, like this:\n\nhttp://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_62b/726191/2/check/openstack-tox-docs/62b7b02/docs/cli/nova-manage.html#cell-v2-simple-cell-setup\n\nYou could also link to an individual command but we\u0027d have to add anchor points (\u0027.. some_test-here:\u0027) before the headers","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cd4f6ff6457cfe1ff448c39d937686a1d446630a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"docs: Use proper headers in nova-manage man page"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is step one in improving the usability of these docs. The current"},{"line_number":10,"context_line":"style makes it impossible to link to individual commands. There is a"},{"line_number":11,"context_line":"better way. Use headers along with code blocks to show the actual"},{"line_number":12,"context_line":"command. This was mostly generated from a find-replace along with some"},{"line_number":13,"context_line":"follow-up manual fixes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_28b11348","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":56},"in_reply_to":"ff570b3c_d758fafa","updated":"2020-05-20 19:18:23.000000000","message":"Ack, thanks.","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"}],"doc/source/cli/nova-manage.rst":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cd4f6ff6457cfe1ff448c39d937686a1d446630a","unresolved":false,"context_lines":[{"line_number":14,"context_line":":Manual group: cloud computing"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Synopsis"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"::"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_88c3ffec","line":17,"updated":"2020-05-20 19:18:23.000000000","message":"Looking at this from a man page perspective (thanks for the instructions on how to look at it), this isn\u0027t really supposed to be nested in. I looked at another man page (example: man git) and the Synopsis and Description and Options are all H1(?) whereas ours starts nesting and making the fonts smaller than a standard man page. I don\u0027t know if that\u0027s something we can or should change though.","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c79c30cd41e0544709ed6194ba16784324301388","unresolved":false,"context_lines":[{"line_number":14,"context_line":":Manual group: cloud computing"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Synopsis"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"::"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_e5a456a8","line":17,"in_reply_to":"ff570b3c_88c3ffec","updated":"2020-05-21 11:14:57.000000000","message":"Took me a while to figure out what was going on here. Turns out the subtitle above wasn\u0027t being rendered as such by the Sphinx manpage builder. I guess this was intended for the docutils manpage writer. This affects all man pages so I\u0027ve added a precursor patch to remove this crud from all pages.","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9fdffb4e207dd86965868bc5509a5dac42f0523c","unresolved":false,"context_lines":[{"line_number":14,"context_line":":Manual group: cloud computing"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Synopsis"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"::"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_fdc34337","line":17,"in_reply_to":"ff570b3c_e5a456a8","updated":"2020-05-21 21:30:19.000000000","message":"Ah, nice find, thanks.","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a4861eaf47a85a8bf55df8e1f4a07ce5e2eb29cf","unresolved":false,"context_lines":[{"line_number":168,"context_line":"----------------------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"db version"},{"line_number":171,"context_line":"~~~~~~~~~~"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":".. program:: nova-manage db version"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_a067104d","line":171,"updated":"2020-05-20 00:53:04.000000000","message":"I don\u0027t know what to compare to, but this header is the same size or smaller than the description text in the rendering and looks a bit weird to me. The header for each command sort of blends in with the other description text and doesn\u0027t stand out. Is that a pattern already used in other openstack docs or?","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9fdffb4e207dd86965868bc5509a5dac42f0523c","unresolved":false,"context_lines":[{"line_number":168,"context_line":"----------------------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"db version"},{"line_number":171,"context_line":"~~~~~~~~~~"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":".. program:: nova-manage db version"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_5dea2fac","line":171,"in_reply_to":"ff570b3c_05bfcaa9","updated":"2020-05-21 21:30:19.000000000","message":"Well ... sorry I wasn\u0027t totally clear before, but I was thinking if we fixed the indenting/subtitle stuff, we could keep the top-level \"Commands\" along with the section titles and it would all render nicely. I had been thinking of un-indenting one level was an alternative way to fixing the weird rendering problem.\n\n(Later) Well, I\u0027ve just rendered the new man pages and I have to say it looks good there and also looks good in the docs preview:\n\nhttps://6eed35a50c35f284b4d2-bf433abff5f8b85f7f80257b72ac6f67.ssl.cf2.rackcdn.com/726191/3/check/openstack-tox-docs/3b107ef/docs/cli/nova-manage.html","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c79c30cd41e0544709ed6194ba16784324301388","unresolved":false,"context_lines":[{"line_number":168,"context_line":"----------------------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"db version"},{"line_number":171,"context_line":"~~~~~~~~~~"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":".. program:: nova-manage db version"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_05bfcaa9","line":171,"in_reply_to":"ff570b3c_282ab3d9","updated":"2020-05-21 11:14:57.000000000","message":"Dropping the top-level \"Commands\" title works for me. In fact, I\u0027d forgotten I had a commit that did something similar for man pages, albeit for the section title (e.g. \"Nova Database Commands\") [1]. I can abandon that now.\n\n[1] https://review.opendev.org/#/c/726194/2","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cd4f6ff6457cfe1ff448c39d937686a1d446630a","unresolved":false,"context_lines":[{"line_number":168,"context_line":"----------------------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"db version"},{"line_number":171,"context_line":"~~~~~~~~~~"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":".. program:: nova-manage db version"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_282ab3d9","line":171,"in_reply_to":"ff570b3c_576cea9a","updated":"2020-05-20 19:18:23.000000000","message":"Hm... I\u0027m actually thinking I wonder if it would be better to remove the \u0027Commands\u0027 section title instead and keep the \u0027Nova Database Commands\u0027 section (and similar sections). In practice, I have linked a command section to someone on occasion \"here are the database commands\", but looking at it as a man page, \u0027Commands\u0027 seems kind of redundant.\n\nAm I understanding the situation right? We can either look at changing the font size for a H5 element or we remove one level of nesting?\n\nI\u0027m on the fence about what to do ... just feel like I want to keep the command category sections for being able to say to someone \"here\u0027s the cells commands\". I guess one could argue you could just link to the first such command instead. But I think the grouping is nice for a doc regardless, instead of just dumping all the commands at the same level in the same section.","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cee0b1b83221449e36ca33c464fe9a3b401eeb70","unresolved":false,"context_lines":[{"line_number":168,"context_line":"----------------------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"db version"},{"line_number":171,"context_line":"~~~~~~~~~~"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":".. program:: nova-manage db version"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_576cea9a","line":171,"in_reply_to":"ff570b3c_a067104d","updated":"2020-05-20 17:23:38.000000000","message":"Interestingly, that\u0027s the default font size for a H5 element in Bootstrap 3.x, which openstackdocstheme is based on. I can look at changing that or I could drop the \u0027Nova Database Commands\u0027 \"section\" title above (and similar headers below). It doesn\u0027t render than nicely in a man page either [1] so that might be better all round. Up to you though\n\n[1] Test like so:\n\n  source .tox/shared/bin/activate \u0026\u0026 \\\n    sphinx-build -b man doc/source doc/build/man \u0026\u0026 \\\n    man doc/build/man/nova-manage.1","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a4861eaf47a85a8bf55df8e1f4a07ce5e2eb29cf","unresolved":false,"context_lines":[{"line_number":194,"context_line":"the cell0 database). If ``--local_cell`` is specified, then only the main"},{"line_number":195,"context_line":"database in the current cell is upgraded. The local database connection is"},{"line_number":196,"context_line":"determined by :oslo.config:option:`database.connection` in the"},{"line_number":197,"context_line":"configuration file, passed to nova-manage using the ``--config-file``"},{"line_number":198,"context_line":"option(s). This command should be run after ``nova-manage api_db sync``."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Returns exit code 0 if the database schema was synced successfully, or 1 if"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_00d07cc8","line":197,"range":{"start_line":197,"start_character":52,"end_line":197,"end_character":69},"updated":"2020-05-20 00:53:04.000000000","message":"Should we :option:`--config-file` here instead?","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cee0b1b83221449e36ca33c464fe9a3b401eeb70","unresolved":false,"context_lines":[{"line_number":194,"context_line":"the cell0 database). If ``--local_cell`` is specified, then only the main"},{"line_number":195,"context_line":"database in the current cell is upgraded. The local database connection is"},{"line_number":196,"context_line":"determined by :oslo.config:option:`database.connection` in the"},{"line_number":197,"context_line":"configuration file, passed to nova-manage using the ``--config-file``"},{"line_number":198,"context_line":"option(s). This command should be run after ``nova-manage api_db sync``."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Returns exit code 0 if the database schema was synced successfully, or 1 if"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_973042a1","line":197,"range":{"start_line":197,"start_character":52,"end_line":197,"end_character":69},"in_reply_to":"ff570b3c_00d07cc8","updated":"2020-05-20 17:23:38.000000000","message":"I can\u0027t do that yet since I don\u0027t have a corresponding \u0027.. option::\u0027 directive for this yet. I add that in a later patch though so could use that once this is done, yes","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a4861eaf47a85a8bf55df8e1f4a07ce5e2eb29cf","unresolved":false,"context_lines":[{"line_number":195,"context_line":"database in the current cell is upgraded. The local database connection is"},{"line_number":196,"context_line":"determined by :oslo.config:option:`database.connection` in the"},{"line_number":197,"context_line":"configuration file, passed to nova-manage using the ``--config-file``"},{"line_number":198,"context_line":"option(s). This command should be run after ``nova-manage api_db sync``."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Returns exit code 0 if the database schema was synced successfully, or 1 if"},{"line_number":201,"context_line":"cell0 cannot be accessed."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_e0d2a8d0","line":198,"range":{"start_line":198,"start_character":44,"end_line":198,"end_character":71},"updated":"2020-05-20 00:53:04.000000000","message":"Should we link to `api_db sync` here instead? (I don\u0027t know how to do that.)\n\n(Later) I\u0027m realizing this patch is likely focusing on making a minimal consistent change, which is fine and makes sense.","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cee0b1b83221449e36ca33c464fe9a3b401eeb70","unresolved":false,"context_lines":[{"line_number":195,"context_line":"database in the current cell is upgraded. The local database connection is"},{"line_number":196,"context_line":"determined by :oslo.config:option:`database.connection` in the"},{"line_number":197,"context_line":"configuration file, passed to nova-manage using the ``--config-file``"},{"line_number":198,"context_line":"option(s). This command should be run after ``nova-manage api_db sync``."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Returns exit code 0 if the database schema was synced successfully, or 1 if"},{"line_number":201,"context_line":"cell0 cannot be accessed."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ff570b3c_571a2a16","line":198,"range":{"start_line":198,"start_character":44,"end_line":198,"end_character":71},"in_reply_to":"ff570b3c_e0d2a8d0","updated":"2020-05-20 17:23:38.000000000","message":"As you say, I\u0027m trying to keep this as small as possible","commit_id":"80567ed0b8e1f8acf8f7f358f0a60229f49f131b"}]}