)]}'
{"doc/ext/extra_specs.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7f3ff92fa05fd6641d1193a66693432ee5488289","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    if validator.deprecated:"},{"line_number":134,"context_line":"        yield _indent(\u0027.. warning::\u0027)"},{"line_number":135,"context_line":"        yield _indent("},{"line_number":136,"context_line":"            \u0027This extra spec has been deprecated and should not be used.\u0027, 2"},{"line_number":137,"context_line":"        )"},{"line_number":138,"context_line":"        yield \u0027\u0027"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e4034ab7","line":136,"range":{"start_line":136,"start_character":75,"end_line":136,"end_character":76},"updated":"2020-05-14 06:47:40.000000000","message":"nit the should be count\u003d2\n\nusing keyword argments as positionals is a code smell and actually dangouous or at least fragile as the expectaion is the order that keyword arguments are listed in a function defintion should not matter since but when they are treated as postianl like this it will break.\n\nthat said looking at the rendering  where this this used in the follow up it looks good to me.\n\nhttps://33563ef9b3f744137075-b42c6b31cdcfa4f4b221838bf717961f.ssl.cf2.rackcdn.com/722187/9/check/openstack-tox-docs/53b6f03/docs/configuration/extra-specs.html#others-uncategorized","commit_id":"8a2ed8a78ef71e36333d3a1ec4fa30a2c2d21651"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"99bd8836aab0e1e468fe08de76b3c875c01de9ac","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    if validator.deprecated:"},{"line_number":134,"context_line":"        yield _indent(\u0027.. warning::\u0027)"},{"line_number":135,"context_line":"        yield _indent("},{"line_number":136,"context_line":"            \u0027This extra spec has been deprecated and should not be used.\u0027, 2"},{"line_number":137,"context_line":"        )"},{"line_number":138,"context_line":"        yield \u0027\u0027"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_334d869a","line":136,"range":{"start_line":136,"start_character":75,"end_line":136,"end_character":76},"in_reply_to":"ff570b3c_38bf2562","updated":"2020-05-14 11:11:20.000000000","message":"i think should is still correct but this is minor enought that its fine for now.\n\ni kind of wish we had a hacking check that enforced that we only use keyword arguments via keywords but since we dont ill drop my -1","commit_id":"8a2ed8a78ef71e36333d3a1ec4fa30a2c2d21651"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e49156dff9a254d822580c713a18990569e60340","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    if validator.deprecated:"},{"line_number":134,"context_line":"        yield _indent(\u0027.. warning::\u0027)"},{"line_number":135,"context_line":"        yield _indent("},{"line_number":136,"context_line":"            \u0027This extra spec has been deprecated and should not be used.\u0027, 2"},{"line_number":137,"context_line":"        )"},{"line_number":138,"context_line":"        yield \u0027\u0027"},{"line_number":139,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_38bf2562","line":136,"range":{"start_line":136,"start_character":75,"end_line":136,"end_character":76},"in_reply_to":"ff570b3c_e4034ab7","updated":"2020-05-14 10:17:35.000000000","message":"*could be\n\nPython supports keyword-only arguments [1] and positional-only arguments [2]. This is neither, so calling things this was is perfectly fine. Now, if there were multiple arguments here, I\u0027d be more inclined to agree with you, simply for readability if noting else. As-is though, this is perfectly fine :)\n\n[1] https://www.python.org/dev/peps/pep-3102/\n[2] https://www.python.org/dev/peps/pep-0570/","commit_id":"8a2ed8a78ef71e36333d3a1ec4fa30a2c2d21651"}]}