)]}'
{"nova/virt/vmwareapi/volumeops.py":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"bcd3adfd4831b76cd47c508e4e1a2d56c0338e60","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                             \u0027get_dynamic_property\u0027,"},{"line_number":103,"context_line":"                                             vm_ref, \u0027VirtualMachine\u0027,"},{"line_number":104,"context_line":"                                             prop)"},{"line_number":105,"context_line":"        if opt_val:"},{"line_number":106,"context_line":"            return opt_val.value"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def detach_disk_from_vm(self, vm_ref, instance, device,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2F7dE%3D","line":105,"updated":"2014-03-03 14:01:23.000000000","message":"Not a nit:\nif opt_val is not None:\n\nNit:\nIs it good practise to rely on the default return value?","commit_id":"9cd915cba64a6919f4affaa22df5cf74c332315c"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"f69622a11b6e14d70e33a498fb545261110665e6","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                                             \u0027get_dynamic_property\u0027,"},{"line_number":103,"context_line":"                                             vm_ref, \u0027VirtualMachine\u0027,"},{"line_number":104,"context_line":"                                             prop)"},{"line_number":105,"context_line":"        if opt_val:"},{"line_number":106,"context_line":"            return opt_val.value"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def detach_disk_from_vm(self, vm_ref, instance, device,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2Fwng%3D","line":105,"in_reply_to":"AAAAVn%2F%2F7dE%3D","updated":"2014-03-04 08:46:18.000000000","message":"1) Done.\n\n2) I think it is more pythonic to omit \"return None\"","commit_id":"9cd915cba64a6919f4affaa22df5cf74c332315c"}]}