)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"59fcded64bb358373906680757a697bfc96e2d55","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This has introduced a new version of pycodestyle, which has improved its"},{"line_number":10,"context_line":"parser to catch new corner cases and introduced some new tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I13774729fef82b7c6c07ceb2afa6e304a506da90"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_8c2e2ca3","line":11,"updated":"2020-05-12 10:23:35.000000000","message":"please tell us which PEP8 errors are now provided by default with this new version","commit_id":"306808951810406edb58a69cfe7d321977640f24"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"874d3193466da6fb52fbed7dcc44a4773dda4248","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if \u0027server\u0027 not in robj.obj:"},{"line_number":102,"context_line":"            return robj"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        link \u003d [x for x in robj.obj[\u0027server\u0027][\u0027links\u0027] if x[\u0027rel\u0027] \u003d\u003d \u0027self\u0027]"},{"line_number":105,"context_line":"        if link:"},{"line_number":106,"context_line":"            robj[\u0027Location\u0027] \u003d link[0][\u0027href\u0027]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_6c4598b3","line":104,"range":{"start_line":104,"start_character":57,"end_line":104,"end_character":60},"updated":"2020-05-12 10:16:56.000000000","message":"why are you changing this from l to x\n\nthis seams unrelated or at least deserves a comment.","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"59fcded64bb358373906680757a697bfc96e2d55","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if \u0027server\u0027 not in robj.obj:"},{"line_number":102,"context_line":"            return robj"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        link \u003d [x for x in robj.obj[\u0027server\u0027][\u0027links\u0027] if x[\u0027rel\u0027] \u003d\u003d \u0027self\u0027]"},{"line_number":105,"context_line":"        if link:"},{"line_number":106,"context_line":"            robj[\u0027Location\u0027] \u003d link[0][\u0027href\u0027]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_ec188882","line":104,"range":{"start_line":104,"start_character":57,"end_line":104,"end_character":60},"in_reply_to":"ff570b3c_6c4598b3","updated":"2020-05-12 10:23:35.000000000","message":"at least I need to understand which PEP8 error needs to modify this.","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ffb6e612c900dfa7c17569eafc8c273923f19207","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if \u0027server\u0027 not in robj.obj:"},{"line_number":102,"context_line":"            return robj"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        link \u003d [x for x in robj.obj[\u0027server\u0027][\u0027links\u0027] if x[\u0027rel\u0027] \u003d\u003d \u0027self\u0027]"},{"line_number":105,"context_line":"        if link:"},{"line_number":106,"context_line":"            robj[\u0027Location\u0027] \u003d link[0][\u0027href\u0027]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a703490d","line":104,"range":{"start_line":104,"start_character":57,"end_line":104,"end_character":60},"in_reply_to":"ff570b3c_6c4598b3","updated":"2020-05-12 10:28:11.000000000","message":"https://www.flake8rules.com/rules/E741.html","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"708f472e21234c1b56f71eb9a939b029369f7cc5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if \u0027server\u0027 not in robj.obj:"},{"line_number":102,"context_line":"            return robj"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        link \u003d [x for x in robj.obj[\u0027server\u0027][\u0027links\u0027] if x[\u0027rel\u0027] \u003d\u003d \u0027self\u0027]"},{"line_number":105,"context_line":"        if link:"},{"line_number":106,"context_line":"            robj[\u0027Location\u0027] \u003d link[0][\u0027href\u0027]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e7bc216b","line":104,"range":{"start_line":104,"start_character":57,"end_line":104,"end_character":60},"in_reply_to":"ff570b3c_87b8c52a","updated":"2020-05-12 10:57:32.000000000","message":"That doesn\u0027t fit on one line. I also don\u0027t think there\u0027s anything wrong with using single character variables inside a list comprehension, given the extremely narrow scope","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"139d3ea656bc8be461d955a9a4570cba1e0c600c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if \u0027server\u0027 not in robj.obj:"},{"line_number":102,"context_line":"            return robj"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        link \u003d [x for x in robj.obj[\u0027server\u0027][\u0027links\u0027] if x[\u0027rel\u0027] \u003d\u003d \u0027self\u0027]"},{"line_number":105,"context_line":"        if link:"},{"line_number":106,"context_line":"            robj[\u0027Location\u0027] \u003d link[0][\u0027href\u0027]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_87b8c52a","line":104,"range":{"start_line":104,"start_character":57,"end_line":104,"end_character":60},"in_reply_to":"ff570b3c_a703490d","updated":"2020-05-12 10:45:56.000000000","message":"im not sure i agree with this if we are going to arbitraly ignore think liek i then we should ban all 1 leter variables.\n\nchange \n\n[x for x in robj.obj[\u0027server\u0027][\u0027links\u0027] if x[\u0027rel\u0027] \u003d\u003d \u0027self\u0027]\n\nto\n\n[link for link in robj.obj[\u0027server\u0027][\u0027links\u0027] if link[\u0027rel\u0027] \u003d\u003d \u0027self\u0027]\n\nusing a proper name for the variable.","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffa8494c0c8592b205db7ae915d3fb8b83794d22","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if \u0027server\u0027 not in robj.obj:"},{"line_number":102,"context_line":"            return robj"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        link \u003d [x for x in robj.obj[\u0027server\u0027][\u0027links\u0027] if x[\u0027rel\u0027] \u003d\u003d \u0027self\u0027]"},{"line_number":105,"context_line":"        if link:"},{"line_number":106,"context_line":"            robj[\u0027Location\u0027] \u003d link[0][\u0027href\u0027]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_22ae072e","line":104,"range":{"start_line":104,"start_character":57,"end_line":104,"end_character":60},"in_reply_to":"ff570b3c_e7bc216b","updated":"2020-05-12 11:57:19.000000000","message":"sure but for the same reason l was not a bad choice and \nE741 which si not actully part of pep8 is not a good style checking rule that we should be following in nova.\n\nanyway im not gong to make you fight this battle to the death\n\ni just dont think this improved readability in anyway","commit_id":"306808951810406edb58a69cfe7d321977640f24"}],"nova/db/sqlalchemy/migrate_repo/versions/330_enforce_mitaka_online_migrations.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"874d3193466da6fb52fbed7dcc44a4773dda4248","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # if the definition is altered."},{"line_number":46,"context_line":"    count \u003d select([func.count()]).select_from(pci_devices).where(and_("},{"line_number":47,"context_line":"        pci_devices.c.deleted \u003d\u003d 0,"},{"line_number":48,"context_line":"        pci_devices.c.parent_addr \u003d\u003d None,  # noqa"},{"line_number":49,"context_line":"        pci_devices.c.dev_type \u003d\u003d \u0027type-VF\u0027)).execute().scalar()"},{"line_number":50,"context_line":"    if count \u003e 0:"},{"line_number":51,"context_line":"        msg \u003d WARNING_MSG % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_6c1e38bb","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":50},"updated":"2020-05-12 10:16:56.000000000","message":"what warning is this preventing.\nand why is it here and not at the end of the function","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"59fcded64bb358373906680757a697bfc96e2d55","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # if the definition is altered."},{"line_number":46,"context_line":"    count \u003d select([func.count()]).select_from(pci_devices).where(and_("},{"line_number":47,"context_line":"        pci_devices.c.deleted \u003d\u003d 0,"},{"line_number":48,"context_line":"        pci_devices.c.parent_addr \u003d\u003d None,  # noqa"},{"line_number":49,"context_line":"        pci_devices.c.dev_type \u003d\u003d \u0027type-VF\u0027)).execute().scalar()"},{"line_number":50,"context_line":"    if count \u003e 0:"},{"line_number":51,"context_line":"        msg \u003d WARNING_MSG % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_2c0a8025","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":50},"in_reply_to":"ff570b3c_6c1e38bb","updated":"2020-05-12 10:23:35.000000000","message":"+1","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ffb6e612c900dfa7c17569eafc8c273923f19207","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # if the definition is altered."},{"line_number":46,"context_line":"    count \u003d select([func.count()]).select_from(pci_devices).where(and_("},{"line_number":47,"context_line":"        pci_devices.c.deleted \u003d\u003d 0,"},{"line_number":48,"context_line":"        pci_devices.c.parent_addr \u003d\u003d None,  # noqa"},{"line_number":49,"context_line":"        pci_devices.c.dev_type \u003d\u003d \u0027type-VF\u0027)).execute().scalar()"},{"line_number":50,"context_line":"    if count \u003e 0:"},{"line_number":51,"context_line":"        msg \u003d WARNING_MSG % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_871c456b","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":50},"in_reply_to":"ff570b3c_6c1e38bb","updated":"2020-05-12 10:28:11.000000000","message":"https://www.flake8rules.com/rules/E711.html\n\nFor some reason, this now has to be on the affected line, rather than at the end of it","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"139d3ea656bc8be461d955a9a4570cba1e0c600c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # if the definition is altered."},{"line_number":46,"context_line":"    count \u003d select([func.count()]).select_from(pci_devices).where(and_("},{"line_number":47,"context_line":"        pci_devices.c.deleted \u003d\u003d 0,"},{"line_number":48,"context_line":"        pci_devices.c.parent_addr \u003d\u003d None,  # noqa"},{"line_number":49,"context_line":"        pci_devices.c.dev_type \u003d\u003d \u0027type-VF\u0027)).execute().scalar()"},{"line_number":50,"context_line":"    if count \u003e 0:"},{"line_number":51,"context_line":"        msg \u003d WARNING_MSG % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_87e60544","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":50},"in_reply_to":"ff570b3c_871c456b","updated":"2020-05-12 10:45:56.000000000","message":"so \n pci_devices.c.parent_addr \u003d\u003d None,  # noqa\n\nbecomes\n pci_devices.c.parent_addr is None,\n\nunless sqlalchem is doing something weird withthe arguments such as reflecting on them in which case you should add a comment to that effect to explay why the # noqa is there.","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"708f472e21234c1b56f71eb9a939b029369f7cc5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # if the definition is altered."},{"line_number":46,"context_line":"    count \u003d select([func.count()]).select_from(pci_devices).where(and_("},{"line_number":47,"context_line":"        pci_devices.c.deleted \u003d\u003d 0,"},{"line_number":48,"context_line":"        pci_devices.c.parent_addr \u003d\u003d None,  # noqa"},{"line_number":49,"context_line":"        pci_devices.c.dev_type \u003d\u003d \u0027type-VF\u0027)).execute().scalar()"},{"line_number":50,"context_line":"    if count \u003e 0:"},{"line_number":51,"context_line":"        msg \u003d WARNING_MSG % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a7c229e8","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":50},"in_reply_to":"ff570b3c_87e60544","updated":"2020-05-12 10:57:32.000000000","message":"This is sqlalchemy stuff so I genuinely don\u0027t know if we can do this. It\u0027s also a functional change so I\u0027d rather not do it.","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffa8494c0c8592b205db7ae915d3fb8b83794d22","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # if the definition is altered."},{"line_number":46,"context_line":"    count \u003d select([func.count()]).select_from(pci_devices).where(and_("},{"line_number":47,"context_line":"        pci_devices.c.deleted \u003d\u003d 0,"},{"line_number":48,"context_line":"        pci_devices.c.parent_addr \u003d\u003d None,  # noqa"},{"line_number":49,"context_line":"        pci_devices.c.dev_type \u003d\u003d \u0027type-VF\u0027)).execute().scalar()"},{"line_number":50,"context_line":"    if count \u003e 0:"},{"line_number":51,"context_line":"        msg \u003d WARNING_MSG % {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_a2505734","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":50},"in_reply_to":"ff570b3c_a7c229e8","updated":"2020-05-12 11:57:19.000000000","message":"fine i still think a comment as to why this is beign done would be nice or at least doing \"# noqa: E711\" instead of \"# noqa\"","commit_id":"306808951810406edb58a69cfe7d321977640f24"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"874d3193466da6fb52fbed7dcc44a4773dda4248","unresolved":false,"context_lines":[{"line_number":6261,"context_line":"            mock_get_allocations, mock_ins_save, mock_spawn):"},{"line_number":6262,"context_line":""},{"line_number":6263,"context_line":"        accel_info \u003d [{\u0027k1\u0027: \u0027v1\u0027, \u0027k2\u0027: \u0027v2\u0027}]"},{"line_number":6264,"context_line":""},{"line_number":6265,"context_line":"        @contextlib.contextmanager"},{"line_number":6266,"context_line":"        def fake_build_resources(compute_mgr, *args, **kwargs):"},{"line_number":6267,"context_line":"            yield {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_4c6c1436","line":6264,"updated":"2020-05-12 10:16:56.000000000","message":"is this unrelated or do we now need a line befoer inner function definetions.","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"59fcded64bb358373906680757a697bfc96e2d55","unresolved":false,"context_lines":[{"line_number":6261,"context_line":"            mock_get_allocations, mock_ins_save, mock_spawn):"},{"line_number":6262,"context_line":""},{"line_number":6263,"context_line":"        accel_info \u003d [{\u0027k1\u0027: \u0027v1\u0027, \u0027k2\u0027: \u0027v2\u0027}]"},{"line_number":6264,"context_line":""},{"line_number":6265,"context_line":"        @contextlib.contextmanager"},{"line_number":6266,"context_line":"        def fake_build_resources(compute_mgr, *args, **kwargs):"},{"line_number":6267,"context_line":"            yield {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_c7fe3d04","line":6264,"in_reply_to":"ff570b3c_4c6c1436","updated":"2020-05-12 10:23:35.000000000","message":"+1\n\nIf so, I\u0027m pretty sure we would have to modify more methods than only this one...","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ffb6e612c900dfa7c17569eafc8c273923f19207","unresolved":false,"context_lines":[{"line_number":6261,"context_line":"            mock_get_allocations, mock_ins_save, mock_spawn):"},{"line_number":6262,"context_line":""},{"line_number":6263,"context_line":"        accel_info \u003d [{\u0027k1\u0027: \u0027v1\u0027, \u0027k2\u0027: \u0027v2\u0027}]"},{"line_number":6264,"context_line":""},{"line_number":6265,"context_line":"        @contextlib.contextmanager"},{"line_number":6266,"context_line":"        def fake_build_resources(compute_mgr, *args, **kwargs):"},{"line_number":6267,"context_line":"            yield {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e726e1b7","line":6264,"in_reply_to":"ff570b3c_c7fe3d04","updated":"2020-05-12 10:28:11.000000000","message":"The latter. https://www.flake8rules.com/rules/E306.html","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"139d3ea656bc8be461d955a9a4570cba1e0c600c","unresolved":false,"context_lines":[{"line_number":6261,"context_line":"            mock_get_allocations, mock_ins_save, mock_spawn):"},{"line_number":6262,"context_line":""},{"line_number":6263,"context_line":"        accel_info \u003d [{\u0027k1\u0027: \u0027v1\u0027, \u0027k2\u0027: \u0027v2\u0027}]"},{"line_number":6264,"context_line":""},{"line_number":6265,"context_line":"        @contextlib.contextmanager"},{"line_number":6266,"context_line":"        def fake_build_resources(compute_mgr, *args, **kwargs):"},{"line_number":6267,"context_line":"            yield {"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_c75f5de3","line":6264,"in_reply_to":"ff570b3c_e726e1b7","updated":"2020-05-12 10:45:56.000000000","message":"ok this one makes sense to me its consiten with all other function defineiton that are not at module scope.","commit_id":"306808951810406edb58a69cfe7d321977640f24"}],"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"874d3193466da6fb52fbed7dcc44a4773dda4248","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.flags(**startup_flags)"},{"line_number":124,"context_line":"        with mock.patch("},{"line_number":125,"context_line":"                \u0027nova.virt.vmwareapi.driver.VMwareAPISession.__init__\u0027):"},{"line_number":126,"context_line":"            e \u003d self.assertRaises(Exception, driver.VMwareVCDriver, None)  # noqa"},{"line_number":127,"context_line":"            self.assertIs(type(e), expected_exception_type)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_start_driver_no_user(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_0c9fbc03","line":126,"range":{"start_line":126,"start_character":74,"end_line":126,"end_character":81},"updated":"2020-05-12 10:16:56.000000000","message":"what is the noqa needed for?\n\nthe other form using a hanging indent should have been also allowed though i personlly only do that if they dont fit on one line so this si correct but its not clear why you are doing this.\n\nthe noqa should have disabled checking this statement so this should not have been required.","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ffb6e612c900dfa7c17569eafc8c273923f19207","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.flags(**startup_flags)"},{"line_number":124,"context_line":"        with mock.patch("},{"line_number":125,"context_line":"                \u0027nova.virt.vmwareapi.driver.VMwareAPISession.__init__\u0027):"},{"line_number":126,"context_line":"            e \u003d self.assertRaises(Exception, driver.VMwareVCDriver, None)  # noqa"},{"line_number":127,"context_line":"            self.assertIs(type(e), expected_exception_type)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_start_driver_no_user(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_e75b812b","line":126,"range":{"start_line":126,"start_character":74,"end_line":126,"end_character":81},"in_reply_to":"ff570b3c_0c9fbc03","updated":"2020-05-12 10:28:11.000000000","message":"assertRaises(foo) is treated as equivalent to \u0027except foo\u0027. Here, as there, plain old Exception is seen as too broad to catch. However, we want to do that and were doing so before via noqa. The only change is that the noqa now has to be on the same line as the error.","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"708f472e21234c1b56f71eb9a939b029369f7cc5","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.flags(**startup_flags)"},{"line_number":124,"context_line":"        with mock.patch("},{"line_number":125,"context_line":"                \u0027nova.virt.vmwareapi.driver.VMwareAPISession.__init__\u0027):"},{"line_number":126,"context_line":"            e \u003d self.assertRaises(Exception, driver.VMwareVCDriver, None)  # noqa"},{"line_number":127,"context_line":"            self.assertIs(type(e), expected_exception_type)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_start_driver_no_user(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_678f71cc","line":126,"range":{"start_line":126,"start_character":74,"end_line":126,"end_character":81},"in_reply_to":"ff570b3c_47f98d7e","updated":"2020-05-12 10:57:32.000000000","message":"Turns out its not a bug in flake8. It\u0027s intentional. See [1] and [2]\n\n[1] https://gitlab.com/pycqa/flake8/-/issues/638\n[2] https://gitlab.com/pycqa/flake8/-/merge_requests/331","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ffa8494c0c8592b205db7ae915d3fb8b83794d22","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.flags(**startup_flags)"},{"line_number":124,"context_line":"        with mock.patch("},{"line_number":125,"context_line":"                \u0027nova.virt.vmwareapi.driver.VMwareAPISession.__init__\u0027):"},{"line_number":126,"context_line":"            e \u003d self.assertRaises(Exception, driver.VMwareVCDriver, None)  # noqa"},{"line_number":127,"context_line":"            self.assertIs(type(e), expected_exception_type)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_start_driver_no_user(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_c2190b89","line":126,"range":{"start_line":126,"start_character":74,"end_line":126,"end_character":81},"in_reply_to":"ff570b3c_678f71cc","updated":"2020-05-12 11:57:19.000000000","message":"can you add the error number so # noqa: E\u003cwhatever\u003e\n\ni have left a comment expressing my displeasure on [1] for breaking semver rules and not doing a major verion bump for a no additive api breakage.\n\nit may have been intentional but that should have resulted in a 4.0.0 release.","commit_id":"306808951810406edb58a69cfe7d321977640f24"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"139d3ea656bc8be461d955a9a4570cba1e0c600c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.flags(**startup_flags)"},{"line_number":124,"context_line":"        with mock.patch("},{"line_number":125,"context_line":"                \u0027nova.virt.vmwareapi.driver.VMwareAPISession.__init__\u0027):"},{"line_number":126,"context_line":"            e \u003d self.assertRaises(Exception, driver.VMwareVCDriver, None)  # noqa"},{"line_number":127,"context_line":"            self.assertIs(type(e), expected_exception_type)"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_start_driver_no_user(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_47f98d7e","line":126,"range":{"start_line":126,"start_character":74,"end_line":126,"end_character":81},"in_reply_to":"ff570b3c_e75b812b","updated":"2020-05-12 10:45:56.000000000","message":"ya here your just reflowing the line\nbut it would be nice to have a comment saying why you are using # noqa\n\nbasically i dont think we should ever add a # noqa comment without leaving a comment in the code saying why.\n\ni know you are not added a new one here but it would be nice to say why this is here for futrure readers.\n\nalso your eplcantion makes this sound like a bug either in hacking or flake8 as it is clearly parsing this incorrectly if its mistaking a function call for a except block.","commit_id":"306808951810406edb58a69cfe7d321977640f24"}]}