)]}'
{"id":"openstack%2Fnova~727140","triplet_id":"openstack%2Fnova~master~I13774729fef82b7c6c07ceb2afa6e304a506da90","project":"openstack/nova","branch":"master","topic":"trivial","hashtags":[],"change_id":"I13774729fef82b7c6c07ceb2afa6e304a506da90","subject":"trivial: Address issues with flake8 3.8.0","status":"ABANDONED","created":"2020-05-12 10:05:11.000000000","updated":"2020-05-12 17:02:43.000000000","total_comment_count":22,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fa8b25638685d9af453ccea514f4d7953387fee3","_number":727140,"virtual_id_number":727140,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"date":"2020-05-12 10:41:53.000000000","_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"date":"2020-05-12 10:05:39.000000000","_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"all":[{"value":-1,"date":"2020-05-12 10:16:56.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-05-12 10:33:55.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":-1,"date":"2020-05-12 10:23:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-12 10:05:39.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-05-12 10:16:56.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2020-05-12 10:23:35.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2020-05-12 10:33:55.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"}],"messages":[{"id":"7242a37c0b606b65e01c6d78be4e41947dd51fe2","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-05-12 10:05:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"18a74902c5183be9822bef9362b43758da9cab69","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2020-05-12 10:05:39.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"874d3193466da6fb52fbed7dcc44a4773dda4248","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-05-12 10:16:56.000000000","message":"Patch Set 1: Code-Review-1\n\n(4 comments)\n\nits not clear why any of these change are really needed so can you comment on that","accounts_in_message":[],"_revision_number":1},{"id":"59fcded64bb358373906680757a697bfc96e2d55","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2020-05-12 10:23:35.000000000","message":"Patch Set 1: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ffb6e612c900dfa7c17569eafc8c273923f19207","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-05-12 10:28:11.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"d4d9f402adb242a7f777b84bcdd32ce40825f804","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-05-12 10:33:55.000000000","message":"Patch Set 1: Code-Review-1\n\nLocally I get more failures running this patch: http://paste.openstack.org/show/793434/","accounts_in_message":[],"_revision_number":1},{"id":"d332c0d3d448ce0fc03f0c1299091bbb424f2b19","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2020-05-12 10:35:19.000000000","message":"Patch Set 1:\n\n\u003e Locally I get more failures running this patch: http://paste.openstack.org/show/793434/\n\nThere is flake 3.8.1 pulled in for me, released 5 hours ago","accounts_in_message":[],"_revision_number":1},{"id":"2cab3a422c2da80ee1d8881ae62feceabf6c4801","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-05-12 10:41:53.000000000","message":"Patch Set 1:\n\nOkay, here were the error messages I was seeing:\n\n  ./nova/api/openstack/compute/servers.py:104:23: E741 ambiguous variable name \u0027l\u0027\n  ./nova/db/sqlalchemy/migrate_repo/versions/330_enforce_mitaka_online_migrations.py:48:35: E711 comparison to None should be \u0027if cond is None:\u0027\n  ./nova/tests/unit/virt/vmwareapi/test_driver_api.py:126:14: H202: assertRaises Exception too broad\n  ./nova/tests/unit/compute/test_compute_mgr.py:6264:9: E306 expected 1 blank line before a nested definition, found 0\n\nHowever, it looks like there\u0027s more gone wrong here so I guess we\u0027re going to have to just wait for the hacking patch to land.","accounts_in_message":[],"_revision_number":1},{"id":"bc7388d92054819ca7094b3cd851af49c7398345","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-05-12 10:41:57.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"9879d389af8f402bb82670263ab4c3993a8d5c98","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-05-12 10:43:53.000000000","message":"Patch Set 1:\n\n\u003e \u003e Locally I get more failures running this patch: http://paste.openstack.org/show/793434/\n \u003e \n \u003e There is flake 3.8.1 pulled in for me, released 5 hours ago\n\nWeird. I did \u0027tox -e pep8 --recreate\u0027 and didn\u0027t see those, even though I have flake8 3.8.1.\n\n  $ source .tox/shared/bin/activate\n  $ (shared) pip freeze | grep flake8\n  flake8\u003d\u003d3.8.1","accounts_in_message":[],"_revision_number":1},{"id":"139d3ea656bc8be461d955a9a4570cba1e0c600c","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-05-12 10:45:56.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"708f472e21234c1b56f71eb9a939b029369f7cc5","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-05-12 10:57:32.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ffa8494c0c8592b205db7ae915d3fb8b83794d22","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-05-12 11:57:19.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"bbc792ea4ce6f16eb8198e12879468fe74330aea","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2020-05-12 17:02:43.000000000","message":"Patch Set 1:\n\ni also saw the issue gibi hit and the strange thing is i see them with 3.5.0 as well so there may be some other interfaction here too","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"306808951810406edb58a69cfe7d321977640f24","revisions":{"306808951810406edb58a69cfe7d321977640f24":{"kind":"REWORK","_number":1,"created":"2020-05-12 10:05:11.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/40/727140/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/40/727140/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/727140/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/727140/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/40/727140/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/40/727140/1"}}},"commit":{"parents":[{"commit":"1d2934445732bfa214b1e6f2772ef16b1f51b3f9","subject":"Merge \"Suppress remaining policy warnings in unit tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1d2934445732bfa214b1e6f2772ef16b1f51b3f9"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-05-12 09:58:37.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2020-05-12 10:03:15.000000000","tz":60},"subject":"trivial: Address issues with flake8 3.8.0","message":"trivial: Address issues with flake8 3.8.0\n\nThis has introduced a new version of pycodestyle, which has improved its\nparser to catch new corner cases and introduced some new tests.\n\nChange-Id: I13774729fef82b7c6c07ceb2afa6e304a506da90\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/306808951810406edb58a69cfe7d321977640f24"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/306808951810406edb58a69cfe7d321977640f24"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}