)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6ae54b1f489306514f5b5e7971c45c600ade8a49","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangbailin \u003czhangbailin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-14 16:15:05 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix flake8 error from hacking \u003c3.0.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This has introduced a new version of pycodestyle, which has improved its"},{"line_number":10,"context_line":"parser to catch new corner cases and introduced some new tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff570b3c_1299601e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":36},"updated":"2020-05-14 08:49:41.000000000","message":"given we will only support hacking\u003e\u003d3.0.1 after we merge https://review.opendev.org/#/c/727347/ why should we modify Nova for non-supported hacking versions ?","commit_id":"373c679401f55809f57e74bac4be9dd4eef39913"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"c4234636da6588011e9aa54af86e632532c1e53b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangbailin \u003czhangbailin@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-05-14 16:15:05 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix flake8 error from hacking \u003c3.0.1"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This has introduced a new version of pycodestyle, which has improved its"},{"line_number":10,"context_line":"parser to catch new corner cases and introduced some new tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff570b3c_b8afb5e1","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":36},"in_reply_to":"ff570b3c_1299601e","updated":"2020-05-14 09:40:15.000000000","message":"As talked IIRC, although use hacking\u003e\u003d3.0.1 can avoid hit these issue, but IMO, we should keep nova code style more readable, we dont should keep these unreasonable code style in Nova.\n\nThere is a common saying that \"every skyscraper is built from the ground.\"","commit_id":"373c679401f55809f57e74bac4be9dd4eef39913"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f2f5d1b5a2750ebc5e88a7fdfdafe2a85c6bac8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This has introduced a new version of pycodestyle, which has improved its"},{"line_number":10,"context_line":"parser to catch new corner cases and introduced some new tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit also ignored F811 in tox.ini, due to the decorator top of"},{"line_number":13,"context_line":"it will generate unique functions dynamically, it not cause a flake8"},{"line_number":14,"context_line":"bug."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1878317"},{"line_number":17,"context_line":"Change-Id: I853cf4dbd7ad6b7903a7f444f5c1da3f0fb21f77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ff570b3c_e2120109","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":4},"updated":"2020-05-15 09:22:52.000000000","message":"This is no longer true, right?","commit_id":"4b05740845ee92084fbd7f64cb7839f7feea9469"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0159e3a5e4d8ca10c02f80e627edab6b0314f4f9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This has introduced a new version of pycodestyle, which has improved its"},{"line_number":10,"context_line":"parser to catch new corner cases and introduced some new tests."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This commit also ignored F811 in tox.ini, due to the decorator top of"},{"line_number":13,"context_line":"it will generate unique functions dynamically, it not cause a flake8"},{"line_number":14,"context_line":"bug."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1878317"},{"line_number":17,"context_line":"Change-Id: I853cf4dbd7ad6b7903a7f444f5c1da3f0fb21f77"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ff570b3c_82db4519","line":14,"range":{"start_line":12,"start_character":0,"end_line":14,"end_character":4},"in_reply_to":"ff570b3c_e2120109","updated":"2020-05-15 09:39:55.000000000","message":"Done","commit_id":"4b05740845ee92084fbd7f64cb7839f7feea9469"}],"nova/api/openstack/compute/console_auth_tokens.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"4a612f217ffe29f4a0f081bc1518bce74c21607a","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @wsgi.Controller.api_version(\"2.31\")  # noqa"},{"line_number":78,"context_line":"    @wsgi.expected_errors((400, 404))"},{"line_number":79,"context_line":"    def show(self, req, id):  # noqa"},{"line_number":80,"context_line":"        return self._show(req, id, False)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff570b3c_47f29407","line":79,"range":{"start_line":79,"start_character":0,"end_line":79,"end_character":36},"updated":"2020-05-19 18:28:04.000000000","message":"with F811 checks we do not have much choice here. let\u0027s go with noqa","commit_id":"61b99a1295c5208deef806b69ba74a7d031ad851"}],"nova/db/sqlalchemy/migrate_repo/versions/330_enforce_mitaka_online_migrations.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2529c6f7057b0b3410f7242692ab34634ef551e8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # if the definition is altered."},{"line_number":46,"context_line":"    count \u003d select([func.count()]).select_from(pci_devices).where(and_("},{"line_number":47,"context_line":"        pci_devices.c.deleted \u003d\u003d 0,"},{"line_number":48,"context_line":"        pci_devices.c.parent_addr \u003d\u003d None,  # noqa"},{"line_number":49,"context_line":"        pci_devices.c.dev_type \u003d\u003d \u0027type-VF\u0027)).execute().scalar()  # NOQA"},{"line_number":50,"context_line":"    if count \u003e 0:"},{"line_number":51,"context_line":"        msg \u003d WARNING_MSG % {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_24bf10d1","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":50},"updated":"2020-05-13 15:38:37.000000000","message":"what error is there for this. I am thinking if we can avoid this new  #noqa","commit_id":"2a542e82aa49df52fa31edbe8eaac9b92325812b"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"23ea99e3a3f4f51ff22a0f95140a6325d4caa321","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # if the definition is altered."},{"line_number":46,"context_line":"    count \u003d select([func.count()]).select_from(pci_devices).where(and_("},{"line_number":47,"context_line":"        pci_devices.c.deleted \u003d\u003d 0,"},{"line_number":48,"context_line":"        pci_devices.c.parent_addr \u003d\u003d None,  # noqa"},{"line_number":49,"context_line":"        pci_devices.c.dev_type \u003d\u003d \u0027type-VF\u0027)).execute().scalar()  # NOQA"},{"line_number":50,"context_line":"    if count \u003e 0:"},{"line_number":51,"context_line":"        msg \u003d WARNING_MSG % {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_61bc4fdc","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":50},"in_reply_to":"ff570b3c_24bf10d1","updated":"2020-05-14 00:09:33.000000000","message":"I am not sure why this be reported, but it\u0027s real True cause the pep8 failed in https://review.opendev.org/#/c/724260/6, and https://review.opendev.org/#/c/726564/2.","commit_id":"2a542e82aa49df52fa31edbe8eaac9b92325812b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"df1daf9febf1eb9d64775c92b3ebdd5944457957","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # if the definition is altered."},{"line_number":46,"context_line":"    count \u003d select([func.count()]).select_from(pci_devices).where(and_("},{"line_number":47,"context_line":"        pci_devices.c.deleted \u003d\u003d 0,"},{"line_number":48,"context_line":"        pci_devices.c.parent_addr \u003d\u003d None,  # noqa"},{"line_number":49,"context_line":"        pci_devices.c.dev_type \u003d\u003d \u0027type-VF\u0027)).execute().scalar()  # NOQA"},{"line_number":50,"context_line":"    if count \u003e 0:"},{"line_number":51,"context_line":"        msg \u003d WARNING_MSG % {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_e4e7ca3f","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":50},"in_reply_to":"ff570b3c_61bc4fdc","updated":"2020-05-14 06:36:07.000000000","message":"in normal python you should not use \u003d\u003d and None\nyou shoudl do x is None\n\nNone is a uniary type in pythons type system.\nthere is only ever one instanc eof the None object and you are ment to do comparisons with it via an identity check\ni.e. X is None rather then an equality check x \u003d\u003d None\n\nthat said this si part of the sqlalcamy dsl and not standard python and we are not sure if that support \"x is None\" in this context to generate sql that will check if the column is Null.\n\nmy understanding is that sqlalceamy reflecting over this statement to generate the sql query so it would have to expclitly support both forms so the pythonic transformation of \u003d\u003d to is might break it hence the need for # noqa","commit_id":"2a542e82aa49df52fa31edbe8eaac9b92325812b"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b91861f8954bab63b261482874a91676ff82dcfa","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    # if the definition is altered."},{"line_number":46,"context_line":"    count \u003d select([func.count()]).select_from(pci_devices).where(and_("},{"line_number":47,"context_line":"        pci_devices.c.deleted \u003d\u003d 0,"},{"line_number":48,"context_line":"        pci_devices.c.parent_addr \u003d\u003d None,  # noqa"},{"line_number":49,"context_line":"        pci_devices.c.dev_type \u003d\u003d \u0027type-VF\u0027)).execute().scalar()  # NOQA"},{"line_number":50,"context_line":"    if count \u003e 0:"},{"line_number":51,"context_line":"        msg \u003d WARNING_MSG % {"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_327744a3","line":48,"range":{"start_line":48,"start_character":43,"end_line":48,"end_character":50},"in_reply_to":"ff570b3c_e4e7ca3f","updated":"2020-05-14 08:17:50.000000000","message":"@Sean I agree with you, x is None is better than x\u003d\u003dNone, but I am not sure sqlalceamy whether can accept x \u003d\u003d None and x is None, I think keep current status is security.","commit_id":"2a542e82aa49df52fa31edbe8eaac9b92325812b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"df1daf9febf1eb9d64775c92b3ebdd5944457957","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    count \u003d select([func.count()]).select_from(pci_devices).where(and_("},{"line_number":47,"context_line":"        pci_devices.c.deleted \u003d\u003d 0,"},{"line_number":48,"context_line":"        pci_devices.c.parent_addr \u003d\u003d None,  # noqa"},{"line_number":49,"context_line":"        pci_devices.c.dev_type \u003d\u003d \u0027type-VF\u0027)).execute().scalar()  # NOQA"},{"line_number":50,"context_line":"    if count \u003e 0:"},{"line_number":51,"context_line":"        msg \u003d WARNING_MSG % {"},{"line_number":52,"context_line":"            \u0027count\u0027: count,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_a44b1229","line":49,"range":{"start_line":49,"start_character":66,"end_line":49,"end_character":72},"updated":"2020-05-14 06:36:07.000000000","message":"you missed removing this","commit_id":"2a542e82aa49df52fa31edbe8eaac9b92325812b"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"b91861f8954bab63b261482874a91676ff82dcfa","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    count \u003d select([func.count()]).select_from(pci_devices).where(and_("},{"line_number":47,"context_line":"        pci_devices.c.deleted \u003d\u003d 0,"},{"line_number":48,"context_line":"        pci_devices.c.parent_addr \u003d\u003d None,  # noqa"},{"line_number":49,"context_line":"        pci_devices.c.dev_type \u003d\u003d \u0027type-VF\u0027)).execute().scalar()  # NOQA"},{"line_number":50,"context_line":"    if count \u003e 0:"},{"line_number":51,"context_line":"        msg \u003d WARNING_MSG % {"},{"line_number":52,"context_line":"            \u0027count\u0027: count,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_b23cf4c8","line":49,"range":{"start_line":49,"start_character":66,"end_line":49,"end_character":72},"in_reply_to":"ff570b3c_a44b1229","updated":"2020-05-14 08:17:50.000000000","message":"Done","commit_id":"2a542e82aa49df52fa31edbe8eaac9b92325812b"}],"test-requirements.txt":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2d4cca706be9bb22c3a39788d97c0bee37233164","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"hacking\u003e\u003d3.1.0"},{"line_number":6,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":7,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":8,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":5,"id":"ff570b3c_617716d6","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":14},"updated":"2020-05-15 01:10:37.000000000","message":"hacking\u003e\u003d3.1.0\u003c3.1.1\n\nyou need upper cap also.\n\nversioning things on hacking side are not so great and consistent so let\u0027s be safer side and keep \u003c3.1.1","commit_id":"431c8417f3feb8bcb368494534bf2b4fdddddee4"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"38f3e1eb82252baf156b89e3e9fb0fae7696d5b3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"hacking\u003e\u003d3.1.0"},{"line_number":6,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":7,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":8,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":5,"id":"ff570b3c_a12f6e9f","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":14},"in_reply_to":"ff570b3c_617716d6","updated":"2020-05-15 01:18:47.000000000","message":"Done","commit_id":"431c8417f3feb8bcb368494534bf2b4fdddddee4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0b3470a4dc2cdae00c5d319121e5065f1d0cccee","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"hacking\u003e\u003d3.1.0\u003c3.1.1 # Apache-2.0"},{"line_number":6,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":7,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":8,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":7,"id":"ff570b3c_537e2919","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":33},"updated":"2020-05-15 01:59:33.000000000","message":"missing comma which we missed always :) and used new hacking even with upper cap.\n\nhacking\u003e\u003d3.1.0,\u003c3.1.1 # Apache-2.0","commit_id":"b078a18a5d3f4e73d62afbcc630dd20495c65fd7"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"3092fe871fe5755f0f617d72867b44638d780139","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"hacking\u003e\u003d3.1.0\u003c3.1.1 # Apache-2.0"},{"line_number":6,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":7,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":8,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":7,"id":"ff570b3c_b3bb45c2","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":33},"in_reply_to":"ff570b3c_537e2919","updated":"2020-05-15 02:03:00.000000000","message":"Ah, yeah, I concerned you fix, I will rebased again, and then fix this.","commit_id":"b078a18a5d3f4e73d62afbcc630dd20495c65fd7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f2f5d1b5a2750ebc5e88a7fdfdafe2a85c6bac8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"hacking\u003e\u003d3.1.0,\u003c3.1.1 # Apache-2.0"},{"line_number":6,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":7,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":8,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":8,"id":"ff570b3c_a263e9b0","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":21},"updated":"2020-05-15 09:22:52.000000000","message":"3.2.0\n\nIf there\u0027s ever a future 3.1.1, it will be a bugfix only that we\u0027d likely want to pick up","commit_id":"4b05740845ee92084fbd7f64cb7839f7feea9469"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0159e3a5e4d8ca10c02f80e627edab6b0314f4f9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"hacking\u003e\u003d3.1.0,\u003c3.1.1 # Apache-2.0"},{"line_number":6,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":7,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":8,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":8,"id":"ff570b3c_e2ea01aa","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":21},"in_reply_to":"ff570b3c_a263e9b0","updated":"2020-05-15 09:39:55.000000000","message":"I am not an expert in identifying hacking versions, I will follow you.","commit_id":"4b05740845ee92084fbd7f64cb7839f7feea9469"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a5bf30206fa85cee3ba059d56ce3323570a8c2ec","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"hacking\u003e\u003d3.1.0,\u003c3.2.0 # Apache-2.0"},{"line_number":6,"context_line":"mypy\u003e\u003d0.761 # MIT"},{"line_number":7,"context_line":"coverage!\u003d4.4,\u003e\u003d4.0 # Apache-2.0"},{"line_number":8,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":9,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"}],"source_content_type":"text/plain","patch_set":11,"id":"ff570b3c_7dcdc12f","line":6,"updated":"2020-05-19 00:13:54.000000000","message":"It was conflict with https://review.opendev.org/#/c/676208/16/test-requirements.txt, rebased and resolve the merged conflict.","commit_id":"61b99a1295c5208deef806b69ba74a7d031ad851"}],"tox.ini":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1328cb4c54bd1b9ab67daf90f965e9df59060436","unresolved":false,"context_lines":[{"line_number":243,"context_line":"# E731 temporarily skipped because of the number of"},{"line_number":244,"context_line":"# these that have to be fixed"},{"line_number":245,"context_line":"#"},{"line_number":246,"context_line":"# F811 Skipped due to the decorator top of it will generate unique functions"},{"line_number":247,"context_line":"# dynamically"},{"line_number":248,"context_line":"enable-extensions \u003d H106,H203,H904"},{"line_number":249,"context_line":"ignore \u003d E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405,W504,E731,H238,F811"},{"line_number":250,"context_line":"exclude \u003d  .venv,.git,.tox,dist,*lib/python*,*egg,build,tools/xenserver*,releasenotes"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_f31dce66","line":247,"range":{"start_line":246,"start_character":0,"end_line":247,"end_character":13},"updated":"2020-05-14 10:24:00.000000000","message":"This is way too broad to ignore. What you need to do, unfortunately, is duplicate the noqa for affected lines, e.g.\n\n  @wsgi.Controller.api_version(\"2.1\", MAX_PROXY_API_SUPPORT_VERSION)\n  @wsgi.expected_errors(400)\n  def show(self, req, id):\n      return self._show(req, id, [])\n\n  @wsgi.Controller.api_version(  # noqa\n      MIN_WITHOUT_PROXY_API_SUPPORT_VERSION, \u00272.56\u0027)\n  @wsgi.expected_errors(400)\n  def show(self, req, id):\n      return self._show(req, id, FILTERED_QUOTAS_2_36)\n\nWould become:\n\n  @wsgi.Controller.api_version(\"2.1\", MAX_PROXY_API_SUPPORT_VERSION)\n  @wsgi.expected_errors(400)\n  def show(self, req, id):\n      return self._show(req, id, [])\n\n  @wsgi.Controller.api_version(  # noqa\n      MIN_WITHOUT_PROXY_API_SUPPORT_VERSION, \u00272.56\u0027)\n  @wsgi.expected_errors(400)\n  def show(self, req, id):  # noqa  \u003c-- extra noqa\n      return self._show(req, id, FILTERED_QUOTAS_2_36)","commit_id":"373c679401f55809f57e74bac4be9dd4eef39913"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"43f9fe9d9ca213191cb5b570ab57f18405f209cc","unresolved":false,"context_lines":[{"line_number":243,"context_line":"# E731 temporarily skipped because of the number of"},{"line_number":244,"context_line":"# these that have to be fixed"},{"line_number":245,"context_line":"#"},{"line_number":246,"context_line":"# F811 Skipped due to the decorator top of it will generate unique functions"},{"line_number":247,"context_line":"# dynamically"},{"line_number":248,"context_line":"enable-extensions \u003d H106,H203,H904"},{"line_number":249,"context_line":"ignore \u003d E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405,W504,E731,H238,F811"},{"line_number":250,"context_line":"exclude \u003d  .venv,.git,.tox,dist,*lib/python*,*egg,build,tools/xenserver*,releasenotes"}],"source_content_type":"text/x-properties","patch_set":3,"id":"ff570b3c_d3f9aa4d","line":247,"range":{"start_line":246,"start_character":0,"end_line":247,"end_character":13},"in_reply_to":"ff570b3c_f31dce66","updated":"2020-05-14 11:07:52.000000000","message":"yes.","commit_id":"373c679401f55809f57e74bac4be9dd4eef39913"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4f2f5d1b5a2750ebc5e88a7fdfdafe2a85c6bac8","unresolved":false,"context_lines":[{"line_number":243,"context_line":"# E731 temporarily skipped because of the number of"},{"line_number":244,"context_line":"# these that have to be fixed"},{"line_number":245,"context_line":"#"},{"line_number":246,"context_line":"# F811 Skipped due to the decorator top of it will generate unique functions"},{"line_number":247,"context_line":"# dynamically"},{"line_number":248,"context_line":"enable-extensions \u003d H106,H203,H904"},{"line_number":249,"context_line":"ignore \u003d E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405,W504,E731,H238,F811"},{"line_number":250,"context_line":"exclude \u003d  .venv,.git,.tox,dist,*lib/python*,*egg,build,tools/xenserver*,releasenotes"}],"source_content_type":"text/x-properties","patch_set":8,"id":"ff570b3c_424bed29","line":247,"range":{"start_line":246,"start_character":0,"end_line":247,"end_character":13},"updated":"2020-05-15 09:22:52.000000000","message":"This is still here and shouldn\u0027t be","commit_id":"4b05740845ee92084fbd7f64cb7839f7feea9469"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0159e3a5e4d8ca10c02f80e627edab6b0314f4f9","unresolved":false,"context_lines":[{"line_number":243,"context_line":"# E731 temporarily skipped because of the number of"},{"line_number":244,"context_line":"# these that have to be fixed"},{"line_number":245,"context_line":"#"},{"line_number":246,"context_line":"# F811 Skipped due to the decorator top of it will generate unique functions"},{"line_number":247,"context_line":"# dynamically"},{"line_number":248,"context_line":"enable-extensions \u003d H106,H203,H904"},{"line_number":249,"context_line":"ignore \u003d E121,E122,E123,E124,E125,E126,E127,E128,E129,E131,E251,H405,W504,E731,H238,F811"},{"line_number":250,"context_line":"exclude \u003d  .venv,.git,.tox,dist,*lib/python*,*egg,build,tools/xenserver*,releasenotes"}],"source_content_type":"text/x-properties","patch_set":8,"id":"ff570b3c_62d6f1f3","line":247,"range":{"start_line":246,"start_character":0,"end_line":247,"end_character":13},"in_reply_to":"ff570b3c_424bed29","updated":"2020-05-15 09:39:55.000000000","message":"Done","commit_id":"4b05740845ee92084fbd7f64cb7839f7feea9469"}]}