)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a4f980c7b07b0bd62851c0f624ba9b115851e7bc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"openstackdocstheme extension released in version 2.1.0, it has stopped"},{"line_number":11,"context_line":"always overriding the latex_engine to \u0027xelatex\u0027. In the nova docs, we"},{"line_number":12,"context_line":"need the \u0027xelatex\u0027 engine to be able to handle some Unicode characters"},{"line_number":13,"context_line":"contained in our feature classification matrix, like the \"X\" mark."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This configures latex_engine \u003d \u0027xelatex\u0027 in our docs config."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff570b3c_c4460650","line":13,"updated":"2020-05-14 06:26:33.000000000","message":"Note: maybe there\u0027s some other engine we should be using but from what I gathered while googling, use of a Unicode-based engine seemed appropriate:\n\nhttps://texfaq.org/FAQ-xetex-luatex\n\nIf there\u0027s a different approach we should take, let me know.","commit_id":"6faf51d7af7891c2b7ed842b465b36d6caccb6c8"}],"bindep.txt":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e510269b569d623f5b22c5ea6e91cbab00ed78ee","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"build-essential [platform:dpkg test]"},{"line_number":5,"context_line":"# fonts-freefont-otf is needed for pdf docs builds with the \u0027xelatex\u0027 engine"},{"line_number":6,"context_line":"fonts-freefont-otf"},{"line_number":7,"context_line":"gcc [platform:rpm test]"},{"line_number":8,"context_line":"# gettext and graphviz are needed by doc builds only. For transition,"},{"line_number":9,"context_line":"# have them in both doc and test."}],"source_content_type":"text/plain","patch_set":2,"id":"ff570b3c_5c05b4c1","line":6,"updated":"2020-05-14 01:36:30.000000000","message":"Note: I\u0027m not sure if this is the best way to get the fonts needed to build the pdf docs. That is, I don\u0027t understand how openstackdocstheme 2.0.2 with the \u0027xelatex\u0027 engine used to work without the fonts package. Maybe stephenfin can advise.","commit_id":"5d93f63169ac60ed23ef858b60dc9315d054e80e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b44e3bab39681a7b90e6ad509d42d02a87154180","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"build-essential [platform:dpkg test]"},{"line_number":5,"context_line":"# fonts-freefont-otf is needed for pdf docs builds with the \u0027xelatex\u0027 engine"},{"line_number":6,"context_line":"fonts-freefont-otf"},{"line_number":7,"context_line":"gcc [platform:rpm test]"},{"line_number":8,"context_line":"# gettext and graphviz are needed by doc builds only. For transition,"},{"line_number":9,"context_line":"# have them in both doc and test."}],"source_content_type":"text/plain","patch_set":2,"id":"ff570b3c_fe4f5d8f","line":6,"in_reply_to":"ff570b3c_5c05b4c1","updated":"2020-05-14 05:20:41.000000000","message":"we shoud use the lables so this is not always installed\n\nso add [doc]","commit_id":"5d93f63169ac60ed23ef858b60dc9315d054e80e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"65f9431f1a0a3b92426a857e8fd990274b4759de","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"build-essential [platform:dpkg test]"},{"line_number":5,"context_line":"# fonts-freefont-otf is needed for pdf docs builds with the \u0027xelatex\u0027 engine"},{"line_number":6,"context_line":"fonts-freefont-otf"},{"line_number":7,"context_line":"gcc [platform:rpm test]"},{"line_number":8,"context_line":"# gettext and graphviz are needed by doc builds only. For transition,"},{"line_number":9,"context_line":"# have them in both doc and test."}],"source_content_type":"text/plain","patch_set":2,"id":"ff570b3c_217a54f0","line":6,"in_reply_to":"ff570b3c_619a8c63","updated":"2020-05-14 06:08:58.000000000","message":"ya there are also some special ones like platform:\nos you can list the same depency with different names for different operating systems \n\n\nwe really should be adding and making use of more lables e.g. one per virt driver and per storage/rpc/database/network backend\n\ne.g. add libvirt,vmware rbd/ceph ect labels so that if you want to install all the deps for nova with mysql, libvirt and ceph back you can just do \n\nbindep -l newline mysql libvirt ceph | xargs \u003cpackage manager\u003e install -y\n\nor vmware with postgres\n\nbindep -l newline postgress vmware | xargs \u003cpackage manager\u003e install -y\n\n\nat the moement we dont really track all our bindeps just the ones needed for tox jobs but it would be nice to track them all.","commit_id":"5d93f63169ac60ed23ef858b60dc9315d054e80e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7446a10b3f37a3cbd551573d3b79f6994f489e81","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"build-essential [platform:dpkg test]"},{"line_number":5,"context_line":"# fonts-freefont-otf is needed for pdf docs builds with the \u0027xelatex\u0027 engine"},{"line_number":6,"context_line":"fonts-freefont-otf"},{"line_number":7,"context_line":"gcc [platform:rpm test]"},{"line_number":8,"context_line":"# gettext and graphviz are needed by doc builds only. For transition,"},{"line_number":9,"context_line":"# have them in both doc and test."}],"source_content_type":"text/plain","patch_set":2,"id":"ff570b3c_619a8c63","line":6,"in_reply_to":"ff570b3c_fe4f5d8f","updated":"2020-05-14 05:54:11.000000000","message":"Oh, derp, I didn\u0027t know that\u0027s what those notations were. Thanks.","commit_id":"5d93f63169ac60ed23ef858b60dc9315d054e80e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5c6933b911e1d803948796fe3ed87243d78bb809","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"build-essential [platform:dpkg test]"},{"line_number":5,"context_line":"# fonts-freefont-otf is needed for pdf docs builds with the \u0027xelatex\u0027 engine"},{"line_number":6,"context_line":"fonts-freefont-otf [doc]"},{"line_number":7,"context_line":"gcc [platform:rpm test]"},{"line_number":8,"context_line":"# gettext and graphviz are needed by doc builds only. For transition,"},{"line_number":9,"context_line":"# have them in both doc and test."}],"source_content_type":"text/plain","patch_set":3,"id":"ff570b3c_653a9134","line":6,"updated":"2020-05-14 11:42:22.000000000","message":"actully while your at it mind adding \ntexlive [pdf-docs]\ntexlive-xetex [pdf-docs]\ntexlive-latex-recommended [pdf-docs]\nlatexmk [pdf-docs]\n\nif fonts-freefont-otf is only needed for pdf docs\nthen it should be [pdf-docs] instead of doc","commit_id":"6faf51d7af7891c2b7ed842b465b36d6caccb6c8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7464d1d9881b1bd2c3bb9255e2f03e5e1052e217","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"build-essential [platform:dpkg test]"},{"line_number":5,"context_line":"# fonts-freefont-otf is needed for pdf docs builds with the \u0027xelatex\u0027 engine"},{"line_number":6,"context_line":"fonts-freefont-otf [doc]"},{"line_number":7,"context_line":"gcc [platform:rpm test]"},{"line_number":8,"context_line":"# gettext and graphviz are needed by doc builds only. For transition,"},{"line_number":9,"context_line":"# have them in both doc and test."}],"source_content_type":"text/plain","patch_set":3,"id":"ff570b3c_d54fc48f","line":6,"in_reply_to":"ff570b3c_1245d217","updated":"2020-05-14 19:56:43.000000000","message":"Thanks Andreas. I\u0027m still mystified how the docs job used to get the needed prerequisite packages before openstackdocstheme 2.1.0, but if this is the right thing to do regardless, let\u0027s do that.","commit_id":"6faf51d7af7891c2b7ed842b465b36d6caccb6c8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cc96e9f6b97bd52797db55b465e4d2a8a1314b71","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"build-essential [platform:dpkg test]"},{"line_number":5,"context_line":"# fonts-freefont-otf is needed for pdf docs builds with the \u0027xelatex\u0027 engine"},{"line_number":6,"context_line":"fonts-freefont-otf [doc]"},{"line_number":7,"context_line":"gcc [platform:rpm test]"},{"line_number":8,"context_line":"# gettext and graphviz are needed by doc builds only. For transition,"},{"line_number":9,"context_line":"# have them in both doc and test."}],"source_content_type":"text/plain","patch_set":3,"id":"ff570b3c_8cec29f4","line":6,"in_reply_to":"ff570b3c_653a9134","updated":"2020-05-14 17:14:21.000000000","message":"I actually don\u0027t understand why we had to specify the fonts in our bindep.txt after the change in 2.1.0 when they\u0027re already called out in openstackdocstheme bindep.txt:\n\nhttps://github.com/openstack/openstackdocstheme/blob/31642dd188121539395091979cf279e41be664a6/bindep.txt\n\nWhat is it about openstackdocstheme setting latex_engine \u003d \u0027xelatex\u0027 that pulls in the fonts but then doesn\u0027t pull in the fonts if it doesn\u0027t set latex_engine that way?","commit_id":"6faf51d7af7891c2b7ed842b465b36d6caccb6c8"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"09ed2e028c08364b3ea7f44e62190c7d5e90b641","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"build-essential [platform:dpkg test]"},{"line_number":5,"context_line":"# fonts-freefont-otf is needed for pdf docs builds with the \u0027xelatex\u0027 engine"},{"line_number":6,"context_line":"fonts-freefont-otf [doc]"},{"line_number":7,"context_line":"gcc [platform:rpm test]"},{"line_number":8,"context_line":"# gettext and graphviz are needed by doc builds only. For transition,"},{"line_number":9,"context_line":"# have them in both doc and test."}],"source_content_type":"text/plain","patch_set":3,"id":"ff570b3c_1245d217","line":6,"in_reply_to":"ff570b3c_8cec29f4","updated":"2020-05-14 18:32:53.000000000","message":"\u003e I actually don\u0027t understand why we had to specify the fonts in our\n \u003e bindep.txt after the change in 2.1.0 when they\u0027re already called\n \u003e out in openstackdocstheme bindep.txt:\n \nWe do not install bindep.txt from other packages.\n\n \u003e https://github.com/openstack/openstackdocstheme/blob/31642dd188121539395091979cf279e41be664a6/bindep.txt\n \u003e \n \u003e What is it about openstackdocstheme setting latex_engine \u003d\n \u003e \u0027xelatex\u0027 that pulls in the fonts but then doesn\u0027t pull in the\n \u003e fonts if it doesn\u0027t set latex_engine that way?\n\nI wonder whether you really need those - or whether something else pulls them.\n\nAdding them here is the right thing in general.","commit_id":"6faf51d7af7891c2b7ed842b465b36d6caccb6c8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"87f00c0204d620eb0866bbcc7c399f6ce0a757e8","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"build-essential [platform:dpkg test]"},{"line_number":5,"context_line":"# fonts-freefont-otf is needed for pdf docs builds with the \u0027xelatex\u0027 engine"},{"line_number":6,"context_line":"fonts-freefont-otf [doc]"},{"line_number":7,"context_line":"gcc [platform:rpm test]"},{"line_number":8,"context_line":"# gettext and graphviz are needed by doc builds only. For transition,"},{"line_number":9,"context_line":"# have them in both doc and test."}],"source_content_type":"text/plain","patch_set":3,"id":"ff570b3c_964d39c6","line":6,"in_reply_to":"ff570b3c_aac8df21","updated":"2020-05-16 01:47:00.000000000","message":"Oh, sorry, I didn\u0027t know you meant for local runs. Let me do that then.","commit_id":"6faf51d7af7891c2b7ed842b465b36d6caccb6c8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"153dbf6c9f960998b793fb1da459aa530e840092","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"build-essential [platform:dpkg test]"},{"line_number":5,"context_line":"# fonts-freefont-otf is needed for pdf docs builds with the \u0027xelatex\u0027 engine"},{"line_number":6,"context_line":"fonts-freefont-otf [doc]"},{"line_number":7,"context_line":"gcc [platform:rpm test]"},{"line_number":8,"context_line":"# gettext and graphviz are needed by doc builds only. For transition,"},{"line_number":9,"context_line":"# have them in both doc and test."}],"source_content_type":"text/plain","patch_set":3,"id":"ff570b3c_aac8df21","line":6,"in_reply_to":"ff570b3c_d54fc48f","updated":"2020-05-15 12:24:13.000000000","message":"we shoudl add them so that people can run this locally\n\nbut melanie the reason its not pulled in trasitivly is that is not how bindep works.\n\nwe do not run bindeps for each of the pip libs that we depend on. when you use bindeps in the nova repo it only read the bindeps.txt in nova so if we dont list the bindeps for the pdf-generation in nova i.e.\ntexlive [pdf-docs]\ntexlive-xetex [pdf-docs]\ntexlive-latex-recommended [pdf-docs]\nlatexmk [pdf-docs]\n\nthen we need ot go find those ourselves if we want to run it locally.\n\nwith that said i can go update this in a spereate patch if you like.","commit_id":"6faf51d7af7891c2b7ed842b465b36d6caccb6c8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f171f533d3206a415d2cbe29c75b6323fcdc77e4","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"build-essential [platform:dpkg test]"},{"line_number":5,"context_line":"# fonts-freefont-otf is needed for pdf docs builds with the \u0027xelatex\u0027 engine"},{"line_number":6,"context_line":"fonts-freefont-otf [pdf-docs]"},{"line_number":7,"context_line":"gcc [platform:rpm test]"},{"line_number":8,"context_line":"# gettext and graphviz are needed by doc builds only. For transition,"},{"line_number":9,"context_line":"# have them in both doc and test."}],"source_content_type":"text/plain","patch_set":5,"id":"ff570b3c_136e7100","line":6,"range":{"start_line":6,"start_character":20,"end_line":6,"end_character":28},"updated":"2020-05-15 02:49:06.000000000","message":"Also learned that the pdf-docs label doesn\u0027t work for the bindep role, so we have to use [doc] only:\n\nhttps://opendev.org/openstack/openstack-zuul-jobs/src/commit/e19fa5ad474994a48e0e15e4c2fb424f9ac10f2c/zuul.d/jobs.yaml#L435\n\nI\u0027ve proposed adding the fonts to infra here in case people like that idea:\n\nhttps://review.opendev.org/728333","commit_id":"22c26aa69ce0810136c25ac8053560705975c913"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f171f533d3206a415d2cbe29c75b6323fcdc77e4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"librsvg2-tools [doc platform:rpm]"},{"line_number":15,"context_line":"librsvg2-bin [doc platform:dpkg]"},{"line_number":16,"context_line":"language-pack-en [platform:ubuntu]"},{"line_number":17,"context_line":"latexmk [pdf-docs]"},{"line_number":18,"context_line":"libffi-dev [platform:dpkg test]"},{"line_number":19,"context_line":"libffi-devel [platform:rpm test]"},{"line_number":20,"context_line":"libmysqlclient-dev [platform:dpkg]"}],"source_content_type":"text/plain","patch_set":5,"id":"ff570b3c_73a7ed50","line":17,"updated":"2020-05-15 02:49:06.000000000","message":"Learned we don\u0027t need this or the other reqs on L46-48 because they\u0027re already included via infra:\n\nhttps://opendev.org/openstack/openstack-zuul-jobs/src/commit/e19fa5ad474994a48e0e15e4c2fb424f9ac10f2c/roles/prepare-build-pdf-docs/tasks/main.yaml","commit_id":"22c26aa69ce0810136c25ac8053560705975c913"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"7e7e84c1498bb3091e78fbdac6b502c32145ea80","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"build-essential [platform:dpkg test]"},{"line_number":5,"context_line":"# fonts-freefont-otf is needed for pdf docs builds with the \u0027xelatex\u0027 engine"},{"line_number":6,"context_line":"fonts-freefont-otf [pdf-docs]"},{"line_number":7,"context_line":"gcc [platform:rpm test]"},{"line_number":8,"context_line":"# gettext and graphviz are needed by doc builds only. For transition,"},{"line_number":9,"context_line":"# have them in both doc and test."}],"source_content_type":"text/plain","patch_set":7,"id":"ff570b3c_1a1ce4bf","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":29},"updated":"2020-05-27 20:57:50.000000000","message":"This needs platform:dpkg as it isn\u0027t available on rpm based distros but that\u0027s more of a nit as I assume we just target Ubuntu by default?","commit_id":"d40a0856ad2436afc929645bee03484fb98e8a6f"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"7e7e84c1498bb3091e78fbdac6b502c32145ea80","unresolved":false,"context_lines":[{"line_number":44,"context_line":"python34-devel [platform:centos]"},{"line_number":45,"context_line":"sqlite-devel [platform:rpm test]"},{"line_number":46,"context_line":"texlive [pdf-docs]"},{"line_number":47,"context_line":"texlive-latex-recommended [pdf-docs]"},{"line_number":48,"context_line":"texlive-xetex [pdf-docs]"},{"line_number":49,"context_line":"libpcre3-dev [platform:dpkg test]"},{"line_number":50,"context_line":"pcre-devel [platform:rpm test]"}],"source_content_type":"text/plain","patch_set":7,"id":"ff570b3c_3a21e8fc","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":36},"updated":"2020-05-27 20:57:50.000000000","message":"As above, this doesn\u0027t exist on Fedora at least.","commit_id":"d40a0856ad2436afc929645bee03484fb98e8a6f"}]}