)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3799ed247f2689170dd3f6da6c768f83173b193d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Change-Id: I642b1e3ed6de2be4dcc19fe214f84095d2e1d31a"},{"line_number":23,"context_line":"Closes-Bug: #1825584"},{"line_number":24,"context_line":"(cherry picked from commit d6f664524dfa4eecbe3e16fda0fec5359faf84c6)"},{"line_number":25,"context_line":"(cherry picked from commit 2d98d7c6c241701d5f82cb8031fa738618ebb915)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_c4f10d98","line":25,"range":{"start_line":25,"start_character":27,"end_line":25,"end_character":67},"updated":"2020-06-10 16:14:31.000000000","message":"This isn\u0027t valid. You want\n\n1caddc4250b4acbdb8a945c8f26a0792bee5e2ed","commit_id":"bb8a5415d024f77412711da11c46e34591bf6782"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1c4473bf802ef64bca352bc95aa6b575887f1954","unresolved":false,"context_lines":[{"line_number":19,"context_line":"the issue the warning is just noise and many operators"},{"line_number":20,"context_line":"and customers find it to be off-putting."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Changes:"},{"line_number":23,"context_line":"  The rabbit_heartbeat_filter function has been converted"},{"line_number":24,"context_line":"  to a subclass of logging.filter to support python 2."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I642b1e3ed6de2be4dcc19fe214f84095d2e1d31a"},{"line_number":27,"context_line":"Closes-Bug: #1825584"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bf51134e_8a2bcd31","line":24,"range":{"start_line":22,"start_character":0,"end_line":24,"end_character":54},"updated":"2020-07-17 17:59:45.000000000","message":"I meant if you were doing this, to just list the changed files (replicating the \u0027Conflicts:\u0027 section we normally have. Since there\u0027s only one change here, you don\u0027t really need that either","commit_id":"56466a33deba38c806ad85866e8d75dafca9b331"}],"nova/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dce8aaf48a08cb6349174bb0d32c73436488bf08","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    # but we handle both form to allow this to be backported"},{"line_number":40,"context_line":"    # without consideration of the version of oslo.messaging used."},{"line_number":41,"context_line":"    # TODO(sean-k-mooney): remove support for typo in follow up"},{"line_number":42,"context_line":"    # to allow this to be easily backported without modification."},{"line_number":43,"context_line":"    messages \u003d ["},{"line_number":44,"context_line":"        \"Unexpected error during heartbeart thread processing\","},{"line_number":45,"context_line":"        \"Unexpected error during heartbeat thread processing\"]"},{"line_number":46,"context_line":"    return not any(msg in log_record.msg for msg in messages)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def parse_args(argv, default_config_files\u003dNone, configure_db\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_ee8540b0","line":46,"range":{"start_line":42,"start_character":0,"end_line":46,"end_character":61},"updated":"2020-07-17 15:54:21.000000000","message":"stephen and lee fount that this construction of a filter is supproted on python 3 only\n\nin python 2 this has to be a subclass with a filter method.\nill adress this after dinner.","commit_id":"99c8022ab6b2a2198d594cfca6a471c5b4bfefe0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1c4473bf802ef64bca352bc95aa6b575887f1954","unresolved":false,"context_lines":[{"line_number":32,"context_line":"CONF \u003d nova.conf.CONF"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# NOTE(sean-k-mooney): in python 3 log filters can"},{"line_number":36,"context_line":"# simply be a function that returns true or false and accepts"},{"line_number":37,"context_line":"# single argument which is the record to filter."},{"line_number":38,"context_line":"# To support python 3 the rabbit_heartbeat_filter has been"},{"line_number":39,"context_line":"# converted into an instance of a new  HeartbeatFilter"},{"line_number":40,"context_line":"# class with its implementation moved to the filter method."},{"line_number":41,"context_line":"# this is otherwise unchanged."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class HeartbeatFilter(logging.Filter):"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_2a68c185","line":41,"range":{"start_line":35,"start_character":0,"end_line":41,"end_character":30},"updated":"2020-07-17 17:59:45.000000000","message":"I meant put this into the commit message :)","commit_id":"56466a33deba38c806ad85866e8d75dafca9b331"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"11d0eeb610bc829ab96b2a0f670faf2239044785","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \"Unexpected error during heartbeat thread processing\"]"},{"line_number":55,"context_line":"        return not any(msg in record.msg for msg in messages)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"rabbit_heartbeat_filter \u003d HeartbeatFilter()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def parse_args(argv, default_config_files\u003dNone, configure_db\u003dTrue,"},{"line_number":60,"context_line":"               init_rpc\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_39d8191d","line":57,"updated":"2020-07-18 01:13:30.000000000","message":"pep8: E305 expected 2 blank lines after class or function definition, found 1","commit_id":"56466a33deba38c806ad85866e8d75dafca9b331"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1c4473bf802ef64bca352bc95aa6b575887f1954","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return not any(msg in record.msg for msg in messages)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"rabbit_heartbeat_filter \u003d HeartbeatFilter()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def parse_args(argv, default_config_files\u003dNone, configure_db\u003dTrue,"},{"line_number":60,"context_line":"               init_rpc\u003dTrue):"},{"line_number":61,"context_line":"    log.register_options(CONF)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_ca0ca5ee","line":58,"updated":"2020-07-17 17:59:45.000000000","message":"I think you\u0027ll need a newline here, but I could be wrong","commit_id":"56466a33deba38c806ad85866e8d75dafca9b331"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e756fdc0daa563886c7f43cf512497a6ee8a9889","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return not any(msg in record.msg for msg in messages)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"rabbit_heartbeat_filter \u003d HeartbeatFilter()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def parse_args(argv, default_config_files\u003dNone, configure_db\u003dTrue,"},{"line_number":60,"context_line":"               init_rpc\u003dTrue):"},{"line_number":61,"context_line":"    log.register_options(CONF)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_14b070dd","line":58,"in_reply_to":"bf51134e_ca0ca5ee","updated":"2020-07-20 10:29:30.000000000","message":"nope your right ills fix this up now and rework the stine version too","commit_id":"56466a33deba38c806ad85866e8d75dafca9b331"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"11d0eeb610bc829ab96b2a0f670faf2239044785","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"rabbit_heartbeat_filter \u003d HeartbeatFilter()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def parse_args(argv, default_config_files\u003dNone, configure_db\u003dTrue,"},{"line_number":60,"context_line":"               init_rpc\u003dTrue):"},{"line_number":61,"context_line":"    log.register_options(CONF)"},{"line_number":62,"context_line":"    # We use the oslo.log default log levels which includes suds\u003dINFO"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_19d555e6","line":59,"updated":"2020-07-18 01:13:30.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"56466a33deba38c806ad85866e8d75dafca9b331"}]}
