)]}'
{"doc/source/user/flavors.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40ee312ea86bf0fcb67b7340911b590f34fff8f2","unresolved":false,"context_lines":[{"line_number":467,"context_line":"  .. note::"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"     The ``hw:cpu_dedicated_mask`` option is only valid if ``hw:cpu_policy``"},{"line_number":470,"context_line":"     is set to ``mixed``, and cannot be configured with"},{"line_number":471,"context_line":"     ``hw:cpu_realtime_mask`` at the same time."},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"  Valid CPU-THREAD-POLICY values are:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_8b6676ec","line":470,"range":{"start_line":470,"start_character":24,"end_line":470,"end_character":25},"updated":"2020-07-14 11:09:29.000000000","message":"drop","commit_id":"40e5129a0f3c6ebfff6fecab479cb9bfbc93945c"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"afa4384dd7fc8f3e63ae95d14297a1807845b2a5","unresolved":false,"context_lines":[{"line_number":467,"context_line":"  .. note::"},{"line_number":468,"context_line":""},{"line_number":469,"context_line":"     The ``hw:cpu_dedicated_mask`` option is only valid if ``hw:cpu_policy``"},{"line_number":470,"context_line":"     is set to ``mixed``, and cannot be configured with"},{"line_number":471,"context_line":"     ``hw:cpu_realtime_mask`` at the same time."},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"  Valid CPU-THREAD-POLICY values are:"}],"source_content_type":"text/x-rst","patch_set":8,"id":"bf51134e_6fe159d0","line":470,"range":{"start_line":470,"start_character":24,"end_line":470,"end_character":25},"in_reply_to":"bf51134e_8b6676ec","updated":"2020-07-15 14:13:40.000000000","message":"Done","commit_id":"40e5129a0f3c6ebfff6fecab479cb9bfbc93945c"}],"nova/exception.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"8644fdf4447791622b8ac7a8778b8f75ef920a7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2010 United States Government as represented by the"},{"line_number":2,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf51134e_61166c58","line":1,"updated":"2020-07-17 05:31:53.000000000","message":"pep8: E902 TokenError: EOF in multi-line statement","commit_id":"64211d82bdc318884ed60a062091aa6f1c100255"}],"nova/scheduler/utils.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c227916778f29c787196e861e445528c9df8f86a","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                dedicated_cpus \u003d hardware.get_dedicated_cpu_constraint(flavor)"},{"line_number":274,"context_line":"                realtime_cpus \u003d hardware.get_realtime_cpu_constraint(flavor,"},{"line_number":275,"context_line":"                                                                     image)"},{"line_number":276,"context_line":"                if (dedicated_cpus and realtime_cpus or"},{"line_number":277,"context_line":"                        not (dedicated_cpus or realtime_cpus)):"},{"line_number":278,"context_line":"                    raise exception.RequiredMixedOrRealtimeCPUMask"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                pcpus \u003d len(realtime_cpus or dedicated_cpus)"},{"line_number":281,"context_line":"                vcpus \u003d flavor.vcpus - pcpus"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_23a22a4c","line":278,"range":{"start_line":276,"start_character":0,"end_line":278,"end_character":66},"updated":"2020-06-22 17:01:24.000000000","message":"This is definitely somewhere where we\u0027d benefit from exception with unique messages. Failing because we have both configured is quite different from failing because both are configured.\n\nLater: Actually, as I said in an earlier PS, I don\u0027t think you need this check. We\u0027ll have already validated things at the API level so this can\u0027t get here","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"f3e770addde53c6d60e13429c10fa18762331c43","unresolved":false,"context_lines":[{"line_number":275,"context_line":"                                                                     image)"},{"line_number":276,"context_line":"                if (dedicated_cpus and realtime_cpus or"},{"line_number":277,"context_line":"                        not (dedicated_cpus or realtime_cpus)):"},{"line_number":278,"context_line":"                    raise exception.RequiredMixedOrRealtimeCPUMask"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"                pcpus \u003d len(realtime_cpus or dedicated_cpus)"},{"line_number":281,"context_line":"                vcpus \u003d flavor.vcpus - pcpus"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_65368353","line":278,"updated":"2020-06-29 13:46:58.000000000","message":"Yes. This check have been performed in the API level in formating an instance object, it\u0027s over checked.\nDropped this check.","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"}],"nova/tests/unit/scheduler/test_utils.py":[{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"f3e770addde53c6d60e13429c10fa18762331c43","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"        self.assertResourceRequestsEqual(expected, rr)"},{"line_number":1102,"context_line":"        self.assertFalse(rr.cpu_pinning_requested)"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    def test_resource_request_init_with_mixed_cpus_dedicated(self):"},{"line_number":1105,"context_line":"        extra_specs \u003d {"},{"line_number":1106,"context_line":"            \u0027hw:cpu_policy\u0027: \u0027mixed\u0027,"},{"line_number":1107,"context_line":"            \u0027hw:cpu_dedicated_mask\u0027: \u00272,3\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_8533d761","line":1104,"updated":"2020-06-29 13:46:58.000000000","message":"Yes, I am aware of this requirement.\nDone.","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c227916778f29c787196e861e445528c9df8f86a","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"        self.assertResourceRequestsEqual(expected, rr)"},{"line_number":1102,"context_line":"        self.assertFalse(rr.cpu_pinning_requested)"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"    def test_resource_request_init_with_mixed_cpus_dedicated(self):"},{"line_number":1105,"context_line":"        extra_specs \u003d {"},{"line_number":1106,"context_line":"            \u0027hw:cpu_policy\u0027: \u0027mixed\u0027,"},{"line_number":1107,"context_line":"            \u0027hw:cpu_dedicated_mask\u0027: \u00272,3\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_43b63e8c","line":1104,"updated":"2020-06-22 17:01:24.000000000","message":"docstring, please\n\n(are you seeing a trend here? :))","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40ee312ea86bf0fcb67b7340911b590f34fff8f2","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"        self._test_resource_request_init_with_mixed_cpus(extra_specs)"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"    def test_resource_request_init_with_mixed_cpus_realtime(self):"},{"line_number":1114,"context_line":"        \"\"\"TODO: docstring here\"\"\""},{"line_number":1115,"context_line":"        extra_specs \u003d {"},{"line_number":1116,"context_line":"            \u0027hw:cpu_policy\u0027: \u0027mixed\u0027,"},{"line_number":1117,"context_line":"            \"hw:cpu_realtime\": \"yes\","}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_cb5cee1a","line":1114,"range":{"start_line":1114,"start_character":8,"end_line":1114,"end_character":34},"updated":"2020-07-14 11:09:29.000000000","message":"TODO","commit_id":"40e5129a0f3c6ebfff6fecab479cb9bfbc93945c"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"afa4384dd7fc8f3e63ae95d14297a1807845b2a5","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"        self._test_resource_request_init_with_mixed_cpus(extra_specs)"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"    def test_resource_request_init_with_mixed_cpus_realtime(self):"},{"line_number":1114,"context_line":"        \"\"\"TODO: docstring here\"\"\""},{"line_number":1115,"context_line":"        extra_specs \u003d {"},{"line_number":1116,"context_line":"            \u0027hw:cpu_policy\u0027: \u0027mixed\u0027,"},{"line_number":1117,"context_line":"            \"hw:cpu_realtime\": \"yes\","}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_f51d360f","line":1114,"range":{"start_line":1114,"start_character":8,"end_line":1114,"end_character":34},"in_reply_to":"bf51134e_cb5cee1a","updated":"2020-07-15 14:13:40.000000000","message":"Done","commit_id":"40e5129a0f3c6ebfff6fecab479cb9bfbc93945c"}],"nova/virt/hardware.py":[{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"f3e770addde53c6d60e13429c10fa18762331c43","unresolved":false,"context_lines":[{"line_number":1977,"context_line":"            raise exception.RequiredMixedInstancePolicy"},{"line_number":1978,"context_line":"        # But for an instance with \u0027dedicated\u0027 CPU allocation policy, all"},{"line_number":1979,"context_line":"        # CPUs are \u0027dedicated\u0027 CPUs, which is 1:1 pinned to a host CPU."},{"line_number":1980,"context_line":"        dedicated_cpus \u003d set(range(flavor.vcpus))"},{"line_number":1981,"context_line":"    else:  # MIXED"},{"line_number":1982,"context_line":"        if (realtime_cpus and dedicated_cpus or"},{"line_number":1983,"context_line":"                not (realtime_cpus or dedicated_cpus)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_c5402fa8","line":1980,"updated":"2020-06-29 13:46:58.000000000","message":"I am aware of some problem existed for code here and in this[1] place.\n\nIf I set the \u0027dedicated_cpus\u0027 when \u0027realtime_cpus\u0027 is unset, then the \u0027pcups\u0027 got in place [1] is the CPU number of realtime_cpus, which is less than \u0027flavor.vcpus\u0027. This is problematic that we request to create a DEDICATED instance, but creates a MIXED instance. I\u0027d like to swap the order of setting \u0027pcpus\u0027 in [1].\n\n     pcpus \u003d dedicated_cpus or realtime_cpus\n\nIf it is a dedicated instance, whatever it has any realtime CPU or not, the \u0027dedicated_cpus\u0027 suppress the \u0027realtime_cpus\u0027 and all vCPUs are PCPUs. and the realtime policy will be handled in later by hypervisor driver if it is a realtime instance.\n\nIf it is a mixed instance, we are ensured that either dedicated or realtime CPU list is defined, not both.","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c227916778f29c787196e861e445528c9df8f86a","unresolved":false,"context_lines":[{"line_number":1975,"context_line":"        # \u0027dedicated\u0027 policy."},{"line_number":1976,"context_line":"        if dedicated_cpus is not None:"},{"line_number":1977,"context_line":"            raise exception.RequiredMixedInstancePolicy"},{"line_number":1978,"context_line":"        # But for an instance with \u0027dedicated\u0027 CPU allocation policy, all"},{"line_number":1979,"context_line":"        # CPUs are \u0027dedicated\u0027 CPUs, which is 1:1 pinned to a host CPU."},{"line_number":1980,"context_line":"        dedicated_cpus \u003d set(range(flavor.vcpus))"},{"line_number":1981,"context_line":"    else:  # MIXED"},{"line_number":1982,"context_line":"        if (realtime_cpus and dedicated_cpus or"},{"line_number":1983,"context_line":"                not (realtime_cpus or dedicated_cpus)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_a3291a9c","line":1980,"range":{"start_line":1978,"start_character":0,"end_line":1980,"end_character":49},"updated":"2020-06-22 17:01:24.000000000","message":"I\u0027d prefer if we only set this if realtime_cpus is unset. Otherwise, this is a bit of lie as it will be ignored.","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"99f767dd78a6b44e815d3dde2d17cf3319ac9e9a","unresolved":false,"context_lines":[{"line_number":1977,"context_line":"            raise exception.RequiredMixedInstancePolicy"},{"line_number":1978,"context_line":"        # But for an instance with \u0027dedicated\u0027 CPU allocation policy, all"},{"line_number":1979,"context_line":"        # CPUs are \u0027dedicated\u0027 CPUs, which is 1:1 pinned to a host CPU."},{"line_number":1980,"context_line":"        dedicated_cpus \u003d set(range(flavor.vcpus))"},{"line_number":1981,"context_line":"    else:  # MIXED"},{"line_number":1982,"context_line":"        if (realtime_cpus and dedicated_cpus or"},{"line_number":1983,"context_line":"                not (realtime_cpus or dedicated_cpus)):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_9e696426","line":1980,"in_reply_to":"bf51134e_c5402fa8","updated":"2020-06-29 16:40:14.000000000","message":"Okay, I understand now. So if we request a DEDICATED policy, then pcpus \u003d\u003d range(flavor.vcpus), and if we request MIXED policy then pcpus \u003d\u003d range(rt_cpus). Right? If so, let\u0027s keep this but change the next conditional (MIXED). See below.","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c227916778f29c787196e861e445528c9df8f86a","unresolved":false,"context_lines":[{"line_number":1979,"context_line":"        # CPUs are \u0027dedicated\u0027 CPUs, which is 1:1 pinned to a host CPU."},{"line_number":1980,"context_line":"        dedicated_cpus \u003d set(range(flavor.vcpus))"},{"line_number":1981,"context_line":"    else:  # MIXED"},{"line_number":1982,"context_line":"        if (realtime_cpus and dedicated_cpus or"},{"line_number":1983,"context_line":"                not (realtime_cpus or dedicated_cpus)):"},{"line_number":1984,"context_line":"            raise exception.RequiredMixedOrRealtimeCPUMask"},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"    # TODO(huaqiang): Removed once we don\u0027t worry about the \u0027mixed\u0027 instance"},{"line_number":1987,"context_line":"    # upgrade problem."}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_a302ba09","line":1984,"range":{"start_line":1982,"start_character":0,"end_line":1984,"end_character":58},"updated":"2020-06-22 17:01:24.000000000","message":"Can you make this two separate checks with separate error messages, please?","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"f3e770addde53c6d60e13429c10fa18762331c43","unresolved":false,"context_lines":[{"line_number":1981,"context_line":"    else:  # MIXED"},{"line_number":1982,"context_line":"        if (realtime_cpus and dedicated_cpus or"},{"line_number":1983,"context_line":"                not (realtime_cpus or dedicated_cpus)):"},{"line_number":1984,"context_line":"            raise exception.RequiredMixedOrRealtimeCPUMask"},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"    # TODO(huaqiang): Removed once we don\u0027t worry about the \u0027mixed\u0027 instance"},{"line_number":1987,"context_line":"    # upgrade problem."}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_a53b7b35","line":1984,"updated":"2020-06-29 13:46:58.000000000","message":"Sure, I\u0027d like to.","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"99f767dd78a6b44e815d3dde2d17cf3319ac9e9a","unresolved":false,"context_lines":[{"line_number":1982,"context_line":"        if (realtime_cpus and dedicated_cpus or"},{"line_number":1983,"context_line":"                not (realtime_cpus or dedicated_cpus)):"},{"line_number":1984,"context_line":"            raise exception.RequiredMixedOrRealtimeCPUMask"},{"line_number":1985,"context_line":""},{"line_number":1986,"context_line":"    # TODO(huaqiang): Removed once we don\u0027t worry about the \u0027mixed\u0027 instance"},{"line_number":1987,"context_line":"    # upgrade problem."},{"line_number":1988,"context_line":"    if (cpu_policy \u003d\u003d fields.CPUAllocationPolicy.MIXED and"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_7e445074","line":1985,"updated":"2020-06-29 16:40:14.000000000","message":"Would it make sense to add this line here?\n\n  # NOTE(huaquiang): If using mixed with realtime, then cores listed\n  # in the realtime mask are dedicated and everything else is\n  # shared\n  dedicated_cpus \u003d dedicated_cpus or realtime_cpus\n\nIf we do, we can change line 2008 below to:\n\n  pcpus \u003d dedicated_cpus","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"f3e770addde53c6d60e13429c10fa18762331c43","unresolved":false,"context_lines":[{"line_number":2004,"context_line":"        fields.CPUAllocationPolicy.DEDICATED,"},{"line_number":2005,"context_line":"        fields.CPUAllocationPolicy.MIXED,"},{"line_number":2006,"context_line":"    ):"},{"line_number":2007,"context_line":"        cpus \u003d set(range(flavor.vcpus))"},{"line_number":2008,"context_line":"        pcpus \u003d realtime_cpus or dedicated_cpus or set()"},{"line_number":2009,"context_line":"        vcpus \u003d cpus - pcpus"},{"line_number":2010,"context_line":"        nodes \u003d nodes or 1"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_0547c7bd","line":2007,"updated":"2020-06-29 13:46:58.000000000","message":"[1] this place ...","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"f3e770addde53c6d60e13429c10fa18762331c43","unresolved":false,"context_lines":[{"line_number":2005,"context_line":"        fields.CPUAllocationPolicy.MIXED,"},{"line_number":2006,"context_line":"    ):"},{"line_number":2007,"context_line":"        cpus \u003d set(range(flavor.vcpus))"},{"line_number":2008,"context_line":"        pcpus \u003d realtime_cpus or dedicated_cpus or set()"},{"line_number":2009,"context_line":"        vcpus \u003d cpus - pcpus"},{"line_number":2010,"context_line":"        nodes \u003d nodes or 1"},{"line_number":2011,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_4516dfa9","line":2008,"updated":"2020-06-29 13:46:58.000000000","message":"Done.","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c227916778f29c787196e861e445528c9df8f86a","unresolved":false,"context_lines":[{"line_number":2005,"context_line":"        fields.CPUAllocationPolicy.MIXED,"},{"line_number":2006,"context_line":"    ):"},{"line_number":2007,"context_line":"        cpus \u003d set(range(flavor.vcpus))"},{"line_number":2008,"context_line":"        pcpus \u003d realtime_cpus or dedicated_cpus or set()"},{"line_number":2009,"context_line":"        vcpus \u003d cpus - pcpus"},{"line_number":2010,"context_line":"        nodes \u003d nodes or 1"},{"line_number":2011,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_ce055513","line":2008,"range":{"start_line":2008,"start_character":47,"end_line":2008,"end_character":56},"updated":"2020-06-22 17:01:24.000000000","message":"as noted earlier, this should never be triggered and can be removed","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"f3e770addde53c6d60e13429c10fa18762331c43","unresolved":false,"context_lines":[{"line_number":2005,"context_line":"        fields.CPUAllocationPolicy.MIXED,"},{"line_number":2006,"context_line":"    ):"},{"line_number":2007,"context_line":"        cpus \u003d set(range(flavor.vcpus))"},{"line_number":2008,"context_line":"        pcpus \u003d realtime_cpus or dedicated_cpus or set()"},{"line_number":2009,"context_line":"        vcpus \u003d cpus - pcpus"},{"line_number":2010,"context_line":"        nodes \u003d nodes or 1"},{"line_number":2011,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_e541f3a7","line":2008,"updated":"2020-06-29 13:46:58.000000000","message":"pcpus \u003d dedicated_cpus or realtime_cpus","commit_id":"98a0ec3632b79fab5b27c4d21c24d1c09bfe7614"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"240057f5d7ff1a0fa3aa166fa3c3ba167a7d032b","unresolved":false,"context_lines":[{"line_number":2004,"context_line":"        # which will be used later to calculate the per-NUMA-cell CPU set."},{"line_number":2005,"context_line":"        cpus \u003d set(range(flavor.vcpus))"},{"line_number":2006,"context_line":"        pcpus \u003d dedicated_cpus"},{"line_number":2007,"context_line":"        vcpus \u003d cpus - pcpus"},{"line_number":2008,"context_line":""},{"line_number":2009,"context_line":"        nodes \u003d nodes or 1"},{"line_number":2010,"context_line":"        cpu_list \u003d _get_numa_cpu_constraint(flavor, image_meta)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_f82478b1","line":2007,"updated":"2020-07-08 11:43:40.000000000","message":"Done","commit_id":"e37a336b22242548f333152afb0c5506f3302f3a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"82b6ac8ca05877726afb153dc8eab6ae7fa24e7a","unresolved":false,"context_lines":[{"line_number":2004,"context_line":"        # which will be used later to calculate the per-NUMA-cell CPU set."},{"line_number":2005,"context_line":"        cpus \u003d set(range(flavor.vcpus))"},{"line_number":2006,"context_line":"        pcpus \u003d dedicated_cpus"},{"line_number":2007,"context_line":"        vcpus \u003d cpus - pcpus"},{"line_number":2008,"context_line":""},{"line_number":2009,"context_line":"        nodes \u003d nodes or 1"},{"line_number":2010,"context_line":"        cpu_list \u003d _get_numa_cpu_constraint(flavor, image_meta)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_42382a3c","line":2007,"updated":"2020-07-07 10:05:34.000000000","message":"pep8: error: Unsupported operand types for - (\"Set[int]\" and \"None\")","commit_id":"e37a336b22242548f333152afb0c5506f3302f3a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"82b6ac8ca05877726afb153dc8eab6ae7fa24e7a","unresolved":false,"context_lines":[{"line_number":2004,"context_line":"        # which will be used later to calculate the per-NUMA-cell CPU set."},{"line_number":2005,"context_line":"        cpus \u003d set(range(flavor.vcpus))"},{"line_number":2006,"context_line":"        pcpus \u003d dedicated_cpus"},{"line_number":2007,"context_line":"        vcpus \u003d cpus - pcpus"},{"line_number":2008,"context_line":""},{"line_number":2009,"context_line":"        nodes \u003d nodes or 1"},{"line_number":2010,"context_line":"        cpu_list \u003d _get_numa_cpu_constraint(flavor, image_meta)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_a23e6626","line":2007,"updated":"2020-07-07 10:05:34.000000000","message":"pep8: note: Right operand is of type \"Optional[Set[int]]\"","commit_id":"e37a336b22242548f333152afb0c5506f3302f3a"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"240057f5d7ff1a0fa3aa166fa3c3ba167a7d032b","unresolved":false,"context_lines":[{"line_number":2012,"context_line":""},{"line_number":2013,"context_line":"        if cpu_list is None and mem_list is None:"},{"line_number":2014,"context_line":"            numa_topology \u003d _get_numa_topology_auto("},{"line_number":2015,"context_line":"                nodes, flavor, vcpus, pcpus,"},{"line_number":2016,"context_line":"            )"},{"line_number":2017,"context_line":"        elif cpu_list is not None and mem_list is not None:"},{"line_number":2018,"context_line":"            # If any node has data set, all nodes must have data set"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_583be4cf","line":2015,"updated":"2020-07-08 11:43:40.000000000","message":"Done","commit_id":"e37a336b22242548f333152afb0c5506f3302f3a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"82b6ac8ca05877726afb153dc8eab6ae7fa24e7a","unresolved":false,"context_lines":[{"line_number":2012,"context_line":""},{"line_number":2013,"context_line":"        if cpu_list is None and mem_list is None:"},{"line_number":2014,"context_line":"            numa_topology \u003d _get_numa_topology_auto("},{"line_number":2015,"context_line":"                nodes, flavor, vcpus, pcpus,"},{"line_number":2016,"context_line":"            )"},{"line_number":2017,"context_line":"        elif cpu_list is not None and mem_list is not None:"},{"line_number":2018,"context_line":"            # If any node has data set, all nodes must have data set"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_8239a240","line":2015,"updated":"2020-07-07 10:05:34.000000000","message":"pep8: error: Argument 4 to \"_get_numa_topology_auto\" has incompatible type \"Optional[Set[int]]\"; expected \"Set[int]\"","commit_id":"e37a336b22242548f333152afb0c5506f3302f3a"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"240057f5d7ff1a0fa3aa166fa3c3ba167a7d032b","unresolved":false,"context_lines":[{"line_number":2020,"context_line":"                raise exception.ImageNUMATopologyIncomplete()"},{"line_number":2021,"context_line":""},{"line_number":2022,"context_line":"            numa_topology \u003d _get_numa_topology_manual("},{"line_number":2023,"context_line":"                nodes, flavor, vcpus, pcpus, cpu_list, mem_list"},{"line_number":2024,"context_line":"            )"},{"line_number":2025,"context_line":"        else:"},{"line_number":2026,"context_line":"            # If one property list is specified both must be"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_3836f0e8","line":2023,"updated":"2020-07-08 11:43:40.000000000","message":"Done","commit_id":"e37a336b22242548f333152afb0c5506f3302f3a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"82b6ac8ca05877726afb153dc8eab6ae7fa24e7a","unresolved":false,"context_lines":[{"line_number":2020,"context_line":"                raise exception.ImageNUMATopologyIncomplete()"},{"line_number":2021,"context_line":""},{"line_number":2022,"context_line":"            numa_topology \u003d _get_numa_topology_manual("},{"line_number":2023,"context_line":"                nodes, flavor, vcpus, pcpus, cpu_list, mem_list"},{"line_number":2024,"context_line":"            )"},{"line_number":2025,"context_line":"        else:"},{"line_number":2026,"context_line":"            # If one property list is specified both must be"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_e2485ecd","line":2023,"updated":"2020-07-07 10:05:34.000000000","message":"pep8: error: Argument 4 to \"_get_numa_topology_manual\" has incompatible type \"Optional[Set[int]]\"; expected \"Set[int]\"","commit_id":"e37a336b22242548f333152afb0c5506f3302f3a"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"c054aec9f6c3a47eac0e97f61b583311c87ff16b","unresolved":false,"context_lines":[{"line_number":1970,"context_line":"            raise exception.RequiredMixedInstancePolicy()"},{"line_number":1971,"context_line":"    else:  # MIXED"},{"line_number":1972,"context_line":"        if realtime_cpus and dedicated_cpus:"},{"line_number":1973,"context_line":"            raise exception.RequiredMixedOrRealtimeCPUMask()"},{"line_number":1974,"context_line":""},{"line_number":1975,"context_line":"        if not (realtime_cpus or dedicated_cpus):"},{"line_number":1976,"context_line":"            raise exception.RequiredMixedOrRealtimeCPUMask()"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf51134e_213914a3","line":1973,"updated":"2020-07-17 03:59:59.000000000","message":"Done.","commit_id":"ec8fca409f6d70a0a49b4d455df946831a3fd409"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a09d67105b45f2a5729a5383c1706412afbea196","unresolved":false,"context_lines":[{"line_number":1970,"context_line":"            raise exception.RequiredMixedInstancePolicy()"},{"line_number":1971,"context_line":"    else:  # MIXED"},{"line_number":1972,"context_line":"        if realtime_cpus and dedicated_cpus:"},{"line_number":1973,"context_line":"            raise exception.RequiredMixedOrRealtimeCPUMask()"},{"line_number":1974,"context_line":""},{"line_number":1975,"context_line":"        if not (realtime_cpus or dedicated_cpus):"},{"line_number":1976,"context_line":"            raise exception.RequiredMixedOrRealtimeCPUMask()"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf51134e_2475b432","line":1973,"range":{"start_line":1973,"start_character":17,"end_line":1973,"end_character":60},"updated":"2020-07-16 08:09:20.000000000","message":"so it means we don\u0027t support specify both realtime and dedicated mask? if yes, we probaly need an new exception, otherwise, the error message to the user is confused.","commit_id":"ec8fca409f6d70a0a49b4d455df946831a3fd409"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"93251f40e29451076914eba55cefa2d23ead2023","unresolved":false,"context_lines":[{"line_number":1970,"context_line":"            raise exception.RequiredMixedInstancePolicy()"},{"line_number":1971,"context_line":"    else:  # MIXED"},{"line_number":1972,"context_line":"        if realtime_cpus and dedicated_cpus:"},{"line_number":1973,"context_line":"            raise exception.RequiredMixedOrRealtimeCPUMask()"},{"line_number":1974,"context_line":""},{"line_number":1975,"context_line":"        if not (realtime_cpus or dedicated_cpus):"},{"line_number":1976,"context_line":"            raise exception.RequiredMixedOrRealtimeCPUMask()"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf51134e_be6d2fce","line":1973,"updated":"2020-07-17 22:14:57.000000000","message":"Looks like Alex\u0027s comment is still unresolved? [1]\n\nLater: never mind, I see you changed the exception string. Thanks!\n\nhttps://review.opendev.org/#/c/728485/9/nova/virt/hardware.py@1973","commit_id":"61c3173d3d7857458dda5aac9adbbcd27c17e8a2"}]}