)]}'
{"nova/tests/unit/virt/test_hardware.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f6de888c8244017e910cd10cbe217dbe12c3e2b9","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        for topo_test in testdata:"},{"line_number":393,"context_line":"            image_meta \u003d objects.ImageMeta.from_dict(topo_test[\"image\"])"},{"line_number":394,"context_line":"            if type(topo_test[\"expect\"]) \u003d\u003d tuple:"},{"line_number":395,"context_line":"                (preferred, maximum) \u003d hw.get_cpu_topology_constraints("},{"line_number":396,"context_line":"                    topo_test[\"flavor\"], image_meta)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"                self.assertEqual(topo_test[\"expect\"][0], preferred.sockets)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_ba3c8d2f","line":395,"range":{"start_line":395,"start_character":16,"end_line":395,"end_character":36},"updated":"2020-05-18 13:02:42.000000000","message":"nit: can you drop these brackets? You don\u0027t need them since Python automatically packs/unpacks tuples","commit_id":"cdbdaf1a02f2c6b2ad0c4663df51cc65399dfc24"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"835ffffff6f6299446367dcf571c181e096fceeb","unresolved":false,"context_lines":[{"line_number":392,"context_line":"        for topo_test in testdata:"},{"line_number":393,"context_line":"            image_meta \u003d objects.ImageMeta.from_dict(topo_test[\"image\"])"},{"line_number":394,"context_line":"            if type(topo_test[\"expect\"]) \u003d\u003d tuple:"},{"line_number":395,"context_line":"                (preferred, maximum) \u003d hw.get_cpu_topology_constraints("},{"line_number":396,"context_line":"                    topo_test[\"flavor\"], image_meta)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"                self.assertEqual(topo_test[\"expect\"][0], preferred.sockets)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_5aed3fb5","line":395,"range":{"start_line":395,"start_character":16,"end_line":395,"end_character":36},"in_reply_to":"ff570b3c_ba3c8d2f","updated":"2020-05-20 08:33:06.000000000","message":"Sure. The brackets here are redundant.","commit_id":"cdbdaf1a02f2c6b2ad0c4663df51cc65399dfc24"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f6de888c8244017e910cd10cbe217dbe12c3e2b9","unresolved":false,"context_lines":[{"line_number":786,"context_line":"                            cpu_topology\u003dobjects.VirtCPUTopology("},{"line_number":787,"context_line":"                                sockets\u003d1, cores\u003d1, threads\u003d2)),"},{"line_number":788,"context_line":"                        objects.InstanceNUMACell("},{"line_number":789,"context_line":"                            id\u003d1, cpuset\u003dset([2, 3]), memory\u003d1024)"},{"line_number":790,"context_line":"                    ]"},{"line_number":791,"context_line":"                ),"},{"line_number":792,"context_line":"                \"expect\": [1, 2, 2]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_7a1035a9","line":789,"updated":"2020-05-18 13:02:42.000000000","message":"nit: trailing commas after this would be nice (here and elsewhere)","commit_id":"cdbdaf1a02f2c6b2ad0c4663df51cc65399dfc24"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"835ffffff6f6299446367dcf571c181e096fceeb","unresolved":false,"context_lines":[{"line_number":786,"context_line":"                            cpu_topology\u003dobjects.VirtCPUTopology("},{"line_number":787,"context_line":"                                sockets\u003d1, cores\u003d1, threads\u003d2)),"},{"line_number":788,"context_line":"                        objects.InstanceNUMACell("},{"line_number":789,"context_line":"                            id\u003d1, cpuset\u003dset([2, 3]), memory\u003d1024)"},{"line_number":790,"context_line":"                    ]"},{"line_number":791,"context_line":"                ),"},{"line_number":792,"context_line":"                \"expect\": [1, 2, 2]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_1a3c672d","line":789,"in_reply_to":"ff570b3c_7a1035a9","updated":"2020-05-20 08:33:06.000000000","message":"Sure. I\u0027ll fix them.","commit_id":"cdbdaf1a02f2c6b2ad0c4663df51cc65399dfc24"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f6de888c8244017e910cd10cbe217dbe12c3e2b9","unresolved":false,"context_lines":[{"line_number":806,"context_line":"                \"numa_topology\": objects.InstanceNUMATopology("},{"line_number":807,"context_line":"                    cells\u003d["},{"line_number":808,"context_line":"                        objects.InstanceNUMACell("},{"line_number":809,"context_line":"                            id\u003d0, cpuset\u003dset([0, 1, 2, 3]), memory\u003d2048,"},{"line_number":810,"context_line":"                            cpu_topology\u003dobjects.VirtCPUTopology("},{"line_number":811,"context_line":"                                sockets\u003d1, cores\u003d1, threads\u003d4))"},{"line_number":812,"context_line":"                    ]"},{"line_number":813,"context_line":"                ),"},{"line_number":814,"context_line":"                \"expect\": [2, 1, 2]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_158f4a75","line":811,"range":{"start_line":809,"start_character":0,"end_line":811,"end_character":63},"updated":"2020-05-18 13:02:42.000000000","message":"nit: life will be much easier for you in a future change if you put these on separate lines (here and elsewhere)","commit_id":"cdbdaf1a02f2c6b2ad0c4663df51cc65399dfc24"},{"author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"change_message_id":"835ffffff6f6299446367dcf571c181e096fceeb","unresolved":false,"context_lines":[{"line_number":806,"context_line":"                \"numa_topology\": objects.InstanceNUMATopology("},{"line_number":807,"context_line":"                    cells\u003d["},{"line_number":808,"context_line":"                        objects.InstanceNUMACell("},{"line_number":809,"context_line":"                            id\u003d0, cpuset\u003dset([0, 1, 2, 3]), memory\u003d2048,"},{"line_number":810,"context_line":"                            cpu_topology\u003dobjects.VirtCPUTopology("},{"line_number":811,"context_line":"                                sockets\u003d1, cores\u003d1, threads\u003d4))"},{"line_number":812,"context_line":"                    ]"},{"line_number":813,"context_line":"                ),"},{"line_number":814,"context_line":"                \"expect\": [2, 1, 2]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_7afc833d","line":811,"range":{"start_line":809,"start_character":0,"end_line":811,"end_character":63},"in_reply_to":"ff570b3c_158f4a75","updated":"2020-05-20 08:33:06.000000000","message":"I would like to move \u0027cpuset\u0027 to a separate line, and later the \u0027pcpuset\u0027 would be put on the same line. \n\nCode would be: \n\n```\nobjects.InstanceNUMACell(\n    id\u003d0, memory\u003d2048,\n    cpuset\u003dset([0, 1, 2, 3]), pcpuset\u003dset()\n    cpu_topology\u003dobjects.VirtCPUTopology(\n        sockets\u003d1, cores\u003d1, threads\u003d4)\n    )\n```\n\nHow do you think?","commit_id":"cdbdaf1a02f2c6b2ad0c4663df51cc65399dfc24"}]}