)]}'
{"id":"openstack%2Fnova~728793","triplet_id":"openstack%2Fnova~master~I81f1af98861a7f26d34348473ec245598ff856a8","project":"openstack/nova","branch":"master","topic":"bp/use-pcpu-and-vcpu-in-one-instance","hashtags":[],"change_id":"I81f1af98861a7f26d34348473ec245598ff856a8","subject":"test_hardware: code formating for multiline construct","status":"MERGED","created":"2020-05-18 08:51:57.000000000","updated":"2020-07-13 15:28:35.000000000","submitted":"2020-07-13 15:21:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"728793-1594653697619-462dbf12","meta_rev_id":"41eee97f6ad15c6628213fbae003b7cb2c42e79d","_number":728793,"virtual_id_number":728793,"owner":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-13 15:21:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-07-10 07:42:17.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"date":"2020-07-10 04:27:20.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"date":"2020-07-10 04:20:50.000000000","_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},{"value":0,"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"date":"2020-07-10 04:40:53.000000000","_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"date":"2020-07-10 04:55:04.000000000","_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2020-07-10 03:45:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},{"value":0,"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2020-07-10 06:53:50.000000000","_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},{"value":0,"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":1,"date":"2020-07-10 06:53:50.000000000","_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"date":"2020-07-13 02:35:24.000000000","_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},{"value":0,"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},{"value":0,"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"value":0,"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"value":0,"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"value":0,"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},{"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-20 09:13:21.000000000","updated_by":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-05-20 09:13:30.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-06-30 10:43:13.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2020-07-03 01:45:13.000000000","updated_by":{"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},"reviewer":{"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},"state":"REVIEWER"},{"updated":"2020-07-09 17:18:26.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-07-10 04:20:50.000000000","updated_by":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-10 04:27:20.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2020-07-10 04:40:53.000000000","updated_by":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-10 04:55:04.000000000","updated_by":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-10 06:53:50.000000000","updated_by":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"reviewer":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"state":"REVIEWER"},{"updated":"2020-07-10 07:42:17.000000000","updated_by":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"reviewer":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"state":"REVIEWER"},{"updated":"2020-07-13 02:35:24.000000000","updated_by":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"reviewer":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"state":"REVIEWER"},{"updated":"2020-07-13 15:21:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a2b10549c1cbb1e624665a3bcb68f39e6f161205","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-05-18 08:51:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"289cf1b1331d04376710fc3b6f2b5e81982dd8cd","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2020-05-18 08:52:39.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1d4416a317659587815c8796ce477f2e84e737dc","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-18 09:26:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5720f69523d14602b9f85d3de4d65b51 : SUCCESS in 22m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8fc9f6f29aef49cfbe6ef7fa1f82fdba : SUCCESS in 15m 43s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b5e59aba623a4cc98a3df46664eefacf : SUCCESS in 8m 00s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d051b7c4cb274ca68c1ccd60daa49cff : SUCCESS in 14m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/62829461c33d47f696fa82da582878e4 : SUCCESS in 12m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/983e3d16f9cd402eb55e9dc41597ded6 : SUCCESS in 11m 12s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/6582d153c0af448ea0e4394d76c35894 : SUCCESS in 16m 49s","accounts_in_message":[],"_revision_number":1},{"id":"9f5b342a000ba94be41c751ace1b62c0adb78043","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2020-05-18 09:27:32.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/93/728793/1/check/EMC_VxFlexOS_NOVA/c3cb283/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":1},{"id":"44b81753d41a95b5fb27db20e528599b8a46e2c6","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-05-18 10:31:08.000000000","message":"Patch Set 1:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-93-728793-1 : SUCCESS \n\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI","accounts_in_message":[],"_revision_number":1},{"id":"e58f326347c4c6a9b24884090c126f89928d5a52","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-05-18 11:08:30.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/728793/1 : SUCCESS in 2h 14m 51s","accounts_in_message":[],"_revision_number":1},{"id":"1b2de31716965bb9a2b94cde9586f80faab58ced","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-05-18 12:24:19.000000000","message":"Patch Set 1:\n\nHi Stephen,\n\nThis patch is to reformat the code of test_hardware.py due to coding style insistence in functions, such as test_topology_constraints. I think you might be interested in this since you have mentioned such kind of refactoring during the review of bp/use-pcpu-and-vcpu-in-one-instance. If you have time, please review.\n\nBr\nHuaqiang","accounts_in_message":[],"_revision_number":1},{"id":"f6de888c8244017e910cd10cbe217dbe12c3e2b9","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-05-18 13:02:42.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nThis seems fine. My only question is whether we should be taking this approach or use the opportunity to switch to DDT as seen at [1]. Would it make sense to combine the two?\n\n[1] https://review.opendev.org/#/c/692205/","accounts_in_message":[],"_revision_number":1},{"id":"24bef9bbe09c4747ac75aa71fc5dd5ee765db716","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-05-18 18:09:19.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/93/728793/1/check/pmem-tempest-plugin-filtered/1acc4d9/ : RETRY_LIMIT in 1m 39s\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/93/728793/1/check/pmem-tempest-plugin-filtered-multi-node/b94e25a/ : RETRY_LIMIT in 2m 00s","accounts_in_message":[],"_revision_number":1},{"id":"835ffffff6f6299446367dcf571c181e096fceeb","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-05-20 08:33:06.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nHi Stephen,\n\nThanks for the review.\n\nRegarding \u0027https://review.opendev.org/#/c/692205/\u0027, yes, I know the pain that a developer has in dealing with error happened in test case like \u0027NUMATopologyTest.test_cpu_policy_constraint\u0027, it is hard to locate the test parameter that creates the error. I have made an update based on the work of Eric, if you have time please review this commit also.\n\nThanks.","accounts_in_message":[],"_revision_number":1},{"id":"2ae3ac056a03a341207e2c499d1f9e3cd5d6c48b","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-05-20 09:12:34.000000000","message":"Patch Set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"8df62091f8368daa9c68c072faed29b85cf29285","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-20 09:12:55.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"5cc75abc9519d5cf87718e5425fc168e7ba8721a","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-05-20 09:13:17.000000000","message":"Patch Set 2:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"1cb6f6cb205e71b57cd5e0a321212ea19f1d2f56","author":{"_account_id":16376,"name":"Intel NFV CI","email":"openstack-nfv-ci@intel.com","username":"intel-nfv-ci","tags":["SERVICE_USER"]},"date":"2020-05-20 09:13:21.000000000","message":"Patch Set 2:\n\nBuild succeeded (check pipeline).\n\n- tempest-dsvm-intel-nfv-xenial tempest-dsvm-intel-nfv-xenial : SKIPPED (non-voting)\n- tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial tempest-dsvm-multinode-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)\n- tempest-dsvm-ovsdpdk-nfv-networking-xenial tempest-dsvm-ovsdpdk-nfv-networking-xenial : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a6950d94db9db281e56a0b5393104c8dec4a5dc6","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2020-05-20 09:13:30.000000000","message":"Patch Set 2:\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"681c0b8076be09dabe5126eb78d5e3ccd03ec806","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-06-22 06:36:17.000000000","message":"Patch Set 2: Workflow-1\n\nCurrently there are too much high priority commits over \u0027test_hardware.py\u0027, which cause conflicts.\n\nWill resume once confliction is not that much.","accounts_in_message":[],"_revision_number":2},{"id":"85ee0779ec12eec56ca5aafff34c32d5091c3961","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-06-30 10:24:45.000000000","message":"Patch Set 2: -Workflow","accounts_in_message":[],"_revision_number":2},{"id":"d86945aa09fb38eecf57fc50d52d0224b6278ff9","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-06-30 10:29:48.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"dc33c9df25fb6a23ea22fd0b38fc6f58829d00a1","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-06-30 10:34:33.000000000","message":"Patch Set 3: Workflow-1\n\nRun topic, will drop.","accounts_in_message":[],"_revision_number":3},{"id":"b311e9c48540f4d65fff80b90fdcfade281168c0","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-06-30 10:35:33.000000000","message":"Abandoned\n\nApplied a run wrong topic.","accounts_in_message":[],"_revision_number":3},{"id":"197733bbe829c61570a0a2e328229dad99190f93","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-06-30 10:39:48.000000000","message":"Restored\n\nBeen abandoned with mistake, restore for review.","accounts_in_message":[],"_revision_number":3},{"id":"5a62cbb2e97e99b6096d7e57d39de98ee2d450c8","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-06-30 10:40:12.000000000","message":"Removed Workflow-1 by Huaqiang Wang \u003chuaqiang.wang@intel.com\u003e\n","accounts_in_message":[],"_revision_number":3},{"id":"deecc497de34d038cab4ca2c28a6b35e92c6bca0","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2020-06-30 10:41:14.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/93/728793/3/check/EMC_VxFlexOS_NOVA/5bdcf88/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":3},{"id":"15b5718f5179daef657d139ccd625855c29ec315","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2020-06-30 10:43:13.000000000","message":"Patch Set 3:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/728793/3 : FAILURE in 36s","accounts_in_message":[],"_revision_number":3},{"id":"d1af4a142b80719aa13440e91747b7c30ad77b44","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-30 11:04:32.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/459b2188c15a4fada6cf96956c0b2a6a : SUCCESS in 17m 14s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c2e5e65ababc4f30a90abdf382f1aeda : SUCCESS in 19m 19s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3ca13a446fe54464a4e324c6b973ad60 : SUCCESS in 8m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/72a31e120f8a49e2936608a6fd2b317d : SUCCESS in 13m 35s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2a0fe88adf324a928029800059b94e0f : SUCCESS in 15m 07s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/845b6e651a7d43e3ae403b3ae39c31d0 : SUCCESS in 10m 33s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/1258d5a37b0a43d2a387a8e068d25a13 : SUCCESS in 18m 34s","accounts_in_message":[],"_revision_number":3},{"id":"a2a869b35cf30663a07c3c6a0c69a51c35ea779a","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2020-06-30 11:05:44.000000000","message":"Patch Set 3:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/93/728793/3/check/EMC_VxFlexOS_NOVA/2b7203d/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":3},{"id":"337c39624754e67094d4e8c5bb166ceb9288fa37","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-06-30 11:31:16.000000000","message":"Patch Set 3:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/93/728793/3/check/pmem-tempest-plugin-filtered-multi-node/6acf408/ : FAILURE in 45m 59s","accounts_in_message":[],"_revision_number":3},{"id":"85efd9f2aa73d53aa1e40070942dc8c5385ff877","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-06-30 12:08:50.000000000","message":"Patch Set 3:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-93-728793-3 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":3},{"id":"251d44ee1fcad6e42e14aeb49f41be13c8170723","author":{"_account_id":32071,"name":"Hui Jiang","email":"jhui@vmware.com","username":"jhui"},"date":"2020-07-03 01:45:13.000000000","message":"Patch Set 3:\n\nvmware-recheck-patch","accounts_in_message":[],"_revision_number":3},{"id":"8a768d14120823497a094acbd7e12eabc5ea167c","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-03 02:47:11.000000000","message":"Patch Set 3:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/93/728793/3/check-vote/ext-nova-zuul/22dd98f : SUCCESS in 53m 40s","accounts_in_message":[],"_revision_number":3},{"id":"b0f77ffbeee641db8a3d941593d83006357c3539","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2020-07-06 08:00:29.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"32ae50eaab3ba906a5633a97a0266a4e4e3c07f7","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-07-08 11:47:14.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"75c1572ed2318745d7b9960b0e2a2140fb3a0e58","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-07-08 12:26:08.000000000","message":"Patch Set 4:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/93/728793/4/check/pmem-tempest-plugin-filtered-multi-node/be68e76/ : FAILURE in 35m 36s","accounts_in_message":[],"_revision_number":4},{"id":"fce50b46d7e8ad57fc85440129d4f481ec20da98","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-08 12:44:59.000000000","message":"Patch Set 4:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/93/728793/4/check-vote/ext-nova-zuul/1d31968 : SUCCESS in 54m 35s","accounts_in_message":[],"_revision_number":4},{"id":"cd390be46fac0f36be4c5c556cee5a63191209df","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2020-07-08 14:42:04.000000000","message":"Patch Set 4:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-43649 : FAILURE in 1h 35m 11s","accounts_in_message":[],"_revision_number":4},{"id":"a4198dd7656f5fc3d02a024df0cf0558240a93ab","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-08 17:51:00.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2616ed3aa62740a6a1df4ffdb53e781c : SUCCESS in 20m 56s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9667832a27b849b6a8191e58ff0c77d2 : SUCCESS in 18m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b4ea3423563549cda3172523888b99b9 : SUCCESS in 9m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/63f12b7367804409a6e9e8acb986b0e0 : SUCCESS in 15m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c737a30c46a0442dbcf18a7cefba8f66 : SUCCESS in 21m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/11dfdac737fd4b6384246657f589c527 : SUCCESS in 11m 47s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/44efacc584b5405e9c7ad07bdf45333e : SUCCESS in 18m 31s","accounts_in_message":[],"_revision_number":4},{"id":"219d39085b677ec244126be9827d29b2e1d0bbd4","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2020-07-08 17:52:31.000000000","message":"Patch Set 4:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/93/728793/4/check/EMC_VxFlexOS_NOVA/f74a1fd/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":4},{"id":"6027b6cab83c36421bd0c4c39fdc8fc450ffc33f","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-07-08 18:16:33.000000000","message":"Patch Set 4:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-93-728793-4 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":4},{"id":"5591c6ce2ccc69e166e3122e22119cae62c76d71","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-07-09 17:18:26.000000000","message":"Patch Set 4: Code-Review+2\n\nTrivial change that should make the following patches easier to review. LGTM","accounts_in_message":[],"_revision_number":4},{"id":"1d2727ca1a6c0d54ef1205e596241b1a59eafcf5","author":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"date":"2020-07-10 03:45:56.000000000","message":"Uploaded patch set 5: Patch Set 4 was rebased.","accounts_in_message":[],"_revision_number":5},{"id":"ddc4652ddedba4cdd4fc70c29deb1b79d6dea87d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-10 04:13:34.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d538ffe05d7c43f5a27ea8326e97f51c : SUCCESS in 18m 11s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5213b20c6ca34cb8bf7a44e72a02cb69 : SUCCESS in 24m 48s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2f42beaca4cb422b831cd7dd26fdaf3b : SUCCESS in 13m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4511fa68afbc4b36a87dccba88e750f3 : SUCCESS in 22m 27s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ea0298f4ed1b49849ef354bc2055fbf3 : SUCCESS in 18m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/95225173b0d2472fb716b5d04b8f1d3a : SUCCESS in 15m 37s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/8d218f63f022461d993aa1f1e3623641 : SUCCESS in 24m 43s","accounts_in_message":[],"_revision_number":5},{"id":"a5a2e445852bed25b32b593f0673e7f50d90eff6","author":{"_account_id":15941,"name":"DellEMC PowerFlex CI","email":"emc.scaleio.ci@emc.com","username":"emc-scaleio-ci","tags":["SERVICE_USER"]},"date":"2020-07-10 04:20:50.000000000","message":"Patch Set 5:\n\nBuild failed.  For information on how to proceed, see https://docs.openstack.org/infra/manual/developers.html\n\n- EMC_VxFlexOS_NOVA http://publiclogs.emc.com/93/728793/5/check/EMC_VxFlexOS_NOVA/0d3187c/EMC_VxFlexOS_NOVA/None : NOT_REGISTERED\n\nLeave a comment with \u0027run-DellEMC VxFlexOS CI\u0027 to trigger a recheck. For more information about CI, please see https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_VxFlexOS_CI","accounts_in_message":[],"_revision_number":5},{"id":"d6dc13b3f06fc3587b23b5b3a75ecb617ebd2b6e","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2020-07-10 04:27:20.000000000","message":"Patch Set 5:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered-multi-node http://52.27.155.124/93/728793/5/check/pmem-tempest-plugin-filtered-multi-node/82d5354/ : FAILURE in 37m 28s","accounts_in_message":[],"_revision_number":5},{"id":"8fa169f3204f3e859cd00452e456e26dad7f37b3","author":{"_account_id":14384,"name":"Quobyte CI","email":"openstack-ci-external@quobyte.com","username":"quobyteci","tags":["SERVICE_USER"]},"date":"2020-07-10 04:40:53.000000000","message":"Patch Set 5:\n\n* nova-quobyteci-dsvm-volume http://78.46.57.153:8081/refs-changes-93-728793-5 : FAILURE \n\nSee https://wiki.openstack.org/wiki/ThirdPartySystems/Quobyte_CI for rechecking and info.","accounts_in_message":[],"_revision_number":5},{"id":"a1da779f8ddbee9513aeb7d662b2940b34683f86","author":{"_account_id":9008,"name":"VMware NSX CI","username":"vmwareminesweeper","tags":["SERVICE_USER"]},"date":"2020-07-10 04:55:04.000000000","message":"Patch Set 5:\n\nBuild succeeded\n\n- dsvm-nova http://207.189.188.190/logs/93/728793/5/check-vote/ext-nova-zuul/905ffe3 : SUCCESS in 1h 06m 29s","accounts_in_message":[],"_revision_number":5},{"id":"a4c8393fde00d75f8655e5538556077bbe2ce6ed","author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"date":"2020-07-10 06:53:50.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"e4d583e2df1c3cadeee36ea73fe4b4b082eb9662","author":{"_account_id":23498,"name":"IBM zVM CI","email":"zvmosci@us.ibm.com","username":"zvmosci"},"date":"2020-07-10 07:42:17.000000000","message":"Patch Set 5:\n\nTesting completed on the zVM Driver CI system check-nova pipeline and failed.  To recheck only the zVM driver plugins, submit a comment with only  zvm: recheck in the comment.. Contact information: zvmosci@us.ibm.com. For information see https://wiki.openstack.org/wiki/ZVMDriver.\n\n- check-nova-master http://extbasicopstackcilog01.podc.sl.edst.ibm.com/test_logs/jenkins-check-nova-master-43735 : FAILURE in 2h 46m 27s","accounts_in_message":[],"_revision_number":5},{"id":"8a387964589bce90c78db65b16a64281e3c74a2c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-13 13:04:39.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"c5ab1486b78cb5861449f74eebe4e79265338597","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-13 15:21:33.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/71827fdb7e48469686786830d9207eb1 : SUCCESS in 17m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fd15e4b8b0f8458d9260f4e39da4f90e : SUCCESS in 10m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d27720917cd9468db237a117364d5ca0 : SUCCESS in 12m 43s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/b658b802b3994c989242ef16e73b89f2 : SUCCESS in 14m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e4f5a9451faa47d38a75a27db1880273 : SUCCESS in 11m 10s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/331de09f82234d21bcca105fed732038 : SUCCESS in 22m 19s","accounts_in_message":[],"_revision_number":5},{"id":"9656b5b539bcb74ff9e5c50cbfb4e3cb5694c58e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-13 15:21:37.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5},{"id":"c83609eff0a637e21de0228fabd1fb296f79f4af","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-13 15:28:35.000000000","message":"Patch Set 5:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2d25fbf9833f4f7c910b1bf4d24ca527 : SUCCESS in 1m 55s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"55ff7517750662ddb4d529803a64206bd2dc621d","revisions":{"cdbdaf1a02f2c6b2ad0c4663df51cc65399dfc24":{"kind":"REWORK","_number":1,"created":"2020-05-18 08:51:57.000000000","uploader":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"ref":"refs/changes/93/728793/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/93/728793/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/93/728793/1"}}},"commit":{"parents":[{"commit":"b8fe7fac846d441f133088c35086f46896875d71","subject":"Merge \"Switch to newer openstackdocstheme and reno versions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b8fe7fac846d441f133088c35086f46896875d71"}]}],"author":{"name":"Wang Huaqiang","email":"huaqiang.wang@intel.com","date":"2020-05-18 07:11:38.000000000","tz":480},"committer":{"name":"Wang Huaqiang","email":"huaqiang.wang@intel.com","date":"2020-05-18 08:49:30.000000000","tz":480},"subject":"test_hardware: code formating for multiline construct","message":"test_hardware: code formating for multiline construct\n\nThe coding style, in file test_hardware.py, mostly related to\ncreating \u0027Flavor\u0027 and \u0027InstanceNUMATopology\u0027 objects, is\ninconsistent, reformat these part of code according to following\nrules:\n\n- Arrange the `extra_specs` property in a seperate line to allow the\n  extra_spec with a lone name or value in a graceful way.\n\n    An example:\n    some code before reformating:\n\n    ```\n    \"flavor\": objects.Flavor(vcpus\u003d4, memory_mb\u003d2048,\n                             extra_specs\u003d{\n        \"hw:cpu_max_sockets\": \"5\",\n        \"hw:cpu_max_cores\": \"2\",\n        \"hw:cpu_max_threads\": \"3\",\n    }),\n    ```\n\n    It will be formated as:\n\n    ```\n\t\"flavor\": objects.Flavor(\n            vcpus\u003d4, memory_mb\u003d2048,\n            extra_specs\u003d{\n                \"hw:cpu_max_sockets\": \"5\",\n                \"hw:cpu_max_cores\": \"2\",\n                \"hw:cpu_max_threads\": \"3\",\n\t}\n    ```\n- *Try* to put the closing brace/bracket/parenthesis on multiline\n  constructs line up under the first character of the line that\n  starts the multiline construct.\n\n  example:\n  an piece of code in original code\n  ```\n    {\n        \"numa_topology\": objects.InstanceNUMATopology(\n            cells\u003d[\n                objects.InstanceNUMACell(\n                id\u003d0, cpuset\u003dset([0, 1, 2, 3]), memory\u003d2048,\n                cpu_topology\u003dobjects.VirtCPUTopology(\n                sockets\u003d1, cores\u003d1, threads\u003d4))]),\n        \"expect\": [2, 1, 2]\n    },\n  ```\n\n  after the reformating, it is\n\n  ```\n    {\n        \"numa_topology\": objects.InstanceNUMATopology(\n            cells\u003d[\n                objects.InstanceNUMACell(\n                id\u003d0, cpuset\u003dset([0, 1, 2, 3]), memory\u003d2048,\n                cpu_topology\u003dobjects.VirtCPUTopology(\n                sockets\u003d1, cores\u003d1, threads\u003d4))\n            ]\n        ),\n        \"expect\": [2, 1, 2]\n    },\n  ```\n  In example above, the closing bracket and closing parenthese are put in a\n  separeate line and lined up under the first character of the code block,\n  make a clear boundary of the code block.\n\n- No space or new-line between an empty brace:\n\n  change following code\n\n  ```\n  \"image\": {\n  }\n  ```\n  to\n\n  ```\n  \"image\": {}\n  ```\n\nChange-Id: I81f1af98861a7f26d34348473ec245598ff856a8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cdbdaf1a02f2c6b2ad0c4663df51cc65399dfc24"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cdbdaf1a02f2c6b2ad0c4663df51cc65399dfc24"}]},"branch":"refs/heads/master"},"962afb14e2c97e3c81665dfa594b51cfafe12e75":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-05-20 09:12:34.000000000","uploader":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"ref":"refs/changes/93/728793/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/93/728793/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/93/728793/2"}}},"commit":{"parents":[{"commit":"b8fe7fac846d441f133088c35086f46896875d71","subject":"Merge \"Switch to newer openstackdocstheme and reno versions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b8fe7fac846d441f133088c35086f46896875d71"}]}],"author":{"name":"Wang Huaqiang","email":"huaqiang.wang@intel.com","date":"2020-05-18 07:11:38.000000000","tz":480},"committer":{"name":"Huaqiang Wang","email":"huaqiang.wang@intel.com","date":"2020-05-20 09:12:34.000000000","tz":0},"subject":"test_hardware: code formating for multiline construct","message":"test_hardware: code formating for multiline construct\n\nThe coding style, in file test_hardware.py, mostly related to\ncreating \u0027Flavor\u0027 and \u0027InstanceNUMATopology\u0027 objects, is\ninconsistent, reformat these part of code according to following\nrules:\n\n- Arrange the `extra_specs` property in a seperate line to allow the\n  extra_spec with a lone name or value in a graceful way.\n\n    An example:\n    some code before reformating:\n\n    ```\n    \"flavor\": objects.Flavor(vcpus\u003d4, memory_mb\u003d2048,\n                             extra_specs\u003d{\n        \"hw:cpu_max_sockets\": \"5\",\n        \"hw:cpu_max_cores\": \"2\",\n        \"hw:cpu_max_threads\": \"3\",\n    }),\n    ```\n\n    It will be formated as:\n\n    ```\n\t\"flavor\": objects.Flavor(\n            vcpus\u003d4, memory_mb\u003d2048,\n            extra_specs\u003d{\n                \"hw:cpu_max_sockets\": \"5\",\n                \"hw:cpu_max_cores\": \"2\",\n                \"hw:cpu_max_threads\": \"3\",\n\t}\n    ```\n- *Try* to put the closing brace/bracket/parenthesis on multiline\n  constructs line up under the first character of the line that\n  starts the multiline construct.\n\n  example:\n  an piece of code in original code\n  ```\n    {\n        \"numa_topology\": objects.InstanceNUMATopology(\n            cells\u003d[\n                objects.InstanceNUMACell(\n                id\u003d0, cpuset\u003dset([0, 1, 2, 3]), memory\u003d2048,\n                cpu_topology\u003dobjects.VirtCPUTopology(\n                sockets\u003d1, cores\u003d1, threads\u003d4))]),\n        \"expect\": [2, 1, 2]\n    },\n  ```\n\n  after the reformating, it is\n\n  ```\n    {\n        \"numa_topology\": objects.InstanceNUMATopology(\n            cells\u003d[\n                objects.InstanceNUMACell(\n                id\u003d0, cpuset\u003dset([0, 1, 2, 3]), memory\u003d2048,\n                cpu_topology\u003dobjects.VirtCPUTopology(\n                sockets\u003d1, cores\u003d1, threads\u003d4))\n            ]\n        ),\n        \"expect\": [2, 1, 2]\n    },\n  ```\n  In example above, the closing bracket and closing parenthese are put in a\n  separeate line and lined up under the first character of the code block,\n  make a clear boundary of the code block.\n\n- No space or new-line between an empty brace:\n\n  change following code\n\n  ```\n  \"image\": {\n  }\n  ```\n  to\n\n  ```\n  \"image\": {}\n  ```\nDepends-On: I7b7971645c80efb3df3519133111d7c4bd3792ae\nChange-Id: I81f1af98861a7f26d34348473ec245598ff856a8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/962afb14e2c97e3c81665dfa594b51cfafe12e75"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/962afb14e2c97e3c81665dfa594b51cfafe12e75"}]},"branch":"refs/heads/master"},"2acb504321947a2c387a9750a2b7b9d3d587ee6d":{"kind":"REWORK","_number":3,"created":"2020-06-30 10:29:48.000000000","uploader":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"ref":"refs/changes/93/728793/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/93/728793/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/93/728793/3"}}},"commit":{"parents":[{"commit":"5d56f44ee9338d9a76358042f1c6bde282f8a89f","subject":"hardware: Tweak the \u0027cpu_realtime_mask\u0027 handling slightly","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5d56f44ee9338d9a76358042f1c6bde282f8a89f"}]}],"author":{"name":"Wang Huaqiang","email":"huaqiang.wang@intel.com","date":"2020-05-18 07:11:38.000000000","tz":480},"committer":{"name":"Wang Huaqiang","email":"huaqiang.wang@intel.com","date":"2020-06-30 09:07:36.000000000","tz":480},"subject":"test_hardware: code formating for multiline construct","message":"test_hardware: code formating for multiline construct\n\nThe coding style, in file test_hardware.py, mostly related to\ncreating \u0027Flavor\u0027 and \u0027InstanceNUMATopology\u0027 objects, is\ninconsistent, reformat these part of code according to following\nrules:\n\n- Arrange the `extra_specs` property in a seperate line to allow the\n  extra_spec with a lone name or value in a graceful way.\n\n    An example:\n    some code before reformating:\n\n    \"flavor\": objects.Flavor(vcpus\u003d4, memory_mb\u003d2048,\n                             extra_specs\u003d{\n        \"hw:cpu_max_sockets\": \"5\",\n        \"hw:cpu_max_cores\": \"2\",\n        \"hw:cpu_max_threads\": \"3\",\n    }),\n\n    It will be formated as:\n\n\t\"flavor\": objects.Flavor(\n            vcpus\u003d4, memory_mb\u003d2048,\n            extra_specs\u003d{\n                \"hw:cpu_max_sockets\": \"5\",\n                \"hw:cpu_max_cores\": \"2\",\n                \"hw:cpu_max_threads\": \"3\",\n\t}\n\n- *Try* to put the closing brace/bracket/parenthesis on multiline\n  constructs line up under the first character of the line that\n  starts the multiline construct.\n\n  example:\n  a piece of code in original code\n    {\n        \"numa_topology\": objects.InstanceNUMATopology(\n            cells\u003d[\n                objects.InstanceNUMACell(\n                id\u003d0, cpuset\u003dset([0, 1, 2, 3]), memory\u003d2048,\n                cpu_topology\u003dobjects.VirtCPUTopology(\n                sockets\u003d1, cores\u003d1, threads\u003d4))]),\n        \"expect\": [2, 1, 2]\n    },\n\n  after the reformating, it would be\n\n    {\n        \"numa_topology\": objects.InstanceNUMATopology(cells\u003d[\n            objects.InstanceNUMACell(\n                id\u003d0, cpuset\u003dset([0, 1, 2, 3]), memory\u003d2048,\n                cpu_topology\u003dobjects.VirtCPUTopology(\n                sockets\u003d1, cores\u003d1, threads\u003d4)),\n        ]),\n        \"expect\": [2, 1, 2]\n    },\n\n- No space or new-line between an empty brace:\n\n  change following code\n\n  ```\n  \"image\": {\n  }\n  ```\n  to\n\n  ```\n  \"image\": {}\n  ```\n\nChange-Id: I81f1af98861a7f26d34348473ec245598ff856a8\nSigned-off-by: Wang Huaqiang \u003chuaqiang.wang@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2acb504321947a2c387a9750a2b7b9d3d587ee6d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2acb504321947a2c387a9750a2b7b9d3d587ee6d"}]},"branch":"refs/heads/master"},"026ffdff3d2b7688b7c4d0d676e55284acda1c6a":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2020-07-08 11:47:14.000000000","uploader":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"ref":"refs/changes/93/728793/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/93/728793/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/93/728793/4"}}},"commit":{"parents":[{"commit":"5d56f44ee9338d9a76358042f1c6bde282f8a89f","subject":"hardware: Tweak the \u0027cpu_realtime_mask\u0027 handling slightly","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5d56f44ee9338d9a76358042f1c6bde282f8a89f"}]}],"author":{"name":"Wang Huaqiang","email":"huaqiang.wang@intel.com","date":"2020-05-18 07:11:38.000000000","tz":480},"committer":{"name":"Wang Huaqiang","email":"huaqiang.wang@intel.com","date":"2020-07-08 08:22:55.000000000","tz":480},"subject":"test_hardware: code formating for multiline construct","message":"test_hardware: code formating for multiline construct\n\nThe coding style, in test cases of VCPUTopologyTest and\n NUMATopologyTest test classes from file test_hardware.py,\nis inconsistent. This patch is to reformat these part of\ncode according to following rules:\n\n- Arrange the `extra_specs` property in a seperate line to allow the\n  extra_spec with a long name or value.\n\n    An example:\n    some code before reformating:\n\n    \"flavor\": objects.Flavor(vcpus\u003d4, memory_mb\u003d2048,\n                             extra_specs\u003d{\n        \"hw:cpu_max_sockets\": \"5\",\n        \"hw:cpu_max_cores\": \"2\",\n        \"hw:cpu_max_threads\": \"3\",\n    }),\n\n    It will be formated as:\n\n\t\"flavor\": objects.Flavor(\n            vcpus\u003d4, memory_mb\u003d2048,\n            extra_specs\u003d{\n                \"hw:cpu_max_sockets\": \"5\",\n                \"hw:cpu_max_cores\": \"2\",\n                \"hw:cpu_max_threads\": \"3\",\n\t    }\n\t)\n\n- *Try* to put the closing brace/bracket/parenthesis on multiline\n  constructs line up under the first character of the line that\n  starts the multiline construct.\n\n  example:\n  a piece of code in original code\n    {\n        \"numa_topology\": objects.InstanceNUMATopology(\n            cells\u003d[\n                objects.InstanceNUMACell(\n                id\u003d0, cpuset\u003dset([0, 1, 2, 3]), memory\u003d2048,\n                cpu_topology\u003dobjects.VirtCPUTopology(\n                sockets\u003d1, cores\u003d1, threads\u003d4))]),\n        \"expect\": [2, 1, 2]\n    },\n\n  after the reformating, it would be\n\n    {\n        \"numa_topology\": objects.InstanceNUMATopology(cells\u003d[\n            objects.InstanceNUMACell(\n                id\u003d0, cpuset\u003dset([0, 1, 2, 3]), memory\u003d2048,\n                cpu_topology\u003dobjects.VirtCPUTopology(\n                sockets\u003d1, cores\u003d1, threads\u003d4)),\n        ]),\n        \"expect\": [2, 1, 2]\n    },\n\n- No space or new-line between an empty brace:\n\n  change following code\n\n  \"image\": {\n  }\n\n  to\n\n  \"image\": {}\n\nChange-Id: I81f1af98861a7f26d34348473ec245598ff856a8\nSigned-off-by: Wang Huaqiang \u003chuaqiang.wang@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/026ffdff3d2b7688b7c4d0d676e55284acda1c6a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/026ffdff3d2b7688b7c4d0d676e55284acda1c6a"}]},"branch":"refs/heads/master"},"55ff7517750662ddb4d529803a64206bd2dc621d":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2020-07-10 03:45:56.000000000","uploader":{"_account_id":30209,"name":"Huaqiang","email":"huaqiang.wang@intel.com","username":"Huaqiang.Wang"},"ref":"refs/changes/93/728793/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/93/728793/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/728793/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/93/728793/5"}}},"commit":{"parents":[{"commit":"9fc63c764429c10f9041e6b53659e0cbd595bf6b","subject":"hardware: Tweak the \u0027cpu_realtime_mask\u0027 handling slightly","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9fc63c764429c10f9041e6b53659e0cbd595bf6b"}]}],"author":{"name":"Wang Huaqiang","email":"huaqiang.wang@intel.com","date":"2020-05-18 07:11:38.000000000","tz":480},"committer":{"name":"Wang Huaqiang","email":"huaqiang.wang@intel.com","date":"2020-07-10 03:42:06.000000000","tz":480},"subject":"test_hardware: code formating for multiline construct","message":"test_hardware: code formating for multiline construct\n\nThe coding style, in test cases of VCPUTopologyTest and\n NUMATopologyTest test classes from file test_hardware.py,\nis inconsistent. This patch is to reformat these part of\ncode according to following rules:\n\n- Arrange the `extra_specs` property in a seperate line to allow the\n  extra_spec with a long name or value.\n\n    An example:\n    some code before reformating:\n\n    \"flavor\": objects.Flavor(vcpus\u003d4, memory_mb\u003d2048,\n                             extra_specs\u003d{\n        \"hw:cpu_max_sockets\": \"5\",\n        \"hw:cpu_max_cores\": \"2\",\n        \"hw:cpu_max_threads\": \"3\",\n    }),\n\n    It will be formated as:\n\n\t\"flavor\": objects.Flavor(\n            vcpus\u003d4, memory_mb\u003d2048,\n            extra_specs\u003d{\n                \"hw:cpu_max_sockets\": \"5\",\n                \"hw:cpu_max_cores\": \"2\",\n                \"hw:cpu_max_threads\": \"3\",\n\t    }\n\t)\n\n- *Try* to put the closing brace/bracket/parenthesis on multiline\n  constructs line up under the first character of the line that\n  starts the multiline construct.\n\n  example:\n  a piece of code in original code\n    {\n        \"numa_topology\": objects.InstanceNUMATopology(\n            cells\u003d[\n                objects.InstanceNUMACell(\n                id\u003d0, cpuset\u003dset([0, 1, 2, 3]), memory\u003d2048,\n                cpu_topology\u003dobjects.VirtCPUTopology(\n                sockets\u003d1, cores\u003d1, threads\u003d4))]),\n        \"expect\": [2, 1, 2]\n    },\n\n  after the reformating, it would be\n\n    {\n        \"numa_topology\": objects.InstanceNUMATopology(cells\u003d[\n            objects.InstanceNUMACell(\n                id\u003d0, cpuset\u003dset([0, 1, 2, 3]), memory\u003d2048,\n                cpu_topology\u003dobjects.VirtCPUTopology(\n                sockets\u003d1, cores\u003d1, threads\u003d4)),\n        ]),\n        \"expect\": [2, 1, 2]\n    },\n\n- No space or new-line between an empty brace:\n\n  change following code\n\n  \"image\": {\n  }\n\n  to\n\n  \"image\": {}\n\nChange-Id: I81f1af98861a7f26d34348473ec245598ff856a8\nSigned-off-by: Wang Huaqiang \u003chuaqiang.wang@intel.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/55ff7517750662ddb4d529803a64206bd2dc621d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/55ff7517750662ddb4d529803a64206bd2dc621d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}