)]}'
{"nova/tests/functional/libvirt/base.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9c73f42a603099fa065c37f6bf3bceb35588e928","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":73,"context_line":"            \u0027nova.virt.libvirt.host.Host.get_online_cpus\u0027,"},{"line_number":74,"context_line":"            return_value\u003dset(range(16))))"},{"line_number":75,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":76,"context_line":"            \u0027nova.virt.libvirt.driver.connector\u0027,"},{"line_number":77,"context_line":"            fake_os_brick_connector))"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_941cc078","line":75,"updated":"2020-05-20 17:07:29.000000000","message":"Could you comment this like we\u0027ve done for the below? It should have been done for a few of the above too","commit_id":"656c65e92d7f439a0218945f58bcd2410d879e5d"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"6f065cad7222f7536460a9edd10ffc6832ca2434","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":73,"context_line":"            \u0027nova.virt.libvirt.host.Host.get_online_cpus\u0027,"},{"line_number":74,"context_line":"            return_value\u003dset(range(16))))"},{"line_number":75,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":76,"context_line":"            \u0027nova.virt.libvirt.driver.connector\u0027,"},{"line_number":77,"context_line":"            fake_os_brick_connector))"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_4d377db1","line":75,"in_reply_to":"ff570b3c_941cc078","updated":"2020-07-10 11:58:32.000000000","message":"Done","commit_id":"656c65e92d7f439a0218945f58bcd2410d879e5d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2ad7fef18cd3946aa07ca2b79417ac37cea572f4","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        # os-brick connector for attaching iSCSI volumes to a host."},{"line_number":83,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":84,"context_line":"            \u0027nova.virt.libvirt.driver.connector\u0027,"},{"line_number":85,"context_line":"            fake_os_brick_connector))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # Mock the \u0027get_connection\u0027 function, as we\u0027re going to need to provide"},{"line_number":88,"context_line":"        # custom capabilities for each test"}],"source_content_type":"text/x-python","patch_set":2,"id":"59d03458_704f9023","line":85,"updated":"2021-02-17 13:57:28.000000000","message":"Do we want to do this here or in \u0027FakeLibvirtFixture\u0027? That also lets us remove the mock in \u0027nova/tests/unit/virt/test_virt_drivers.py\u0027. Heck, we could fold in the small \u0027fake_os_brick_connector\u0027 into \u0027fakelibvirt\u0027, though that\u0027s purely optional","commit_id":"f91a829095371597a7b89c4aa36e72bdcf2eee1e"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"43485588454000e9fbb16f677b58862f4c347a52","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        # os-brick connector for attaching iSCSI volumes to a host."},{"line_number":83,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":84,"context_line":"            \u0027nova.virt.libvirt.driver.connector\u0027,"},{"line_number":85,"context_line":"            fake_os_brick_connector))"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        # Mock the \u0027get_connection\u0027 function, as we\u0027re going to need to provide"},{"line_number":88,"context_line":"        # custom capabilities for each test"}],"source_content_type":"text/x-python","patch_set":2,"id":"29cb3744_13b98c82","line":85,"in_reply_to":"59d03458_704f9023","updated":"2021-02-17 14:57:37.000000000","message":"Here IMHO. If anything fake_os_brick_connector should be moved out of nova.tests.unit.virt.libvirt as it\u0027s used by multiple virt drivers.","commit_id":"f91a829095371597a7b89c4aa36e72bdcf2eee1e"}]}