)]}'
{"nova/hacking/checks.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"5f1da4d01738d866907a2bfab0aba968ac74ea0a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"asse_raises_regexp \u003d re.compile(r\"assertRaisesRegexp\\(\")"},{"line_number":78,"context_line":"conf_attribute_set_re \u003d re.compile(r\"CONF\\.[a-z0-9_.]+\\s*\u003d\\s*\\w\")"},{"line_number":79,"context_line":"translated_log \u003d re.compile("},{"line_number":80,"context_line":"    r\"(.)*LOG\\.(audit|debug|error|info|critical|exception)\""},{"line_number":81,"context_line":"    r\"\\(\\s*_\\(\\s*(\u0027|\\\")\")"},{"line_number":82,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":83,"context_line":"string_translation \u003d re.compile(r\"[^_]*_\\(\\s*(\u0027|\\\")\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_42c378ed","line":80,"range":{"start_line":80,"start_character":16,"end_line":80,"end_character":57},"updated":"2020-05-21 10:36:35.000000000","message":"\u0027warning\u0027 is missing.","commit_id":"66dcf99db1cffaa894667cc12439b1fe3eff2b20"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f86091cee215a953e3148fe42779b0c129852b1d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"asse_raises_regexp \u003d re.compile(r\"assertRaisesRegexp\\(\")"},{"line_number":78,"context_line":"conf_attribute_set_re \u003d re.compile(r\"CONF\\.[a-z0-9_.]+\\s*\u003d\\s*\\w\")"},{"line_number":79,"context_line":"translated_log \u003d re.compile("},{"line_number":80,"context_line":"    r\"(.)*LOG\\.(audit|debug|error|info|critical|exception)\""},{"line_number":81,"context_line":"    r\"\\(\\s*_\\(\\s*(\u0027|\\\")\")"},{"line_number":82,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":83,"context_line":"string_translation \u003d re.compile(r\"[^_]*_\\(\\s*(\u0027|\\\")\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_855d9a7a","line":80,"range":{"start_line":80,"start_character":16,"end_line":80,"end_character":57},"in_reply_to":"ff570b3c_42c378ed","updated":"2020-05-21 11:24:05.000000000","message":"Ah, that would explain [1]. I\u0027ve just replaced this with \u0027\\w+\u0027 since we don\u0027t need to filter out debug anymore\n\n[1] https://review.opendev.org/#/c/728966/1/nova/virt/libvirt/driver.py@1800","commit_id":"66dcf99db1cffaa894667cc12439b1fe3eff2b20"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e905cd99624c1b5023a5b27aac9ac9aa75587ae4","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                    r\"[\\[|\u0027|\\\"](, .*)?\\)\")"},{"line_number":77,"context_line":"asse_raises_regexp \u003d re.compile(r\"assertRaisesRegexp\\(\")"},{"line_number":78,"context_line":"conf_attribute_set_re \u003d re.compile(r\"CONF\\.[a-z0-9_.]+\\s*\u003d\\s*\\w\")"},{"line_number":79,"context_line":"translated_log \u003d re.compile(r\"(.)*LOG\\.\\w+\\(\\s*_\\(\\s*(\u0027|\\\")\")"},{"line_number":80,"context_line":"mutable_default_args \u003d re.compile(r\"^\\s*def .+\\((.+\u003d\\{\\}|.+\u003d\\[\\])\")"},{"line_number":81,"context_line":"string_translation \u003d re.compile(r\"[^_]*_\\(\\s*(\u0027|\\\")\")"},{"line_number":82,"context_line":"underscore_import_check \u003d re.compile(r\"(.)*import _(.)*\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_3cad9d31","line":79,"range":{"start_line":79,"start_character":40,"end_line":79,"end_character":42},"updated":"2020-05-25 08:45:24.000000000","message":"this change was not strictly required but i understand why you did it.\nspecifically you changed this so that people dont get a warning baout traslation if tye use a different log level then those in the list e.g. warning\n\nso in context this makse sense but it might not be obvious why you change this. it weird that warning was not in the list before.","commit_id":"b7b41478c663e1ac40047b787b5a86509cf6309d"}],"nova/tests/unit/test_hacking.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e905cd99624c1b5023a5b27aac9ac9aa75587ae4","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                   msg \u003d \u0027add to me\u0027 + _(\u0027test\u0027)"},{"line_number":405,"context_line":"                   return msg"},{"line_number":406,"context_line":"               \"\"\""},{"line_number":407,"context_line":"        errors \u003d [(9, 10, \u0027N326\u0027), (10, 24, \u0027N326\u0027)]"},{"line_number":408,"context_line":"        self._assert_has_errors(code, checker, expected_errors\u003derrors)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        code \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_dc18e185","line":407,"range":{"start_line":407,"start_character":8,"end_line":407,"end_character":52},"updated":"2020-05-25 08:45:24.000000000","message":"by the way its not clear to me what these number correspond too. im assuming these are line and column number or something like that?","commit_id":"b7b41478c663e1ac40047b787b5a86509cf6309d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f582d7ae06d80ce7abd2d42e04058241525ad520","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                   msg \u003d \u0027add to me\u0027 + _(\u0027test\u0027)"},{"line_number":405,"context_line":"                   return msg"},{"line_number":406,"context_line":"               \"\"\""},{"line_number":407,"context_line":"        errors \u003d [(9, 10, \u0027N326\u0027), (10, 24, \u0027N326\u0027)]"},{"line_number":408,"context_line":"        self._assert_has_errors(code, checker, expected_errors\u003derrors)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        code \u003d \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_0a7167e1","line":407,"range":{"start_line":407,"start_character":8,"end_line":407,"end_character":52},"in_reply_to":"ff570b3c_dc18e185","updated":"2020-05-25 10:42:32.000000000","message":"Yes, exactly. Line and column numbers.","commit_id":"b7b41478c663e1ac40047b787b5a86509cf6309d"}]}