)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c79ce8a3205b60c24358b4c6ab93afe2bfb4509f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"While this is extremely chatty given the 0.5 second loop used by callers"},{"line_number":10,"context_line":"into this method it will provide useful insight into why certain"},{"line_number":11,"context_line":"failures are seen.t rc"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6e58908966a2dc62a3fff155bb81481d68aa2d68"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_b60aafce","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":22},"updated":"2020-05-20 13:52:44.000000000","message":"typo","commit_id":"dfba409922e0c5db3cdff24670cd27d5128971cd"}],"nova/virt/libvirt/guest.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7aa74f9b7528b4b6b3ea456eaaa34bd97770bd67","unresolved":false,"context_lines":[{"line_number":864,"context_line":"            return True"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        # Track blockjob progress in DEBUG, helpful when reviewing failures."},{"line_number":867,"context_line":"        job_type \u003d LIBVIRT_BLOCK_JOB_TYPE[status.job]"},{"line_number":868,"context_line":"        LOG.debug(\"%(job)s block job progress, current cursor: %(cur)s \""},{"line_number":869,"context_line":"                  \"final cursor: %(end)s\","},{"line_number":870,"context_line":"                  {\u0027job\u0027: job_type, \u0027cur\u0027: status.cur, \u0027end\u0027: status.end})"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_804e0194","line":867,"updated":"2020-07-20 06:43:22.000000000","message":"/!\\ This can raise an AttributeError if libvirt supports a new status job type.\n\nCould you please change to :\n\n  job_type \u003d LIBVIRT_BLOCK_JOB_TYPE.get(status.job, VIR_DOMAIN_BLOCK_JOB_TYPE_UNKNOWN)\n\nplease ?","commit_id":"3aada2a54dc5f8dd6d5eda9daf0add308f58f23b"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f0ab5e77a11aca9e695ea7b81fbc94e6de8712d5","unresolved":false,"context_lines":[{"line_number":864,"context_line":"            return True"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        # Track blockjob progress in DEBUG, helpful when reviewing failures."},{"line_number":867,"context_line":"        job_type \u003d LIBVIRT_BLOCK_JOB_TYPE[status.job]"},{"line_number":868,"context_line":"        LOG.debug(\"%(job)s block job progress, current cursor: %(cur)s \""},{"line_number":869,"context_line":"                  \"final cursor: %(end)s\","},{"line_number":870,"context_line":"                  {\u0027job\u0027: job_type, \u0027cur\u0027: status.cur, \u0027end\u0027: status.end})"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_2efeff6a","line":867,"in_reply_to":"bf51134e_804e0194","updated":"2020-07-20 16:24:25.000000000","message":"Yup I guess that\u0027s fair, I don\u0027t think we should return the numeric value however. I\u0027ll respin now.","commit_id":"3aada2a54dc5f8dd6d5eda9daf0add308f58f23b"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fc9a06ba084a773b595e2ab2c739e05c91a1b6e0","unresolved":false,"context_lines":[{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        # Track blockjob progress in DEBUG, helpful when reviewing failures."},{"line_number":867,"context_line":"        job_type \u003d LIBVIRT_BLOCK_JOB_TYPE.get("},{"line_number":868,"context_line":"            status.job, f\"Unknown to Nova ({status.job})\")"},{"line_number":869,"context_line":"        LOG.debug(\"%(job_type)s block job progress, current cursor: %(cur)s \""},{"line_number":870,"context_line":"                  \"final cursor: %(end)s\","},{"line_number":871,"context_line":"                  {\u0027job_type\u0027: job_type, \u0027cur\u0027: status.cur, \u0027end\u0027: status.end})"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_36cf4d58","line":868,"range":{"start_line":868,"start_character":24,"end_line":868,"end_character":26},"updated":"2020-07-22 13:28:21.000000000","message":"again, my concern is about bugfix backports. You do Py3 styling, I understand the reasoning behind this but I\u0027m not sure stable cores would see it.\n\nSince you don\u0027t provide an unittest for it, CI in ,say,  Stein would accept it but then if the libvirt driver provides a new job type, then you would get a SyntaxError.\n\nOf course, you could say \"heh, but if it\u0027s Stein, why should we be supporting new driver releases ?\" and I agree with you, it shouldn\u0027t be a problem.\nBut, the more we provide new py3 styles without thinking about backports, the more we could get issues with backporting, right?","commit_id":"c97ccb3634985db0e4d66d16834e141be8a20914"}]}