)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6896,"name":"Loganathan Parthipan","email":"parthi@hpe.com","username":"parthipan"},"change_message_id":"b054c12f14cbf52055ded39fddbf7e6d02037e1d","unresolved":false,"context_lines":[{"line_number":2927,"context_line":"                                                           disk_mapping,"},{"line_number":2928,"context_line":"                                                           inst_type)"},{"line_number":2929,"context_line":"                    devices.append(disklocal)"},{"line_number":2930,"context_line":""},{"line_number":2931,"context_line":"            else:"},{"line_number":2932,"context_line":"                if \u0027disk\u0027 in disk_mapping:"},{"line_number":2933,"context_line":"                    diskos \u003d self.get_guest_disk_config(instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Fh%2FI%3D","line":2930,"updated":"2014-02-12 15:17:26.000000000","message":"This is not enough. There can be multiple ephemerals. You have to use block_device_info_get_ephemerals and add them as well.","commit_id":"60d34b0788a5267a11a9461f5836fefdd2eb6c89"},{"author":{"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},"change_message_id":"00045ea8b7f680160f7e9f2fe63c59711e763457","unresolved":false,"context_lines":[{"line_number":2927,"context_line":"                                                           disk_mapping,"},{"line_number":2928,"context_line":"                                                           inst_type)"},{"line_number":2929,"context_line":"                    devices.append(disklocal)"},{"line_number":2930,"context_line":""},{"line_number":2931,"context_line":"            else:"},{"line_number":2932,"context_line":"                if \u0027disk\u0027 in disk_mapping:"},{"line_number":2933,"context_line":"                    diskos \u003d self.get_guest_disk_config(instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2Fh2g%3D","line":2930,"in_reply_to":"AAAAUX%2F%2Fh%2FI%3D","updated":"2014-02-12 15:31:43.000000000","message":"Sure thing. My reading of the bug was what led me to only deal with the default ephemeral. I\u0027ll look at handling the others now.","commit_id":"60d34b0788a5267a11a9461f5836fefdd2eb6c89"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8a1fd7533b551cec2df7e6ba8ee9bb46f3d0cf86","unresolved":false,"context_lines":[{"line_number":2935,"context_line":"                        instance,"},{"line_number":2936,"context_line":"                        blockinfo.get_eph_disk(idx),"},{"line_number":2937,"context_line":"                        disk_mapping, inst_type)"},{"line_number":2938,"context_line":"                    devices.append(diskeph)"},{"line_number":2939,"context_line":""},{"line_number":2940,"context_line":"            else:"},{"line_number":2941,"context_line":"                if \u0027disk\u0027 in disk_mapping:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2Bt6Y%3D","line":2938,"updated":"2014-02-19 16:01:08.000000000","message":"You\u0027ve fixed presence of disk.local and the other ephemeral disks,  but we\u0027re still missing disk.swap and any block volume mappings.\n\nI can\u0027t help thinking we should just get rid of this big \u0027if rescue\u0027  conditional. Have one codepath for setting up the disks, but simply do \u0027disk.rescue\u0027 first if needed.","commit_id":"9a2819c8eb66e617ee466528593d5b10bc052ecd"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c3a50c35ca5f6091a00745c9f91fa298612ffa43","unresolved":false,"context_lines":[{"line_number":2935,"context_line":"                        instance,"},{"line_number":2936,"context_line":"                        blockinfo.get_eph_disk(idx),"},{"line_number":2937,"context_line":"                        disk_mapping, inst_type)"},{"line_number":2938,"context_line":"                    devices.append(diskeph)"},{"line_number":2939,"context_line":""},{"line_number":2940,"context_line":"            else:"},{"line_number":2941,"context_line":"                if \u0027disk\u0027 in disk_mapping:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAVn%2F%2Bw2Y%3D","line":2938,"in_reply_to":"AAAAUX%2F%2BXsA%3D","updated":"2014-03-12 10:29:24.000000000","message":"I also wonder if we need to update the block device mappings in the database, to ensure that reflects reality at this point?","commit_id":"9a2819c8eb66e617ee466528593d5b10bc052ecd"},{"author":{"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},"change_message_id":"2edc29824a190a36d77af4a60f1d8567db04a89d","unresolved":false,"context_lines":[{"line_number":2935,"context_line":"                        instance,"},{"line_number":2936,"context_line":"                        blockinfo.get_eph_disk(idx),"},{"line_number":2937,"context_line":"                        disk_mapping, inst_type)"},{"line_number":2938,"context_line":"                    devices.append(diskeph)"},{"line_number":2939,"context_line":""},{"line_number":2940,"context_line":"            else:"},{"line_number":2941,"context_line":"                if \u0027disk\u0027 in disk_mapping:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2BXsA%3D","line":2938,"in_reply_to":"AAAAUX%2F%2Bt6Y%3D","updated":"2014-02-21 15:36:29.000000000","message":"I\u0027m happy to go that way with it. I\u0027ll have a look at what it might entail.","commit_id":"9a2819c8eb66e617ee466528593d5b10bc052ecd"},{"author":{"_account_id":6896,"name":"Loganathan Parthipan","email":"parthi@hpe.com","username":"parthipan"},"change_message_id":"0c5180319c0d9c4b540e2a5012cf0d0815f96295","unresolved":false,"context_lines":[{"line_number":2989,"context_line":"                        instance,"},{"line_number":2990,"context_line":"                        blockinfo.get_eph_disk(idx),"},{"line_number":2991,"context_line":"                        disk_mapping, inst_type)"},{"line_number":2992,"context_line":"                    devices.append(diskeph)"},{"line_number":2993,"context_line":"            else:"},{"line_number":2994,"context_line":"                if \u0027disk\u0027 in disk_mapping:"},{"line_number":2995,"context_line":"                    diskos \u003d self.get_guest_disk_config(instance,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2F9CU%3D","line":2992,"updated":"2014-04-09 09:25:29.000000000","message":"One question here, which I hadn\u0027t thought of earlier: Have you verified the case if there\u0027s also (one or more) volume(s) attached at boot time and it works as expected with this patchset?\n\nI think it would work fine and not be mounted, just like a dynamic volume, but something that I\u0027d like to have verified.","commit_id":"c71f66455560d42014989655007f298a1e9d15eb"},{"author":{"_account_id":1882,"name":"dave-mcnally","email":"dave.mcnally@hpe.com","username":"dave-mcnally"},"change_message_id":"3afaf20db65d73f91c3065cef56dee68b03d5a29","unresolved":false,"context_lines":[{"line_number":2989,"context_line":"                        instance,"},{"line_number":2990,"context_line":"                        blockinfo.get_eph_disk(idx),"},{"line_number":2991,"context_line":"                        disk_mapping, inst_type)"},{"line_number":2992,"context_line":"                    devices.append(diskeph)"},{"line_number":2993,"context_line":"            else:"},{"line_number":2994,"context_line":"                if \u0027disk\u0027 in disk_mapping:"},{"line_number":2995,"context_line":"                    diskos \u003d self.get_guest_disk_config(instance,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAW3%2F%2F6Ao%3D","line":2992,"in_reply_to":"AAAAW3%2F%2F9CU%3D","updated":"2014-04-09 15:19:26.000000000","message":"It wouldn\u0027t be mounted. The only new items mounted under this fix are ephemeral disks during a rescue.","commit_id":"c71f66455560d42014989655007f298a1e9d15eb"}]}