)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d7d44598d21f802a8742694b247741a33ee19640","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I don\u0027t actually grok what this does that \u0027oslopolicy-checker\u0027 couldn\u0027t"},{"line_number":10,"context_line":"do, so perhaps we can deprecate this in the future. For now though,"},{"line_number":11,"context_line":"simply document the thing."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Yes, \u0027nova-policy policy check\u0027 is dumb. Don\u0027t blame me :)"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"43d2805b_de7714d2","line":11,"updated":"2021-04-13 16:38:56.000000000","message":"yes i think we should determine that and remove if we dont need it anymore.\nbut i agree documenting makes sense while we have it.","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c47229fed7f179e1e5af3af356724f379bc8d3c","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I don\u0027t actually grok what this does that \u0027oslopolicy-checker\u0027 couldn\u0027t"},{"line_number":10,"context_line":"do, so perhaps we can deprecate this in the future. For now though,"},{"line_number":11,"context_line":"simply document the thing."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Yes, \u0027nova-policy policy check\u0027 is dumb. Don\u0027t blame me :)"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"c01d6b67_2bc5dec5","line":11,"in_reply_to":"43d2805b_de7714d2","updated":"2021-04-13 16:49:40.000000000","message":"you are actully doing 3 things in the patch\n1 improving the exsiting help strings\n2 adding a new doc for nova-policy\n3 enabling manpage support\ncan you call out all 3 in the commit message.","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84fff31db5c46a94a35f9a39605c64c00336eff5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I don\u0027t actually grok what this does that \u0027oslopolicy-checker\u0027 couldn\u0027t"},{"line_number":10,"context_line":"do, so perhaps we can deprecate this in the future. For now though,"},{"line_number":11,"context_line":"simply document the thing."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Yes, \u0027nova-policy policy check\u0027 is dumb. Don\u0027t blame me :)"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d5743212_793b2237","line":11,"in_reply_to":"c01d6b67_2bc5dec5","updated":"2021-04-14 09:55:50.000000000","message":"Done","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"}],"doc/source/cli/nova-compute.rst":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"51905491451f074820815c3fce06fb4a9959615a","unresolved":true,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. todo: We shouldn\u0027t have policy configuration in this non-API service, but"},{"line_number":37,"context_line":"   bug #1675486 means we do have one"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* ``/etc/nova/nova.conf``"},{"line_number":40,"context_line":"* ``/etc/nova/policy.yaml``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"b65e4f96_6f0bacfd","line":37,"updated":"2021-04-17 20:42:23.000000000","message":"Is this supposed to show up in the doc? I don\u0027t see it here:\n\nhttps://ab1542f2bab916d04e8d-f9581a5a5cbf2c732684738263e0ea57.ssl.cf1.rackcdn.com/729918/7/check/openstack-tox-docs/dc9a5ba/docs/cli/nova-compute.html","commit_id":"f7d95e41b2b8293f45cbfc0857c899cc38f36eb3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5389343a87616eb89eae8f1f1ae7905380fee647","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. todo: We shouldn\u0027t have policy configuration in this non-API service, but"},{"line_number":37,"context_line":"   bug #1675486 means we do have one"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* ``/etc/nova/nova.conf``"},{"line_number":40,"context_line":"* ``/etc/nova/policy.yaml``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba1a680e_c41d4ff5","line":37,"in_reply_to":"b65e4f96_6f0bacfd","updated":"2021-04-19 09:47:31.000000000","message":"No, I purposefully didn\u0027t include it since I didn\u0027t think it made sense in a man page (as opposed to HTML docs). If you wanted it to appear, you\u0027d need another colon\n\n  .. todo:: text here","commit_id":"f7d95e41b2b8293f45cbfc0857c899cc38f36eb3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8fe049fcead9373c60a816153417c85a3adab87a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"\u003d\u003d\u003d\u003d\u003d"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. todo: We shouldn\u0027t have policy configuration in this non-API service, but"},{"line_number":37,"context_line":"   bug #1675486 means we do have one"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"* ``/etc/nova/nova.conf``"},{"line_number":40,"context_line":"* ``/etc/nova/policy.yaml``"}],"source_content_type":"text/x-rst","patch_set":7,"id":"f307bd4f_59badd52","line":37,"in_reply_to":"ba1a680e_c41d4ff5","updated":"2021-04-19 15:30:38.000000000","message":"OK, thanks for confirming","commit_id":"f7d95e41b2b8293f45cbfc0857c899cc38f36eb3"}],"doc/source/cli/nova-policy.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c47229fed7f179e1e5af3af356724f379bc8d3c","unresolved":true,"context_lines":[{"line_number":14,"context_line":"Description"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":":program:`nova-policy` is a tool that allows for inspection of policy"},{"line_number":18,"context_line":"configuration for the specified user. It provides a way to identify the actions"},{"line_number":19,"context_line":"available for a user."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a830a22_758c46e8","line":17,"range":{"start_line":17,"start_character":10,"end_line":17,"end_character":21},"updated":"2021-04-13 16:49:40.000000000","message":"we really should have a way to do this from the api possible enabled by keystone middelware.\n\ne.g. so that as an enduser of openstack you can do this via the rest api. currently this need the policy file so only the operator can do this which limits the utility of the tool.","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84fff31db5c46a94a35f9a39605c64c00336eff5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Description"},{"line_number":15,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":":program:`nova-policy` is a tool that allows for inspection of policy"},{"line_number":18,"context_line":"configuration for the specified user. It provides a way to identify the actions"},{"line_number":19,"context_line":"available for a user."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"6c0daea7_f9f31e60","line":17,"range":{"start_line":17,"start_character":10,"end_line":17,"end_character":21},"in_reply_to":"1a830a22_758c46e8","updated":"2021-04-14 09:55:50.000000000","message":"Fair point, though not really relevant to this change 😉","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e59b5300910d7901d79aae3fcc64b9e8c9cd94e","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. rubric:: General options"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. include:: opts/common.rst"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. rubric:: User options"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"bcf3ede7_17bf4fe9","line":26,"updated":"2021-04-13 17:23:25.000000000","message":"by the way im guessing this add a --config option that allows you to specifiy an alternive nova.conf to use and then the policy file comes from that right?","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84fff31db5c46a94a35f9a39605c64c00336eff5","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":".. rubric:: General options"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. include:: opts/common.rst"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. rubric:: User options"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"55eb6934_91e3c54a","line":26,"in_reply_to":"bcf3ede7_17bf4fe9","updated":"2021-04-14 09:55:50.000000000","message":"It will \"include\" the \"opts/common.rst\" file verbatim here. That file contains a whole load of \u0027.. option\u0027 directives, yes. You can see this by looking at the built docs.","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c47229fed7f179e1e5af3af356724f379bc8d3c","unresolved":true,"context_lines":[{"line_number":73,"context_line":"Files"},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* ``/etc/nova/policy.json``"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"See Also"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"222ba4dd_79fcb9f4","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":1},"updated":"2021-04-13 16:49:40.000000000","message":"is this hard coded i would have like to see a couple of clarifications\n\n1 where this path comes from e.g. is it coming form nova.conf\n2 does it work with policy.yaml which should be our default now.\n3 i would like a note here that calls out that this will use the files on your local machine where the command is invoked not the rest api or data form the remote cloud.","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84fff31db5c46a94a35f9a39605c64c00336eff5","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Files"},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"* ``/etc/nova/policy.json``"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"See Also"},{"line_number":79,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"75caa4b3_fba10daa","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":1},"in_reply_to":"222ba4dd_79fcb9f4","updated":"2021-04-14 09:55:50.000000000","message":"\u003e is this hard coded i would have like to see a couple of clarifications\n\nThis is copy-pasted from the other man pages so I haven\u0027t really given it much thought. However, I think the structure here (i.e. just listing files) is correct. From man-page(7) [1]:\n\n  FILES\n\n  lists the files the program or function uses, such as configuration files,\n  startup files, and files the program directly operates on. Give the full\n  pathname of these files, and use the installation process to modify the\n  directory part to match user preferences. For many programs, the default\n  installation location is in /usr/local, so your base manual page should\n  use /usr/local as the base. \n\nObviously we use \u0027/etc/nova\u0027 rather than \u0027/usr/local\u0027 as our installation directory so that must be changed, but otherwise we\u0027re doing as we\u0027ve been told to do.\n\nTo answer your questions\n\n\u003e 1 where this path comes from e.g. is it coming form nova.conf\n\nThis is kind of implicit. We use absolute paths with \u0027/etc/nova\u0027 for the \u0027provider.yaml\u0027 and \u0027rootwrap\u0027 configuration, (via \u0027[compute] provider_config_location\u0027 and \u0027[DEFAULT] rootwrap_config\u0027, respectively), however, the policy file path is a relative path (defined by oslo.config in \u0027oslo_config/opts.py\u0027 but currently overridden in \u0027nova/policy.py\u0027 to prefer the \u0027.yaml\u0027 format) which means it must be laid down beside \u0027nova.conf\u0027. \u0027nova.conf\u0027 is by custom found in \u0027/etc/nova\u0027. This path is derived from oslo.config\u0027s \u0027find_config_files\u0027 function (found in \u0027oslo_config/cfg.py\u0027) which uses the following paths:\n\n- ~/.${project}/\n- ~/\n- /etc/${project}/\n- /etc/\n- ${SNAP_COMMON}/etc/${project}\n- ${SNAP}/etc/${project}\n\nProject here is obviously \u0027nova\u0027.\n\nNone of this information belongs here. I can put it into our config docs in a follow-up.\n\n\u003e 2 does it work with policy.yaml which should be our default now.\n\nYes, and this should read \u0027policy.yaml\u0027. Updated.w\n\n\u003e 3 i would like a note here that calls out that this will use the files on your local machine where the command is invoked not the rest api or data form the remote cloud.\n\nI clarified this above in the summary.\n\n[1] https://linux.die.net/man/7/man-pages","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"}],"doc/source/cli/nova-status.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c47229fed7f179e1e5af3af356724f379bc8d3c","unresolved":true,"context_lines":[{"line_number":152,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":":doc:`nova-manage(1) \u003cnova-manage\u003e`,"},{"line_number":155,"context_line":":doc:`nova-policy(1) \u003cnova-policy\u003e`"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Bugs"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"9a1b89fe_977617e1","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":1},"updated":"2021-04-13 16:49:40.000000000","message":"not strictly related to adding manpages as the commit sugges but yes this is an improment if an unrelated one","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84fff31db5c46a94a35f9a39605c64c00336eff5","unresolved":false,"context_lines":[{"line_number":152,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":":doc:`nova-manage(1) \u003cnova-manage\u003e`,"},{"line_number":155,"context_line":":doc:`nova-policy(1) \u003cnova-policy\u003e`"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"Bugs"},{"line_number":158,"context_line":"\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"34c7e2ce_8336a8ad","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":1},"in_reply_to":"9a1b89fe_977617e1","updated":"2021-04-14 09:55:50.000000000","message":"Ack","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"}],"doc/source/conf.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c47229fed7f179e1e5af3af356724f379bc8d3c","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    ("},{"line_number":102,"context_line":"        \u0027nova-policy\u0027,"},{"line_number":103,"context_line":"        \u0027Inspect policy configuration for the OpenStack Compute services.\u0027,"},{"line_number":104,"context_line":"    ),"},{"line_number":105,"context_line":"    ("},{"line_number":106,"context_line":"        \u0027nova-scheduler\u0027,"},{"line_number":107,"context_line":"        \u0027Server for the OpenStack Compute scheduler service.\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"55d8ccae_1c246770","line":104,"updated":"2021-04-13 16:49:40.000000000","message":"this is the main change that enable the man page generation","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84fff31db5c46a94a35f9a39605c64c00336eff5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    ("},{"line_number":102,"context_line":"        \u0027nova-policy\u0027,"},{"line_number":103,"context_line":"        \u0027Inspect policy configuration for the OpenStack Compute services.\u0027,"},{"line_number":104,"context_line":"    ),"},{"line_number":105,"context_line":"    ("},{"line_number":106,"context_line":"        \u0027nova-scheduler\u0027,"},{"line_number":107,"context_line":"        \u0027Server for the OpenStack Compute scheduler service.\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ec33880_75aef2d6","line":104,"in_reply_to":"55d8ccae_1c246770","updated":"2021-04-14 09:55:50.000000000","message":"Yup","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"}],"nova/cmd/policy.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c47229fed7f179e1e5af3af356724f379bc8d3c","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @cmd_common.args("},{"line_number":66,"context_line":"        \u0027--api-name\u0027, dest\u003d\u0027api_name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":67,"context_line":"        help\u003d\u0027Return only the passing policy rules containing the given API \u0027"},{"line_number":68,"context_line":"             \u0027name. If None, all passing policy rules will be returned.\u0027"},{"line_number":69,"context_line":"    )"},{"line_number":70,"context_line":"    @cmd_common.args("}],"source_content_type":"text/x-python","patch_set":6,"id":"6f8b45aa_dff6dea3","line":67,"updated":"2021-04-13 16:49:40.000000000","message":"ok this is just a tense change with a clarificaiton of what happens in not passed which was previously only in the doc string for the devloper and is now user facing +1","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84fff31db5c46a94a35f9a39605c64c00336eff5","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @cmd_common.args("},{"line_number":66,"context_line":"        \u0027--api-name\u0027, dest\u003d\u0027api_name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":67,"context_line":"        help\u003d\u0027Return only the passing policy rules containing the given API \u0027"},{"line_number":68,"context_line":"             \u0027name. If None, all passing policy rules will be returned.\u0027"},{"line_number":69,"context_line":"    )"},{"line_number":70,"context_line":"    @cmd_common.args("}],"source_content_type":"text/x-python","patch_set":6,"id":"99dccaaf_725ae505","line":67,"in_reply_to":"6f8b45aa_dff6dea3","updated":"2021-04-14 09:55:50.000000000","message":"Ack","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8c47229fed7f179e1e5af3af356724f379bc8d3c","unresolved":true,"context_lines":[{"line_number":74,"context_line":"             \"used, the other targets will be overwritten. If None, the given \""},{"line_number":75,"context_line":"             \"user will be considered the target.\" %"},{"line_number":76,"context_line":"             \u0027, \u0027.join(_ACCEPTABLE_TARGETS)"},{"line_number":77,"context_line":"    )"},{"line_number":78,"context_line":"    def check(self, api_name\u003dNone, target\u003dNone):"},{"line_number":79,"context_line":"        \"\"\"Prints all passing policy rules for the given user.\"\"\""},{"line_number":80,"context_line":"        context \u003d self._get_context()"}],"source_content_type":"text/x-python","patch_set":6,"id":"a48402cc_4de8d233","line":77,"updated":"2021-04-13 16:49:40.000000000","message":"this also combins the useful info form the function doc string into the user faceing help string with is good +1","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"84fff31db5c46a94a35f9a39605c64c00336eff5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"             \"used, the other targets will be overwritten. If None, the given \""},{"line_number":75,"context_line":"             \"user will be considered the target.\" %"},{"line_number":76,"context_line":"             \u0027, \u0027.join(_ACCEPTABLE_TARGETS)"},{"line_number":77,"context_line":"    )"},{"line_number":78,"context_line":"    def check(self, api_name\u003dNone, target\u003dNone):"},{"line_number":79,"context_line":"        \"\"\"Prints all passing policy rules for the given user.\"\"\""},{"line_number":80,"context_line":"        context \u003d self._get_context()"}],"source_content_type":"text/x-python","patch_set":6,"id":"96c15e5d_9a4e5bbd","line":77,"in_reply_to":"a48402cc_4de8d233","updated":"2021-04-14 09:55:50.000000000","message":"Ack","commit_id":"fb14feb236561ef46f3d8156a71fd83b8325ce36"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"51905491451f074820815c3fce06fb4a9959615a","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    @cmd_common.args("},{"line_number":66,"context_line":"        \u0027--api-name\u0027, dest\u003d\u0027api_name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":67,"context_line":"        help\u003d("},{"line_number":68,"context_line":"            \u0027Return only the passing policy rules containing the given API \u0027"},{"line_number":69,"context_line":"            \u0027name. If None, all passing policy rules will be returned.\u0027"},{"line_number":70,"context_line":"        ),"},{"line_number":71,"context_line":"    )"},{"line_number":72,"context_line":"    @cmd_common.args("}],"source_content_type":"text/x-python","patch_set":7,"id":"4d9c6a29_54401cdd","line":69,"range":{"start_line":68,"start_character":12,"end_line":69,"end_character":71},"updated":"2021-04-17 20:42:23.000000000","message":"Same","commit_id":"f7d95e41b2b8293f45cbfc0857c899cc38f36eb3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5389343a87616eb89eae8f1f1ae7905380fee647","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    @cmd_common.args("},{"line_number":66,"context_line":"        \u0027--api-name\u0027, dest\u003d\u0027api_name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":67,"context_line":"        help\u003d("},{"line_number":68,"context_line":"            \u0027Return only the passing policy rules containing the given API \u0027"},{"line_number":69,"context_line":"            \u0027name. If None, all passing policy rules will be returned.\u0027"},{"line_number":70,"context_line":"        ),"},{"line_number":71,"context_line":"    )"},{"line_number":72,"context_line":"    @cmd_common.args("}],"source_content_type":"text/x-python","patch_set":7,"id":"63f12c1e_51c1b15d","line":69,"range":{"start_line":68,"start_character":12,"end_line":69,"end_character":71},"in_reply_to":"4d9c6a29_54401cdd","updated":"2021-04-19 09:47:31.000000000","message":"Done","commit_id":"f7d95e41b2b8293f45cbfc0857c899cc38f36eb3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"51905491451f074820815c3fce06fb4a9959615a","unresolved":true,"context_lines":[{"line_number":72,"context_line":"    @cmd_common.args("},{"line_number":73,"context_line":"        \u0027--target\u0027, nargs\u003d\u0027+\u0027, dest\u003d\u0027target\u0027, metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":74,"context_line":"        help\u003d("},{"line_number":75,"context_line":"            \"The target(s) against which the policy rule authorization will \""},{"line_number":76,"context_line":"            \"be tested. The available targets are %s. When \u0027instance_id\u0027 is \""},{"line_number":77,"context_line":"            \"used, the other targets will be overwritten. If None, the given \""},{"line_number":78,"context_line":"            \"user will be considered the target.\" % \u0027, \u0027.join("},{"line_number":79,"context_line":"                _ACCEPTABLE_TARGETS"},{"line_number":80,"context_line":"            )"},{"line_number":81,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":7,"id":"fc823af2_275055fa","line":78,"range":{"start_line":75,"start_character":11,"end_line":78,"end_character":49},"updated":"2021-04-17 20:42:23.000000000","message":"This doesn\u0027t quite match what you have at https://review.opendev.org/c/openstack/nova/+/729918/7/doc/source/cli/nova-policy.rst#71\n\nIs it intentional?","commit_id":"f7d95e41b2b8293f45cbfc0857c899cc38f36eb3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5389343a87616eb89eae8f1f1ae7905380fee647","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    @cmd_common.args("},{"line_number":73,"context_line":"        \u0027--target\u0027, nargs\u003d\u0027+\u0027, dest\u003d\u0027target\u0027, metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":74,"context_line":"        help\u003d("},{"line_number":75,"context_line":"            \"The target(s) against which the policy rule authorization will \""},{"line_number":76,"context_line":"            \"be tested. The available targets are %s. When \u0027instance_id\u0027 is \""},{"line_number":77,"context_line":"            \"used, the other targets will be overwritten. If None, the given \""},{"line_number":78,"context_line":"            \"user will be considered the target.\" % \u0027, \u0027.join("},{"line_number":79,"context_line":"                _ACCEPTABLE_TARGETS"},{"line_number":80,"context_line":"            )"},{"line_number":81,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":7,"id":"036247aa_26f1b2b2","line":78,"range":{"start_line":75,"start_character":11,"end_line":78,"end_character":49},"in_reply_to":"fc823af2_275055fa","updated":"2021-04-19 09:47:31.000000000","message":"Nope. Fixed.","commit_id":"f7d95e41b2b8293f45cbfc0857c899cc38f36eb3"}]}