)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a2b45bdb55c71777df55cdea1236b2f01376b19","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cap jsonschema 3.2.0 as the minimal version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previous versions of jsonschema (\u003c3.2.0) doesn\u0027t support python 3.8 [1]."},{"line_number":10,"context_line":"Python 3.8 is part of the victoria supported runtimes [2] so we now force"},{"line_number":11,"context_line":"to use jsonschema version 3.2.0 to avoid issues, remove ambiguity and ensure"},{"line_number":12,"context_line":"that everything works with python 3 in general."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_6b9729ed","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":72},"updated":"2020-05-27 00:30:27.000000000","message":"is it ? py38 job pass without issue with old jsonschema version also","commit_id":"325e51f1b029f8e8c79a119b1632f873e6328865"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"3d8278f254058be7eced8c32e1517f0b4afb6c54","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cap jsonschema 3.2.0 as the minimal version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previous versions of jsonschema (\u003c3.2.0) doesn\u0027t support python 3.8 [1]."},{"line_number":10,"context_line":"Python 3.8 is part of the victoria supported runtimes [2] so we now force"},{"line_number":11,"context_line":"to use jsonschema version 3.2.0 to avoid issues, remove ambiguity and ensure"},{"line_number":12,"context_line":"that everything works with python 3 in general."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_bb1b2c19","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":72},"in_reply_to":"ff570b3c_6b9729ed","updated":"2020-05-28 14:57:08.000000000","message":"I think it\u0027s because in the current requirements we cap to `jsonschema\u003e\u003d2.6.0` so latest version (3.2.0) is pulled so this is why we don\u0027t facing any issue in CI, but if for some reason a version lower than 3.2.0 and higher or equal 2.6.0 is already installed then requirements could be seen as satisfied and then we could face an issue in this case, so these changes ensure to don\u0027t fall in this scenario.","commit_id":"325e51f1b029f8e8c79a119b1632f873e6328865"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5dba1e84fffb82dd9b0a69e9f630d695a167550a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Cap jsonschema 3.2.0 as the minimal version"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Previous versions of jsonschema (\u003c3.2.0) doesn\u0027t support python 3.8 [1]."},{"line_number":10,"context_line":"Python 3.8 is part of the victoria supported runtimes [2] so we now force"},{"line_number":11,"context_line":"to use jsonschema version 3.2.0 to avoid issues, remove ambiguity and ensure"},{"line_number":12,"context_line":"that everything works with python 3 in general."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_757b1b7a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":72},"in_reply_to":"ff570b3c_bb1b2c19","updated":"2020-06-23 20:37:13.000000000","message":"yeah on gate we are ok with 3.2.0 is being selected. \n\nI was worried if we end up using the default validator of 3.2.0 which is Draft7Validator but in nova we have hardcoded that to Draft4Validator[1] which is safe here and later we can migrate it to Draft7Validator.\n\nhttps://github.com/openstack/nova/blob/f1ebc15dfc8ffb7f23b2cb9879f0ca9376931a90/nova/api/validation/validators.py#L260","commit_id":"325e51f1b029f8e8c79a119b1632f873e6328865"}]}