)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6d6359608540f402b8752e2fcfa2bfc5c7580883","unresolved":false,"context_lines":[{"line_number":30,"context_line":"backports. Future changes should be made to use this class removing some"},{"line_number":31,"context_line":"of the common setUp logic from _LibvirtEvacuateTest."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"NOTE(lyarwood): Calls to _wait_for_state_change and"},{"line_number":34,"context_line":"_wait_for_server_parameter now provide self.api as required prior to"},{"line_number":35,"context_line":"I8c96b337f32148f8f5899c9b87af331b1fa41424 landing in Ussuri."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Co-Authored-By: Lee Yarwood \u003clyarwood@redhat.com\u003e"},{"line_number":38,"context_line":"Related-Bug: #1550919"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_caf2cf6f","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":60},"updated":"2020-06-09 14:56:45.000000000","message":"Note to other reviewers: these changes aren\u0027t immediately obvious since there aren\u0027t any merge conflicts here. Rather, the changes were to handle changes in APIs as lyarwood notes here.\n\n    diff --git nova/tests/functional/libvirt/test_evacuate.py nova/tests/functional/libvirt/test_evacuate.py\n    index 4dd173adb2..605c0792f8 100644\n    --- nova/tests/functional/libvirt/test_evacuate.py\n    +++ nova/tests/functional/libvirt/test_evacuate.py\n    @@ -505,8 +505,8 @@ class _LibvirtEvacuateTest(integrated_helpers.InstanceHelperMixin):\n                 # Wait for server to become ACTIVE, and return its updated state\n                 # NOTE(mdbooth): Increase max_retries from default to reduce\n                 # chances of timeout.\n    -            return self._wait_for_state_change(server, \u0027ACTIVE\u0027,\n    -                                               max_retries\u003d30)\n    +            return self._wait_for_state_change(\n    +                self.api, server, \u0027ACTIVE\u0027, max_retries\u003d30)\n     \n             return [_create_server(server) for server in SERVER_FIXTURES]\n     \n    @@ -534,7 +534,7 @@ class _LibvirtEvacuateTest(integrated_helpers.InstanceHelperMixin):\n                         \u0027instance.rebuild.start\u0027)\n                 self._wait_for_migration_status(server, [\u0027failed\u0027])\n                 server \u003d self._wait_for_server_parameter(\n    -                server, {\u0027OS-EXT-STS:task_state\u0027: None})\n    +                self.api, server, {\u0027OS-EXT-STS:task_state\u0027: None})\n     \n                 # Meta-test\n                 plug_vifs.assert_called()","commit_id":"172eb21dee1d93b140c2b691cb8dfbc68b721bfe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2fc710cb68ddcaeab5d869e8a63ccfb9ee754979","unresolved":false,"context_lines":[{"line_number":30,"context_line":"backports. Future changes should be made to use this class removing some"},{"line_number":31,"context_line":"of the common setUp logic from _LibvirtEvacuateTest."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"NOTE(lyarwood): Calls to _wait_for_state_change and"},{"line_number":34,"context_line":"_wait_for_server_parameter now provide self.api as required prior to"},{"line_number":35,"context_line":"I8c96b337f32148f8f5899c9b87af331b1fa41424 landing in Ussuri."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Co-Authored-By: Lee Yarwood \u003clyarwood@redhat.com\u003e"},{"line_number":38,"context_line":"Related-Bug: #1550919"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_2a39cbf1","line":35,"range":{"start_line":33,"start_character":0,"end_line":35,"end_character":60},"in_reply_to":"ff570b3c_caf2cf6f","updated":"2020-06-09 14:59:15.000000000","message":"BTW, I personally like adding a \u0027Changes\u0027 section similar to the \u0027Conflicts\u0027 section when you\u0027ve to make manual changes like this. Certainly not a necessity though","commit_id":"172eb21dee1d93b140c2b691cb8dfbc68b721bfe"}],"nova/tests/functional/libvirt/test_evacuate.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6d6359608540f402b8752e2fcfa2bfc5c7580883","unresolved":false,"context_lines":[{"line_number":506,"context_line":"            # NOTE(mdbooth): Increase max_retries from default to reduce"},{"line_number":507,"context_line":"            # chances of timeout."},{"line_number":508,"context_line":"            return self._wait_for_state_change("},{"line_number":509,"context_line":"                self.api, server, \u0027ACTIVE\u0027, max_retries\u003d30)"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        return [_create_server(server) for server in SERVER_FIXTURES]"},{"line_number":512,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_aafb1b45","line":509,"range":{"start_line":509,"start_character":16,"end_line":509,"end_character":25},"updated":"2020-06-09 14:56:45.000000000","message":"here","commit_id":"172eb21dee1d93b140c2b691cb8dfbc68b721bfe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6d6359608540f402b8752e2fcfa2bfc5c7580883","unresolved":false,"context_lines":[{"line_number":534,"context_line":"                    \u0027instance.rebuild.start\u0027)"},{"line_number":535,"context_line":"            self._wait_for_migration_status(server, [\u0027failed\u0027])"},{"line_number":536,"context_line":"            server \u003d self._wait_for_server_parameter("},{"line_number":537,"context_line":"                self.api, server, {\u0027OS-EXT-STS:task_state\u0027: None})"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"            # Meta-test"},{"line_number":540,"context_line":"            plug_vifs.assert_called()"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_0aa2074c","line":537,"range":{"start_line":537,"start_character":16,"end_line":537,"end_character":25},"updated":"2020-06-09 14:56:45.000000000","message":"and here","commit_id":"172eb21dee1d93b140c2b691cb8dfbc68b721bfe"}]}