)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c66db4b9c77a3a60128332beb1f721c74105fd10","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This change modifies spawn in the libvirt driver such that it only"},{"line_number":16,"context_line":"cleans up resources it created."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"NOTE(lyarwood): Conflicts due to I08cd4787ab4c9539574237e26ba5bf6d4246b32e"},{"line_number":19,"context_line":"and I5a9e5532c46a5f7064441ae644125d21efe5fda1 not being present in"},{"line_number":20,"context_line":"stable/train."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Conflicts:"},{"line_number":23,"context_line":"    nova/tests/unit/virt/libvirt/test_driver.py"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Co-Authored-By: Lee Yarwood \u003clyarwood@redhat.com\u003e"},{"line_number":26,"context_line":"Closes-Bug: #1550919"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_0a17a753","line":23,"range":{"start_line":18,"start_character":0,"end_line":23,"end_character":47},"updated":"2020-06-09 15:08:21.000000000","message":"nit: I\u0027d like to see these switched, i.e. what changed followed by why. Also, it\u0027d be nice if the subject of the commit was also included alongside the change ID\n\n  NOTE(lyarwood): Conflicts due to I08cd4787ab4c9539574237e26ba5bf6d4246b32e\n  (\"Compose accelerator PCI devices into domain XML in libvirt driver.\")\n  and ...\n\nplus the reason we don\u0027t want to backport those things.\n\nFor other reviewers, the changes are really minimal, consisting of three hunks. The first is to do with cyborg, where additional tests were added, while the latter is a nova-net removal patch, which dropped the \u0027firewall_driver\u0027 attribute and the need to mock same. Clearly neither should be backported.","commit_id":"005fcaf01f22aebee58ee70cdcc7ef56da6c59af"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1da086713d53edc4e04bf12c7096d8e855e3ab93","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This change modifies spawn in the libvirt driver such that it only"},{"line_number":16,"context_line":"cleans up resources it created."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"NOTE(lyarwood): Conflicts due to I08cd4787ab4c9539574237e26ba5bf6d4246b32e"},{"line_number":19,"context_line":"and I5a9e5532c46a5f7064441ae644125d21efe5fda1 not being present in"},{"line_number":20,"context_line":"stable/train."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Conflicts:"},{"line_number":23,"context_line":"    nova/tests/unit/virt/libvirt/test_driver.py"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Co-Authored-By: Lee Yarwood \u003clyarwood@redhat.com\u003e"},{"line_number":26,"context_line":"Closes-Bug: #1550919"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_ec16c855","line":23,"range":{"start_line":18,"start_character":0,"end_line":23,"end_character":47},"in_reply_to":"ff570b3c_0a17a753","updated":"2020-06-10 00:20:03.000000000","message":"+1 you are right that we usually add the NOTE after the Conflicts: list, this might have been a one-off.\n\nFWIW, we usually don\u0027t note the reason not to backport the missing conflicting changes if they are obvious like these. Sometimes, there are changes not present on the stable branch that cause conflicts and are mixed in with larger or feature-related changes [that should not be backported], and in that case we selectively cherry pick the pieces we need for the backport and note it in the commit message too.","commit_id":"005fcaf01f22aebee58ee70cdcc7ef56da6c59af"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"1da086713d53edc4e04bf12c7096d8e855e3ab93","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Co-Authored-By: Lee Yarwood \u003clyarwood@redhat.com\u003e"},{"line_number":26,"context_line":"Closes-Bug: #1550919"},{"line_number":27,"context_line":"Change-Id: I764481966c96a67d993da6e902dc9fc3ad29ee36"},{"line_number":28,"context_line":"(cherry picked from commit 083df01a4d90e155c1b4ef9e954d8be14a02d830)"},{"line_number":29,"context_line":"(cherry picked from commit 497360b0ea970f1e68912be8229ef8c3f5454e9e)"},{"line_number":30,"context_line":"(cherry picked from commit d298f7763b709cfc01f89222de31f566310748b3)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff570b3c_4c0b742a","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":68},"updated":"2020-06-10 00:20:03.000000000","message":"Need to remove this line like in the ussuri backport.","commit_id":"005fcaf01f22aebee58ee70cdcc7ef56da6c59af"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c66db4b9c77a3a60128332beb1f721c74105fd10","unresolved":false,"context_lines":[{"line_number":6179,"context_line":"              mock.patch.object(drvr, \u0027_is_booted_from_volume\u0027,"},{"line_number":6180,"context_line":"                                return_value\u003dFalse),"},{"line_number":6181,"context_line":"              mock.patch.object(drvr, \u0027plug_vifs\u0027),"},{"line_number":6182,"context_line":"              mock.patch.object(drvr, \u0027firewall_driver\u0027),"},{"line_number":6183,"context_line":"              mock.patch.object(drvr, \u0027_cleanup\u0027)):"},{"line_number":6184,"context_line":"            self.assertRaises(ValueError,"},{"line_number":6185,"context_line":"                              drvr._create_domain_and_network,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_a5334cf6","line":6182,"range":{"start_line":6182,"start_character":0,"end_line":6182,"end_character":57},"updated":"2020-06-09 15:08:21.000000000","message":"This wasn\u0027t present on stable/ussuri","commit_id":"005fcaf01f22aebee58ee70cdcc7ef56da6c59af"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c66db4b9c77a3a60128332beb1f721c74105fd10","unresolved":false,"context_lines":[{"line_number":13988,"context_line":"        instance \u003d objects.Instance(**self.test_instance)"},{"line_number":13989,"context_line":"        instance.config_drive \u003d \u0027True\u0027"},{"line_number":13990,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":13991,"context_line":""},{"line_number":13992,"context_line":"        instance_info \u003d hardware.InstanceInfo(state\u003dpower_state.RUNNING)"},{"line_number":13993,"context_line":""},{"line_number":13994,"context_line":"        mock_build_device_metadata.return_value \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_855e0810","line":13991,"updated":"2020-06-09 15:08:21.000000000","message":"There are tests (intentionally) missing here due to the absence of cyborg integration on this branch","commit_id":"005fcaf01f22aebee58ee70cdcc7ef56da6c59af"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c66db4b9c77a3a60128332beb1f721c74105fd10","unresolved":false,"context_lines":[{"line_number":18417,"context_line":"                {\u0027id\u0027: uuids.vif_2, \u0027active\u0027: False}]"},{"line_number":18418,"context_line":""},{"line_number":18419,"context_line":"        @mock.patch.object(drvr, \u0027plug_vifs\u0027)"},{"line_number":18420,"context_line":"        @mock.patch.object(drvr, \u0027firewall_driver\u0027)"},{"line_number":18421,"context_line":"        @mock.patch.object(drvr, \u0027_create_domain\u0027)"},{"line_number":18422,"context_line":"        @mock.patch.object(drvr, \u0027_cleanup\u0027)"},{"line_number":18423,"context_line":"        def test_create(cleanup, create, fw_driver, plug_vifs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_653e54ba","line":18420,"range":{"start_line":18420,"start_character":0,"end_line":18420,"end_character":51},"updated":"2020-06-09 15:08:21.000000000","message":"This wasn\u0027t present on stable/ussuri","commit_id":"005fcaf01f22aebee58ee70cdcc7ef56da6c59af"}]}