)]}'
{"nova/compute/api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"837c7bd8ee8926f3714f6b4158acc68dfbe40532","unresolved":false,"context_lines":[{"line_number":4649,"context_line":"    def detach_volume(self, context, instance, volume):"},{"line_number":4650,"context_line":"        \"\"\"Detach a volume from an instance.\"\"\""},{"line_number":4651,"context_line":"        if instance.vm_state \u003d\u003d vm_states.SHELVED_OFFLOADED:"},{"line_number":4652,"context_line":"            self._detach_volume_shelved_offloaded(context, instance, volume)"},{"line_number":4653,"context_line":"        else:"},{"line_number":4654,"context_line":"            try:"},{"line_number":4655,"context_line":"                self.volume_api.begin_detaching(context, volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_f9335af4","line":4652,"updated":"2020-06-29 16:49:44.000000000","message":"nit: An early return here would be nice and allow you dedent the below. With that said, I wonder would it make sense to fold this function back in here now too? There\u0027s surely some deduping to be done","commit_id":"3dbcfa5614063f13e900faa2fbb8fd26162724d2"}]}