)]}'
{"nova/compute/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ab25a0fb9704f474b39f398a0cc11ef80cf8b831","unresolved":false,"context_lines":[{"line_number":4424,"context_line":"        \"\"\"Create a BlockDeviceMapping object remotely on the compute"},{"line_number":4425,"context_line":""},{"line_number":4426,"context_line":"            This is done on the compute host because we want to avoid a race"},{"line_number":4427,"context_line":"            where two devices are requested at the same time. When db access"},{"line_number":4428,"context_line":"            is removed from compute, the bdm will be created here and we will"},{"line_number":4429,"context_line":"            have to make sure that they are assigned atomically."},{"line_number":4430,"context_line":""},{"line_number":4431,"context_line":"        :param context: nova auth RequestContext"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_b88e7c24","line":4428,"range":{"start_line":4427,"start_character":62,"end_line":4428,"end_character":35},"updated":"2020-05-29 16:36:50.000000000","message":"This happened a long time ago. Maybe we shouldn\u0027t blindly copy it into the docstring here?","commit_id":"a6dbca7918da6bc5056bc1c44bb3d9725983c714"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"5b3a6aa0bef495fbcc3ce8859a9d5f39995ef95a","unresolved":false,"context_lines":[{"line_number":4424,"context_line":"        \"\"\"Create a BlockDeviceMapping object remotely on the compute"},{"line_number":4425,"context_line":""},{"line_number":4426,"context_line":"            This is done on the compute host because we want to avoid a race"},{"line_number":4427,"context_line":"            where two devices are requested at the same time. When db access"},{"line_number":4428,"context_line":"            is removed from compute, the bdm will be created here and we will"},{"line_number":4429,"context_line":"            have to make sure that they are assigned atomically."},{"line_number":4430,"context_line":""},{"line_number":4431,"context_line":"        :param context: nova auth RequestContext"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_13f7868d","line":4428,"range":{"start_line":4427,"start_character":62,"end_line":4428,"end_character":35},"in_reply_to":"ff570b3c_b88e7c24","updated":"2020-05-29 21:36:59.000000000","message":"I honestly took this to mean db access via the conductor, I didn\u0027t even think it might pre-date that but yeah I\u0027ll remove.","commit_id":"a6dbca7918da6bc5056bc1c44bb3d9725983c714"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ab25a0fb9704f474b39f398a0cc11ef80cf8b831","unresolved":false,"context_lines":[{"line_number":4445,"context_line":"            volume_bdm.delete_on_termination \u003d delete_on_termination"},{"line_number":4446,"context_line":"            volume_bdm.save()"},{"line_number":4447,"context_line":"            return volume_bdm"},{"line_number":4448,"context_line":"        except oslo_exceptions.MessagingTimeout:"},{"line_number":4449,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":4450,"context_line":"                try:"},{"line_number":4451,"context_line":"                    bdm \u003d self._fetch_bdm_by_vol_and_instance("}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_18c6884a","line":4448,"updated":"2020-05-29 16:36:50.000000000","message":"What is the thing that is actually taking a long time? The reserve or the save? Assuming the former, can we put the save outside the try..except so as not to confuse the timeout for the reserve with the save?\n\nAlso, is there any reason not to make this a long RPC call which can tolerate it legitimately taking a while? What\u0027s the actual thing making this take so long and ist here some reason not to use the call mechanism that will actually wait?","commit_id":"a6dbca7918da6bc5056bc1c44bb3d9725983c714"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"5b3a6aa0bef495fbcc3ce8859a9d5f39995ef95a","unresolved":false,"context_lines":[{"line_number":4445,"context_line":"            volume_bdm.delete_on_termination \u003d delete_on_termination"},{"line_number":4446,"context_line":"            volume_bdm.save()"},{"line_number":4447,"context_line":"            return volume_bdm"},{"line_number":4448,"context_line":"        except oslo_exceptions.MessagingTimeout:"},{"line_number":4449,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":4450,"context_line":"                try:"},{"line_number":4451,"context_line":"                    bdm \u003d self._fetch_bdm_by_vol_and_instance("}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_9330b658","line":4448,"in_reply_to":"ff570b3c_18c6884a","updated":"2020-05-29 21:36:59.000000000","message":"As I\u0027ve already said this isn\u0027t about compute timeouts but failures by the compute to reply leading to timeouts on the API side.","commit_id":"a6dbca7918da6bc5056bc1c44bb3d9725983c714"}]}