)]}'
{"nova/compute/utils.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"12ab792d3e46f88e959075ea23aa248b587e73c5","unresolved":false,"context_lines":[{"line_number":452,"context_line":"    method(context, \u0027compute.instance.%s\u0027 % event_suffix, usage_info)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"def _get_fault_and_priority_from_exception(exception: Exception):"},{"line_number":456,"context_line":"    fault \u003d None"},{"line_number":457,"context_line":"    priority \u003d fields.NotificationPriority.INFO"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_9871437b","line":455,"range":{"start_line":455,"start_character":43,"end_line":455,"end_character":63},"updated":"2020-06-10 10:42:41.000000000","message":"I do understand why you\u0027d like to use PEP484 syntax for enforcing exception types, but doing this will make a backport of this bugfix a bit difficult since stable/stein also supports Py2.\n\nI\u0027d recommend you to follow the py2 convention defined in the PEP here https://www.python.org/dev/peps/pep-0484/#suggested-syntax-for-python-2-7-and-straddling-code","commit_id":"125df26bf9d6b4cfbfb68770fa47f2055f29b8dc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2daea49503dab35ee0a7725e6b676a6ba81d11ca","unresolved":false,"context_lines":[{"line_number":452,"context_line":"    method(context, \u0027compute.instance.%s\u0027 % event_suffix, usage_info)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"def _get_fault_and_priority_from_exception(exception: Exception):"},{"line_number":456,"context_line":"    fault \u003d None"},{"line_number":457,"context_line":"    priority \u003d fields.NotificationPriority.INFO"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_f8df9f09","line":455,"range":{"start_line":455,"start_character":43,"end_line":455,"end_character":63},"in_reply_to":"ff570b3c_7878af2a","updated":"2020-06-10 10:58:07.000000000","message":"Or what bauzas said above :)","commit_id":"125df26bf9d6b4cfbfb68770fa47f2055f29b8dc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"759887c06f411f59bfd8c85e5978750bd37efd8c","unresolved":false,"context_lines":[{"line_number":452,"context_line":"    method(context, \u0027compute.instance.%s\u0027 % event_suffix, usage_info)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"def _get_fault_and_priority_from_exception(exception: Exception):"},{"line_number":456,"context_line":"    fault \u003d None"},{"line_number":457,"context_line":"    priority \u003d fields.NotificationPriority.INFO"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_7878af2a","line":455,"range":{"start_line":455,"start_character":43,"end_line":455,"end_character":63},"in_reply_to":"ff570b3c_9871437b","updated":"2020-06-10 10:57:41.000000000","message":"For other reviewers, we discussed this on IRC. To summarize, I think this is acceptable. Attempting to backport this to stable/train or earlier will cause the Python 2.7 jobs to fail due to invalid syntax (SyntaxError). This is no different to f-strings, kw-only args or any other Python 3.x-only syntax and should be pretty obvious to the reviewer.\n\nIt\u0027s also reasonable to include this change here. I\u0027m changing the function signature so this is a related change. If I were not changing the signature, then I would agree that this should be done separately, yes.","commit_id":"125df26bf9d6b4cfbfb68770fa47f2055f29b8dc"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e8c87e33a1839d9d62a94b65dcf07b556e1a1733","unresolved":false,"context_lines":[{"line_number":452,"context_line":"    method(context, \u0027compute.instance.%s\u0027 % event_suffix, usage_info)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"def _get_fault_and_priority_from_exception(exception: Exception):"},{"line_number":456,"context_line":"    fault \u003d None"},{"line_number":457,"context_line":"    priority \u003d fields.NotificationPriority.INFO"},{"line_number":458,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_389c775c","line":455,"range":{"start_line":455,"start_character":43,"end_line":455,"end_character":63},"in_reply_to":"ff570b3c_9871437b","updated":"2020-06-10 10:56:30.000000000","message":"OK, after discussing on IRC, I\u0027m OK with approving this change as of now, provided people wanting to review this change WOULD READ MY COMMENT AND UNDERSTAND THAT THIS COULDN\u0027T WORK WITH STABLE/STEIN AND STABLE/TRAIN.","commit_id":"125df26bf9d6b4cfbfb68770fa47f2055f29b8dc"}],"nova/notifications/objects/exception.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e8c87e33a1839d9d62a94b65dcf07b556e1a1733","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            module \u003d inspect.getmodule(traceback)"},{"line_number":60,"context_line":"            function_name \u003d traceback.tb_frame.f_code.co_name"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        module_name \u003d module.__name__ if module else \u0027unknown\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # TODO(gibi): apply strutils.mask_password on exception_message and"},{"line_number":65,"context_line":"        # consider emitting the exception_message only if the safe flag is"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_b8a7e7a7","line":62,"updated":"2020-06-10 10:56:30.000000000","message":"I\u0027m OK with the logic","commit_id":"125df26bf9d6b4cfbfb68770fa47f2055f29b8dc"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"691c5a25c825c0ecb43a072c9f92294491d7ebbc","unresolved":false,"context_lines":[{"line_number":12585,"context_line":"        self.assertRaises(test.TestingException,"},{"line_number":12586,"context_line":"            self.compute._reschedule_resize_or_reraise, self.context,"},{"line_number":12587,"context_line":"            self.instance, exc_info, self.instance_type,"},{"line_number":12588,"context_line":"            self.request_spec, filter_properties, None)"},{"line_number":12589,"context_line":""},{"line_number":12590,"context_line":"    def test_reschedule_resize_or_reraise_no_retry_info(self):"},{"line_number":12591,"context_line":"        \"\"\"Test behavior when ``filter_properties`` doesn\u0027t contain \u0027retry\u0027."}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_2e4638c1","line":12588,"updated":"2020-06-05 10:14:25.000000000","message":"this seems unrealted","commit_id":"b7b2928395df6561c920dfaa9855805516416118"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3df3fb694f6854f95fb771e23ada76b0112a0a51","unresolved":false,"context_lines":[{"line_number":12585,"context_line":"        self.assertRaises(test.TestingException,"},{"line_number":12586,"context_line":"            self.compute._reschedule_resize_or_reraise, self.context,"},{"line_number":12587,"context_line":"            self.instance, exc_info, self.instance_type,"},{"line_number":12588,"context_line":"            self.request_spec, filter_properties, None)"},{"line_number":12589,"context_line":""},{"line_number":12590,"context_line":"    def test_reschedule_resize_or_reraise_no_retry_info(self):"},{"line_number":12591,"context_line":"        \"\"\"Test behavior when ``filter_properties`` doesn\u0027t contain \u0027retry\u0027."}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_af2189ff","line":12588,"in_reply_to":"ff570b3c_2e4638c1","updated":"2020-06-08 13:11:34.000000000","message":"It is related, actually. Bug #1881455 occurs when we call \u0027_reschedule_resize_or_reraise\u0027 from outside the context of an exception handler. This test was hiding the bug because it was enclosing a call to that function within an unrelated exception handler. Given that we\u0027re only using the try-except to generate an exception and traceback, there\u0027s no reason to be doing this inside the except so I\u0027ve stopped. I couldn\u0027t do so in the previous patch as it would have caused a failure without the fix.","commit_id":"b7b2928395df6561c920dfaa9855805516416118"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0d2411fc7b281eed0169cafa8c0979e6a85c056b","unresolved":false,"context_lines":[{"line_number":12585,"context_line":"        self.assertRaises(test.TestingException,"},{"line_number":12586,"context_line":"            self.compute._reschedule_resize_or_reraise, self.context,"},{"line_number":12587,"context_line":"            self.instance, exc_info, self.instance_type,"},{"line_number":12588,"context_line":"            self.request_spec, filter_properties, None)"},{"line_number":12589,"context_line":""},{"line_number":12590,"context_line":"    def test_reschedule_resize_or_reraise_no_retry_info(self):"},{"line_number":12591,"context_line":"        \"\"\"Test behavior when ``filter_properties`` doesn\u0027t contain \u0027retry\u0027."}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_8159f936","line":12588,"in_reply_to":"ff570b3c_af2189ff","updated":"2020-06-08 13:35:01.000000000","message":"you are totally right. Sorry.","commit_id":"b7b2928395df6561c920dfaa9855805516416118"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"691c5a25c825c0ecb43a072c9f92294491d7ebbc","unresolved":false,"context_lines":[{"line_number":12604,"context_line":"        self.assertRaises(test.TestingException,"},{"line_number":12605,"context_line":"            self.compute._reschedule_resize_or_reraise, self.context,"},{"line_number":12606,"context_line":"            self.instance, exc_info, self.instance_type,"},{"line_number":12607,"context_line":"            self.request_spec, filter_properties, None)"},{"line_number":12608,"context_line":""},{"line_number":12609,"context_line":"    @mock.patch.object(compute_manager.ComputeManager, \u0027_instance_update\u0027)"},{"line_number":12610,"context_line":"    @mock.patch(\u0027nova.conductor.api.ComputeTaskAPI.resize_instance\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_0e41b4a6","line":12607,"updated":"2020-06-05 10:14:25.000000000","message":"ditto","commit_id":"b7b2928395df6561c920dfaa9855805516416118"}],"nova/tests/unit/compute/test_compute_utils.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b2f0150f99dab97a0c0a251eeb3f2a69180891ce","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import copy"},{"line_number":20,"context_line":"import datetime"},{"line_number":21,"context_line":"import string"},{"line_number":22,"context_line":"import traceback"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import mock"},{"line_number":25,"context_line":"from oslo_serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_f4ad3c31","line":22,"updated":"2020-06-04 20:10:44.000000000","message":"pep8: F401 \u0027traceback\u0027 imported but unused","commit_id":"b7b2928395df6561c920dfaa9855805516416118"}]}