)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6c565a1aa17b2c9978d9cf111b8d4b683329a2a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Removes the delta file once image is extracted"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For live snapshot 100% copy of the original file using"},{"line_number":10,"context_line":"libvirt/qemu to sync the disk to it using \"Shallow\" mode"},{"line_number":11,"context_line":"(this is the .delta file). From that .delta file it extracts"},{"line_number":12,"context_line":"the image and uploads it. When concurrent snapshots happening"},{"line_number":13,"context_line":"in a multiple VM\u0027s on a hypervisor leads to disk space issue,"},{"line_number":14,"context_line":"3x required for keeping the \u0027.delta\u0027 file until the extracted"},{"line_number":15,"context_line":"image gets uploaded."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Fixes bug 1881727"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_fb8527ae","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":20},"updated":"2020-06-26 16:58:24.000000000","message":"Took me a while to figure out how we were actually deleting the delta. Turns out we create a temporary directory and clean that up after. How about this:\n\n  When creating a live snapshot of an instance, nova creates a\n  copy of the instance disk using a QEMU shallow rebase. This\n  copy - the delta file - is then extracted and uploaded. The\n  delta file will eventually be deleted, when the temporary\n  working directory nova is using for the live snapshot is\n  discarded, however, until this happens, we will use 3x the\n  size of the image of host disk space: the original disk,\n  the delta file, and the extracted file. This can be problematic\n  when concurrent snapshots of multiple instances are requested\n  at once.\n\n  The solution is simple: delete the delta file after it has\n  been extracted and is no longer necessary.","commit_id":"1ea08ddfe069716b562197f1264f93d3478220b4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e6c565a1aa17b2c9978d9cf111b8d4b683329a2a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"3x required for keeping the \u0027.delta\u0027 file until the extracted"},{"line_number":15,"context_line":"image gets uploaded."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Fixes bug 1881727"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I15e9975fa516d81e7d34206e5a4069db5431caa9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_9bc06be3","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":17},"updated":"2020-06-26 16:58:24.000000000","message":"Closes-Bug: #1881727\n\n(put it after the \u0027Change-Id\u0027 line)","commit_id":"1ea08ddfe069716b562197f1264f93d3478220b4"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"ba698aa3907fc9eaa864ef988be128e69a48d3f4","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"The solution is simple: delete the delta file after it has"},{"line_number":21,"context_line":"been extracted and is no longer necessary."},{"line_number":22,"context_line":"  "},{"line_number":23,"context_line":"Change-Id: I15e9975fa516d81e7d34206e5a4069db5431caa9"},{"line_number":24,"context_line":"Closes-Bug: #1881727"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_afe4bf0f","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":2},"updated":"2020-07-21 11:04:23.000000000","message":"nit - Whitespace","commit_id":"fd6e7aff0d8c84be5d20eeaf4a57501626f38ca1"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b78b835e3bbba4fda4a4d45ce6eafd9499dd7bf7","unresolved":false,"context_lines":[{"line_number":2608,"context_line":"        # NOTE (rmk): We are using shallow rebases as a workaround to a bug"},{"line_number":2609,"context_line":"        #             in QEMU 1.3. In order to do this, we need to create"},{"line_number":2610,"context_line":"        #             a destination image with the original backing file"},{"line_number":2611,"context_line":"        #             and matching size of the instance root disk."},{"line_number":2612,"context_line":"        src_disk_size \u003d libvirt_utils.get_disk_size(disk_path,"},{"line_number":2613,"context_line":"                                                    format\u003dsource_format)"},{"line_number":2614,"context_line":"        src_back_path \u003d libvirt_utils.get_disk_backing_file(disk_path,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_da5b64f3","line":2611,"updated":"2020-07-24 13:20:50.000000000","message":"This mention of versions suggests we can actually remove the delta file now, but that\u0027s not a backportable fix.","commit_id":"21be28cd9ea91da75d0c6c92c94c437c1ba2bf40"}]}