)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7471ad695b307e8496e9f3c7aea6443cdb412506","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: Mark e1000e VIF as supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is supported by the QEMU/KVM backends in libvirt. There\u0027s no reason"},{"line_number":10,"context_line":"not to support it in nova. This appears to have been an oversight."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I12a5d28d75bc32a76a4f3765cb4db4cbc46c0c75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_8dfe2336","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":54},"updated":"2020-06-10 10:11:26.000000000","message":"e1000e is the qemu upstream default for q35 as well so its not only supported tis there new default\n\nwe shoudl keep using virtio however\nthey dont default to virtio because windows does not ship with virtio drivers\n\n\nvirtio is a better choice in the cloud but we should not block e1000e","commit_id":"644cb5cb8bf44184d9b3f046cc67746b13550dd6"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"196f3302b4985b200a1c5e799797eb7b3fd021cb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt: Mark e1000e VIF as supported"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is supported by the QEMU/KVM backends in libvirt. There\u0027s no reason"},{"line_number":10,"context_line":"not to support it in nova. This appears to have been an oversight."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I12a5d28d75bc32a76a4f3765cb4db4cbc46c0c75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_52312a0b","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":54},"in_reply_to":"ff570b3c_8dfe2336","updated":"2020-06-18 08:39:04.000000000","message":"+1","commit_id":"644cb5cb8bf44184d9b3f046cc67746b13550dd6"}],"nova/virt/libvirt/vif.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"cf05728c7fdaa1be6b7c89febfecec7e6cd5b2ce","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        network_model.VIF_MODEL_PCNET,"},{"line_number":66,"context_line":"        network_model.VIF_MODEL_RTL8139,"},{"line_number":67,"context_line":"        network_model.VIF_MODEL_E1000,"},{"line_number":68,"context_line":"        network_model.VIF_MODEL_E1000E,"},{"line_number":69,"context_line":"        network_model.VIF_MODEL_LAN9118,"},{"line_number":70,"context_line":"        network_model.VIF_MODEL_SPAPR_VLAN],"},{"line_number":71,"context_line":"    \u0027kvm\u0027: ["}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_def1e397","line":68,"updated":"2020-06-10 13:02:05.000000000","message":"also checked, we have trait for it https://github.com/openstack/os-traits/blob/master/os_traits/compute/net.py#L26","commit_id":"644cb5cb8bf44184d9b3f046cc67746b13550dd6"}]}