)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"deb396b469425a8712088f53286bfe7ce99f0189","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Harshavardhan Metla \u003charshavardhan.metla@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-17 13:12:57 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raising a failure in case of 403"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Description: Running openstack flavor set from a project in which a user"},{"line_number":10,"context_line":"has an admin role allows the provided project to be mapped to the flavor"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9f560f44_1021e8b4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":17},"updated":"2020-08-25 23:47:07.000000000","message":"This isn\u0027t accurate in the latest PS. Should instead say something like \"Emit deprecation warning\"","commit_id":"5a15c19896c9ce66b1d1177e08361e23edf38213"},{"author":{"_account_id":30905,"name":"Harshavardhan Metla","email":"harshavardhan.metla@tcs.com","username":"harsha24"},"change_message_id":"fbac552c21f502164004bf0e1c9d0f5890216bfd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Harshavardhan Metla \u003charshavardhan.metla@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-08-17 13:12:57 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Raising a failure in case of 403"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Description: Running openstack flavor set from a project in which a user"},{"line_number":10,"context_line":"has an admin role allows the provided project to be mapped to the flavor"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9f560f44_bd9399a2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":17},"in_reply_to":"9f560f44_1021e8b4","updated":"2020-09-11 10:58:53.000000000","message":"Done","commit_id":"5a15c19896c9ce66b1d1177e08361e23edf38213"}],"nova/api/openstack/identity.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5fa0b0fcdb94f3d40620784110a3fde3f07df352","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \"Insufficient permissions for user %(user)s to verify \""},{"line_number":66,"context_line":"            \"existence of project_id %(pid)s\","},{"line_number":67,"context_line":"            {\"user\": context.user_id, \"pid\": project_id})"},{"line_number":68,"context_line":"        #return True"},{"line_number":69,"context_line":"        raise failure"},{"line_number":70,"context_line":"    else:"},{"line_number":71,"context_line":"        LOG.warning("}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_ac5e74e6","line":68,"updated":"2020-06-11 09:17:25.000000000","message":"pep8: E265 block comment should start with \u0027# \u0027","commit_id":"0a839e1d82036e0b39e58e8bba469de9d68f62b2"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5fa0b0fcdb94f3d40620784110a3fde3f07df352","unresolved":false,"context_lines":[{"line_number":75,"context_line":"             \"code\": resp.status_code,"},{"line_number":76,"context_line":"             \"content\": resp.content})"},{"line_number":77,"context_line":"        # realize we did something wrong, but move on with a warning"},{"line_number":78,"context_line":"        #return True"},{"line_number":79,"context_line":"        raise failure"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_8c61f0ab","line":78,"updated":"2020-06-11 09:17:25.000000000","message":"pep8: E265 block comment should start with \u0027# \u0027","commit_id":"0a839e1d82036e0b39e58e8bba469de9d68f62b2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4e37b963cb5e13195d0d65cd513b2c6818baa4bb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        # we got access, and we know this project is not there"},{"line_number":60,"context_line":"        raise failure"},{"line_number":61,"context_line":"    elif resp.status_code \u003d\u003d 403:"},{"line_number":62,"context_line":"        # we don\u0027t have enough permission to verify this, so default"},{"line_number":63,"context_line":"        # to \"it\u0027s ok\"."},{"line_number":64,"context_line":"        LOG.info("},{"line_number":65,"context_line":"            \"Insufficient permissions for user %(user)s to verify \""},{"line_number":66,"context_line":"            \"existence of project_id %(pid)s\","}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_36434644","line":63,"range":{"start_line":62,"start_character":8,"end_line":63,"end_character":23},"updated":"2020-06-25 17:18:48.000000000","message":"this si now raising an error so this is not correct anymore","commit_id":"ebd228122798b35884a030e4814f97d452ca5fa4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1f98902bdf4955299523d65ab34df3aa4929542a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \"Insufficient permissions for user %(user)s to verify \""},{"line_number":66,"context_line":"            \"existence of project_id %(pid)s\","},{"line_number":67,"context_line":"            {\"user\": context.user_id, \"pid\": project_id})"},{"line_number":68,"context_line":"        raise failure"},{"line_number":69,"context_line":"    else:"},{"line_number":70,"context_line":"        LOG.warning("},{"line_number":71,"context_line":"            \"Unexpected response from keystone trying to \""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_56b99a12","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":21},"updated":"2020-06-25 17:30:08.000000000","message":"as noted on irc you need to update\n\nhttps://github.com/openstack/nova/blob/master/nova/tests/unit/test_identity.py#L85-L94\n\nto account for the new behaviour\n\nthat is why the majority of the test failed.\n\nignore the grenade failure for now.\n\nthat was caused because it failed to install a package and is unrelated to your code change","commit_id":"ebd228122798b35884a030e4814f97d452ca5fa4"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f7be03e55f4786679d8556e259cce2f94f8ae9d4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \"Insufficient permissions for user %(user)s to verify \""},{"line_number":66,"context_line":"            \"existence of project_id %(pid)s\","},{"line_number":67,"context_line":"            {\"user\": context.user_id, \"pid\": project_id})"},{"line_number":68,"context_line":"        raise failure"},{"line_number":69,"context_line":"    else:"},{"line_number":70,"context_line":"        LOG.warning("},{"line_number":71,"context_line":"            \"Unexpected response from keystone trying to \""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_7c911ff1","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":21},"updated":"2020-06-25 20:03:32.000000000","message":"this change the API but during ML discussion we agreed to fix it as bug not with microversion bump.\n\nNote: this is special case of API change which need operators to change the permission level of users to make this change as no-impact. \n\nuser without having the \u0027GET /project\u0027 permission in keystone and add valid project in flavor access:\n\n-Before this change: able to set the flavor with *valid project*\n\n-After this change: need to have GET /project permission first to add *valid project* (or say allowing them to continue the same what they used to do).\n\nIt is more like we are changing the API but changes can be no-impact if policy configuration is modified by operators. which is nothing but similar to a policy or config default value change. policy or config change does not need microversion but need deprecation warning phase so that we notify them and give time to avoid breaking their users.\n\nSimilar way, I suggest to add the deprecation warning here for one cycle and then do this change. That way we can notify operators about this needed-configuration-changes from their side in advance before actual break.\n\nBut I am open to know more opinion here.","commit_id":"80b695d3c70db3979881453e034bbbbc9198fc2f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2f0b295bf421573dfc4fdba8d72d560fb16d3083","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \"Insufficient permissions for user %(user)s to verify \""},{"line_number":66,"context_line":"            \"existence of project_id %(pid)s\","},{"line_number":67,"context_line":"            {\"user\": context.user_id, \"pid\": project_id})"},{"line_number":68,"context_line":"        raise failure"},{"line_number":69,"context_line":"    else:"},{"line_number":70,"context_line":"        LOG.warning("},{"line_number":71,"context_line":"            \"Unexpected response from keystone trying to \""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_0c3b399c","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":21},"in_reply_to":"bf51134e_7c911ff1","updated":"2020-07-02 16:58:00.000000000","message":"Discussed this in today\u0027s IRC meeting. The conclusion seems to be to raise a warning in V and fix properly in W. We\u0027re doing this rather than a microversion because users shouldn\u0027t have to opt out of broken behavior. I\u0027m not all that happy with this halfway solution. If the fix is important enough to warrant skipping a microversion, then we should fix it now and backport that fix. This might break some deployments where policy is misconfigured (afaict, this won\u0027t happen with the policy we ship), however, again, if this is important enough to skip a microversion for, it\u0027s important enough to deal with this headache. We can document things and resolve them as necessary. My 2c, anyway.","commit_id":"80b695d3c70db3979881453e034bbbbc9198fc2f"},{"author":{"_account_id":30905,"name":"Harshavardhan Metla","email":"harshavardhan.metla@tcs.com","username":"harsha24"},"change_message_id":"7f918f79a432f508cd7f2428c3efa4127add1f19","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            \"Insufficient permissions for user %(user)s to verify \""},{"line_number":66,"context_line":"            \"existence of project_id %(pid)s\","},{"line_number":67,"context_line":"            {\"user\": context.user_id, \"pid\": project_id})"},{"line_number":68,"context_line":"        raise failure"},{"line_number":69,"context_line":"    else:"},{"line_number":70,"context_line":"        LOG.warning("},{"line_number":71,"context_line":"            \"Unexpected response from keystone trying to \""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_1e08add7","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":21},"in_reply_to":"bf51134e_7c911ff1","updated":"2020-07-06 02:53:51.000000000","message":"So what should be the content of the deprecated warning and should it be displayed on the horizon dashboard as a warning from server-side","commit_id":"80b695d3c70db3979881453e034bbbbc9198fc2f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ce63f96beff4ef7a91ea836ded8e73562fed660b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        # we don\u0027t have enough permission to verify this, so default"},{"line_number":63,"context_line":"        # to \"it\u0027s ok\"."},{"line_number":64,"context_line":"        LOG.info("},{"line_number":65,"context_line":"            \"This is the final cycle where nova ignores the permission and will be deprecated from the next release\""},{"line_number":66,"context_line":"            \"Insufficient permissions for user %(user)s to verify \""},{"line_number":67,"context_line":"            \"existence of project_id %(pid)s\","},{"line_number":68,"context_line":"            {\"user\": context.user_id, \"pid\": project_id})"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_4fb691db","line":65,"updated":"2020-07-30 22:48:42.000000000","message":"pep8: E501 line too long (116 \u003e 79 characters)","commit_id":"77e42b4de2a8d566532167e80a5b01c11a47564a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7cc5f453eaa2cbd3940fb980f878a0a7d42ce55a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        LOG.warning("},{"line_number":67,"context_line":"            \"This is the final cycle where nova ignores the permission \""},{"line_number":68,"context_line":"            \"and will be deprecated from the next release\")"},{"line_number":69,"context_line":"        LOG.info(            "},{"line_number":70,"context_line":"            \"Insufficient permissions for user %(user)s to verify \""},{"line_number":71,"context_line":"            \"existence of project_id %(pid)s\","},{"line_number":72,"context_line":"            {\"user\": context.user_id, \"pid\": project_id})"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f560f44_c793a5f9","line":69,"updated":"2020-07-31 09:14:38.000000000","message":"pep8: W291 trailing whitespace","commit_id":"2904a2b6a66a38a85912602893f62bf1fe5b9b4b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5aaaa40f5ab5b9f809bc911289c8f24260cd559e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        # to \"it\u0027s ok\"."},{"line_number":64,"context_line":"        # we are not going for a microversion bump"},{"line_number":65,"context_line":"        # instead we are giving a deprecated warning for this release."},{"line_number":66,"context_line":"        LOG.warning("},{"line_number":67,"context_line":"            \"This is the final cycle where nova ignores the permission \""},{"line_number":68,"context_line":"            \"and will be deprecated from the next release\")"},{"line_number":69,"context_line":"        LOG.info("},{"line_number":70,"context_line":"            \"Insufficient permissions for user %(user)s to verify \""},{"line_number":71,"context_line":"            \"existence of project_id %(pid)s\","}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_f4009a36","line":68,"range":{"start_line":66,"start_character":0,"end_line":68,"end_character":59},"updated":"2020-08-07 19:09:28.000000000","message":"we should provide the complete context for this warning.\n\n        LOG.warning(\n            \"You are either not authorized to get the requested projects or requested \"\n            \"project itself does not exist in keystone. Nova will be returning an \"\n            \"error for such cases from 23.0.0 onwards.\")","commit_id":"cb0c0bce98aaf1bbd2b0b8a8800697cabfbee750"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"91ea8cc8149568cd8261d88125151fc72d0e45e2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        # we are not going for a microversion bump"},{"line_number":65,"context_line":"        # instead we are giving a deprecated warning for this release."},{"line_number":66,"context_line":"        LOG.warning("},{"line_number":67,"context_line":"            \"You are either not authorized to get the requested projects or requested \""},{"line_number":68,"context_line":"            \"project itself does not exist in keystone. Nova will be returning an \""},{"line_number":69,"context_line":"            \"error for such cases from 23.0.0 onwards.\")"},{"line_number":70,"context_line":"        LOG.info("}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_3ee5c438","line":67,"updated":"2020-08-10 05:43:25.000000000","message":"pep8: E501 line too long (87 \u003e 79 characters)","commit_id":"e83873afb73cd1e641204a2d0d68fca632424de4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"91ea8cc8149568cd8261d88125151fc72d0e45e2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        # instead we are giving a deprecated warning for this release."},{"line_number":66,"context_line":"        LOG.warning("},{"line_number":67,"context_line":"            \"You are either not authorized to get the requested projects or requested \""},{"line_number":68,"context_line":"            \"project itself does not exist in keystone. Nova will be returning an \""},{"line_number":69,"context_line":"            \"error for such cases from 23.0.0 onwards.\")"},{"line_number":70,"context_line":"        LOG.info("},{"line_number":71,"context_line":"            \"Insufficient permissions for user %(user)s to verify \""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_1ee0c025","line":68,"updated":"2020-08-10 05:43:25.000000000","message":"pep8: E501 line too long (83 \u003e 79 characters)","commit_id":"e83873afb73cd1e641204a2d0d68fca632424de4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ab90d516ee57817e802695a56767fb2de75506a9","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            \"You are either not authorized to get the requested \""},{"line_number":68,"context_line":"            \"projects or requested project itself does not exist \""},{"line_number":69,"context_line":"            \"in keystone. Nova will be returning an error for such \""},{"line_number":70,"context_line":"            \"cases from 23.0.0 onwards\")"},{"line_number":71,"context_line":"        LOG.info("},{"line_number":72,"context_line":"            \"Insufficient permissions for user %(user)s to verify \""},{"line_number":73,"context_line":"            \"existence of project_id %(pid)s\","}],"source_content_type":"text/x-python","patch_set":12,"id":"1f621f24_47041ec7","line":70,"range":{"start_line":70,"start_character":24,"end_line":70,"end_character":26},"updated":"2020-10-28 11:18:26.000000000","message":"24?","commit_id":"545de1ef94a2b207d8c714fdec7eced2701ee196"}]}