)]}'
{"tools/check-cherry-picks.sh":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"db8cf6ab956c641ab8d6ceb25dd90799e9627c33","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    branches+\u003d\" $branch\""},{"line_number":17,"context_line":"    checked\u003d$(($checked + 1))"},{"line_number":18,"context_line":"done"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"echo Checked $checked cherry-pick hashes on branches: $(echo $branches | tr \u0027 \u0027 \u0027\\n\u0027 | sort | uniq)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff570b3c_84209c9d","line":19,"updated":"2020-06-11 18:22:25.000000000","message":"you might want to assert checked \u003e 0\nhere too to make sure the hash is also present.","commit_id":"7e6493004d1d34e6e7572b5737255d782fa17b3a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"47fc0b5691fc06392d1a207247c5ef3e9eb9c8e0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    branches+\u003d\" $branch\""},{"line_number":17,"context_line":"    checked\u003d$(($checked + 1))"},{"line_number":18,"context_line":"done"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"echo Checked $checked cherry-pick hashes on branches: $(echo $branches | tr \u0027 \u0027 \u0027\\n\u0027 | sort | uniq)"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ff570b3c_64ebc877","line":19,"in_reply_to":"ff570b3c_84209c9d","updated":"2020-06-11 19:05:03.000000000","message":"I actually don\u0027t want that, because for master changes there are none. This only checks the cherry-pick lines, not any random hash mentioned in the commit message.","commit_id":"7e6493004d1d34e6e7572b5737255d782fa17b3a"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"35679fcc749163475a9e51111996cc52cc053e77","unresolved":false,"context_lines":[{"line_number":9,"context_line":"branches+\u003d\"\""},{"line_number":10,"context_line":"for hash in $hashes; do"},{"line_number":11,"context_line":"    branch\u003d$(git branch -a --contains \"$hash\" 2\u003e/dev/null| grep -oE \u0027(master|stable/[a-z]+)\u0027)"},{"line_number":12,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":13,"context_line":"        echo \"Cherry pick hash $hash not on any master or stable branches\""},{"line_number":14,"context_line":"        exit 1"},{"line_number":15,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ff570b3c_bf3ccd30","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":25},"updated":"2020-06-11 19:55:51.000000000","message":"If any of the fixes on stable (not from master) is backported which is only applicable to zuul job stuff or any testing infra things then it might fail.","commit_id":"add30649fa6aeb56c98f355e22dde7af85d2ef11"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ee15e8d892f14fb6f9c5c80be7b74cfbe90ac8c5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"branches+\u003d\"\""},{"line_number":10,"context_line":"for hash in $hashes; do"},{"line_number":11,"context_line":"    branch\u003d$(git branch -a --contains \"$hash\" 2\u003e/dev/null| grep -oE \u0027(master|stable/[a-z]+)\u0027)"},{"line_number":12,"context_line":"    if [ $? -ne 0 ]; then"},{"line_number":13,"context_line":"        echo \"Cherry pick hash $hash not on any master or stable branches\""},{"line_number":14,"context_line":"        exit 1"},{"line_number":15,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ff570b3c_3f127db5","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":25},"in_reply_to":"ff570b3c_bf3ccd30","updated":"2020-06-11 19:57:32.000000000","message":"ah no. it work for that case too so $hash will be from where it started the backport so fail if not merged yet.\n\nWe are good here.","commit_id":"add30649fa6aeb56c98f355e22dde7af85d2ef11"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"92d891d1057e9391af9187716f7d411af720c6f5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        echo \"Checked $checked cherry-pick hashes: OK\""},{"line_number":23,"context_line":"        exit 0"},{"line_number":24,"context_line":"    else"},{"line_number":25,"context_line":"        if ! git show --format\u003d\u0027%b\u0027 --quiet | grep -q \u0027StableOnly\u0027; then"},{"line_number":26,"context_line":"            echo \u0027Stable branch requires either cherry-pick -x headers or StableOnly tag!\u0027"},{"line_number":27,"context_line":"            exit 1"},{"line_number":28,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"ff570b3c_0a9db565","line":25,"range":{"start_line":25,"start_character":55,"end_line":25,"end_character":65},"updated":"2020-06-11 20:52:21.000000000","message":"nit: I haven\u0027t seen \u0027StableOnly\u0027 tag on patches yet, rather \u0027[stable-only]\u0027 tags o:)","commit_id":"70b4995f747d53dc59f2f73c43a2bcc4850983a4"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"2e0e0e6e1ba4a56ea2d958b3c177b04a3fdb47aa","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        echo \"Checked $checked cherry-pick hashes: OK\""},{"line_number":23,"context_line":"        exit 0"},{"line_number":24,"context_line":"    else"},{"line_number":25,"context_line":"        if ! git show --format\u003d\u0027%b\u0027 --quiet | grep -qi \u0027stable.*only\u0027; then"},{"line_number":26,"context_line":"            echo \u0027Stable branch requires either cherry-pick -x headers or [stable-only] tag!\u0027"},{"line_number":27,"context_line":"            exit 1"},{"line_number":28,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bf51134e_3e02bfb5","line":25,"range":{"start_line":25,"start_character":32,"end_line":25,"end_character":34},"updated":"2020-06-15 18:09:39.000000000","message":"[stable-only] tags are usually in the \u0027subject\u0027 of the commit message.\n%b is only the body, without the subject.\nSo this should be %B (raw body, unwrapped subject and body).","commit_id":"72f6e85c0a2b189f2a90b78bcdce4216157a6cf6"}]}