)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"89ef5ab6932ef42531db8be4480c9fe7e5717c27","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch makes it return 409 Conflict, using the same logic as already"},{"line_number":14,"context_line":"present when adding a security group to the instance in such scenario of"},{"line_number":15,"context_line":"duplicate names for security groups."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I28ad999c49d4e11add54405b89185b3f56f165b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_f5ede425","line":15,"updated":"2020-06-17 08:36:56.000000000","message":"would you mind file a bug for this?","commit_id":"2e1a9ce3b4eabef06c0fa30e9c573e5f883f8d35"}],"nova/network/security_group_api.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"bd714c22a9ca668a8a12b4340c451168afd8cc2f","unresolved":false,"context_lines":[{"line_number":677,"context_line":"            security_group_name,"},{"line_number":678,"context_line":"            context.project_id)"},{"line_number":679,"context_line":"    except n_exc.NeutronClientNoUniqueMatch as e:"},{"line_number":680,"context_line":"        raise exception.NoUniqueMatch(str(e))"},{"line_number":681,"context_line":"    except n_exc.NeutronClientException as e:"},{"line_number":682,"context_line":"        exc_info \u003d sys.exc_info()"},{"line_number":683,"context_line":"        if e.status_code \u003d\u003d 404:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_894abe7d","line":680,"updated":"2020-06-15 13:49:00.000000000","message":"pep8: N325 str() and unicode() cannot be used on an exception.  Remove or use six.text_type()","commit_id":"6865909f0805e40d52db908a3caa51cb977f4d38"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"89ef5ab6932ef42531db8be4480c9fe7e5717c27","unresolved":false,"context_lines":[{"line_number":668,"context_line":"                LOG.exception(\"Neutron Error:\")"},{"line_number":669,"context_line":""},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"def remove_from_instance(context, instance, security_group_name):"},{"line_number":672,"context_line":"    \"\"\"Remove the security group associated with the instance.\"\"\""},{"line_number":673,"context_line":"    neutron \u003d neutronapi.get_client(context)"},{"line_number":674,"context_line":"    try:"},{"line_number":675,"context_line":"        security_group_id \u003d neutronv20.find_resourceid_by_name_or_id("},{"line_number":676,"context_line":"            neutron, \u0027security_group\u0027,"},{"line_number":677,"context_line":"            security_group_name,"},{"line_number":678,"context_line":"            context.project_id)"},{"line_number":679,"context_line":"    except n_exc.NeutronClientNoUniqueMatch as e:"},{"line_number":680,"context_line":"        raise exception.NoUniqueMatch(e)"},{"line_number":681,"context_line":"    except n_exc.NeutronClientException as e:"},{"line_number":682,"context_line":"        exc_info \u003d sys.exc_info()"},{"line_number":683,"context_line":"        if e.status_code \u003d\u003d 404:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_95dc6875","line":680,"range":{"start_line":671,"start_character":0,"end_line":680,"end_character":40},"updated":"2020-06-17 08:36:56.000000000","message":"it would be great to have unittest for this.","commit_id":"2e1a9ce3b4eabef06c0fa30e9c573e5f883f8d35"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f2b6f2f1e69e6c0fbaf2d11f92ab85e625a6ff8b","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        return neutronv20.find_resourceid_by_name_or_id("},{"line_number":69,"context_line":"            neutron, \u0027security_group\u0027, name, context.project_id)"},{"line_number":70,"context_line":"    except n_exc.NeutronClientNoUniqueMatch as e:"},{"line_number":71,"context_line":"        raise exception.NoUniqueMatch(six.text_type(e))"},{"line_number":72,"context_line":"    except n_exc.NeutronClientException as e:"},{"line_number":73,"context_line":"        if e.status_code \u003d\u003d 404:"},{"line_number":74,"context_line":"            LOG.debug(\u0027Neutron security group %s not found\u0027, name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f5170479_a963761b","line":71,"updated":"2021-02-01 15:02:57.000000000","message":"Ah, I see, we already do a similar check here.\n\nIt is a shame not reuse this code here... as I guess that is why this bug exists already.","commit_id":"696c8a95f60178b799498dac443371efe5cd23fe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"791661766585a6dc73d338d7ffa23d41760199da","unresolved":false,"context_lines":[{"line_number":604,"context_line":"            neutron, \u0027security_group\u0027,"},{"line_number":605,"context_line":"            security_group_name,"},{"line_number":606,"context_line":"            context.project_id)"},{"line_number":607,"context_line":"    except n_exc.NeutronClientNoUniqueMatch as e:"},{"line_number":608,"context_line":"        raise exception.NoUniqueMatch(six.text_type(e))"},{"line_number":609,"context_line":"    except n_exc.NeutronClientException as e:"},{"line_number":610,"context_line":"        if e.status_code \u003d\u003d 404:"},{"line_number":611,"context_line":"            msg \u003d (_(\"Security group %(name)s is not found for \""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_e5bb130c","line":608,"range":{"start_line":607,"start_character":0,"end_line":608,"end_character":55},"updated":"2020-09-08 08:01:48.000000000","message":"Here we go","commit_id":"696c8a95f60178b799498dac443371efe5cd23fe"}]}