)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"daa9cbea9b81bf6fb06797f998989bb406c60083","unresolved":false,"context_lines":[{"line_number":3825,"context_line":"                      instance\u003dinstance)"},{"line_number":3826,"context_line":"            return"},{"line_number":3827,"context_line":""},{"line_number":3828,"context_line":"        with self._snapshot_semaphore:"},{"line_number":3829,"context_line":"            self._snapshot_instance(context, image_id, instance,"},{"line_number":3830,"context_line":"                                    task_states.IMAGE_SNAPSHOT)"},{"line_number":3831,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_19bb520e","line":3828,"range":{"start_line":3828,"start_character":7,"end_line":3828,"end_character":38},"updated":"2020-06-25 15:09:39.000000000","message":"i was debating if this was too late but i think this its correct.\n\nwe have set the instace state to pending snapshot at this point but not actully started doing it.\n\nif we move the context manager to the start of thet function then while we are waiting for the semaphone the api would still show active or whatever state the instances was in which might lead to observable diffrences in behavior depending on if you had the config option set or not.\n\nby aquireing it here we correctly report the pending state but have not yet performand any action on the instnace ites self so it will continue in its previous state e.g. running or power off.","commit_id":"26e1b9f9bc6e164cf6e0e16ed3fefb8c068ee850"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"124154525693cabb1cdb75fe3dad877d83ce4a2c","unresolved":false,"context_lines":[{"line_number":3825,"context_line":"                      instance\u003dinstance)"},{"line_number":3826,"context_line":"            return"},{"line_number":3827,"context_line":""},{"line_number":3828,"context_line":"        with self._snapshot_semaphore:"},{"line_number":3829,"context_line":"            self._snapshot_instance(context, image_id, instance,"},{"line_number":3830,"context_line":"                                    task_states.IMAGE_SNAPSHOT)"},{"line_number":3831,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_a83379aa","line":3828,"range":{"start_line":3828,"start_character":7,"end_line":3828,"end_character":38},"in_reply_to":"bf51134e_19bb520e","updated":"2020-06-25 15:34:07.000000000","message":"There\u0027s already a gap between going to that state and the image stopping. This would widen that a lot, but not fundamentally change it I think.\n\nFrom a user\u0027s perspective, you\u0027d want to see that it\u0027s queued for snapshot at least. I need to look, but can the user see SNAPSHOT_PENDING task_state or only once we change the vm_state?","commit_id":"26e1b9f9bc6e164cf6e0e16ed3fefb8c068ee850"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"99c89c63adf2e8bcd3eea8669bc22491b7bfd5ed","unresolved":false,"context_lines":[{"line_number":3825,"context_line":"                      instance\u003dinstance)"},{"line_number":3826,"context_line":"            return"},{"line_number":3827,"context_line":""},{"line_number":3828,"context_line":"        with self._snapshot_semaphore:"},{"line_number":3829,"context_line":"            self._snapshot_instance(context, image_id, instance,"},{"line_number":3830,"context_line":"                                    task_states.IMAGE_SNAPSHOT)"},{"line_number":3831,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_13b72988","line":3828,"range":{"start_line":3828,"start_character":7,"end_line":3828,"end_character":38},"in_reply_to":"bf51134e_19bb520e","updated":"2020-06-26 09:51:56.000000000","message":"Yes, instance are in \u0027image_snapshot\u0027 task state, I tested, see on my dan reply","commit_id":"26e1b9f9bc6e164cf6e0e16ed3fefb8c068ee850"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"99c89c63adf2e8bcd3eea8669bc22491b7bfd5ed","unresolved":false,"context_lines":[{"line_number":3825,"context_line":"                      instance\u003dinstance)"},{"line_number":3826,"context_line":"            return"},{"line_number":3827,"context_line":""},{"line_number":3828,"context_line":"        with self._snapshot_semaphore:"},{"line_number":3829,"context_line":"            self._snapshot_instance(context, image_id, instance,"},{"line_number":3830,"context_line":"                                    task_states.IMAGE_SNAPSHOT)"},{"line_number":3831,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_136c4906","line":3828,"range":{"start_line":3828,"start_character":7,"end_line":3828,"end_character":38},"in_reply_to":"bf51134e_a83379aa","updated":"2020-06-26 09:51:56.000000000","message":"I tested the following:\n\n$grep max_concurrent_snapshots /etc/nova/nova-cpu.conf \nmax_concurrent_snapshots \u003d 1\n\nconsider 3 instances 2 ACTIVE, 1 SHUT:\n$openstack server list  --long\n+--------------------------------------+---------+---------+------------+-------------+\n| ID                                   | Name    | Status  | Task State | Power State |\n+--------------------------------------+---------+---------+------------+-------------+\n| 6965bb7a-0ee9-4bab-b89a-46d407a6c99a | inst3   | ACTIVE  | None       | Running     |\n| 9cf64a88-7cfb-4d32-90d2-be0fd9c0996a | inst2   | SHUTOFF | None       | Shutdown    |\n| e7e11d3d-ccd9-4773-8021-b74cdc9cc056 | inst1   | ACTIVE  | None       | Running     |\n+--------------------------------------+---------+---------+------------+-------------+\n\n$openstack server image create inst1\n$openstack server image create inst2\n$openstack server image create inst3\n\n$openstack server list  --long\n+--------------------------------------+---------+---------+----------------------+-------------+\n| ID                                   | Name    | Status  | Task State           | Power State |\n+--------------------------------------+---------+---------+----------------------+-------------+\n| 6965bb7a-0ee9-4bab-b89a-46d407a6c99a | inst3   | ACTIVE  | image_snapshot       | Running     |\n| 9cf64a88-7cfb-4d32-90d2-be0fd9c0996a | inst2   | SHUTOFF | image_snapshot       | Shutdown    |\n| e7e11d3d-ccd9-4773-8021-b74cdc9cc056 | inst1   | ACTIVE  | image_pending_upload | Running     |\n+--------------------------------------+---------+---------+----------------------+-------------+\nonly one instance is snapshoting, other are in image_snapshot\n\ninstance in pending snapshot are lock from API POV:\nstack@alex-devstack:~/nova$ nova reboot --hard inst1\nb\"Cannot \u0027reboot\u0027 instance e7e11d3d-ccd9-4773-8021-b74cdc9cc056 while it is in task_state image_pending_upload (HTTP 409) (Request-ID: req-94954779-270a-4851-8524-1f58e26e0f7d)\"\nERROR (CommandError): Unable to reboot the specified server(s).\nstack@alex-devstack:~/nova$ nova reboot --hard inst2\nb\"Cannot \u0027reboot\u0027 instance 9cf64a88-7cfb-4d32-90d2-be0fd9c0996a while it is in task_state image_snapshot (HTTP 409) (Request-ID: req-463a414d-8d61-449d-96f7-f2b747be7c4b)\"\nERROR (CommandError): Unable to reboot the specified server(s).\nstack@alex-devstack:~/nova$ nova reboot --hard inst3\nb\"Cannot \u0027reboot\u0027 instance 6965bb7a-0ee9-4bab-b89a-46d407a6c99a while it is in task_state image_snapshot (HTTP 409) (Request-ID: req-ac77d77f-7360-490d-9f87-3162a6e9673f)\"\nERROR (CommandError): Unable to reboot the specified server(s).","commit_id":"26e1b9f9bc6e164cf6e0e16ed3fefb8c068ee850"}],"nova/conf/compute.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6a18149745b0126ad0ec76cf3cb926a7bf59b791","unresolved":false,"context_lines":[{"line_number":674,"context_line":"Possible Values:"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"* 0 : treated as unlimited."},{"line_number":677,"context_line":"* Any positive integer representing maximum concurrent builds."},{"line_number":678,"context_line":"\"\"\"),"},{"line_number":679,"context_line":"    cfg.IntOpt(\u0027max_concurrent_live_migrations\u0027,"},{"line_number":680,"context_line":"        default\u003d1,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_63c2bb87","line":677,"range":{"start_line":677,"start_character":55,"end_line":677,"end_character":61},"updated":"2020-06-17 12:40:21.000000000","message":"snapshots","commit_id":"21faa82b7b96d245a36ca12de8420a6f52014c87"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"a42f79f45e25ebbe1449d2b33888bdce70708a8f","unresolved":false,"context_lines":[{"line_number":674,"context_line":"Possible Values:"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"* 0 : treated as unlimited."},{"line_number":677,"context_line":"* Any positive integer representing maximum concurrent builds."},{"line_number":678,"context_line":"\"\"\"),"},{"line_number":679,"context_line":"    cfg.IntOpt(\u0027max_concurrent_live_migrations\u0027,"},{"line_number":680,"context_line":"        default\u003d1,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_237283e6","line":677,"range":{"start_line":677,"start_character":55,"end_line":677,"end_character":61},"in_reply_to":"bf51134e_63c2bb87","updated":"2020-06-17 13:06:34.000000000","message":"Done","commit_id":"21faa82b7b96d245a36ca12de8420a6f52014c87"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"daa9cbea9b81bf6fb06797f998989bb406c60083","unresolved":false,"context_lines":[{"line_number":663,"context_line":"* Any positive integer representing maximum concurrent builds."},{"line_number":664,"context_line":"\"\"\"),"},{"line_number":665,"context_line":"    cfg.IntOpt(\u0027max_concurrent_snapshots\u0027,"},{"line_number":666,"context_line":"        default\u003d5,"},{"line_number":667,"context_line":"        min\u003d0,"},{"line_number":668,"context_line":"        help\u003d\"\"\""},{"line_number":669,"context_line":"Limits the maximum number of instance snapshots to run concurrently by"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_d9455a17","line":666,"range":{"start_line":666,"start_character":16,"end_line":666,"end_character":17},"updated":"2020-06-25 15:09:39.000000000","message":"i think this is an ok default but just calling out that this will be a change in behavior on upgrade so that need to be in the release note.","commit_id":"26e1b9f9bc6e164cf6e0e16ed3fefb8c068ee850"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"99c89c63adf2e8bcd3eea8669bc22491b7bfd5ed","unresolved":false,"context_lines":[{"line_number":663,"context_line":"* Any positive integer representing maximum concurrent builds."},{"line_number":664,"context_line":"\"\"\"),"},{"line_number":665,"context_line":"    cfg.IntOpt(\u0027max_concurrent_snapshots\u0027,"},{"line_number":666,"context_line":"        default\u003d5,"},{"line_number":667,"context_line":"        min\u003d0,"},{"line_number":668,"context_line":"        help\u003d\"\"\""},{"line_number":669,"context_line":"Limits the maximum number of instance snapshots to run concurrently by"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_b3511d39","line":666,"range":{"start_line":666,"start_character":16,"end_line":666,"end_character":17},"in_reply_to":"bf51134e_d9455a17","updated":"2020-06-26 09:51:56.000000000","message":"Done","commit_id":"26e1b9f9bc6e164cf6e0e16ed3fefb8c068ee850"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"69a57a4ff303940d9937f01a4c6009215d81c8ef","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        default\u003d5,"},{"line_number":667,"context_line":"        min\u003d0,"},{"line_number":668,"context_line":"        help\u003d\"\"\""},{"line_number":669,"context_line":"Limits the maximum number of instance snapshots to run concurrently by"},{"line_number":670,"context_line":"nova-compute. This limit is enforced to avoid snapshots overwhelming the"},{"line_number":671,"context_line":"host/network/storage and causing failure. This value can be set per"},{"line_number":672,"context_line":"compute node."},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_d9b13646","line":670,"range":{"start_line":669,"start_character":0,"end_line":670,"end_character":13},"updated":"2020-06-29 16:53:08.000000000","message":"Maximum number of instance snapshot operations to run concurrently.\n\nThis limit is enforced to prevent snapshots overwhelming","commit_id":"41a71158f8ed559161e2ae490b1eb788554ce02d"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"e39ab9294d0ab62fc6120b7b8fe1838e4a2097c4","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        default\u003d5,"},{"line_number":667,"context_line":"        min\u003d0,"},{"line_number":668,"context_line":"        help\u003d\"\"\""},{"line_number":669,"context_line":"Limits the maximum number of instance snapshots to run concurrently by"},{"line_number":670,"context_line":"nova-compute. This limit is enforced to avoid snapshots overwhelming the"},{"line_number":671,"context_line":"host/network/storage and causing failure. This value can be set per"},{"line_number":672,"context_line":"compute node."},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_3e04917e","line":670,"range":{"start_line":669,"start_character":0,"end_line":670,"end_character":13},"in_reply_to":"bf51134e_d9b13646","updated":"2020-06-30 06:05:27.000000000","message":"Done","commit_id":"41a71158f8ed559161e2ae490b1eb788554ce02d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6502a7dfb4e0f397c0d626bbbf1b07e7737e6ccf","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        default\u003d5,"},{"line_number":667,"context_line":"        min\u003d0,"},{"line_number":668,"context_line":"        help\u003d\"\"\""},{"line_number":669,"context_line":"Limits the maximum number of instance snapshots to run concurrently by"},{"line_number":670,"context_line":"nova-compute. This limit is enforced to avoid snapshots overwhelming the"},{"line_number":671,"context_line":"host/network/storage and causing failure. This value can be set per"},{"line_number":672,"context_line":"compute node."},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_f9523add","line":670,"range":{"start_line":669,"start_character":0,"end_line":670,"end_character":13},"in_reply_to":"bf51134e_d9b13646","updated":"2020-06-29 16:56:45.000000000","message":"This is copied from L654 above with the appropriate tweaks. Seems fine to me, FWIW.","commit_id":"41a71158f8ed559161e2ae490b1eb788554ce02d"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"e39ab9294d0ab62fc6120b7b8fe1838e4a2097c4","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        default\u003d5,"},{"line_number":667,"context_line":"        min\u003d0,"},{"line_number":668,"context_line":"        help\u003d\"\"\""},{"line_number":669,"context_line":"Limits the maximum number of instance snapshots to run concurrently by"},{"line_number":670,"context_line":"nova-compute. This limit is enforced to avoid snapshots overwhelming the"},{"line_number":671,"context_line":"host/network/storage and causing failure. This value can be set per"},{"line_number":672,"context_line":"compute node."},{"line_number":673,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_1e09cd94","line":670,"range":{"start_line":669,"start_character":0,"end_line":670,"end_character":13},"in_reply_to":"bf51134e_f9523add","updated":"2020-06-30 06:05:27.000000000","message":"I\u0027m ok with both","commit_id":"41a71158f8ed559161e2ae490b1eb788554ce02d"}],"releasenotes/notes/max-concurrent-snapshots-21a0a437dbe1044a.yaml":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"daa9cbea9b81bf6fb06797f998989bb406c60083","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    to snapshot."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Previously, because ``[DEFAULT]/max_concurrent_snapshots`` was not"},{"line_number":11,"context_line":"    existing, number of concurrent snapshot was unlimited, now it is limited"},{"line_number":12,"context_line":"    by default."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_396e1695","line":12,"range":{"start_line":10,"start_character":3,"end_line":12,"end_character":15},"updated":"2020-06-25 15:09:39.000000000","message":"nit:\n Previously, the number of concurrent snapshot was unlimited,\n now it is limited via ``[DEFAULT]/max_concurrent_snapshots``\n by default to 5.","commit_id":"26e1b9f9bc6e164cf6e0e16ed3fefb8c068ee850"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"99c89c63adf2e8bcd3eea8669bc22491b7bfd5ed","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    to snapshot."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Previously, because ``[DEFAULT]/max_concurrent_snapshots`` was not"},{"line_number":11,"context_line":"    existing, number of concurrent snapshot was unlimited, now it is limited"},{"line_number":12,"context_line":"    by default."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_33018d39","line":12,"range":{"start_line":10,"start_character":3,"end_line":12,"end_character":15},"in_reply_to":"bf51134e_396e1695","updated":"2020-06-26 09:51:56.000000000","message":"Exact, Done","commit_id":"26e1b9f9bc6e164cf6e0e16ed3fefb8c068ee850"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"124154525693cabb1cdb75fe3dad877d83ce4a2c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    to snapshot."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Previously, because ``[DEFAULT]/max_concurrent_snapshots`` was not"},{"line_number":11,"context_line":"    existing, number of concurrent snapshot was unlimited, now it is limited"},{"line_number":12,"context_line":"    by default."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_e8de113c","line":12,"range":{"start_line":10,"start_character":3,"end_line":12,"end_character":15},"in_reply_to":"bf51134e_396e1695","updated":"2020-06-25 15:34:07.000000000","message":"This is substantially better. I\u0027d like to see this changed before we merge as it is much less confusing to me than the existing wording.","commit_id":"26e1b9f9bc6e164cf6e0e16ed3fefb8c068ee850"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"99c89c63adf2e8bcd3eea8669bc22491b7bfd5ed","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    to snapshot."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Previously, because ``[DEFAULT]/max_concurrent_snapshots`` was not"},{"line_number":11,"context_line":"    existing, number of concurrent snapshot was unlimited, now it is limited"},{"line_number":12,"context_line":"    by default."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bf51134e_93fcd93e","line":12,"range":{"start_line":10,"start_character":3,"end_line":12,"end_character":15},"in_reply_to":"bf51134e_e8de113c","updated":"2020-06-26 09:51:56.000000000","message":"more clear yes.","commit_id":"26e1b9f9bc6e164cf6e0e16ed3fefb8c068ee850"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b7b59f9261ee59a66848fd3ee4a7f1ffca7eed3b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    to snapshot."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Previously, the number of concurrent snapshot was unlimited, now it is"},{"line_number":11,"context_line":"    limited via ``[DEFAULT]/max_concurrent_snapshots`` by default to 5."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_46bf1aa9","line":10,"range":{"start_line":10,"start_character":41,"end_line":10,"end_character":49},"updated":"2020-06-26 17:37:28.000000000","message":"nit: snapshots","commit_id":"41a71158f8ed559161e2ae490b1eb788554ce02d"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"e39ab9294d0ab62fc6120b7b8fe1838e4a2097c4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    to snapshot."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Previously, the number of concurrent snapshot was unlimited, now it is"},{"line_number":11,"context_line":"    limited via ``[DEFAULT]/max_concurrent_snapshots`` by default to 5."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_7efe096c","line":10,"range":{"start_line":10,"start_character":41,"end_line":10,"end_character":49},"in_reply_to":"bf51134e_46bf1aa9","updated":"2020-06-30 06:05:27.000000000","message":"Done","commit_id":"41a71158f8ed559161e2ae490b1eb788554ce02d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"69a57a4ff303940d9937f01a4c6009215d81c8ef","unresolved":false,"context_lines":[{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Previously, the number of concurrent snapshot was unlimited, now it is"},{"line_number":11,"context_line":"    limited via ``[DEFAULT]/max_concurrent_snapshots`` by default to 5."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_b999e2c4","line":11,"range":{"start_line":11,"start_character":54,"end_line":11,"end_character":71},"updated":"2020-06-29 16:53:08.000000000","message":", which currently defaults to 5.","commit_id":"41a71158f8ed559161e2ae490b1eb788554ce02d"},{"author":{"_account_id":28332,"name":"Alexandre arents","email":"alexandre.arents@corp.ovh.com","username":"aarents"},"change_message_id":"e39ab9294d0ab62fc6120b7b8fe1838e4a2097c4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Previously, the number of concurrent snapshot was unlimited, now it is"},{"line_number":11,"context_line":"    limited via ``[DEFAULT]/max_concurrent_snapshots`` by default to 5."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_5e034574","line":11,"range":{"start_line":11,"start_character":54,"end_line":11,"end_character":71},"in_reply_to":"bf51134e_b999e2c4","updated":"2020-06-30 06:05:27.000000000","message":"Done","commit_id":"41a71158f8ed559161e2ae490b1eb788554ce02d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6502a7dfb4e0f397c0d626bbbf1b07e7737e6ccf","unresolved":false,"context_lines":[{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Previously, the number of concurrent snapshot was unlimited, now it is"},{"line_number":11,"context_line":"    limited via ``[DEFAULT]/max_concurrent_snapshots`` by default to 5."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf51134e_3962f2ae","line":11,"range":{"start_line":11,"start_character":54,"end_line":11,"end_character":71},"in_reply_to":"bf51134e_b999e2c4","updated":"2020-06-29 16:56:45.000000000","message":"This came direct from Sean in an earlier PS. Also looks fine to me, but not opposed to the suggested wording either.","commit_id":"41a71158f8ed559161e2ae490b1eb788554ce02d"}]}