)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"849c4d241945c0df54804ed6ce225c08aa6b0fa5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cbalazs.gibizer@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-23 14:11:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent libvirt driver to start on non Linux platform"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The libvirt driver reads under /proc and /sys and depends on os.stat to"},{"line_number":10,"context_line":"detect if two directories are on the same device. So the driver is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_38f6c564","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":32},"updated":"2020-06-23 13:03:35.000000000","message":"starting","commit_id":"6af36daac67175b5284943bf166d678b0c88a4bc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"07e12960439e28313b2b46c85445f2f41e94f268","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cbalazs.gibizer@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-06-23 14:11:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prevent libvirt driver to start on non Linux platform"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The libvirt driver reads under /proc and /sys and depends on os.stat to"},{"line_number":10,"context_line":"detect if two directories are on the same device. So the driver is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_ab41baab","line":7,"range":{"start_line":7,"start_character":23,"end_line":7,"end_character":32},"in_reply_to":"bf51134e_38f6c564","updated":"2020-06-25 11:52:35.000000000","message":"Done","commit_id":"6af36daac67175b5284943bf166d678b0c88a4bc"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d5a97f66f178b76ccadeb3a810b9b5162816cb92","unresolved":false,"context_lines":[{"line_number":10,"context_line":"detect if two directories are on the same device. So the driver is"},{"line_number":11,"context_line":"heavily Linux dependent. This patch makes sure that the nova-compute"},{"line_number":12,"context_line":"service refuse to start with the libvirt driver on a non Linux platform."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I29c5a678efec4fbc4bd7958ebe6d454ae30701cd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_163fd7b5","line":13,"updated":"2020-07-01 15:58:43.000000000","message":"should we document that ? IMHO, yes.","commit_id":"68a5531568aa358da8ccddd5d7cb365ca662d890"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b162349da1465b2225c104c2982b873295364703","unresolved":false,"context_lines":[{"line_number":10,"context_line":"detect if two directories are on the same device. So the driver is"},{"line_number":11,"context_line":"heavily Linux dependent. This patch makes sure that the nova-compute"},{"line_number":12,"context_line":"service refuse to start with the libvirt driver on a non Linux platform."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I29c5a678efec4fbc4bd7958ebe6d454ae30701cd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_888fe728","line":13,"in_reply_to":"bf51134e_111d170f","updated":"2020-07-08 16:19:16.000000000","message":"Started the doc patch at https://review.opendev.org/#/c/740061/","commit_id":"68a5531568aa358da8ccddd5d7cb365ca662d890"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b65a26bfa7ce4072d6064bc226f6e4675b4fa287","unresolved":false,"context_lines":[{"line_number":10,"context_line":"detect if two directories are on the same device. So the driver is"},{"line_number":11,"context_line":"heavily Linux dependent. This patch makes sure that the nova-compute"},{"line_number":12,"context_line":"service refuse to start with the libvirt driver on a non Linux platform."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I29c5a678efec4fbc4bd7958ebe6d454ae30701cd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf51134e_111d170f","line":13,"in_reply_to":"bf51134e_163fd7b5","updated":"2020-07-02 10:04:19.000000000","message":"Made a TODO to myself for proposing a new doc with a table showing which virt driver works on which OS.","commit_id":"68a5531568aa358da8ccddd5d7cb365ca662d890"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"328f64c84f8296524138d5d577f1860d451741d3","unresolved":false,"context_lines":[{"line_number":331,"context_line":"        }"},{"line_number":332,"context_line":"        super(LibvirtDriver, self).__init__(virtapi)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        if not sys.platform.startswith(\u0027linux\u0027):"},{"line_number":335,"context_line":"            raise exception.InternalError("},{"line_number":336,"context_line":"                _(\u0027The libvirt driver only works on Linux\u0027))"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_163a37cc","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":48},"updated":"2020-07-01 15:53:38.000000000","message":"This is the correct thing to do, fwiw https://docs.python.org/3/library/sys.html#sys.platform","commit_id":"68a5531568aa358da8ccddd5d7cb365ca662d890"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d5a97f66f178b76ccadeb3a810b9b5162816cb92","unresolved":false,"context_lines":[{"line_number":333,"context_line":""},{"line_number":334,"context_line":"        if not sys.platform.startswith(\u0027linux\u0027):"},{"line_number":335,"context_line":"            raise exception.InternalError("},{"line_number":336,"context_line":"                _(\u0027The libvirt driver only works on Linux\u0027))"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        global libvirt"},{"line_number":339,"context_line":"        if libvirt is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_f636a3e7","line":336,"updated":"2020-07-01 15:58:43.000000000","message":"hah, thanks for writing it, this was my concern to not having a hard-stop in the related change ;)","commit_id":"68a5531568aa358da8ccddd5d7cb365ca662d890"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bf5419a00617f516129b94d781a41717cecc880a","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"        \"\"\"Get the used memory size(MB) of physical computer."},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"        :returns: the total usage of memory(MB)."},{"line_number":1101,"context_line":"        \"\"\""},{"line_number":1102,"context_line":"        if CONF.libvirt.virt_type \u003d\u003d \u0027xen\u0027:"},{"line_number":1103,"context_line":"            # For xen, report the sum of all domains, with"},{"line_number":1104,"context_line":"            return self._sum_domain_memory_mb(include_host\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_58c8d920","line":1101,"updated":"2020-06-23 13:01:19.000000000","message":"I\u0027ve actually done this in [1], which is linked to a bug. Think we could rebase this onto that?\n\n[1] https://review.opendev.org/#/c/733827/1","commit_id":"6af36daac67175b5284943bf166d678b0c88a4bc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"07e12960439e28313b2b46c85445f2f41e94f268","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"        \"\"\"Get the used memory size(MB) of physical computer."},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"        :returns: the total usage of memory(MB)."},{"line_number":1101,"context_line":"        \"\"\""},{"line_number":1102,"context_line":"        if CONF.libvirt.virt_type \u003d\u003d \u0027xen\u0027:"},{"line_number":1103,"context_line":"            # For xen, report the sum of all domains, with"},{"line_number":1104,"context_line":"            return self._sum_domain_memory_mb(include_host\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_8b3cb62f","line":1101,"in_reply_to":"bf51134e_58c8d920","updated":"2020-06-25 11:52:35.000000000","message":"Done","commit_id":"6af36daac67175b5284943bf166d678b0c88a4bc"}]}