)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cc3d7b0810d49237f488b4f81c9b9c18f6fba82f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"vmware: Handle exception in destroy with attached volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an instance didn\u0027t go through and nova retries on the next"},{"line_number":10,"context_line":"nova-compute restart, an instance not existing in the back end anymore"},{"line_number":11,"context_line":"can lead to an uncatched exception in the vmware driver prohibiting"},{"line_number":12,"context_line":"instance deletion. This is the case, if the instance had volumes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_744daf39","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":43},"updated":"2020-08-26 10:57:41.000000000","message":"an attempt to delete an instance doesn\u0027t succeed","commit_id":"4f72c1d25250ec72c3d291390a24282cd090243b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cc3d7b0810d49237f488b4f81c9b9c18f6fba82f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"complete the deletion as seen in the traceback below (which comes from a"},{"line_number":19,"context_line":"queens codebase):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"\t Traceback (most recent call last):"},{"line_number":22,"context_line":"\t   File \"/nova/compute/manager.py\", line 874, in _init_instance"},{"line_number":23,"context_line":"\t\t self._delete_instance(context, instance, bdms)"},{"line_number":24,"context_line":"\t   File \"/nova/hooks.py\", line 154, in inner"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f560f44_945203dd","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":2},"updated":"2020-08-26 10:57:41.000000000","message":"Can you replace these with spaces, please?","commit_id":"4f72c1d25250ec72c3d291390a24282cd090243b"}],"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":31706,"name":"Yingji Sun","email":"yingjisun@vmware.com","username":"yingjisun"},"change_message_id":"a268e51eb3b265db63cd39a015252f6d2014d236","unresolved":false,"context_lines":[{"line_number":1593,"context_line":"        self._destroy_instance_without_vm_ref("},{"line_number":1594,"context_line":"            task_state\u003dtask_states.RESIZE_REVERTING)"},{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":"    def test_destroy_instance_with_vm_ref_but_with_volumes(self):"},{"line_number":1597,"context_line":"        self.destroy_disks \u003d True"},{"line_number":1598,"context_line":"        self._create_instance()"},{"line_number":1599,"context_line":"        bdi \u003d {\u0027block_device_mapping\u0027: [\u0027foo\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_03babb08","line":1596,"updated":"2020-07-07 03:28:15.000000000","message":"Would you change the name to \"test_destroy_instance_with_non_existing_vm_ref_and_volumes\".\n\"but\" is a little confusing.","commit_id":"05fd60a5de1deba89297d71d58ec493de8f56dfa"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"723f9bbaca70241f43074ccaaaf9decdc152fb24","unresolved":false,"context_lines":[{"line_number":1593,"context_line":"        self._destroy_instance_without_vm_ref("},{"line_number":1594,"context_line":"            task_state\u003dtask_states.RESIZE_REVERTING)"},{"line_number":1595,"context_line":""},{"line_number":1596,"context_line":"    def test_destroy_instance_with_vm_ref_but_with_volumes(self):"},{"line_number":1597,"context_line":"        self.destroy_disks \u003d True"},{"line_number":1598,"context_line":"        self._create_instance()"},{"line_number":1599,"context_line":"        bdi \u003d {\u0027block_device_mapping\u0027: [\u0027foo\u0027]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_3e7b94f4","line":1596,"in_reply_to":"bf51134e_03babb08","updated":"2020-07-07 06:57:40.000000000","message":"Done","commit_id":"05fd60a5de1deba89297d71d58ec493de8f56dfa"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"cc3d7b0810d49237f488b4f81c9b9c18f6fba82f","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        if block_device_info is not None:"},{"line_number":624,"context_line":"            try:"},{"line_number":625,"context_line":"                self._detach_instance_volumes(instance, block_device_info)"},{"line_number":626,"context_line":"            except (vexc.ManagedObjectNotFoundException,"},{"line_number":627,"context_line":"                    exception.InstanceNotFound):"},{"line_number":628,"context_line":"                LOG.warning(\u0027Instance does not exists. Proceeding to \u0027"},{"line_number":629,"context_line":"                            \u0027delete instance properties on datastore\u0027,"},{"line_number":630,"context_line":"                            instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_b46467ba","line":627,"range":{"start_line":626,"start_character":0,"end_line":627,"end_character":48},"updated":"2020-08-26 10:57:41.000000000","message":"style nit:\n\n  except (\n      vexc.ManagedObjectNotFoundException,\n      exception.InstanceNotFound,\n  ):","commit_id":"4f72c1d25250ec72c3d291390a24282cd090243b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"afdb562c90c5c146b0233a6b3d837627519ef6df","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        if block_device_info is not None:"},{"line_number":624,"context_line":"            try:"},{"line_number":625,"context_line":"                self._detach_instance_volumes(instance, block_device_info)"},{"line_number":626,"context_line":"            except (vexc.ManagedObjectNotFoundException,"},{"line_number":627,"context_line":"                    exception.InstanceNotFound):"},{"line_number":628,"context_line":"                LOG.warning(\u0027Instance does not exists. Proceeding to \u0027"},{"line_number":629,"context_line":"                            \u0027delete instance properties on datastore\u0027,"},{"line_number":630,"context_line":"                            instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_238f6c75","line":627,"range":{"start_line":626,"start_character":0,"end_line":627,"end_character":48},"in_reply_to":"9f560f44_3d502932","updated":"2020-08-27 08:09:19.000000000","message":"Sure, fine by me","commit_id":"4f72c1d25250ec72c3d291390a24282cd090243b"},{"author":{"_account_id":26250,"name":"Johannes Kulik","email":"johannes.kulik@sap.com","username":"jkulik"},"change_message_id":"221eb27ecff4c41db841fe0d3bcc43c3509ce702","unresolved":false,"context_lines":[{"line_number":623,"context_line":"        if block_device_info is not None:"},{"line_number":624,"context_line":"            try:"},{"line_number":625,"context_line":"                self._detach_instance_volumes(instance, block_device_info)"},{"line_number":626,"context_line":"            except (vexc.ManagedObjectNotFoundException,"},{"line_number":627,"context_line":"                    exception.InstanceNotFound):"},{"line_number":628,"context_line":"                LOG.warning(\u0027Instance does not exists. Proceeding to \u0027"},{"line_number":629,"context_line":"                            \u0027delete instance properties on datastore\u0027,"},{"line_number":630,"context_line":"                            instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_3d502932","line":627,"range":{"start_line":626,"start_character":0,"end_line":627,"end_character":48},"in_reply_to":"9f560f44_b46467ba","updated":"2020-08-27 05:56:29.000000000","message":"I\u0027ve done a quick \"git grep -A 3 \u0027except (\u0027\" in the vmwareapi driver and also the virt directory. It looks to me like we\u0027re consistently using the commit\u0027s style in this part of the code, not the one proposed by you.\n\nI\u0027d go with style consistency then and not change it, if that\u0027s ok with you.","commit_id":"4f72c1d25250ec72c3d291390a24282cd090243b"}]}